BUG#12659 error handling in federated needs improvement. Sanja pointed out that we were copying an entire buffer, most of which was probably garbage, and possibly hidden by null termination in the middle of the buffer. Now we are only copying the error message.

Issuing error about presence of commit/rollback statements in stored functions and triggers added to SP parsing procedure (BUG#13627)

The crash mentioned in original bug report is already prevented by one
of previous patches (fix for bug #13343 "CREATE|etc TRIGGER|VIEW|USER
don't commit the transaction (inconsistency)"), this patch only improve
error returning.

into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug6-5.0

into moonbone.local:/work/14850-bug-5.0-mysql

into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug6-5.0

into  mysql.com:/usr/home/pem/bug14723/mysql-5.0

into mysql.com:/Users/kent/mysql/bk/mysql-5.0

test_if_order_by_key() expected only Item_fields to be in order->item, thus
failing to find available index on view's field, which results in reported
error.

Now test_if_order_by_key() calls order->item->real_item() to get field for
choosing index.

Item_ref's null_value wasn't updated in save_org_in_field() causing reported
error.

into  selena.:H:/MYSQL/src/#14569-mysql-5.0

into  mysql.com:/usr/home/pem/bug14723/mysql-5.0

into mysql.com:/Users/kent/mysql/bk/mysql-5.0

into  selena.:H:/MYSQL/bkt/mysql-5.0

my_sopen() on win32 which allows to use FILE_SHARE_DELETE flag to 
allow deleting opened files. my_sopen() implementation is added to
support this functionality.

  Disabled yaSSL support for now

into mysql.com:/Users/kent/mysql/bk/mysql-5.0-release

  Corrected search for 'mysqlimport' executable

into mysql.com:/Users/kent/mysql/bk/mysql-5.0

we changing current db temporarily and restore it when sp is created. however thd->db
in this case becomes empty string rather than NULL and so all checks of thd->db == NULL 
will be false. So if after this we'll issue create procedure sp2()... without specifying
db it will succeed and create sp with db=NULL, which causes mysqldto crash on 
show procedure status statement.

This patch fixes the problem.

into  mysql.com:/usr/home/pem/bug14723/mysql-5.0

it is added a check of not being empty value. When modifying SP with Admin 
application on win32 it does not pass curent database so sp is stored with
db=null which causes a crash later on show procedure status;

                 in the function body
  Changed the way the end of query was found from the lex state.
  The routine body was not extracted correctly when using the
  /*!version ... */ wrapper (in dump files); for some types of routines
  (e.g. with a label at the first begin), the trailing "*/" was not skipped.

into  mysql.com:/home/timka/mysql/src/5.0-bug-14662

into  mysql.com:/home/timka/mysql/src/5.0-bug-14662

the same column as an aliased and as a non-aliased column.

The problem was that Item_direct_view_ref::eq() was first comparing view columns
by name, and in this case the name of one of them is different since it is aliased.

                  for invalid view
 Permit SHOW CREATE VIEW, SHOW CREATE TABLE, and retrieval of metadata from
 information_schema for invalid views

into  mysql.com:/home/alik/MySQL/devel/5.0-wl2818

into  mysql.com:/home/alik/MySQL/devel/5.0-wl2818

into  zim.(none):/home/brian/mysql/mysql-5.0

into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug4-5.0

into  mysql.com:/home/alik/MySQL/devel/5.0-wl2818