1. 10 Dec, 2004 1 commit
    • unknown's avatar
      Makefile.am: · c2b85ea0
      unknown authored
        Moved "../regex/libregex.a" before "../libmysql/libmysqlclient.la"
        when linking. For -all-static linking libtool put -lc after the .la
        file and this put the libc regex functions before our regex functions
        when linking on Linux.
      
      
      client/Makefile.am:
        Moved "../regex/libregex.a" before "../libmysql/libmysqlclient.la"
        when linking, for static linking libtool put -lc after the .la
        and this put the libc regex functions before out regex functions
        in the link on Linux.
      c2b85ea0
  2. 09 Dec, 2004 1 commit
    • unknown's avatar
      Ensure that we free memory used with --order-by-primary (in mysqldump) · 84f2d119
      unknown authored
      Simple, non critical, fix to mysql_fix_privilege_tables
      
      
      client/mysqldump.c:
        Ensure that we free memory used with --order-by-primary
      mysql-test/t/system_mysql_db_fix.test:
        Remove warnings when compiled with support for ISAM
      scripts/mysql_fix_privilege_tables.sh:
        Ensure that 'my_print_defaults' is called correctly
      sql/set_var.cc:
        Code style cleanups
      sql/sql_db.cc:
        Fixed comments
      sql/udf_example.cc:
        Fixed comments
      84f2d119
  3. 04 Dec, 2004 1 commit
  4. 02 Dec, 2004 1 commit
    • unknown's avatar
      Fix for Bug#6377 "Password Generation Discrepancy" · 233e9bbf
      unknown authored
      client/mysqladmin.cc:
        Fix for Bug#6377 "Password Generation Discrepancy":
        this is not a MySQL bug.
        The problem is that Windows command line client doesn't trim single quotes
        from arguments, as any UNIX shell does.
        The fix just checks for this condition and gives a warning if it is true.
      233e9bbf
  5. 30 Nov, 2004 1 commit
    • unknown's avatar
      mysqldump.c: · d4d72b17
      unknown authored
        minor cleanup to the --order-by-primary feature code
      
      
      client/mysqldump.c:
        minor cleanup to the --order-by-primary feature code
      d4d72b17
  6. 29 Nov, 2004 1 commit
    • unknown's avatar
      Applied some Netware related patches. · caf12257
      unknown authored
      client/mysqladmin.cc:
        Added option to mysqladmin for Netware.
      netware/comp_err.def:
        Copyright notice update, for Netware.
      netware/isamchk.def:
        Copyright notice update, for Netware.
      netware/isamlog.def:
        Copyright notice update, for Netware.
      netware/libmysql.def:
        Copyright notice update, for Netware.
      netware/my_print_defaults.def:
        Copyright notice update, for Netware.
      netware/myisam_ftdump.def:
        Copyright notice update, for Netware.
      netware/myisamchk.def:
        Copyright notice update, for Netware.
      netware/myisamlog.def:
        Copyright notice update, for Netware.
      netware/myisampack.def:
        Copyright notice update, for Netware.
      netware/mysql.def:
        Copyright notice update, for Netware.
      netware/mysql_install.def:
        Copyright notice update, for Netware.
      netware/mysql_install_db.def:
        Copyright notice update, for Netware.
      netware/mysql_test_run.def:
        Copyright notice update, for Netware.
      netware/mysql_waitpid.def:
        Copyright notice update, for Netware.
      netware/mysq...
      caf12257
  7. 24 Nov, 2004 2 commits
  8. 19 Nov, 2004 3 commits
  9. 18 Nov, 2004 2 commits
    • unknown's avatar
      fix for mysqladmin link problem · 00886f71
      unknown authored
           .c -> .cc
          fix source dist problem for ndb
          fix type check problem for mysqladmin
      
      
      
      client/Makefile.am:
        fix for mysqladmin link problem
         .c -> .cc
      client/mysqladmin.cc:
        fix for mysqladmin link problem
         .c -> .cc
      configure.in:
        fix for mysqladmin link problem
         .c -> .cc
      ndb/include/Makefile.am:
        fix source dist problem for ndb
      ndb/src/mgmclient/CommandInterpreter.cpp:
        fix type check problem
      ndb/src/mgmclient/ndb_mgmclient.hpp:
        fix type check problem
      ndb/src/mgmclient/ndb_mgmclient.h:
        fix type check problem
      00886f71
    • unknown's avatar
      changed mysqladmin.c to mysqladmin.cc · 61cf4698
      unknown authored
          no need for dvlags to have DEFINE_CXA_PURE_VIRTUAL anymore
          aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
          removed all dependencies of LocalConfig, except for mgmapi internals
          enabled multiple management servrs to fetch data configurations from eachother
      
      
      client/Makefile.am:
        changed mysqladmin.c to mysqladmin.cc
      client/mysqladmin.cc:
        changed mysqladmin.c to mysqladmin.cc
      configure.in:
        no need for dvlags to have DEFINE_CXA_PURE_VIRTUAL anymore
      ndb/include/mgmapi/mgmapi.h:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/include/mgmcommon/ConfigRetriever.hpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/include/ndbapi/ndb_cluster_connection.hpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/kernel/main.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/kernel/vm/Configuration.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
        changed to config setting to always use noOfMetaTables to make sure we don't overflow arrays
      ndb/src/kernel/vm/Configuration.hpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmapi/LocalConfig.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmapi/LocalConfig.hpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmapi/mgmapi.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmclient/CommandInterpreter.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmclient/main.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmclient/ndb_mgmclient.hpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmclient/ndb_mgmclient.h:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
        enabled multiple management servrs to fetch data configurations from eachother
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmsrv/MgmtSrvrConfig.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/mgmsrv/main.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/src/ndbapi/ndb_cluster_connection.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      ndb/tools/waiter.cpp:
        aligned the parsing of connectstring, retries for connect, allocation of nodeid for all cluster nodes
        removed all dependencies of LocalConfig, except for mgmapi internals
      61cf4698
  10. 16 Nov, 2004 2 commits
    • unknown's avatar
      Add --order-by-primary option, which adds an ORDER BY · 52f9b271
      unknown authored
      clause the the SELECT statement used to dump the data
      for any table which has a primary or unique key.  This
      is useful for dumping MyISAM tables which will be later
      imported into InnoDB tables.
      
      
      client/client_priv.h:
        add option OPT_ORDER_BY_PRIMARY
      52f9b271
    • unknown's avatar
      Makefile.am: · 4738fd2f
      unknown authored
        changed link order to fix linking problems
      
      
      client/Makefile.am:
        changed link order to fix linking problems
      4738fd2f
  11. 15 Nov, 2004 2 commits
    • unknown's avatar
      compilation failures fixes. mysqldump now compiles on AIX 4.3. · 8fbe68ad
      unknown authored
      client/mysqldump.c:
        row[i] is char* so some compilers don't want to put it into a unsigned char*. A C++ comment.
      8fbe68ad
    • unknown's avatar
      changed compile order, mysqladmin with ndbcluster extensions needs ndb to be compiled first · c60412e7
      unknown authored
          added libs variable for ndbmgmclient used by mysqladmin
          add linkage with @ndb_mgmclient_libs@
          additional options for ndbcluster
          added support for managing the cluster to mysqladmin
          added DEFINE_CXA_PURE_VIRTUAL flag to CFLAGS to enable linkage with c++ libs
          use macros for C_MODE_START/END so that define of FIX_GCC_LINKING_PROBLEM works in c-programs
      
      
      Makefile.am:
        changed compile order, mysqladming with ndbcluster extensions needs ndb to be compiled first
      acinclude.m4:
        added libs variable for ndbmgmclient used by mysqladmin
      client/Makefile.am:
        add linkage with @ndb_mgmclient_libs@
      client/client_priv.h:
        additional options for ndbcluster
      client/mysqladmin.c:
        added support for managing the cluster to mysqladmin
      configure.in:
        added DEFINE_CXA_PURE_VIRTUAL flag to CFLAGS to enable linkage with c++ libs
      include/my_global.h:
        use macros for C_MODE_START/END so that define of FIX_GCC_LINKING_PROBLEM works in c-programs
      c60412e7
  12. 14 Nov, 2004 2 commits
  13. 12 Nov, 2004 2 commits
    • unknown's avatar
      After merge fixes · a1267042
      unknown authored
      client/mysqldump.c:
        Merge with 4.0 (and reordering of options)
      client/mysqltest.c:
        Added DB as a user variable
      myisam/mi_check.c:
        Trivial cleanup
      mysql-test/r/grant.result:
        Move test to be in same order as in 4.0
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Updated results
      mysql-test/r/ps_1general.result:
        Updated tests to work after privilege fixes
      mysql-test/r/timezone3.result:
        Updated results to 4.1
      mysql-test/t/ps_1general.test:
        Updated tests to work after privilege fixes
      sql-common/my_time.c:
        Applied sub-second patch from 4.0
      sql/sql_acl.cc:
        More debugging
      a1267042
    • unknown's avatar
      mysqldump.c: · f35ba3cf
      unknown authored
        Add missing sentinel.
      
      
      client/mysqldump.c:
        Add missing sentinel.
      f35ba3cf
  14. 11 Nov, 2004 1 commit
    • unknown's avatar
      mysqldump.c: · 29c873e6
      unknown authored
        Reorder options, revise --hex-blob help string.
      
      
      client/mysqldump.c:
        Reorder options, revise --hex-blob help string.
      29c873e6
  15. 10 Nov, 2004 1 commit
    • unknown's avatar
      WL#1596 "make mysqldump --master-data --single-transaction able to do online... · fbc56a51
      unknown authored
      WL#1596 "make mysqldump --master-data --single-transaction able to do online dump of InnoDB AND report reliable
      binlog coordinates corresponding to the dump".
      The good news is that now mysqldump can be used to get an online backup of InnoDB *which works for
      point-in-time recovery and replication slave creation*. Formerly, mysqldump --master-data --single-transaction
      used to call in fact mysqldump --master-data, so the dump was not an online dump (took big lock all time of dump).
      The only lock which is now taken in this patch is at the beginning of the dump: mysqldump does:
      FLUSH TABLES WITH READ LOCK; START TRANSACTION WITH CONSISTENT SNAPSHOT; SHOW MASTER STATUS; UNLOCK TABLES;
      so the lock time is in fact the time FLUSH TABLES WITH READ LOCK takes to return (can be 0 or very long, if
      a table is undergoing a huge update).
      I have done some more minor changes listed in the paragraph of mysqldump.c.
      WL#2237 "WITH CONSISTENT SNAPSHOT clause for START TRANSACTION":
      it's a START TRANSACTION which additionally starts a consistent read on all
      capable storage engine (i.e. InnoDB). So, can serve as a replacement for
      BEGIN; SELECT * FROM some_innodb_table LIMIT 1; which starts a consistent read too. 
      
      
      client/mysqldump.c:
        Main change: mysqldump --single-transaction --master-data is now able to, at the same time,
        take an online dump of InnoDB (using consistent read) AND get the binlog position corresponding to this dump
        (before, using the two options used to silently cancel --single-transaction).
        This uses the new START TRANSACTION WITH CONSISTENT SNAPSHOT syntax.
        Additional changes: 
        a) cleanup:
         - DBerror calls exit() so some code was unneeded
         - no need to call COMMIT at end, leave disconnection do the job
         - mysql_query_with_error_report()
        b) requirements I had heard from colleagues:
         - --master-data now requires an argument, to comment out ("--") the CHANGE MASTER or not
           (commenting had been asked for point-in-time recovery when replication is not necessary).
         - --first-slave is renamed to --lock-all-tables
        c) more sensible behaviours (has been discussed internally):
         - if used with --master-data, --flush-logs is probably intended to get a flush synchronous
           with the dump, not one random flush per dumped db.
         - disabled automatic reconnection as, at least, SQL_MODE would be lost (and also, depending
           on options, LOCK TABLES, BEGIN, FLUSH TABLES WITH READ LOCK).
      include/mysqld_error.h:
        an error if START TRANSACTION WITH CONSISTENT SNAPSHOT is called and there is no consistent-read capable storage engine
        (idea ((C) PeterG) is that it's a bit like CREATE TABLE ENGINE=InnoDB when there is no support for InnoDB).
      sql/handler.cc:
        new ha_start_consistent_snapshot(), which, inside an existing transaction, starts a consistent read
        (offers an alternative to SELECTing any InnoDB table). Does something only for InnoDB.
        Warning if no suitable engine supported.
      sql/handler.h:
        declarations
      sql/lex.h:
        symbols for lex
      sql/share/czech/errmsg.txt:
        new message
      sql/share/danish/errmsg.txt:
        new message
      sql/share/dutch/errmsg.txt:
        new message
      sql/share/english/errmsg.txt:
        new message
      sql/share/estonian/errmsg.txt:
        new message
      sql/share/french/errmsg.txt:
        new message
      sql/share/german/errmsg.txt:
        new message
      sql/share/greek/errmsg.txt:
        new message
      sql/share/hungarian/errmsg.txt:
        new message
      sql/share/italian/errmsg.txt:
        new message
      sql/share/japanese/errmsg.txt:
        new message
      sql/share/korean/errmsg.txt:
        new message
      sql/share/norwegian-ny/errmsg.txt:
        new message
      sql/share/norwegian/errmsg.txt:
        new message
      sql/share/polish/errmsg.txt:
        new message
      sql/share/portuguese/errmsg.txt:
        new message
      sql/share/romanian/errmsg.txt:
        new message
      sql/share/russian/errmsg.txt:
        new message
      sql/share/serbian/errmsg.txt:
        new message
      sql/share/slovak/errmsg.txt:
        new message
      sql/share/spanish/errmsg.txt:
        new message
      sql/share/swedish/errmsg.txt:
        new message
      sql/share/ukrainian/errmsg.txt:
        new message
      sql/sql_lex.h:
        new option in lex (transaction options)
      sql/sql_parse.cc:
        warning comment (never make UNLOCK TABLES commit a transaction, please);
        support for starting consistent snapshot.
      sql/sql_yacc.yy:
        new clause WITH CONSISTENT SNAPSHOT (syntax ok'd by PeterG) for START TRANSACTION.
      fbc56a51
  16. 09 Nov, 2004 1 commit
  17. 07 Nov, 2004 1 commit
    • unknown's avatar
      Simpler arena swapping code · dda7a6a9
      unknown authored
      Now thd->mem_root is a pointer to thd->main_mem_root and THR_MALLOC is a pointer to thd->mem_root.
      This gives us the following benefits:
      - Allow us to easily detect if arena has already been swapped before (this fixes a bug in setup_conds() where arena was swaped twice in some cases)
      - Faster swaps of arenas (as we don't have to copy the whole MEM_ROOT)
      - We don't anymore have to call my_pthread_setspecific_ptr(THR_MALLOC,...) to change where memory is alloced. Now it's enough to set thd->mem_root
      
      
      
      client/mysqltest.c:
        Remove some not needed defines
        (Things like this should be done in config-win.h)
      include/config-win.h:
        Added popen() and pclose() compatibility macros
      mysql-test/t/rpl_failed_optimize-master.opt:
        Portability fix
      sql/ha_berkeley.cc:
        New thd->memroot handling
      sql/item_cmpfunc.cc:
        Simpler arena swapping code
      sql/item_func.cc:
        Simpler arena swapping code
      sql/item_subselect.cc:
        Simpler arena swapping code
        New thd->mem_root handling
      sql/item_sum.cc:
        New thd->mem_root handling
      sql/item_timefunc.cc:
        Fixed not-initalized usage errors found by valgrind
      sql/log_event.cc:
        New thd->mem_root handling
      sql/mysql_priv.h:
        New thd->mem_root handling
      sql/mysqld.cc:
        New thd->mem_root handling
      sql/opt_range.cc:
        New thd->mem_root handling
      sql/repl_failsafe.cc:
        New thd->mem_root handling
      sql/set_var.cc:
        New thd->mem_root handling
      sql/sql_acl.cc:
        New thd->mem_root handling
      sql/sql_base.cc:
        Simpler arena swapping code
        New thd->mem_root handling
      sql/sql_class.cc:
        New thd->mem_root handling
      sql/sql_class.h:
        Simpler arena swapping code
        New thd->mem_root handling
      sql/sql_db.cc:
        New thd->mem_root handling
      sql/sql_error.cc:
        New thd->mem_root handling
      sql/sql_help.cc:
        New thd->mem_root handling
      sql/sql_insert.cc:
        New thd->mem_root handling
      sql/sql_parse.cc:
        New thd->mem_root handling
        Added some extra checking of return value of new
      sql/sql_prepare.cc:
        New thd->mem_root handling
      sql/sql_select.cc:
        New thd->mem_root handling
      sql/sql_select.h:
        New thd->mem_root handling
      sql/sql_union.cc:
        Simpler arena swapping code
      sql/sql_yacc.yy:
        New thd->mem_root handling
      sql/table.cc:
        New thd->mem_root handling
      sql/thr_malloc.cc:
        New thd->mem_root handling
      tests/client_test.c:
        Added drop table to some tests
        Changed some table names to 't1'
      dda7a6a9
  18. 05 Nov, 2004 5 commits
    • unknown's avatar
      mysqldump.c: · 6aace3da
      unknown authored
        in 4.1: Dump only VARBINARY() in hex,
        while VARCHAR() COLLATE xxx_bin as a string.
      
      
      client/mysqldump.c:
        in 4.1: Dump only VARBINARY() in hex,
        while VARCHAR() COLLATE xxx_bin as a string.
      6aace3da
    • unknown's avatar
      mysqldump.c: · eb7cea98
      unknown authored
        Dump VARCHAR(n) BINARY in HEX if --hex-blob too.
      
      
      client/mysqldump.c:
        Dump VARCHAR(n) BINARY in HEX if --hex-blob too.
      eb7cea98
    • unknown's avatar
      client_priv.h: · 247468f1
      unknown authored
        Backport --hex-blob to 4.0
      
      
      client/client_priv.h:
        Backport --hex-blob to 4.0
      247468f1
    • unknown's avatar
      mysqldump.c: · 92b89585
      unknown authored
        - 'mysqldump --help' comment that --xeh-blob
          doesn't work with --extended-inserts was removed.
          It does work now. Thanks to Lachlan
          who noticed this wrong help message.
        - Switched to use the recently introduced
          mysql_hex_string() instead of slow sprintf().
          Thanks to Sinisa for the idea.
        - 'mysqldump --hex-blob' dumps in HEX not only
          BLOBs but also BINARY(x) columns. 
          Thanks to Paul.
      
      
      client/mysqldump.c:
        - comment that --xeh-blob doesn't work with --extended-inserts was removed. It does work now.
        - Switched to use recently introduced mysql_hex_string()
          instead of sprintf()
        - BINARY(x) are dumped in HEX too
      92b89585
    • unknown's avatar
      mysqladmin.c: · 1b764b9b
      unknown authored
        Missing initialized for "lengths" element.
        ,
      
      
      client/mysqladmin.c:
        Missing initialized for "lengths" element.
        ,
      1b764b9b
  19. 04 Nov, 2004 2 commits
  20. 02 Nov, 2004 2 commits
    • unknown's avatar
      Remove usage of !$ from mysql-tests · 2bcfcbfe
      unknown authored
      Added protocol::flush() for easier embedded-server code
      Increase block allocation variables a bit as they where a bit too small for MySQL 4.1
      Added option --silent to client_test
      
      
      client/mysqltest.c:
        Removed compiler warning
        Fixed identation & comments from earlier push
        Renamed variable 'disable_abort_on_error' to 'abort_on_error'
        Ensure that '$mysql_errno' also with --ps-protocol
      include/mysql_com.h:
        Removed special handling of net_flush for embedded server
      mysql-test/r/mysqltest.result:
        Remove usage of !$ in tests
      mysql-test/t/client_test.test:
        Use --silent
      mysql-test/t/comments.test:
        Remove usage of !$ in tests
      mysql-test/t/join_outer.test:
        Remove usage of !$ in tests
      mysql-test/t/key.test:
        Remove usage of !$ in tests
      mysql-test/t/mysqltest.test:
        Remove usage of !$ in tests
      mysql-test/t/show_check.test:
        Remove usage of !$ in tests
      mysql-test/t/temp_table.test:
        Remove usage of !$ in tests
      mysql-test/t/type_ranges.test:
        Remove usage of !$ in tests
      sql/mysqld.cc:
        Increase block allocation variables a bit as they where a bit too small for MySQL 4.1
      sql/net_serv.cc:
        Remove special usage of net_flush in embedded server
      sql/protocol.cc:
        Added protocol::flush() for easier embedded-server code
      sql/protocol.h:
        Added protocol::flush() for easier embedded-server code
      sql/sql_prepare.cc:
        Added protocol::flush() for easier embedded-server code
        Remove one extra flush() for prepared statements
      sql/sql_show.cc:
        Added protocol::flush() for easier embedded-server code
      tests/client_test.c:
        Added option --silent
      2bcfcbfe
    • unknown's avatar
      A fix (bug #6309: myisamchk compiled without debug support , --help shows vise versa · 40abc17c
      unknown authored
             bug #6380: mysqlcheck --help prints wrong --debug msg for non-debug version).
      
      
      client/mysqlcheck.c:
        A fix (bug #6380: mysqlcheck --help prints wrong --debug msg for non-debug version).
      myisam/myisamchk.c:
        A fix (bug #6309: myisamchk compiled without debug support , --help shows vise versa).
      40abc17c
  21. 29 Oct, 2004 1 commit
    • unknown's avatar
      These modifications are the result of · b863689b
      unknown authored
      WL#2067 add features to mysqltest: "disable_error_abort" + "$mysql_errno"
      
      $mysql_errno is a new builtin variable of mysqltest and contains the
      return code of the last command send to the server.
      
      "--disable_abort_on_error" switches the abort of mysqltest
      after "unmasked" failing statements off.
      "--enable_abort_on_error" switches the abort of mysqltest
      after "unmasked" failing statements on. (default)
      
      "Maskings" are
          !$<error number>  and  --error <error number>
      in the line before the statement to be checked.
      
      The benefit of the option "--disable_abort_on_error" is that
      - all statements after the failing statement are executed
      - a r/<test>.reject will be produced
      - it is possible to write test cases, which perform
        code sequences depending on the return code of a single
        statement
      
      
      client/mysqltest.c:
        Implementation of the features
        - "--disable_abort_on_error"/"--enable_abort_on_error" switch
        - "$mysql_errno" variable
      mysql-test/r/mysqltest.result:
        test cases for the features added
      mysql-test/t/mysqltest.test:
        updated results
      b863689b
  22. 26 Oct, 2004 1 commit
    • unknown's avatar
      A lot of fixes for prepared statements (PS): · 8255e5a3
      unknown authored
      New mysqltest that can run mysqltest with PS
      Added support for ZEROFILL in PS
      Fixed crash when one called mysql_stmt_store_result() without a preceding mysql_stmt_bind_result()
      Updated test cases to support --ps-protocol
      (Some tests are still run using old protocol)
      Fixed crash in PS when using SELECT * FROM t1 NATURAL JOIN t2...
      Fixed crash in PS when using sub queries
      Create table didn't signal when table was created. This could cause a "DROP TABLE created_table" in another thread to wait "forever"
      Fixed wrong permissions check in PS and multi-table updates (one could get permission denied for legal quries)
      Fix for PS and SELECT ... PROCEDURE
      Reset all warnings when executing a new PS query
      group_concat(...ORDER BY) didn't work with PS
      Fixed problem with test suite when not using innodb
      
      
      BitKeeper/deleted/.del-innodb-lock-master.opt~f76a4a1999728f87:
        Delete: mysql-test/t/innodb-lock-master.opt
      client/Makefile.am:
        mysqltest now uses regex
      client/mysqltest.c:
        Added support for testing of prepared statements (with --ps-protocol)
        Main code was done by Kent, I did mainly some cleanups and minor bug fixes
        New test commands:
        --disable_ps_protocol
        --enable_ps_protocol
        NOTE: new code still has some things that needs to be cleaned up.
        For example run_query_stmt_handle_error() should be made more general so that same code can be used also by 'normal' queries
      configure.in:
        mysqltest now uses regex
      libmysql/libmysql.c:
        Reset warning_count after prepare (safety). In the future we should also provide warnings on prepare
        integer -> string conversion now handles ZEROFILL
        double -> string conversion is now closer to the one in the server
        Fixed crash when one called mysql_stmt_store_result() without preceding mysql_stmt_bind_result()
      libmysqld/examples/Makefile.am:
        mysqltest now uses regex
      mysql-test/include/have_query_cache.inc:
        Fixes for --ps-protocol
      mysql-test/include/ps_conv.inc:
        Fixes for --ps-protocol
      mysql-test/mysql-test-run.sh:
        Added options --ps-protocol
      mysql-test/r/ctype_utf8.result:
        Fixed test case
      mysql-test/r/fulltext_cache.result:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/r/fulltext_left_join.result:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/r/fulltext_multi.result:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/r/innodb-lock.result:
        Fixed test to work even if Innodb is not compiled in.
      mysql-test/t/create.test:
        Fixes for --ps-protocol
      mysql-test/t/ctype_utf8.test:
        Remove warnings
      mysql-test/t/date_formats.test:
        Fixes for --ps-protocol
      mysql-test/t/fulltext_cache.test:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/t/fulltext_left_join.test:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/t/fulltext_multi.test:
        Changed output of MATCH to use round() to get same numbers with --ps-protocol
      mysql-test/t/func_group.test:
        Fixes for --ps-protocol
      mysql-test/t/func_sapdb.test:
        Fixes for --ps-protocol
      mysql-test/t/innodb-lock.test:
        Fixed test to work even if Innodb is not compiled in.
      mysql-test/t/insert.test:
        Fixes for --ps-protocol
      mysql-test/t/insert_select.test:
        Fixes for --ps-protocol
      mysql-test/t/insert_update.test:
        Fixes for --ps-protocol
      mysql-test/t/metadata.test:
        Fixes for --ps-protocol
      mysql-test/t/multi_statement.test:
        Fixes for --ps-protocol
      mysql-test/t/ps_1general.test:
        Fixes for --ps-protocol
      mysql-test/t/rollback.test:
        Fixes for --ps-protocol
      mysql-test/t/rpl_redirect.test:
        Fixes for --ps-protocol
      mysql-test/t/rpl_user_variables.test:
        Fixes for --ps-protocol
      mysql-test/t/select.test:
        Fixes for --ps-protocol
      mysql-test/t/status.test:
        Fixes for --ps-protocol
      mysql-test/t/type_blob.test:
        Fixes for --ps-protocol
      mysql-test/t/type_float.test:
        Fixes for --ps-protocol
      mysql-test/t/union.test:
        Fixes for --ps-protocol
      mysql-test/t/warnings.test:
        Fixes for --ps-protocol
      mysys/my_alloc.c:
        More debugging information
      sql-common/client.c:
        More debugging information
      sql-common/my_time.c:
        TIME didn't support full range with PS
      sql/field.cc:
        TIME didn't support full range with PS
      sql/item_cmpfunc.cc:
        IN(constants,...) didn't work with PS
      sql/item_subselect.cc:
        Some subqueries didn't work with PS
      sql/item_sum.cc:
        group_concat(...ORDER BY) didn't work with PS
        Removed variable warning_available as 'warning' can be used for this.
      sql/item_sum.h:
        Removed not needed variable
      sql/protocol.cc:
        TIME didn't support full range with PS
      sql/set_var.cc:
        Style fix
      sql/sql_base.cc:
        setup_wild() didn't properly restore old arena, which caused core dump in PS when using
        SELECT * FROM t1 NATURAL JOIN t2...
      sql/sql_class.cc:
        Style fix
      sql/sql_error.cc:
        Style fix
      sql/sql_insert.cc:
        Create table didn't signal when table was created. This could cause a "DROP TABLE created_table" in another thread to wait "forever"
      sql/sql_lex.h:
        Fix for PS and procedures
      sql/sql_parse.cc:
        More debugging information
        Make a copy of 'db' in PS as this may change
        Fixed wrong permissions check in PS and multi-table updates
      sql/sql_prepare.cc:
        Fix for PS and SELECT ... PROCEDURE
        Reset all warnings when executing a new query
      sql/sql_union.cc:
        Fixes for PS and SELECT ... PROCEDURE
        Reset 'with_wild' as 'wild' is resolved on prepare
      8255e5a3
  23. 22 Oct, 2004 2 commits
    • unknown's avatar
      Fix compiler warnings (detected by Intel's C++ compiler) · 3bfa0e9c
      unknown authored
      Fixed checking of privilege handling in CREATE ... SELECT (Bug #6094)
      
      
      client/mysql.cc:
        Fix compiler warnings
      client/mysqltest.c:
        Fix wrong counting of lines
        Remove compiler warnings
      heap/hp_hash.c:
        Fix compiler warnings
      innobase/dict/dict0load.c:
        Fix compiler warnings
      innobase/include/mem0mem.h:
        Fix compiler warnings
      libmysql/client_settings.h:
        Fix compiler warnings
      myisam/ft_nlq_search.c:
        Add comments about compiler warnings
      myisam/rt_index.c:
        Add comments about compiler warnings
      myisam/rt_mbr.c:
        Add comments about compiler warnings
      mysql-test/r/ps.result:
        Test case for bug#6094
      mysql-test/t/ps.test:
        Test case for bug#6094
      mysys/hash.c:
        Fix compiler warnings
      mysys/my_handler.c:
        Add comments about compiler warnings
      mysys/my_thr_init.c:
        Add comments about compiler warnings
      ndb/include/mgmapi/mgmapi.h:
        Fix compiler warnings
      regex/main.c:
        Fix compiler warnings
      sql/item.h:
        Fix compiler warnings
      sql/item_func.h:
        Add comments about compiler warnings
      sql/spatial.h:
        Add comments about compiler warnings
      sql/sql_lex.h:
        Fix compiler warning
      sql/sql_list.h:
        Fix compiler warning
      sql/sql_parse.cc:
        Move testing of access rights of tables in CREATE ... SELECT to create_table_precheck() to fix privilege checking in CREATE ... SELECT
        (Bug #6094)
      sql/sql_prepare.cc:
        Remove not needed empty line
      sql/sql_string.h:
        Fix compiler warnings
      strings/ctype-mb.c:
        Fix compiler warnings
      3bfa0e9c
    • unknown's avatar
      mysqltest.c, mysqltest.result, mysqltest.test: · f6ec064f
      unknown authored
        Added SQLSTATE matching support to test engine
      mysqltest.result, mysqltest.test:
        new file
      
      
      mysql-test/t/mysqltest.test:
        Added SQLSTATE matching support to test engine
      mysql-test/r/mysqltest.result:
        Added SQLSTATE matching support to test engine
      client/mysqltest.c:
        Added SQLSTATE matching support to test engine
      f6ec064f
  24. 19 Oct, 2004 2 commits
    • unknown's avatar
      Review of all code pushed since last review · da02110d
      unknown authored
      Simple optimzations and cleanups
      Removed compiler warnings and fixed portability issues
      Added client functions 'mysql_embedded()' to allow client to check if we are using embedded server
      Fixes for purify
      
      
      client/mysqlimport.c:
        Remove not used variable
      client/mysqltest.c:
        Remove usage of MAXPATHLEN (all MySQL code uses FN_REFLEN)
        Simplified code
        Remove usage of sprintf("%llu") as this is not portable
      include/mysql.h:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      innobase/srv/srv0start.c:
        Don't use memcmp() when using purify (to avoid false warnings)
      libmysql/libmysql.c:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      libmysql/libmysql.def:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      myisam/myisam_ftdump.c:
        Remove compiler warning
      myisam/myisamchk.c:
        Remove compiler warning
      myisam/rt_test.c:
        #ifdef not used code
      mysys/hash.c...
      da02110d
    • unknown's avatar
      A fix (bug #6101: mysqldump writes invalid SQL). · f914da3d
      unknown authored
      client/mysqldump.c:
        A fix (bug #6101: mysqldump writes invalid SQL).
        Syntax corrected.
      f914da3d