1. 10 Nov, 2007 2 commits
  2. 09 Nov, 2007 5 commits
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · dacae0dc
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/sql_udf.cc:
        Auto merged
      dacae0dc
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32020/my51-bug31445 · e3278b8c
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/sql_udf.cc:
        Auto merged
      e3278b8c
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32020/my50-bug31445 · e68540a6
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      sql/sql_udf.cc:
        Auto merged
      e68540a6
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32020/my50-bug31445 · 0280133a
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug32020/my51-bug31445
      
      
      mysql-test/r/skip_grants.result:
        Auto merged
      mysql-test/t/skip_grants.test:
        Auto merged
      sql/sql_udf.cc:
        Auto merged
      0280133a
    • unknown's avatar
      Fix for bug #32020: loading udfs while --skip-grant-tables is enabled · 737cdfea
      unknown authored
      causes out of memory errors
      
      The code in mysql_create_function() and mysql_drop_function() assumed
      that the only reason for UDFs being uninitialized at that point is an
      out-of-memory error during initialization. However, another possible 
      reason for that is the --skip-grant-tables option in which case UDF 
      initialization is skipped and UDFs are unavailable.
      
      The solution is to check whether mysqld is running with
      --skip-grant-tables and issue a proper error in such a case.
      
      
      mysql-test/r/skip_grants.result:
        Added a test case for bug #32020.
      mysql-test/t/skip_grants.test:
        Added a test case for bug #32020.
      sql/sql_udf.cc:
        Issue a proper error when a user tries to CREATE/DROP a UDF 
        on a server running with the --skip-grant-tables option.
      737cdfea
  3. 08 Nov, 2007 8 commits
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · b56f1c16
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      b56f1c16
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my51-bug26215 · 5a98d8aa
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      5a98d8aa
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-4.1-opt · a5d7fa74
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      a5d7fa74
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my50-bug26215 · 0075aa49
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      0075aa49
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my41-bug26215 · 6c5a2e50
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-4.1-opt
      
      
      6c5a2e50
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my50-bug26215 · fcddc280
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug32103/my51-bug26215
      
      
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/item.h:
        Auto merged
      fcddc280
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug32103/my41-bug26215 · 4713575c
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug32103/my50-bug26215
      
      
      mysql-test/t/select.test:
        Auto merged
      mysql-test/r/select.result:
        Manual merge.
      sql/item.h:
        Manual merge.
      4713575c
    • unknown's avatar
      Bug#31990: MINUTE() and SECOND() return bogus results when used on a DATE · b1fc4b9e
      unknown authored
      HOUR(), MINUTE(), ... returned spurious results when used on a DATE-cast.
      This happened because DATE-cast object did not overload get_time() method
      in superclass Item. The default method was inappropriate here and
      misinterpreted the data.
      
      Patch adds missing method; get_time() on DATE-casts now returns SQL-NULL
      on NULL input, 0 otherwise. This coincides with the way DATE-columns
      behave.
      
      
      mysql-test/r/cast.result:
        Show that HOUR(), MINUTE(), ... return sensible values when used
        on DATE-cast objects, namely NULL for NULL-dates and 0 otherwise.
        Show that this coincides with how DATE-columns behave.
      mysql-test/t/cast.test:
        Show that HOUR(), MINUTE(), ... return sensible values when used
        on DATE-cast objects, namely NULL for NULL-dates and 0 otherwise.
        Show that this coincides with how DATE-columns behave.
      sql/item_timefunc.cc:
        Add get_time() method to DATE-cast object to overload
        the method in Item superclass that would return spurious
        results. Return zero-result; flag NULL if input was NULL.
      sql/item_timefunc.h:
        Add get_time() declaration to DATE-cast object.
      b1fc4b9e
  4. 07 Nov, 2007 3 commits
    • unknown's avatar
      Fix for bug #32103: optimizer crash when join on int and mediumint with · 0a7a55d1
      unknown authored
      variable in where clause.
      
      Problem: the new_item() method of Item_uint used an incorrect
      constructor. "new Item_uint(name, max_length)" calls
      Item_uint::Item_uint(const char *str_arg, uint length) which assumes the
      first argument to be the string representation of the value, not the
      item's name. This could result in either a server crash or incorrect
      results depending on usage scenarios.
      
      Fixed by using the correct constructor in new_item():
      Item_uint::Item_uint(const char *str_arg, longlong i, uint length).
      
      
      mysql-test/r/select.result:
        Added a test case for bug #32103.
      mysql-test/t/select.test:
        Added a test case for bug #32103.
      sql/item.h:
        Use the correct constructor for Item_uint in Item_uint::new_item().
      0a7a55d1
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug25421/my51-bug31445 · 6850e37d
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/opt_range.cc:
        Auto merged
      6850e37d
    • unknown's avatar
      Fix for bug #25421: MySQL threads don't respond to the kill command · dc0a59a2
      unknown authored
      Calculating the estimated number of records for a range scan may take a
      significant time, and it was impossible for a user to interrupt that
      process by killing the connection or the query.
      
      Fixed by checking the thread's 'killed' status in check_quick_keys() and
      interrupting the calculation process if it is set to a non-zero value.
      
      
      sql/opt_range.cc:
        Check the thread's 'killed' status in check_quick_keys() and
        interrupt the calculation process if it is set to a non-zero value.
      dc0a59a2
  5. 06 Nov, 2007 2 commits
  6. 05 Nov, 2007 12 commits
  7. 02 Nov, 2007 8 commits
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · 608f4e7d
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      608f4e7d
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my51-bug26215 · 0d45d202
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      0d45d202
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my50-bug26215 · e397a7b0
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      client/mysql.cc:
        Auto merged
      e397a7b0
    • unknown's avatar
      5.1-specific changes for bug #26215 after merging the patch from 5.0: · 2048ac02
      unknown authored
      - Added trigger tests back.
      - Fixed test cases to match the extended output format of SHOW CREATE ...
      - Replaced 'gptr' with 'uchar *'.
      
      
      client/mysql.cc:
        Replaced 'gptr' with 'uchar *'.
      mysql-test/r/mysql_comments.result:
        Fixed test cases to match the extended output format of SHOW CREATE ...
        Added trigger tests back.
      mysql-test/t/mysql_comments.sql:
        Added trigger tests back.
      2048ac02
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my50-bug26215 · 62f31fac
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug26215/my51-bug26215
      
      
      client/mysql.cc:
        Manual merge.
      62f31fac
    • unknown's avatar
      Fix for: · 1daa54d6
      unknown authored
        bug #26215: mysql command line client should not strip comments
                    from SQL statements
      and
        bug #11230: Keeping comments when storing stored procedures
      
      With the introduction of multiline comments support in the command line
      client (mysql) in MySQL 4.1, it became impossible to preserve
      client-side comments within single SQL statements or stored routines.
      This feature was useful for monitoring tools and maintenance.
      
      The patch adds a new option to the command line client
      ('--enable-comments', '-c') which allows to preserve SQL comments and
      send them to the server for single SQL statements, and to keep comments
      in the code for stored procedures / functions / triggers.
      
      The patch is a modification of the contributed patch from bug #11230
      with the following changes:
      - code style changes to conform to the coding guidelines
      - changed is_prefix() to my_strnncoll() to detect the DELIMITER
      command, since the first one is case-sensitive and not charset-aware
      - renamed t/comments-51.* to t/mysql_comments.*
      - removed tests for comments in triggers since 5.0 does not have SHOW
      CREATE TRIGGER (those tests will be added back in 5.1).
      
      The test cases are only for bug #11230. No automated test case for bug
      #26215 is possible due to the test suite deficiencies (though the cases
      from the bug report were tested manually).
      
      
      client/mysql.cc:
        Applied the contributed patch from bug11230 with the following changes:
        - code style changes to conform to the coding guidelines
        - changed is_prefix() to my_strnncoll() to detect the DELIMITER
        command, since the first one is case-sensitive and not charset-aware
        
        The patch adds a new option to the command line client which allows to
        preserve SQL comments and send them to the server to ensure better
        error reporting and to, keep comments in the code for stored procedures
        / functions / triggers.
      mysql-test/r/mysql_comments.result:
        Added test cases for bug11230.
      mysql-test/t/mysql_comments.sql:
        Added test cases for bug11230.
      mysql-test/t/mysql_comments.test:
        Added test cases for bug11230.
      1daa54d6
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 7524dbaa
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      7524dbaa
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · db499fbd
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B31794-5.1-opt
      
      
      db499fbd