- 10 Dec, 2010 1 commit
-
-
Igor Babaev authored
-
- 08 Dec, 2010 4 commits
-
-
Igor Babaev authored
-
Igor Babaev authored
-
Igor Babaev authored
read after the last element of the array of rec_per_key values for an index. This caused a valgrind complain and probably could result in wrong estimates of the cardinality of index intersections.
-
Igor Babaev authored
-
- 07 Dec, 2010 2 commits
-
-
Igor Babaev authored
the same execution plan that is in the output of the corresponding EXPLAIN.
-
Igor Babaev authored
When ORing two AND-OR formulas the range optimizer could miss a conjunct in one of AND-OR formulas in the result. If the index merge union plan to access a table is formed by this formula that, in general, is not inferred from the original where/on condition,the query could return an incorrect result set.
-
- 06 Dec, 2010 3 commits
-
-
Igor Babaev authored
-
Igor Babaev authored
-
Igor Babaev authored
A crash may happenin the cases when the range optimizer tried to OR two index merge such that the second one contained less range trees than the first one. The bug was introduced by the patch of MWL#24: "index_merge: fair choice between index_merge union and range access".
-
- 05 Dec, 2010 2 commits
-
-
Igor Babaev authored
If a primary key was used in the index intersection for an InnoDB database the size of the memory allocated for the best index intersection plan was one element less than it was needed. That could cause a memory overwrite and a crash as a result of it.
-
Igor Babaev authored
A crash may happenin the cases when the range optimizer tried to OR two index merge such that the second one contained less range trees than the first one. The bug was introduced by the patch of MWL#24: "index_merge: fair choice between index_merge union and range access".
-
- 04 Dec, 2010 7 commits
-
-
Igor Babaev authored
Made range_vs_index_merge.test platform independent
-
Michael Widenius authored
-
Michael Widenius authored
(Not critical, we will just catch the error later)
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
Added missing inc_counter_for_resize_op(pagecache). (caused maria.maria-preload.test to fail) storage/maria/ma_loghandler.c: Fixed compiler warning storage/maria/ma_pagecache.c: Added missing inc_counter_for_resize_op(pagecache). (caused maria.maria-preload.test to fail)
-
Igor Babaev authored
independent execution plans. Fixed a bug in Unique::unique_add that caused a crash for a query from index_intersect_innodb on some platforms. Fixed two bugs in opt_range.cc that led to the choice of not the cheapest plans for index intersections.
-
- 03 Dec, 2010 1 commit
-
-
Michael Widenius authored
Fixed timing test failures. Fixed a failure in the Aria engines page cache and log handler (found with maria.maria-big test) - This could cause a core dump when deleting big blobs. - Added test to end_pagecache() to verify that page cache was correctly used. - inc_counter_for_resize_op and dec_counter_for_resize_op are called same number of times. - All page cache blocks was properly deallocated (empty) mysql-test/suite/innodb/t/innodb_bug38231.test: Fixed timing issue (code comment says it all) mysql-test/suite/innodb_plugin/t/innodb_bug38231.test: Fixed timing issue (code comment says it all) sql/debug_sync.cc: Fixed compiler warning storage/maria/ma_loghandler.c: Fixed bug found by maria.maria-big test: - Fixed race condition between update thread logging a very big blog and checkpoint thread. storage/maria/ma_pagecache.c: Added assert to ensure mutex was properly locked. Added test to end_pagecache() to verify that page cache was correctly used. - inc_counter_for_resize_op and dec_counter_for_resize_op are called same number of times. - All page cache blocks was properly deallocated (empty) In pagecache_delete_internal(), properly reset counters and pins if functions aborts. Added missing inc_counter_for_resize_op() to pagecache_wait_lock(). Added missing dec_counter_for_resize_op() to pagecache_delete()
-
- 02 Dec, 2010 4 commits
-
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
unknown authored
- Make sure creation of t1 is replicated before trying to create trigger on it on slave - Use safe #ifdef for declaration as for definition to avoid warning about unused static function.
-
Igor Babaev authored
The second (final) patch.
-
- 01 Dec, 2010 4 commits
-
-
Vladislav Vaintroub authored
MTR_VS_CONFIG is now determined by looking at parent directory of sql\*\mysqld.exe, instead of looking at *\*\BuildLog.htm Reason : VS2010 does not create BuildLog.htm, hence prior method did not work.
-
Vladislav Vaintroub authored
- Remove all mentioning of /MAP /MAPINFO link options (does not work in VS2010). Remove map files from packaging. - Fix warning about ETIMEDOUT being redefined. - Fix warning about FSP_EXTENT_SIZE in xtradb (32/64 bit right shift mismatch) - Silence warnings coming from generated code (flex/bison) in xtradb/innodb_plugin. - Be nice to people without cygwin (me) and add win/configure-mariadb.bat with options suitable for quick compilation, e.g no embedded
-
Michael Widenius authored
-
Michael Widenius authored
mysql-test/suite/innodb_plugin/t/innodb_bug38231.test: Sometimes you get a timeout here; Disable the not fatal error message. storage/xtradb/sync/sync0rw.c: Disable compiler warning
-
- 30 Nov, 2010 2 commits
-
-
unknown authored
An INSERT query log event is preceeded by an INSERT_ID intvar event if the INSERT allocates a new auto_increment value. But if we ignore the INSERT due to --replicate-ignore-table or similar, then the INSERT_ID event is still executed, and the set value of INSERT_ID lingers around in the slave sql thread THD object indefinitely until the next INSERT that happens to need allocation of a new auto_increment value. Normally this does not cause problems as such following INSERT would normally come with its own INSERT_ID event. In this bug, the user had a trigger on the slave which was missing on the master, and this trigger had an INSERT which could be affected. In any case, it seems better to not leave a stray INSERT_ID hanging around in the sql thread THD indefinitely. Note that events can also be skipped from apply_event_and_update_pos(); however it is not possible in that code to skip the INSERT without also skipping the INSERT_ID event.
-
Michael Widenius authored
-
- 29 Nov, 2010 4 commits
-
-
Michael Widenius authored
configure.in: Added comment mysql-test/suite/innodb_plugin/t/innodb_bug56680.test: Disable test when run with valgrind as we get errors from buf_buddy_relocate() on work for this test. (Should probably be investigated as this may be an issue in xtradb, but probably harmless) Work is an amd-64 running openSUSE 1.11 and valgrind 3.4.1 mysys/charset.c: Remove static function if not used (to remove compiler warning) storage/xtradb/srv/srv0srv.c: Added casts to get rid of compiler warnings
-
Hakan Kuecuekyilmaz authored
-
Michael Widenius authored
-
Michael Widenius authored
- Removed SCCS rule from Makefile.am - Made dummy rule in sql_yacc.yy to get rid of compiler warning about not used label. Don't use maintainer mode with valgrind (as we don't want to initialize all variables) config/ac-macros/maintainer.m4: Don't use maintainer mode with valgrind (as we don't want to initialize all variables) Force initialization of variables when using -Werror (To get rid of compiler warnings) configure.in: Don't use maintainer mode with valgrind (as we don't want to initialize all variables) sql/sql_yacc.yy: Made dummy rule in sql_yacc.yy to get rid of compiler warning about not used label.
-
- 26 Nov, 2010 2 commits
-
-
Michael Widenius authored
extra/libevent/event.c: Tried to fix compiler warning on windows extra/libevent/evutil.h: Define __attribute__ for not gcc compilers extra/libevent/kqueue.c: Fixed compiler warnings extra/libevent/signal.c: Tried to fix compiler warning on windows storage/pbxt/src/ha_pbxt.cc: Fixed compiler warning about "variable might be clobbered by longjmp" storage/pbxt/src/table_xt.cc: Fixed compiler warnings (on windows) storage/xtradb/handler/i_s.cc: Fixed compiler warning by invoking the correct store function.
-
Michael Widenius authored
Fix post-merge failure in 5.1-merge - Let QUICK_RANGE_INTERSECT_SELECT not make assumption that HA_EXTRA_KEYREAD scans do not touch parts of table->record[0] that refer to fields that are not covered by the used index. This assumption is not true for XtraDB (e.g. grep row/row0sel.c for "init null bytes with default values as they might be").
-
- 25 Nov, 2010 4 commits
-
-
Michael Widenius authored
-
Michael Widenius authored
mysql-test/include/have_not_innodb_plugin.inc: Also detect if xtradb is installed mysql-test/suite/innodb/t/innodb_bug56143.test: Disabled test case that doesn't work for innodb_plugin/xtradb. mysql-test/suite/innodb_plugin/r/innodb_bug56632.result: Updated result (key_block_size is lower case in MariaDB, as all other options) mysql-test/suite/pbxt/r/partition_hash.result: Updated results (after partition row count optimization changes) mysql-test/suite/pbxt/r/partition_pruning.result: Updated results (after partition row count optimization changes) mysql-test/suite/pbxt/r/partition_range.result: Updated results (after partition row count optimization changes) mysql-test/suite/pbxt/r/subselect.result: Updated result after ROW() changes.
-
Michael Widenius authored
Fixed compiler warnings in xtradb Added back resetting of null bitmap but now in row_search_for_mysql() storage/xtradb/row/row0sel.c: Added back resetting of null bitmap but now in row_search_for_mysql()
-
Michael Widenius authored
Introduced a new flag in the class Item. The flag is set to 1 only for items that are used in GROUP BY lists of queries with ROLLUP.
-