1. 01 Mar, 2005 17 commits
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · c8c1d6c0
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
      
      
      c8c1d6c0
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 50c10575
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0-ndb
      
      
      ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      50c10575
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 36dbdf01
      unknown authored
      into ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0
      
      
      36dbdf01
    • unknown's avatar
      Fix for Bug#5615 and merge from 4.1 · 53bfeb48
      unknown authored
      
      
      mysql-test/r/func_group.result:
        Added some tests and fix for Bug#5615.
      mysql-test/r/show_check.result:
        Fix for Bug#5615.
      mysql-test/t/func_group.test:
        Added some tests.
      sql/item_sum.cc:
        Fix for Bug#5615.
      sql/item_sum.h:
        Fix for Bug#5615.
      sql/sql_select.cc:
        Fix for Bug#5615.
      sql/sql_select.h:
        Fix for Bug#5615.
      53bfeb48
    • unknown's avatar
      ha_innodb.cc: · c0b12553
      unknown authored
        delete_all_rows(): Revert previous change.
        The transaction has been marked started already
        in external_lock().
      
      
      sql/ha_innodb.cc:
        delete_all_rows(): Revert previous change.
        The transaction has been marked started already
        in external_lock().
      c0b12553
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · 8c9d2612
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      
      sql/ha_innodb.cc:
        Auto merged
      8c9d2612
    • unknown's avatar
      ha_innodb.cc: · 0319b958
      unknown authored
        In TRUNCATE TABLE, MySQL may call innobase_xa_prepare() even though there is no active transaction because it was committed in ha_innobase::delete_all_rows(); in innobase_xa_prepare() InnoDB starts then a new transaction; let us adjust the trx->active_trans flag accordingly
      
      
      sql/ha_innodb.cc:
        In TRUNCATE TABLE, MySQL may call innobase_xa_prepare() even though there is no active transaction because it was committed in ha_innobase::delete_all_rows(); in innobase_xa_prepare() InnoDB starts then a new transaction; let us adjust the trx->active_trans flag accordingly
      0319b958
    • unknown's avatar
      After review fixes. Fix bugs in TRUNCATE. · 39cf45fd
      unknown authored
      
      innobase/dict/dict0crea.c:
        dict_truncate_index_tree(): Commit the mtr after deleting the
        index tree. Add diagnostics for error cases. Let the caller update
        SYS_INDEXES.PAGE_NO to the new root page number. Return the new
        root page number, or FIL_NULL on error.
      innobase/include/dict0crea.h:
        dict_truncate_index_tree(): Commit the mtr after deleting the
        index tree. Add diagnostics for error cases. Let the caller update
        SYS_INDEXES.PAGE_NO to the new root page number. Return the new
        root page number, or FIL_NULL on error.
      innobase/include/page0page.ic:
        page_mem_free(): Disable the memset() call, to make it possible to
        recover some data if someone accidentally deletes a large number
        of records from a table.
      innobase/log/log0recv.c:
        Do not disable InnoDB Hot Backup specific code in MySQL builds.
      innobase/row/row0mysql.c:
        row_truncate_table_for_mysql(): Remove an infinite loop in case
        a SYS_INDEXES record has been deleted. Avoid deadlocks by committing
        and restarting the mini-transaction.
      sql/ha_innodb.cc:
        ha_innobase::delete_all_rows(): set trx->active_trans = 1
      39cf45fd
    • unknown's avatar
      Merge marko@bk-internal.mysql.com:/home/bk/mysql-5.0 · 91fa4862
      unknown authored
      into hundin.mysql.fi:/home/marko/mysql-5.0
      
      
      91fa4862
    • unknown's avatar
      Merge · 42557374
      unknown authored
      
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      mysql-test/r/select_found.result:
        Auto merged
      mysql-test/r/show_check.result:
        Auto merged
      mysql-test/t/func_group.test:
        Auto merged
      mysql-test/t/show_check.test:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      strings/ctype-bin.c:
        Auto merged
      sql/sql_select.cc:
        SCCS merged
      42557374
    • unknown's avatar
    • unknown's avatar
      my_mmap.c: · 6b5ad3c1
      unknown authored
        Changed #warning pragma at the bottom to only occur when being used on non-Windows OS
      
      
      mysys/my_mmap.c:
        Changed #warning pragma at the bottom to only occur when being used on non-Windows OS
      6b5ad3c1
    • unknown's avatar
      InnoDB: Zero fill newly created pages and deleted records to · b9b69440
      unknown authored
      remove old junk and to improve compression ratio.
      InnoDB: Make implicit type conversions explicit. (Bug #8826)
      
      
      innobase/btr/btr0cur.c:
        Add "offsets" parameter to page_cur_delete_rec() calls
        btr_cur_optimistic_delete(): Simplify the logic with a flag variable
        btr_cur_pessimistic_delete(): Compute "offsets" earlier
      innobase/include/page0cur.h:
        page_cur_delete_rec(): Add parameter "offsets"
      innobase/include/page0page.h:
        page_mem_free(): Replace parameter "index" with "offsets"
      innobase/include/page0page.ic:
        page_mem_free(): Replace parameter "index" with "offsets".
        Clear the data bytes of the freed record.
        (The "extra" bytes will be needed by free space management.)
      innobase/include/rem0rec.h:
        Remove unnecessary function rec_get_size()
      innobase/log/log0recv.c:
        Remove function rec_apply_log_recs_for_backup()
        unless #ifdef UNIV_HOTBACKUP.
      innobase/page/page0cur.c:
        Add parameter "offsets" to page_cur_delete_rec().
      innobase/page/page0page.c:
        page_create(): Zero fill the data area.
        page_delete_rec_list_start(): Add parameter "offsets"
        to page_cur_delete_rec().
      innobase/rem/rem0rec.c:
        Remove unnecessary function rec_get_size().
        Fix compiler warnings about implicit type conversions.  (Bug #8826)
      innobase/srv/srv0srv.c:
        Fix compiler warnings about implicit type conversions. (Bug #8826)
      innobase/sync/sync0sync.c:
        Fix compiler warnings about implicit type conversions. (Bug #8826)
      b9b69440
    • unknown's avatar
      Fix for Bug#8801: the bug was in co-operation of Item_ref · 679088a2
      unknown authored
      with view-merge algorithm and prepared statements: in case when some
      Item_ref pointing to a view column was substituted with a reference 
      pointing to the view expression for that column
      Item_ref::ref member of the original Item_ref was left pointing to 
      not_found_item (0x1).
      As we currently perform expression substition part of the view-merge 
      algorithm per each execution of a prepared statement or stored procedure, 
      we need to preserve original Item_ref objects usable.
      
      
      sql/item.cc:
        Set member Item_ref::ref to null whenever the item itself is substituted 
        with another item.
        This is necessary if we want to re-execute a prepared statement next time.
        
        Additionally Item_ref::fix_fields() implementation was cleaned up
        (by Monty and myself) to reduce the number of if branches. This
        doesn't change the logic of this function.
      679088a2
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 59158b85
      unknown authored
      into mysql.com:/usr/home/ram/work/4.1.b6089
      
      
      sql/sql_select.cc:
        Auto merged
      59158b85
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 4dc33bc8
      unknown authored
      into mysql.com:/usr/home/ram/work/4.1.b6089
      
      
      sql/sql_select.cc:
        Auto merged
      4dc33bc8
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 81dea6cd
      unknown authored
      into mysql.com:/usr/home/ram/work/4.1.b5615
      
      
      mysql-test/r/show_check.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      81dea6cd
  2. 28 Feb, 2005 21 commits
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0 · ad1c1e07
      unknown authored
      into mysql.com:/home/cps/mysql/devel/im-fix-review
      
      
      mysys/default.c:
        Auto merged
      ad1c1e07
    • unknown's avatar
      fix compilation failure on sunfire280 · e99c035f
      unknown authored
      e99c035f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · ef7570c7
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      sql/sql_repl.cc:
        Auto merged
      ef7570c7
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 8400a5a4
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0
      
      
      8400a5a4
    • unknown's avatar
      Fix for BUG#8726: In JOIN::optimize on ER_TOO_BIG_SELECT error set JOIN::error to -1 to cause · d2ead18b
      unknown authored
      the error to be sent to the client.
      
      
      mysql-test/r/select_safe.result:
        Testcase for BUG#8726
      mysql-test/t/select_safe.test:
        Testcase for BUG#8726
      sql/sql_select.cc:
        Fix for BUG#8726: On ER_TOO_BIG_SELECT set JOIN::error to -1 to cause the error to be sent to the client.
      d2ead18b
    • unknown's avatar
      Merge mysql.com:/home/timka/mysql/src/5.0-virgin · ed3b4499
      unknown authored
      into mysql.com:/home/timka/mysql/src/5.0-bug-8532
      
      
      ed3b4499
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · cef636d9
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0
      
      
      cef636d9
    • unknown's avatar
      Fixed BUG#8760: Stored Procedures: Invalid SQLSTATE is allowed in · 110f6abd
      unknown authored
                      a DECLARE ? HANDLER FOR stmt.
      
      
      mysql-test/r/sp-error.result:
        New test case for BUG#8776 (check format of sqlstates in handler declarations).
      mysql-test/t/sp-error.test:
        New test case for BUG#8776 (check format of sqlstates in handler declarations).
      sql/share/errmsg.txt:
        New error message for malformed SQLSTATEs.
      sql/sp_pcontext.cc:
        Added function for checking SQLSTATE format.
      sql/sp_pcontext.h:
        Added function for checking SQLSTATE format.
      sql/sql_yacc.yy:
        Check format of SQLSTATE in handler declaration.
      110f6abd
    • unknown's avatar
      merging · f9dd79c7
      unknown authored
      
      mysql-test/r/ps.result:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      f9dd79c7
    • unknown's avatar
    • unknown's avatar
      Fixed BUG#7646: Stored procedure hang if show binlog events · cfff7e6e
      unknown authored
        Return false from show_binlog_events() if successful, otherwise stored
        procedures will think it failed.
      
      
      sql/sql_repl.cc:
        Return false from show_binlog_events() if successful, otherwise stored
        procedures will think it failed.
      cfff7e6e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 1b002905
      unknown authored
      into mysql.com:/home/my/mysql-5.0
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      include/mysql_com.h:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      1b002905
    • unknown's avatar
      Fix for BUG#8532. · 7a703d6a
      unknown authored
      The problem was in that the code that analyses the applicability of the
      QUICK_GROUP_MIN_MAX access method for DISTINC queries assumed that there
      are no duplicate column references in the DISTINCT clause, and it added
      non-exiting key parts for the duplicate column references. 
      
      The solution adds a test to check whether the select list already contained
      a field with the same name. If such field was already present, then it was
      already decided to use its key part for index access. In this such case we
      must skip the duplicate field instead of counting it as a new field.
      
      
      mysql-test/r/group_min_max.result:
        Added test results for BUG#8532.
      mysql-test/t/group_min_max.test:
        Added tests for BUG#8532.
      sql/opt_range.cc:
        The problem was in that the code that analyses the applicability of the
        QUICK_GROUP_MIN_MAX access method for DISTINC queries assumed that there
        are no duplicate column references in the DISTINCT clause, and it added
        non-exiting key parts for the duplicate column references. 
        
        The solution adds a test to check whether the select list already contained
        a field with the same name. If such field was already present, then it was
        already decided to use its key part for index access. In this such case we
        must skip the duplicate field instead of counting it as a new field.
      7a703d6a
    • unknown's avatar
      merging · 7865746c
      unknown authored
      
      mysql-test/r/show_check.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      7865746c
    • unknown's avatar
      portability fix · d4c2c747
      unknown authored
      d4c2c747
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.0 · ebdbe9e5
      unknown authored
      into mysql.com:/home/psergey/mysql-4.0-look
      
      
      ebdbe9e5
    • unknown's avatar
      Merge · c8b3d65c
      unknown authored
      c8b3d65c
    • unknown's avatar
      merge with 4.1 · 45a26d44
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/etc/logging_ok:
        auto-union
      client/mysql.cc:
        Auto merged
      client/mysqldump.c:
        Auto merged
      innobase/dict/dict0dict.c:
        Auto merged
      innobase/fil/fil0fil.c:
        Auto merged
      innobase/row/row0sel.c:
        Auto merged
      mysql-test/r/select_found.result:
        Auto merged
      mysql-test/r/type_set.result:
        Auto merged
      mysys/default.c:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      include/mysql_com.h:
        Merge
      sql/filesort.cc:
        merge
      45a26d44
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 8e3addf9
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      BitKeeper/etc/ignore:
        added support-files/ndb-config-2-node.ini
      8e3addf9
    • unknown's avatar
      Fixed wrong memory references found by purify · 8b8c9452
      unknown authored
      (No really critical errors found, but a few possible wrong results)
      
      
      innobase/dict/dict0dict.c:
        Replace memcmp with comparison of characters to avoid warnings from purify when 'sptr' points to a very short string
      mysql-test/r/select_found.result:
        Add missing drop table
      mysql-test/r/type_set.result:
        More tests
      mysql-test/t/select_found.test:
        Add missing drop table
      mysql-test/t/type_set.test:
        More tests
      mysys/my_init.c:
        Avoid warning from purify (purify doesn't handle getrusage() properly)
      sql/field.h:
        enum & set are sorted as numbers. This fixes an access to uninitialized memory when enum/set are multi-byte characters
      sql/filesort.cc:
        enum & set are sorted as numbers. This fixes an access to uninitialized memory when enum/set are multi-byte characters
      sql/item_cmpfunc.cc:
        Fixed warning from purify. (Not critical as the arguments are passed to a function but not used)
        Allocate Arg_comparator() with 'new' instead of sql_alloc() to ensure proper initialization
      sql/mysqld.cc:
        Wait for signal handler to stop when running --bootstrap
        (Fixes warning from purify)
      sql/sql_insert.cc:
        Initialize slot used by innodb.cc (not critical)
      sql/sql_lex.h:
        Better comments
      sql/sql_repl.cc:
        memcmp -> bcmp() to avoid warning from purify
      sql/sql_select.cc:
        Fix for out-of-bound memory reference when doing DISTINCT on const expressions
      strings/ctype-simple.c:
        Fixes to not access uninitialized memory
        (Not critical)
      8b8c9452
    • unknown's avatar
      Fixed small error in comment · 03a5cacc
      unknown authored
      03a5cacc
  3. 27 Feb, 2005 2 commits