1. 28 Jan, 2011 1 commit
  2. 27 Jan, 2011 4 commits
  3. 26 Jan, 2011 12 commits
    • Mattias Jonsson's avatar
      merge of bug 47902 and (null-merge) of bug 57924. · 6ae9810f
      Mattias Jonsson authored
      bug#57924 does not occur in 5.5, so I reverted the 5.1 specific
      code and used the errors from 5.5 instead in the tests
      6ae9810f
    • Mattias Jonsson's avatar
      merge · ec5e43da
      Mattias Jonsson authored
      ec5e43da
    • Mattias Jonsson's avatar
      merge · ad74ed74
      Mattias Jonsson authored
      ad74ed74
    • Jon Olav Hauglid's avatar
      Bug #42230 during add index, cannot do queries on storage engines · e99f2b1c
      Jon Olav Hauglid authored
                 that implement add_index
      
      The problem was that ALTER TABLE blocked reads on an InnoDB table
      while adding a secondary index, even if this was not needed. It is
      only needed for the final step where the .frm file is updated.
      
      The reason queries were blocked, was that ALTER TABLE upgraded the
      metadata lock from MDL_SHARED_NO_WRITE (which blocks writes) to
      MDL_EXCLUSIVE (which blocks all accesses) before index creation.
      
      The way the server handles index creation, is that storage engines
      publish their capabilities to the server and the server determines
      which of the following three ways this can be handled: 1) build a
      new version of the table; 2) change the existing table but with
      exclusive metadata lock; 3) change the existing table but without
      metadata lock upgrade.
      
      For InnoDB and secondary index creation, option 3) should have been
      selected. However this failed for two reasons. First, InnoDB did
      not publish this capability properly.
      
      Second, the ALTER TABLE code failed to made proper use of the
      information supplied by the storage engine. A variable
      need_lock_for_indexes was set accordingly, but was not later used.
      This patch fixes this problem by only doing metadata lock upgrade
      before index creation/deletion if this variable has been set.
      
      This patch also changes some of the related terminology used 
      in the code. Specifically the use of "fast" and "online" with
      respect to ALTER TABLE. "Fast" was used to indicate that an
      ALTER TABLE operation could be done without involving a
      temporary table. "Fast" has been renamed "in-place" to more
      accurately describe the behavior.
      
      "Online" meant that the operation could be done without taking
      a table lock. However, in the current implementation writes
      are always prohibited during ALTER TABLE and an exclusive
      metadata lock is held while updating the .frm, so ALTER TABLE
      is not completely online. This patch replaces "online" with 
      "in-place", with additional comments indicating if concurrent
      reads are allowed during index creation/deletion or not.
      
      An important part of this update of terminology is renaming
      of the handler flags used by handlers to indicate if index
      creation/deletion can be done in-place and if concurrent reads
      are allowed. For example, the HA_ONLINE_ADD_INDEX_NO_WRITES
      flag has been renamed to HA_INPLACE_ADD_INDEX_NO_READ_WRITE,
      while HA_ONLINE_ADD_INDEX is now HA_INPLACE_ADD_INDEX_NO_WRITE.
      Note that this is a rename to clarify current behavior, the
      flag values have not changed and no flags have been removed or
      added.
      
      Test case added to innodb_mysql_sync.test.
      e99f2b1c
    • Ramil Kalimullin's avatar
      Auto-merge · 02b45f2a
      Ramil Kalimullin authored
      02b45f2a
    • Ramil Kalimullin's avatar
    • Ramil Kalimullin's avatar
      Bug #47811 : remove the non-default alignment specification. · 7083cb0b
      Ramil Kalimullin authored
      Fix backported from to 5.0.
      "Remove the alignment option, let valgrind use its default"
      
      
      mysql-test/mysql-test-run-shell.sh:
        Bug #47811 : remove the non-default alignment specification.
          - backport from 5.1
           "Remove the alignment option, let valgrind use its default"
      mysql-test/mysql-test-run.pl:
        Bug #47811 : remove the non-default alignment specification.
          - backport from 5.1
           "Remove the alignment option, let valgrind use its default"
      7083cb0b
    • Alfranio Correia's avatar
      merge mysql-5.1 --> mysql-5.5 · c4bedd13
      Alfranio Correia authored
      c4bedd13
    • Alfranio Correia's avatar
    • Libing Song's avatar
      Auto Merge. · ed1e03f0
      Libing Song authored
      ed1e03f0
    • Libing Song's avatar
      Null Merge. · 83f603b1
      Libing Song authored
      83f603b1
    • Libing Song's avatar
      Postfix bug#49124 · 8ec9bbaf
      Libing Song authored
      Updated the copyright.
      8ec9bbaf
  4. 25 Jan, 2011 6 commits
  5. 24 Jan, 2011 2 commits
  6. 21 Jan, 2011 2 commits
  7. 20 Jan, 2011 1 commit
  8. 19 Jan, 2011 7 commits
  9. 18 Jan, 2011 5 commits
    • Libing Song's avatar
      Automerge · 76d2e222
      Libing Song authored
      76d2e222
    • Anitha Gopi's avatar
      automerge · fb7a2a00
      Anitha Gopi authored
      fb7a2a00
    • Anitha Gopi's avatar
    • Libing Song's avatar
      Manual merge · 16c09339
      Libing Song authored
      16c09339
    • Libing Song's avatar
      Bug#58546 test rpl_packet timeout failure sporadically on PB · 77bc81b8
      Libing Song authored
                  
      rpl_packet got a timeout failure sporadically on PB when stopping
      slave. The real reason of this bug is that STOP SLAVE stopped
      IO thread first and then stopped SQL thread. It was
      possible that IO thread stopped after replicating part of a
      transaction which SQL thread was executing. SQL thread would
      be hung if the transaction could not be rolled back safely.
                  
      After this patch, STOP SLAVE will stop SQL thread first and then stop IO
      thread, which guarantees that IO thread will fetch the reset of the
      events of the transaction that SQL thread is executing, so that SQL
      thread can finish the transaction if it cannot be rolled back safely.
                  
      Added below auxiliary files to make the test code neater.
      restart_slave_sql.inc
      rpl_connection_master.inc
      rpl_connection_slave.inc
      rpl_connection_slave1.inc
      77bc81b8