An error occurred fetching the project authors.
  1. 20 May, 2005 2 commits
    • unknown's avatar
      compatibility issues · 027c10f3
      unknown authored
      Fixed errors reported by valgrind (some errors in NDB remains)
      
      
      myisam/rt_split.c:
        Added missing cast that caused problem on novell
        (minor code cleanup)
      ndb/src/ndbapi/Ndb.cpp:
        Moved DBUG_ENTER to remove warning from DBUG library
      sql/field_conv.cc:
        Added test for valgrind/purify to avoid warning
      sql/item_sum.cc:
        Removed comment and added ASSERT as setup can't be called twice anymore
      sql/sql_delete.cc:
        Fixed wrong return value
      sql/sql_parse.cc:
        More debugging
      sql/sql_select.cc:
        Removed duplicate call to setup() which caused a memory leak
      strings/my_vsnprintf.c:
        Added support for '%c' (used when printing my_getopt errors)
      027c10f3
    • unknown's avatar
      do not try to use equal field from outer query as field of local join (BUG#6384) · 648b072d
      unknown authored
      mysql-test/r/subselect.result:
        changes in plans
        test for bug#6384
      mysql-test/t/subselect.test:
        test for bug#6384
      sql/sql_select.cc:
        do not set equal field from outer query
      648b072d
  2. 18 May, 2005 2 commits
  3. 16 May, 2005 1 commit
    • unknown's avatar
      Fixed failing tests for not 32 bit intel machines · 70c4325d
      unknown authored
      Fixed bug in mysql_stmt_fetch() when retrieving rows to return
      
      
      mysql-test/r/ps.result:
        Fix to not get warnings if mysql_client_test.test fails
      mysql-test/t/index_merge_ror.test:
        Proper fix for 64 bit intel (which gives uses another, equal good index)
      mysql-test/t/ps.test:
        Fix to not get warnings if mysql_client_test.test fails
      sql-common/client.c:
        More debugging
      sql/sql_prepare.cc:
        Fixed bug in mysql_stmt_fetch() when retrieving rows to return
      sql/sql_select.cc:
        More debugging
      tests/mysql_client_test.c:
        More debugging
      70c4325d
  4. 12 May, 2005 1 commit
    • unknown's avatar
      A fix and test case for Bug#9478 "mysql_stmt_attr_set mysql_stmt_execute" · 2a8556f3
      unknown authored
      (crash on attempt to re-execute a statement with an open cursor) + 
      post-review fixes.
      
      
      include/errmsg.h:
        Add a special error message when we attempt to mysql_stmt_fetch
        from a statement which has no result set.
      libmysql/errmsg.c:
        Error message text for CR_NO_RESULT_SET
      libmysql/libmysql.c:
        Move the code which frees result sets on client and closes the cursor
        on server, resets long data state on client and server.
        This makes one function out of two (mysql_stmt_reset and
        mysql_stmt_free_result), thus aggregating all related reset work
        in one place.
      sql-common/client.c:
        Fix one place where we flushed the pending result set of a statement,
        but didn't set unbuffered_fetch_cancelled flag.
      sql/share/errmsg.txt:
        Fix format of ER_UNKNOWN_STMT_HANDLER error message (needs to
        be fixed separately in 4.1). Add two new error messages 
        for the case when we fetch from when there is no cursor
        and for the case when we attempt to execute a statement while there is
        a cursor.
      sql/sql_prepare.cc:
        Return error when we fetch while there is no open cursor and
        when we call execute while there is a pending cursor.
        Fix mysql_stmt_reset to close the open cursor if there is any.
      sql/sql_select.cc:
        free_items and free_root moved to Cursor::close().
      sql/sql_select.h:
        A comment added.
      tests/mysql_client_test.c:
        A test case for Bug#9478, test the case of mysql_stmt_reset
        called for client-side cached result set and for the case with open cursor.
        All strcpy replaced with strmov (review request).
      2a8556f3
  5. 10 May, 2005 1 commit
    • unknown's avatar
      Many files: · e02416c5
      unknown authored
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      view.test:
        Added test case for bug #8528.
      view.result:
        Added test case for bug #8528. Fixed other test cases.
      
      
      mysql-test/r/view.result:
        Added test case for bug #8528. Fixed other test cases.
      mysql-test/t/view.test:
        Added test case for bug #8528.
      sql/sql_base.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_delete.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_insert.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_parse.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_prepare.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_select.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_update.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/sql_view.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/table.cc:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      sql/table.h:
        Fixed bug #8528.
        Representation for single-table views was made similar to
        representation for multi-table views.
      e02416c5
  6. 08 May, 2005 1 commit
  7. 07 May, 2005 1 commit
  8. 06 May, 2005 1 commit
    • unknown's avatar
      Fixes while reviewing new code · ab54e167
      unknown authored
      Added option --count to mysqlshow (to show number of rows)
      Fixed possible core dump in information schema
      
      
      client/client_priv.h:
        --count for mysqlshow
      client/mysqlshow.c:
        Added option --count to be used when the user want's number of rows per table in the output
        (We shouldn't use count(*) as default as this can be a slow operation)
      mysys/my_thr_init.c:
        Correct comment
      sql/ha_berkeley.cc:
        Remove not used variable
      sql/ha_berkeley.h:
        Remove not used variable
      sql/ha_innodb.cc:
        Remove not used function
      sql/ha_ndbcluster.cc:
        false -> FALSE
        true -> TRUE
      sql/handler.cc:
        Added and fixed comments
        Remove 'strange' code to remove compiler warnings (better to do things like this with attribute)
      sql/item.cc:
        false -> FALSE
      sql/item_cmpfunc.cc:
        Fixed indentation
      sql/item_cmpfunc.h:
        marked BETWEEN as a bool function
      sql/item_func.cc:
        Simple optimzation
      sql/key.cc:
        Removed wrong code
      sql/log.cc:
        Check result from open_index_file()
      sql/mysql_priv.h:
        Simplyfy some test of netware
      sql/mysqld.cc:
        Fixed indentation
        Check result form open_index_file()
        Simplify code with IF_NETWARE()
      sql/opt_range.cc:
        false -> FALSE
        true -> TRUE
        Fixed indentation
      sql/opt_sum.cc:
        Fixed comments
      sql/sp_head.cc:
        Simple optimzation
        Move variable declarations to begining of blocks
      sql/sql_acl.cc:
        Fix long lines
        Rename xx -> column
        Move declaration to beginning of block
      sql/sql_parse.cc:
        Removed comment
      sql/sql_select.cc:
        Indentation fixes
      sql/sql_show.cc:
        Fixed reference outside of array (possible core dump)
      sql/sql_table.cc:
        Simplify code
        Combine common code
      sql/sql_test.cc:
        false -> FALSE
      sql/sql_trigger.cc:
        false -> false
        true -> TRUE
      sql/sql_yacc.yy:
        Simpler test
      sql/unireg.cc:
        Added comment
      ab54e167
  9. 05 May, 2005 2 commits
    • unknown's avatar
      Bug#9509 Optimizer: wrong result after AND with latin1_german2_ci · d8cf7e01
      unknown authored
      We cannot propagate constants with tricky collations.
      
      
      d8cf7e01
    • unknown's avatar
      A lot of fixes to Precision math · 6de14a23
      unknown authored
      Mostly about precision/decimals of the results of the operations
      
      
      include/decimal.h:
        decimal interface changed a little
      sql/field.cc:
        a lot of precision/decimals related changes to the Field_new_decimal
      sql/field.h:
        Field_new_decimal interface changed
      sql/ha_ndbcluster.cc:
        f->precision should be used here
      sql/item.cc:
        precision/decimals counting related changes
      sql/item.h:
        precision/decimals counting related changes
      sql/item_cmpfunc.cc:
        precision/decimals counting related changes
      sql/item_cmpfunc.h:
        precision/decimals counting related changes
      sql/item_func.cc:
        precision/decimals counting related changes
      sql/item_func.h:
        precision/decimals counting related changes
      sql/item_sum.cc:
        precision/decimals counting related changes
      sql/item_sum.h:
        precision/decimals counting related changes
      sql/my_decimal.cc:
        precision/decimals counting related changes
      sql/my_decimal.h:
        precision/decimals counting related changes
      sql/mysqld.cc:
        precision/decimals counting related changes
      sql/set_var.cc:
        precision/decimals counting related changes
      sql/sp_head.cc:
        dbug_decimal_print was replaced with dbug_decimal_as_string
      sql/sql_class.h:
        div_precincrement variable added
      sql/sql_parse.cc:
        precision/decimals counting related changes
      sql/sql_select.cc:
        precision/decimals counting related changes
      sql/sql_show.cc:
        Field::representation_length was removed
      strings/decimal.c:
        decimal_actual_fraction was introduced
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      6de14a23
  10. 30 Apr, 2005 1 commit
    • unknown's avatar
      A fix and a test case for Bug#9520 "SELECT DISTINCT crashes server · 963e94ce
      unknown authored
      with cursor". The patch refactors do_select/sub_select
      functions, which implement the nested loop algorithm, and reuses them to
      fetch rows for cursors as well.
      Pushing with view.test failing (--ps-protocol).
      
      
      sql/sql_prepare.cc:
         Cursor::fetch() now returns void
      sql/sql_select.cc:
        A fix for Bug#9520 "SELECT DISTINCT crashes server with cursor":
        * rename sub_select returns codes to be able to track down what's going
          on in which case.
        * move record processing and outer join record processing to a separate
          function, out of sub_select read-record loop.
        * use generalized sub_select() nested loop function for
        cursors instead of own loop implementation used in Cursor::fetch() before
      sql/sql_select.h:
        Replace all return values of sub_select family with enum.
        Add JOIN::resume_nested_loop flag to indicate we are restarting the nested loop
        for execution of next chunk of cursor's rows.
      tests/mysql_client_test.c:
        A test case for Bug#9520 "SELECT DISTINCT crashes server with cursor"
      963e94ce
  11. 29 Apr, 2005 1 commit
  12. 28 Apr, 2005 1 commit
    • unknown's avatar
      Fix for BUG#10244: · fe40de6f
      unknown authored
      Make get_quick_select_for_ref() accept estimated # records as parameter and 
      set QUICK_RANGE_SELECT::records, as this value is used to allocate buffers 
      in Multi-Range Read. 
      
      
      sql/opt_range.cc:
        Make get_quick_select_for_ref() accept estimated # records as parameter and 
        set QUICK_RANGE_SELECT::records, as this value is used to allocate buffers 
        in Multi-Range Read.
      sql/opt_range.h:
        Added "records" parameter to get_quick_select_for_ref()
      sql/sql_select.cc:
        Added "records" parameter to get_quick_select_for_ref()
      fe40de6f
  13. 26 Apr, 2005 2 commits
    • unknown's avatar
      be sure to call top_level_item() on the new Item_cond_and, · e5e73082
      unknown authored
      that merges ON and WHERE (BUG#10162)
      
      
      mysql-test/r/join_outer.result:
        BUG#10162 - ON is merged with WHERE, left join is convered to a regular join
      mysql-test/t/join_outer.test:
        BUG#10162 - ON is merged with WHERE, left join is convered to a regular join
      e5e73082
    • unknown's avatar
      Cleanups during review · bf17c826
      unknown authored
      mysys/default.c:
        Cleanup:
        - Just test once for recursion level
        - Don't test explicitely for \r or \n as my_isspace() already does that
      sql/sql_insert.cc:
        Fix argument
      sql/sql_select.cc:
        Fixed indentation
        added comment
      bf17c826
  14. 19 Apr, 2005 1 commit
    • unknown's avatar
      sql_select.cc: · 6a97b079
      unknown authored
        Fixed bug #9681.
        The bug happened with queries using derived tables specified by
        a SELECT with ROLLUP, such as:
        SELECT * FROM (SELECT a, SUM(a) FROM t1 GROUP BY a WITH ROLLUP) t2,
        if column a of table t1 is declared as NOT NULL.
        This was to the fact that the first column of the temporary table
        created to contain the derived table erroneously inherited the NOT NULL
        attribute from column a.
      olap.result, olap.test:
        Added a test case for bug #9681.
      
      
      mysql-test/t/olap.test:
        Added a test case for bug #9681.
      mysql-test/r/olap.result:
        Added a test case for bug #9681.
      sql/sql_select.cc:
        Fixed bug #9681.
        The bug happened with queries using derived tables specified by
        a SELECT with ROLLUP, such as:
        SELECT * FROM (SELECT a, SUM(a) FROM t1 GROUP BY a WITH ROLLUP) t2,
        if column a of table t1 is declared as NOT NULL.
        This was to the fact that the first column of the temporary table
        created to contain the derived table erroneously inherited the NOT NULL
        attribute from column a.
      6a97b079
  15. 18 Apr, 2005 1 commit
    • unknown's avatar
      Fix for BUG#9103: · 955ec71f
      unknown authored
      Don't produce data truncation warnings from within cp_buffer_from_ref(). This function
      is only used to make index search tuples and data truncation that occurs here has no
      relation with truncated values being saved into tables.
      
      
      mysql-test/r/update.result:
        Testcase for BUG#9103
      mysql-test/t/update.test:
        Testcase for BUG#9103
      sql/opt_range.cc:
        cp_buffer_from_ref now has THD* parameter
      sql/sql_select.h:
        cp_buffer_from_ref now has THD* parameter
      955ec71f
  16. 16 Apr, 2005 1 commit
    • unknown's avatar
      subselect.result, subselect.test: · 2b92a78e
      unknown authored
        Added a test case for bug #9338.
      sql_select.cc:
        Fixed bug #9338.
        When an occurence of a field reference has to be replaced
        by another field reference the whole Item_field must be
        replaced.
      item.cc:
        Fixed bug #9338.
        The method Item_field::replace_equal_field_processor was
        replaced by Item_field::replace_equal_field. The new method
        is used to replace the occurences of Item_field objects.
      item.h:
        Fixed bug #9338.
        The virtual function replace_equal_field_processor was replaced
        by replace_equal_field. The latter is supposed to be used as a
        callback function in calls of the method transform.
      
      
      sql/item.h:
        Fixed bug #9338.
        The virtual function replace_equal_field_processor was replaced
        by replace_equal_field. The latter is supposed to be used as a
        callback function in calls of the method transform.
      sql/item.cc:
        The method Item_field::replace_equal_field_processor was
        replaced by Item_field::replace_equal_field The new method
        is used to replace the occurences of Item_field objects.
      sql/sql_select.cc:
        Fixed bug #9338.
        When an occurence of a field reference has to be replaced
        by another field reference the whole Item_field must be
        replaced.
      mysql-test/t/subselect.test:
        Added a test case for bug #9338.
      mysql-test/r/subselect.result:
        Added a test case for bug #9338.
      2b92a78e
  17. 15 Apr, 2005 1 commit
  18. 07 Apr, 2005 3 commits
    • unknown's avatar
      Moved some old test and added a new test to only be run with mysql-test-run --big · e10d8144
      unknown authored
      Fixed warnings by valgrind for sum_distinct.test
      Enable buffered-record-reads after filesort for InnoDB tables with short primary key
      Enabled sort-with-data for MyISAM temporary files
      
      
      BitKeeper/etc/ignore:
        added tools/mysqltestmanager
      client/mysqltest.c:
        Ensure that BIG_TEST is always set to 0 or 1
        Fix the 'eval' also honors 'require'
      mysql-test/mysql-test-run.sh:
        Enlarge InnoDB table space for --big tests
      mysql-test/r/heap.result:
        Fix after adding more optimzation for filsort
      mysql-test/r/sum_distinct.result:
        Move 'slow' part of test to sum_distinct-big.test
      mysql-test/t/heap.test:
        Ensure that results are indpendent of optimizer
      mysql-test/t/sum_distinct.test:
        Move 'slow' part of test to sum_distinct-big.test
      sql/filesort.cc:
        Use 'sort with data' also on temporary files and with INSERT ... SELECT
      sql/ha_innodb.h:
        Remove HA_FAST_KEY_READ to enable buffered-record-reads after filesort
      sql/handler.h:
        More comments
      sql/mysql_priv.h:
        A bit smaller limit for cache for buffered-records-read (after testing)
      sql/records.cc:
        Don't use buffered-record-reads if ref_length > MAX_REFLENGTH
        Fixed warning from valgrind in 'sum_distinct'
      sql/sql_select.cc:
        Ensure that tempory tables has query_id set for all fields
        (Required for sort-with-data to work on temp files)
      e10d8144
    • unknown's avatar
      Post-review fixes: local variable renamed · ebbe7058
      unknown authored
      ebbe7058
    • unknown's avatar
      BUG#8877: Post-merge fixes. · 33e54bb8
      unknown authored
      33e54bb8
  19. 06 Apr, 2005 2 commits
    • unknown's avatar
      Minor fix in cursors execution. · df64ac0b
      unknown authored
      sql/sql_select.cc:
        Fix a discrepancy spotted after the setup_end_select_func patch has been 
        pushed: last join sweep assumes that join->tmp_table is zero.
      df64ac0b
    • unknown's avatar
      Refactor parts of do_select() (JOIN execution). · 61c8b3a8
      unknown authored
      sql/sql_select.cc:
        Bits of refactoring of do_select as one step forward to merge cursor and
        non-cursor execution.
        Moving send_fields (metadata handling) out of do_select to one level up
        and moving end_select setting to a separate function.
        This function is used in the Cursor::open() too.
      61c8b3a8
  20. 04 Apr, 2005 2 commits
    • unknown's avatar
      Removed extra comment · 6d2e510a
      unknown authored
      6d2e510a
    • unknown's avatar
      Fix for BUG#8877: Implementation of · 31f2f9bc
      unknown authored
      "Early NULL-values filtering for ref access" (attempt2+post-review fixes)
      1. update_ref_and_keys() accumulates info about null-rejecting
      predicates in in KEY_FIELD::null_rejecting, add_key_part saves
      these to KEYUSE.
      2. create_ref_for_key copies them to TABLE_REF.
      3. add_not_null_conds adds "x IS NOT NULL" to join_tab->select_cond of
      appropiate JOIN_TAB members.
      
      Includes code cleanups: 
      * add_key_field() params: s/COND/Item_func/ (as only Item_funcs are
      passed to it)
      * add_key_fields() params: JOIN_TAB *stat removed (wasn't used)
      
      
      sql/sql_select.cc:
        Fix for BUG#8877: Implementation of 
        "Early NULL-values filtering for ref access"
        1. update_ref_and_keys() accumulates info about null-rejecting
        predicates in in KEY_FIELD::null_rejecting, add_key_part saves
        these to KEYUSE.
        2. create_ref_for_key copies them to TABLE_REF.
        3. add_not_null_conds adds "x IS NOT NULL" to join_tab->select_cond
        of appropiate JOIN_TAB members.
        
        Includes code cleanups: 
        * add_key_field() params: s/COND/Item_func/ (as only Item_funcs are
        passed to it)
        * add_key_fields() params: JOIN_TAB *stat removed (wasn't used)
      sql/sql_select.h:
        Fix for BUG#8877: Implementation of 
        "Early NULL-values filtering for ref access" (attempt2)
      31f2f9bc
  21. 01 Apr, 2005 1 commit
  22. 31 Mar, 2005 1 commit
    • unknown's avatar
      Remove result.es files and support for them, which requires splitting · f0148b21
      unknown authored
      up a couple of tests and adjusting the output of others. Exposes two
      bugs (9472 and 9508).
      
      
      BitKeeper/deleted/.del-drop_temp_table.result.es~bc4cfb1ee1257458:
        Delete: mysql-test/r/drop_temp_table.result.es
      BitKeeper/deleted/.del-insert_select.result.es~ae7eb9891d6c07c4:
        Delete: mysql-test/r/insert_select.result.es
      BitKeeper/deleted/.del-myisam-blob.result.es~d498dae7d9f1a6d4:
        Delete: mysql-test/r/myisam-blob.result.es
      BitKeeper/deleted/.del-packet.result.es~6e71c3b634806185:
        Delete: mysql-test/r/packet.result.es
      BitKeeper/deleted/.del-query_cache.result.es~246ad731a517d9ab:
        Delete: mysql-test/r/query_cache.result.es
      BitKeeper/deleted/.del-select.result.es~240635f6a3f1a079:
        Delete: mysql-test/r/select.result.es
      BitKeeper/deleted/.del-type_blob.result.es~a4a0d4454b2d0218:
        Delete: mysql-test/r/type_blob.result.es
      BitKeeper/deleted/.del-type_float.result.es~a5533e4118eadc04:
        Delete: mysql-test/r/type_float.result.es
      BitKeeper/deleted/.del-type_ranges.result.es~bb77517f4c9dc978:
        Delete: mysql-test/r/type_ranges.result.es
      mysql-test/mysql-test-run.sh:
        Remove support for special result extension -- bad idea!
      mysql-test/t/ps_1general.test:
        Explain --replace_result
      mysql-test/r/insert_select.result:
        Update results
      mysql-test/r/select.result:
        Update results
      mysql-test/r/type_blob.result:
        Update results
      mysql-test/r/type_float.result:
        Update results
      mysql-test/r/type_ranges.result:
        Update results
      mysql-test/t/drop_temp_table.test:
        Skip this test with embedded server
      mysql-test/t/insert_select.test:
        Move binlog test to new file
      mysql-test/t/select.test:
        Replace grants column from 'show full columns'
      mysql-test/t/type_blob.test:
        Replace grants column from 'show full columns'
      mysql-test/t/type_float.test:
        Replace grants column from 'show full columns'
      mysql-test/t/type_ranges.test:
        Replace grants column from 'show full columns'
      sql/sql_select.cc:
        Fix conditional around query_cache_abort() call.
      f0148b21
  23. 30 Mar, 2005 2 commits
    • unknown's avatar
      Fix for BUG#9213: GROUP BY returns wrong query results: · 5ac4670b
      unknown authored
      Make test_if_skip_sort_order() rebuild tab->ref if it decides to use an index
      different from the index join optimizer has choosen.  
      
      
      mysql-test/r/group_by.result:
        Testcase for BUG#9213
      mysql-test/t/group_by.test:
        Testcase for BUG#9213
      sql/table.h:
        Added comments about TABLE::used_keys
      5ac4670b
    • unknown's avatar
      A fix (bug #9401: type_timestamp segfaults mysqld) · 216ed8c7
      unknown authored
      sql/sql_select.cc:
        A fix (bug #9401: type_timestamp segfaults mysqld).
        1. create_tmp_field_from_field() is modified to take 'Item_ref *item' and 'char *name'
        instead of 'bool modify_item' and 'Item *item'.
        2. For Item_sum_min/max we should never modify item, so NULL is 
        passed as item to the create_tmp_field_from_field().
      216ed8c7
  24. 28 Mar, 2005 1 commit
    • unknown's avatar
      fixed mechanism of detection selection from table wich we update · daddf263
      unknown authored
      (BUG##9398, BUG#8703)
      fixed wrong join view detection in multi-delete which lead to server crash
      
      
      mysql-test/r/lowercase_view.result:
        added new tests of updation and selection from the same table
      mysql-test/r/view.result:
        added new tests of updation and selection from the same table
        added test of multidelete command over join view which lead to server crash
        test suite from bugs #9398 and #8703
      mysql-test/t/lowercase_view.test:
        added new tests of updation and selection from the same table
      mysql-test/t/view.test:
        added new tests of updation and selection from the same table
        added test of multidelete command over join view which lead to server crash
        test suite from bugs #9398 and #8703
      sql/sql_base.cc:
        changed procedure of finding tables
      sql/sql_class.cc:
        added derived table procession detection
      sql/sql_class.h:
        added derived table procession detection
      sql/sql_delete.cc:
        fixed detection of selection from table which update for multidelete
      sql/sql_derived.cc:
        added derived table procession detection
      sql/sql_lex.cc:
        added detection os SELECTs processed inside derived tables
        removed old mechanism of multidelete/multiupdate table duplication detection (which can't work with views)
      sql/sql_lex.h:
        added detection os SELECTs processed inside derived tables
        removed old mechanism of multidelete/multiupdate table duplication detection (which can't work with views)
      sql/sql_parse.cc:
        removed wrong test of join view (for multidelete in can be not only first table)
      sql/sql_prepare.cc:
        added detection os SELECTs processed inside derived tables (reset it for reusing in PS/SP)
      sql/sql_select.cc:
        added detection os SELECTs processed inside derived tables
      sql/sql_update.cc:
        fixed detection of selection from table which update for multiupdate
      daddf263
  25. 24 Mar, 2005 1 commit
    • unknown's avatar
      Bug #9317: Wrong count for tables in INFORMATION_SCHEMA · a7f5977c
      unknown authored
        there was no check of result of 
        table->file->write_row() function. When count of rows was
        more than table max_rows(HEAP table) the following recodrs
        were not inserted to the table
        -'schema_table_store_record' function is added. 
          The function checks result of write_row function
          and convert HEAP table to MyISAM if necessary
        - Result check after write_row is added into all 
          I_S function which store the records to I_S tables  
      
      
      mysql-test/r/information_schema.result:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      mysql-test/t/information_schema.test:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      sql/sql_select.cc:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      sql/sql_show.cc:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      sql/table.h:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      a7f5977c
  26. 23 Mar, 2005 1 commit
    • unknown's avatar
      fixed union types merging and table related metadata (BUG#8824) · 5a425250
      unknown authored
      mysql-test/r/func_group.result:
        new result
      mysql-test/r/metadata.result:
        new result
        test of metadata of variables, unions and derived tables
      mysql-test/r/union.result:
        new results
        test of union of enum
      mysql-test/t/metadata.test:
        test of metadata of variables, unions and derived tables
      mysql-test/t/union.test:
        test of union of enum
      sql/field.cc:
        Field type merging rules added
        Fixed table name/alias returting for field made from temporary tables
      sql/field.h:
        removed unned field type reporting
      sql/item.cc:
        fixed bug in NEW_DATE type field creartion
        replaced mechanism of merging types of UNION
      sql/item.h:
        replaced mechanism of merging types of UNION
      sql/item_func.h:
        new item type to make correct field type detection possible
      sql/item_subselect.cc:
        added table name parameter to prepare() to show right table alias for derived tables
      sql/sql_derived.cc:
        added table name parameter to prepare() to show right table alias for derived tables
      sql/sql_lex.h:
        added table name parameter to prepare() to show right table alias for derived tables
      sql/sql_parse.cc:
        made function for enum/set pack length calculation
      sql/sql_prepare.cc:
        added table name parameter to prepare() to show right table alias for derived tables
      sql/sql_select.cc:
        new temporary table field creation by Item_type_holder
        fixed table alias for temporary table
      sql/sql_union.cc:
        added table name parameter to prepare() to show right table alias for derived tables
      5a425250
  27. 22 Mar, 2005 1 commit
  28. 21 Mar, 2005 1 commit
    • unknown's avatar
      Cleanups during review of code · 802c41e0
      unknown authored
      Fixed newly introduced bug in rollup
      
      
      client/mysqldump.c:
        Safer buffer allocation
        Removed wrong assert
      mysql-test/r/olap.result:
        more tests
      mysql-test/t/olap.test:
        more tests
      sql/handler.cc:
        Simple cleanup
        Fixed wrong check for next digit (wrong debug output)
      sql/item.cc:
        Replace shrink_to_length() with mark_as_const() as the former allowed one to do changes to the string
      sql/item_sum.cc:
        Change reference to pointer
        Trivial optimzation of testing 'allways_null'
      sql/mysqld.cc:
        Proper indentation of comment
      sql/sql_select.cc:
        Fixed newly introduced bug in rollup
      sql/sql_string.h:
        Remove not needed 'shrink_to_length()'
        Added 'mark_as_const()' to be used when one want to ensure that a string is not changed
      802c41e0
  29. 20 Mar, 2005 1 commit
    • unknown's avatar
      func_group.test, func_group.result: · 2ba3544f
      unknown authored
        Added a test case for bug #9210.
      sql_select.cc:
        Fixed bug #9210.
        The function calc_group_buffer did not cover the case
        when the GROUP BY expression was decimal.
        Slightly optimized the other code.
      
      
      sql/sql_select.cc:
        Fixed bug #9210.
        The function calc_group_buffer did not cover the case
        when the GROUP by expression was decimal.
        Slightly optimized the other code.
      mysql-test/t/func_group.test:
        Added a test case for bug #9210.
      2ba3544f
  30. 19 Mar, 2005 1 commit
    • unknown's avatar
      Eliminate warnings noticed by VC7. This includes fixing my_mmap() on · 892a6138
      unknown authored
      Windows to call CreateFileMapping() with correct arguments, and
      propogating the introduction of query_id_t to everywhere query ids are
      passed around. (Bug #8826)
      
      
      libmysql/libmysql.c:
        Make implicit cast explicit
      myisam/mi_open.c:
        Make cast of value to smaller data size explicit
      myisam/mi_packrec.c:
        Cast file size (my_off_t) to size_t for mmap
      mysys/my_mmap.c:
        Fix Windows version of my_mmap() to use the right parameters
        for call to CreateFileMapping()
      sql/field.cc:
        Use temporary value of correct type
      sql/field.h:
        Use query_id_t for query_id value
      sql/ha_berkeley.cc:
        Fix flag check
      sql/ha_innodb.h:
        Use query_id_t for query_id value
      sql/handler.cc:
        Explain opt_using_transactions calculation, and add cast
      sql/handler.h:
        Fix forward declaration of COND
      sql/item.cc:
        Fix val_bool() tests of val_int() to avoid implicit cast
      sql/item_cmpfunc.cc:
        Fix typo in switch label
      sql/item_func.cc:
        Make implicit cast explicit
      sql/item_strfunc.cc:
        Now that query_id is a query_id_t, need to cast it to a ulong here
      sql/item_subselect.cc:
        Fix test of value
      sql/log.cc:
        Cast my_off_t used for file size to size_t for memory allocation
        Also cast my_off_t when using it to calculate the number of pages for TC log
        Cast total_ha_2pc to uchar when saving it
      sql/mysql_priv.h:
        Move up query_id definition so it can be used more widely
      sql/opt_range.cc:
        Add unused delete operator to prevent compiler warning
      sql/set_var.cc:
        Cast value for max_user_connections
      sql/sql_cache.cc:
        Remove unused label
      sql/sql_class.h:
        Fix query id values to be of type query_id_t
      sql/sql_db.cc:
        Move variable only used inside #ifdef within the #ifdef
      sql/sql_help.cc:
        Remove unused label
      sql/sql_insert.cc:
        Use query_id_t for query id values
      sql/sql_lex.h:
        Add unused delete operator to prevent compiler warning
      sql/sql_select.cc:
        Remove unused variable
        Make cast of value explicit
      sql/sql_select.h:
        Use query_id_t for query id values
      sql/sql_table.cc:
        Make comparison to function pointer explicit
      sql/sql_update.cc:
        Use query_id_t for query id values
      sql/table.h:
        Use query_id_t for query id values
      strings/ctype-simple.c:
        Add cast of long value to (char) in expression
      strings/ctype-ucs2.c:
        Add cast of long value to (char) in expression
      strings/ctype-utf8.c:
        Make cast to smaller size explicit
      892a6138
  31. 18 Mar, 2005 1 commit
    • unknown's avatar
      olap.test: · ee2633a7
      unknown authored
        Added a test case for bug #8617.
      sql_select.cc:
        Fixed bug #8617.
        Queries with ROLLUP and LIMIT n returned more than n rows
        if SQL_CALC_FOUND_ROWS was used.
      
      
      sql/sql_select.cc:
        Fixed bug #8617.
        Queries with ROLLUP and LIMIT n returned more than n rows
        if SQL_CALC_FOUND_ROWS was used.
      mysql-test/t/olap.test:
        Added a test case for bug #8617.
      ee2633a7