1. 10 Dec, 2007 1 commit
  2. 07 Dec, 2007 1 commit
    • unknown's avatar
      Bug #27440 read_only allows create and drop database · 5826a5c4
      unknown authored
      When read_only option was enabled, a user without SUPER privilege could
      perform CREATE DATABASE and DROP DATABASE operations.
      
      This patch adds a check to make sure this isn't possible. It also attempts to 
      simplify the logic used to determine if relevant tables are updated,
      making it more human readable.
      
      
      mysql-test/r/read_only.result:
        Updated result file
      mysql-test/t/read_only.test:
        A test case is added which shows that it is not possible to drop or create a
        database in read-only mode despite having the GRANT permissions to do so,
        SUPER user excepted.
      sql/sql_parse.cc:
        - Simplified complex predicate by grouping it in a read friendly way.
        - Added predicate to fail on database updates while running in read-only
          mode.
      5826a5c4
  3. 28 Nov, 2007 4 commits
    • unknown's avatar
      Merge lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-base · 21fd6c0f
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-rt-merge
      
      
      sql/sql_yacc.yy:
        Auto merged
      sql-common/client.c:
        Auto merged
      21fd6c0f
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/31479-5.0 · aea86c66
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.0-runtime
      
      
      aea86c66
    • unknown's avatar
      Bug#31479 Bad lock interaction if CREATE TABLE LIKE is killed · 4b002635
      unknown authored
      Kill of a CREATE TABLE source_table LIKE statement waiting for a
      name-lock on the source table causes a bad lock interaction.
      
      The mysql_create_like_table() has a bug that if the connection is
      killed while waiting for the name-lock on the source table, it will
      jump to the wrong error path and try to unlock the source table and
      LOCK_open, but both weren't locked.
      
      The solution is to simple return when the name lock request is killed,
      it's safe to do so because no lock was acquired and no cleanup is needed.
      
      Original bug report also contains description of other problems
      related to this scenario but they either already fixed in 5.1 or
      will be addressed separately (see bug report for details).
      
      
      mysql-test/r/lock_multi.result:
        Add test case result for Bug#31479
      mysql-test/t/lock_multi.test:
        Add test case for Bug#31479
      sql/sql_table.cc:
        Rerturn TRUE when the lock gets killed.
      4b002635
    • unknown's avatar
      Bug#29149 Test "kill" fails on Windows · 7991e6a6
      unknown authored
      Disabled test case.
      
      
      7991e6a6
  4. 27 Nov, 2007 8 commits
  5. 26 Nov, 2007 8 commits
  6. 25 Nov, 2007 1 commit
  7. 23 Nov, 2007 8 commits
  8. 22 Nov, 2007 3 commits
    • unknown's avatar
      Merge endora.local:/Users/davi/mysql/bugs/32528-5.0 · a8b4bc81
      unknown authored
      into  endora.local:/Users/davi/mysql/mysql-5.0-runtime
      
      
      a8b4bc81
    • unknown's avatar
      Bug#32528 Global read lock with a low priority write lock causes a server crash · 719e64e4
      unknown authored
      FLUSH TABLES WITH READ LOCK fails to properly detect write locked
      tables when running under low priority updates.
      
      The problem is that when trying to aspire a global read lock, the
      reload_acl_and_cache() function fails to properly check if the thread
      has a low priority write lock, which later my cause a server crash or
      deadlock.
      
      The solution is to simple check if the thread has any type of the
      possible exclusive write locks.
      
      
      mysql-test/r/flush.result:
        Add test case result for Bug#32528
      mysql-test/t/flush.test:
        Add test case for Bug#32528
      sql/sql_parse.cc:
        Although it should not matter under LOCK TABLES, use TL_WRITE_ALLOW_WRITE
        to emphasize that it should fail in case of any write lock.
      719e64e4
    • unknown's avatar
      Merge lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-base · a11256f4
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-rt-merge
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      a11256f4
  9. 21 Nov, 2007 6 commits