1. 20 Jul, 2006 1 commit
    • unknown's avatar
      Bug#20471 LIKE search fails with indexed utf8 char column · d2f7fe35
      unknown authored
      The main problem was already fixed by Igor under terms of 16674.
      Adding some additional minor fixes and tests.
      
      
      include/m_ctype.h:
        Adding reference to CHARSET_INFO.txt
      mysql-test/r/ctype_utf8.result:
        Adding test case
      mysql-test/t/ctype_utf8.test:
        Adding test case
      strings/CHARSET_INFO.txt:
        Adding comment about max_sort_char
      strings/ctype-mb.c:
        Restiring that non-Unicode character sets use 0xFF as pad character
        for max_str. Only Unicode character sets use wc_mb.
      strings/ctype-utf8.c:
        Fixed that max_sort_char for UTF8 from U+00FF to U+FFFF.
      d2f7fe35
  2. 19 Jul, 2006 1 commit
    • unknown's avatar
      mysql.spec.sh: · b53e47a1
      unknown authored
        Added new "mysql_explain_log" man page
        Added missing install of "myisam_ftdump" man page
        Added missing install of "mysqlman" man page
      
      
      support-files/mysql.spec.sh:
        Added new "mysql_explain_log" man page
        Added missing install of "myisam_ftdump" man page
        Added missing install of "mysqlman" man page
      b53e47a1
  3. 18 Jul, 2006 3 commits
    • unknown's avatar
      Merge moonbone.local:/home/evgen/bk-trees/mysql-4.1 · 6abe1c71
      unknown authored
      into  moonbone.local:/work/tmp_merge-4.1-opt-mysql
      
      
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/t/date_formats.test:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      6abe1c71
    • unknown's avatar
      Merge moonbone.local:/work/mysql-4.1 · 5a77e566
      unknown authored
      into  moonbone.local:/work/tmp_merge-4.1-opt-mysql
      
      
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/t/date_formats.test:
        Auto merged
      5a77e566
    • unknown's avatar
      Backporting Kostja's changes made for 5.0 into 4.1. · d39e8532
      unknown authored
      Please use "ul" when merging this changeset to 5.0.
      
      
      sql/item_timefunc.cc:
        Fix a valgrind warning in type_date test.
      sql/sql_locale.cc:
        Fix a Windows build failure:  "false" -> FALSE
      d39e8532
  4. 15 Jul, 2006 1 commit
  5. 14 Jul, 2006 5 commits
  6. 13 Jul, 2006 6 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · ae3d1248
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.16017
      
      
      ae3d1248
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · d9992cc7
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.16017
      
      
      include/sql_common.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      libmysqld/libmysqld.c:
        merging
      d9992cc7
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 3c2bdb59
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/m41-maint--07AB5
      
      
      3c2bdb59
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1-maint · 5392be95
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/m41-maint--07AB5
      
      
      5392be95
    • unknown's avatar
      Merge igreenhoe@bk-internal.mysql.com:/home/bk/mysql-4.1-maint · 4bdc4251
      unknown authored
      into  anubis.greendragongames.com:/home/greenman/workspace-mysql/mysql/pending/bug-4.1-15977
      
      
      4bdc4251
    • unknown's avatar
      Bug#20432: mysql client interprets commands in comments · 76215977
      unknown authored
      do not look for client-specific commands while inside a multi-line comment.
      we will allow multi-comments pretty much anywhere within SQL-statements,
      but client-specific commands (help, use, print, ...) must be the first token
      in the input.
      
      
      client/mysql.cc:
        Bug#20432: mysql client interprets commands in comments
      mysql-test/r/mysql_client.result:
        Bug#20432: mysql client interprets commands in comments
        test client-side parsing of comments and client-specific commands
      mysql-test/t/mysql_client.test:
        Bug#20432: mysql client interprets commands in comments
        test client-side parsing of comments and client-specific commands
      76215977
  7. 12 Jul, 2006 4 commits
    • unknown's avatar
      Merge dl145k.mysql.com:/data0/mkindahl/bkroot/mysql-4.1 · 17870724
      unknown authored
      into  dl145k.mysql.com:/data0/mkindahl/bk/mysql-4.1-rpl
      
      
      17870724
    • unknown's avatar
      Bug #17212 results not sorted correctly by ORDER BY when using index · 41445430
      unknown authored
        * don't use join cache when the incoming data set is already ordered
          for ORDER BY
          This choice must be made because join cache will effectively
          reverse the join order and the results will be sorted by the index
          of the table that uses join cache.
      
      
      mysql-test/r/innodb_mysql.result:
        Bug #17212 results not sorted correctly by ORDER BY when using index
          * Test suite for the bug
      mysql-test/t/innodb_mysql.test:
        Bug #17212 results not sorted correctly by ORDER BY when using index
          * Test suite for the bug
      sql/sql_select.cc:
        Bug #17212 results not sorted correctly by ORDER BY when using index
          * don't use join cache when the incoming data set is already sorted
      41445430
    • unknown's avatar
      Merge cmiller@bk-internal.mysql.com:/home/bk/mysql-4.1 · 0f7258e0
      unknown authored
      into  maint1.mysql.com:/data/localhome/cmiller/mysql-4.1
      
      
      0f7258e0
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · e2c448fb
      unknown authored
      into  moonbone.local:/work/16302-bug-4.1-opt-mysql
      
      
      mysql-test/r/subselect.result:
        SCCS merged
      mysql-test/t/subselect.test:
        SCCS merged
      e2c448fb
  8. 11 Jul, 2006 8 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 03dbc219
      unknown authored
      into  moonbone.local:/work/18503-bug-4.1-mysql
      
      
      sql/sql_select.cc:
        Auto merged
      03dbc219
    • unknown's avatar
      Fixed bug#18503: Queries with a quantified subquery returning empty set · d2bbf288
      unknown authored
      may return a wrong result.
      
      An Item_sum_hybrid object has the was_values flag which indicates whether any
      values were added to the sum function. By default it is set to true and reset
      to false on any no_rows_in_result() call. This method is called only in
      return_zero_rows() function. An ALL/ANY subquery can be optimized by MIN/MAX
      optimization. The was_values flag is used to indicate whether the subquery
      has returned at least one row. This bug occurs because return_zero_rows() is
      called only when we know that the select will return zero rows before
      starting any scans but often such information is not known.
      In the reported case the return_zero_rows() function is not called and
      the was_values flag is not reset to false and yet the subquery return no rows
      Item_func_not_all and Item_func_nop_all functions return a wrong
      comparison result.
      
      The end_send_group() function now calls no_rows_in_result() for each item
      in the fields_list if there is no rows were found for the (sub)query.
      
      
      mysql-test/t/subselect.test:
        Added test case for bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
      mysql-test/r/subselect.result:
        Added test case for bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
      sql/sql_select.cc:
        Fixed bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
        
        The end_send_group() function now calls no_rows_in_result() for each item
        in the fields_list if there is no matching rows were found.
      d2bbf288
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 26ddd5cb
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/m41-maint--07AB5
      
      
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/t/date_formats.test:
        Auto merged
      26ddd5cb
    • unknown's avatar
      Bug#20729: Bad date_format() call makes mysql server crash · ed001f18
      unknown authored
          
      The problem is that the author used the wrong function to send a warning to the 
      user about truncation of data.  push_warning() takes a constant string and 
      push_warning_printf() takes a format and variable arguments to fill it.
      
      Since the string we were complaining about contains percent characters, the 
      printf() code interprets the "%Y" et c. that the user sends.  That's wrong, and
      often causes a crash, especially if the date mentions seconds, "%s".
      
      A alternate fix would be to use  push_warning_printf(..., "%s", warn_buff) .
      
      
      mysql-test/r/date_formats.result:
        Test that an invalid date doesn't crash the server.  We should get a warning back 
        instead of a dead socket.
      mysql-test/t/date_formats.test:
        Test that an invalid date doesn't crash the server.  We should get a warning back 
        instead of a dead socket.
      sql/time.cc:
        Don't try to use warn_buf as the start of a varible arguement list to send 
        to a warning-formatted my_vsnprintf() .
      ed001f18
    • unknown's avatar
      ndb - (4.1) trivial fix to error.log (wday=0 was printed as "x") · 27721ce5
      unknown authored
      
      ndb/src/kernel/error/TimeModule.cpp:
        0=Sunday
      27721ce5
    • unknown's avatar
      Merge moonbone.local:/work/allany-4.1-mysql · bf01313c
      unknown authored
      into  moonbone.local:/work/16302-bug-4.1-opt-mysql
      
      
      bf01313c
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 7642d181
      unknown authored
      into  moonbone.local:/home/evgen/bk-trees/mysql-4.1-opt
      
      
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      7642d181
    • unknown's avatar
      Merge zippy.(none):/home/cmiller/work/mysql/mysql-4.0__bug19006 · d1a31ef5
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/merge/mysql-4.1
      
      
      client/sql_string.h:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/sql_string.h:
        Auto merged
      configure.in:
        Null merge.
      sql/item_strfunc.cc:
        Null merged
      d1a31ef5
  9. 10 Jul, 2006 7 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 7bea031d
      unknown authored
      into  moonbone.local:/work/allany-4.1-mysql
      
      
      7bea031d
    • unknown's avatar
      Fixed bug#16302: Quantified subquery without any tables gives wrong results · ad88eabd
      unknown authored
      The ALL/ANY subqueries are the subject of MIN/MAX optimization. The matter
      of this optimization is to embed MIN() or MAX() function into the subquery
      in order to get only one row by which we can tell whether the expression
      with ALL/ANY subquery is true or false.
      But when it is applied to a subquery like 'select a_constant' the reported bug
      occurs. As no tables are specified in the subquery the do_select() function 
      isn't called for the optimized subquery and thus no values have been added 
      to a MIN()/MAX() function and it returns NULL instead of a_constant.
      This leads to a wrong query result.
      
      For the subquery like 'select a_constant' there is no reason to apply
      MIN/MAX optimization because the subquery anyway will return at most one row.
      Thus the Item_maxmin_subselect class is more appropriate for handling such
      subqueries.
      
      The Item_in_subselect::single_value_transformer() function now checks
      whether tables are specified for the subquery. If no then this subselect is
      handled like a UNION using an Item_maxmin_subselect object.
      
      
      mysql-test/t/subselect.test:
        Added test case for bug#16302: Quantified subquery without any tables gives wrong results
      mysql-test/r/subselect.result:
        Added test case for bug#16302: Quantified subquery without any tables gives wrong results
      sql/item_subselect.cc:
        Fixed bug#16302: Quantified subquery without any tables gives wrong results
         
        The Item_in_subselect::single_value_transformer() function now checks
        whether tables are specified for the subquery. If no then this subselect is
        handled like a UNION using an Item_maxmin_subselect object.
      ad88eabd
    • unknown's avatar
      Merge rakia:mysql/4.1/B14553 · ca1e4aab
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B14553-4.1-opt
      
      
      sql/sql_class.cc:
        SCCS merged
      sql/sql_select.cc:
        SCCS merged
      ca1e4aab
    • unknown's avatar
      BUG#14553: NULL in WHERE resets LAST_INSERT_ID · 0806d9a8
      unknown authored
      To make MySQL compatible with some ODBC applications, you can find
      the AUTO_INCREMENT value for the last inserted row with the following query:
       SELECT * FROM tbl_name WHERE auto_col IS NULL.
      This is done with a special code that replaces 'auto_col IS NULL' with
      'auto_col = LAST_INSERT_ID'.
      However this also resets the LAST_INSERT_ID to 0 as it uses it for a flag
      so as to ensure that only the first SELECT ... WHERE auto_col IS NULL
      after an INSERT has this special behaviour.
      In order to avoid resetting the LAST_INSERT_ID a special flag is introduced
      in the THD class. This flag is used to restrict the second and subsequent
      SELECTs instead of LAST_INSERT_ID.
      
      
      mysql-test/r/odbc.result:
        test suite for the bug
      mysql-test/r/rpl_insert_id.result:
        test for the fix in replication
      mysql-test/t/odbc.test:
        test suite for the bug
      mysql-test/t/rpl_insert_id.test:
        test for the fix in replication
      sql/sql_class.cc:
        initialize the flag
      sql/sql_class.h:
        flag's declaration and set code when setting the last_insert_id
      sql/sql_select.cc:
        the special flag is used instead of last_insert_id
      0806d9a8
    • unknown's avatar
      ndb - bug#20847: non-debug compile fix · 665db1a6
      unknown authored
      
      ndb/src/kernel/blocks/dbtup/DbtupMeta.cpp:
        non-debug compile fix
      665db1a6
    • unknown's avatar
      Merge orca.ndb.mysql.com:/space/pekka/ndb/version/my41 · 9be46326
      unknown authored
      into  orca.ndb.mysql.com:/space_old/pekka/ndb/version/my41-bug20847
      
      
      9be46326
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-4.1 · d6d8749c
      unknown authored
      into  orca.ndb.mysql.com:/space_old/pekka/ndb/version/my41
      
      
      d6d8749c
  10. 09 Jul, 2006 1 commit
    • unknown's avatar
      BUG#20919 temp tables closing fails when binlog is off · 868fee4d
      unknown authored
      closing temp tables through end_thread
      had a flaw in binlog-off branch of close_temporary_tables where
      next table to close was reset via table->next
       for (table= thd->temporary_tables; table; table= table->next)
      which was wrong since the current table instance got destoyed at
      	close_temporary(table, 1);
      
      The fix adapts binlog-on branch method to engage the loop's internal 'next' variable which holds table->next prior table's destoying.
      
      
      
      sql/sql_base.cc:
        no-binlog branch is fixed: scanning across temporary_tables must be careful to save next table since the current is being destroyed inside of close_temporary. 
        binlog-is-open case is ok.
      868fee4d
  11. 08 Jul, 2006 3 commits