1. 24 Jan, 2015 1 commit
  2. 23 Jan, 2015 2 commits
    • Olivier Bertrand's avatar
      - This to fix MDEV-7498. All changes made to AllocateValue to be sure that · 2cd36ad7
      Olivier Bertrand authored
        the sp and p variable be initialised failed. Not understanding what causes
        this valgrind warning, I finally changed the way Mulval is allocated just
        to avoid it. This is a BAD solution as it does not really fix the problem
        but just hide it. This will have to be re-considered.
      modified:
        storage/connect/tabjson.cpp
        storage/connect/value.cpp
      2cd36ad7
    • Olivier Bertrand's avatar
      - Fix MDEV-7489 (in add_field) · dc091a29
      Olivier Bertrand authored
      modified:
        storage/connect/ha_connect.cc
      
      - Fix MDEV-7494 (adding Insert_quoted in the STRING class)
      modified:
        storage/connect/tabmysql.cpp
        storage/connect/xobject.cpp
        storage/connect/xobject.h
      
      - Fix MDEV-7498 in value.cpp (AllocateValue)
      modified:
        storage/connect/value.cpp
      
      - Handle backslash in Json serialize + uchar + typo.
      modified:
        storage/connect/json.cpp
        storage/connect/tabjson.cpp
      dc091a29
  3. 20 Jan, 2015 2 commits
    • Olivier Bertrand's avatar
      - Last revision was to add the JSON table type. This one adds a sort · e5767723
      Olivier Bertrand authored
        on the multiple table result to obtain the same result on Windows
        and Linux (because files can be retrieved in a different order)
      modified:
        storage/connect/mysql-test/connect/r/json.result
        storage/connect/mysql-test/connect/t/json.test
      e5767723
    • Olivier Bertrand's avatar
      - Fix compile errors and warnings of LINUX G++ · 8fc69564
      Olivier Bertrand authored
      added:
        storage/connect/json.cpp
        storage/connect/json.h
        storage/connect/mysql-test/connect/r/json.result
        storage/connect/mysql-test/connect/std_data/biblio.jsn
        storage/connect/mysql-test/connect/std_data/expense.jsn
        storage/connect/mysql-test/connect/std_data/mulexp3.jsn
        storage/connect/mysql-test/connect/std_data/mulexp4.jsn
        storage/connect/mysql-test/connect/std_data/mulexp5.jsn
        storage/connect/mysql-test/connect/t/json.test
        storage/connect/tabjson.cpp
        storage/connect/tabjson.h
      modified:
        storage/connect/CMakeLists.txt
        storage/connect/engmsg.h
        storage/connect/filamtxt.h
        storage/connect/ha_connect.cc
        storage/connect/msgid.h
        storage/connect/mycat.cc
        storage/connect/plgdbsem.h
        storage/connect/tabdos.cpp
        storage/connect/value.cpp
        storage/connect/value.h
      8fc69564
  4. 19 Jan, 2015 1 commit
    • Olivier Bertrand's avatar
      - Adding the JSON table type · 2d2e110b
      Olivier Bertrand authored
      added:
        storage/connect/json.cpp
        storage/connect/json.h
        storage/connect/mysql-test/connect/r/json.result
        storage/connect/mysql-test/connect/std_data/biblio.jsn
        storage/connect/mysql-test/connect/std_data/expense.jsn
        storage/connect/mysql-test/connect/std_data/mulexp3.jsn
        storage/connect/mysql-test/connect/std_data/mulexp4.jsn
        storage/connect/mysql-test/connect/std_data/mulexp5.jsn
        storage/connect/mysql-test/connect/t/json.test
        storage/connect/tabjson.cpp
        storage/connect/tabjson.h
      modified:
        storage/connect/CMakeLists.txt
        storage/connect/engmsg.h
        storage/connect/filamtxt.h
        storage/connect/ha_connect.cc
        storage/connect/msgid.h
        storage/connect/mycat.cc
        storage/connect/plgdbsem.h
        storage/connect/tabdos.cpp
        storage/connect/value.cpp
        storage/connect/value.h
      2d2e110b
  5. 17 Jan, 2015 2 commits
    • Olivier Bertrand's avatar
      - Fix two bugs concerning Discovery of CSV tables: · fb3f4696
      Olivier Bertrand authored
        Sep_char default is now ',' like when discovery is not used
        If data_charset is UTF8, column names retrieved from the header
        are no longer converted to UTF8 considering they already are (MDEV-7421)
      modified:
        storage/connect/ha_connect.cc
      fb3f4696
    • Olivier Bertrand's avatar
      - Fix two bugs concerning Discovery of CSV tables: · f5beda48
      Olivier Bertrand authored
        Sep_char default is now ',' like when discovery is not used
        If data_charset is UTF8, column names retrieved from the header
        are no longer converted to UTF8 considering they already are.
      modified:
        storage/connect/ha_connect.cc
      f5beda48
  6. 13 Jan, 2015 1 commit
  7. 09 Jan, 2015 1 commit
  8. 06 Jan, 2015 2 commits
    • Olivier Bertrand's avatar
      - Typo to eliminate some GCC warnings · d4bf6455
      Olivier Bertrand authored
      modified:
        storage/connect/odbconn.cpp
        storage/connect/plgdbsem.h
      d4bf6455
    • Olivier Bertrand's avatar
      - Set connection charset before calling mysql_real_connect for MYSQL · afd373c1
      Olivier Bertrand authored
        tables. This should fix bug MDEV-7343.
      modified:
        storage/connect/ha_connect.cc
        storage/connect/myconn.cpp
        storage/connect/myconn.h
        storage/connect/reldef.cpp
        storage/connect/reldef.h
        storage/connect/table.cpp
        storage/connect/tabmysql.cpp
        storage/connect/xtable.h
      
      - Prevent double column evaluation when CONNECT does filtering
      modified:
        storage/connect/connect.cc
      
      - Export CreateFileMap and CloseMemMap (for OEM tables)
      modified:
        storage/connect/maputil.h
      
      - Add the compute function to be used on VALUE types.
        Preserve precision for DOUBLE values.
      modified:
        storage/connect/value.cpp
        storage/connect/value.h
      
      - Typo (in preparation to the future JSON table type)
      modified:
        storage/connect/ha_connect.cc
        storage/connect/mycat.cc
        storage/connect/plgdbsem.h
      afd373c1
  9. 14 Dec, 2014 1 commit
    • Olivier Bertrand's avatar
      - Temporary fix for MDEV-7304. · 8761f22a
      Olivier Bertrand authored
      modified:
        storage/connect/rcmsg.c
      
      - Avoid Memory copying when reading an ODBC table when the entire table
        is already in the result set.
      modified:
        storage/connect/odbconn.cpp
        storage/connect/odbconn.h
        storage/connect/tabodbc.cpp
        storage/connect/tabodbc.h
      8761f22a
  10. 24 Nov, 2014 3 commits
  11. 23 Nov, 2014 1 commit
  12. 20 Nov, 2014 3 commits
  13. 16 Nov, 2014 2 commits
    • Olivier Bertrand's avatar
      - Commit resolved conflicted files · cfa872f6
      Olivier Bertrand authored
      modified:
        storage/connect/engmsg.h
        storage/connect/filamtxt.cpp
      cfa872f6
    • Olivier Bertrand's avatar
      - Remove gcc warning (no previous declaration of msglang) · b9165cb5
      Olivier Bertrand authored
      modified:
        storage/connect/ha_connect.cc
      
      - Define strcasecmp for Linux
      modified:
        storage/connect/rcmsg.c
      
      - Avoid potential buffer overflow
      modified:
        storage/connect/plgdbutl.cpp
        
      - Change %d in %lld in VALUE_TOO_BIG message
      modified:
        storage/connect/encas.h
        storage/connect/english.msg
        storage/connect/frcas.h
        storage/connect/french.msg
        storage/connect/frmsg.h
      b9165cb5
  14. 15 Nov, 2014 1 commit
    • Olivier Bertrand's avatar
      - Implement the NEWMSG and XMSG methods · 5d831196
      Olivier Bertrand authored
        They are still experimental and should not be used in production.
      added:
        storage/connect/encas.h
        storage/connect/english.msg
        storage/connect/enids.h
        storage/connect/frcas.h
        storage/connect/french.msg
        storage/connect/frids.h
        storage/connect/frmsg.h
      modified:
        storage/connect/connect.cc
        storage/connect/engmsg.h
        storage/connect/filamdbf.cpp
        storage/connect/global.h
        storage/connect/ha_connect.cc
        storage/connect/msgid.h
        storage/connect/plgdbutl.cpp
        storage/connect/plugutil.c
        storage/connect/rcmsg.c
        storage/connect/resource.h
        storage/connect/tabfmt.h
      
      - Fix global variable not being properly initialized (MDEV-6690, MDEV-7094)
      modified:
        storage/connect/ha_connect.cc
        storage/connect/plugutil.c
        storage/connect/user_connect.cc
        storage/connect/xindex.cpp
      
      - Implement Rewind for ODBC tables (MDEV-7097)
      modified:
        storage/connect/odbconn.cpp
        storage/connect/odbconn.h
        storage/connect/tabmysql.cpp
        storage/connect/tabodbc.cpp
      
      - Reset N when reopening MYSQL tables
      modified:
        storage/connect/tabmysql.cpp
      5d831196
  15. 09 Nov, 2014 1 commit
  16. 08 Nov, 2014 3 commits
    • Olivier Bertrand's avatar
      - Compile protect against not fully implemented optione XMSG and NEWMSG · f3e7e50d
      Olivier Bertrand authored
      modified:
        storage/connect/global.h
      
      - Commit typo error
      modified:
        storage/connect/tabmul.cpp*
      f3e7e50d
    • Olivier Bertrand's avatar
      - fix typo error · 2c6839ff
      Olivier Bertrand authored
      modified:
        storage/connect/tabmul.cpp
      2c6839ff
    • Olivier Bertrand's avatar
      - Calculate next position in filamap without assuming ENDING option is true. · bd481432
      Olivier Bertrand authored
      modified:
        storage/connect/filamap.cpp
      
      - ftell error: indicate in the error msg that is can be due to wrong ENDING value.
        filamtxt.cpp (MDEV-7030)
      modified:
        storage/connect/filamtxt.cpp
      
      - Change STRING according to Alexander Barkov remarks.
        Suppress the wrong Strz function. The unconditional function strz is no more
        used for s->db and s->table_name because they are zero terminated.
      modified:
        storage/connect/ha_connect.cc
        storage/connect/xobject.cpp
      
      - Change version number
      modified:
        storage/connect/filamap.cpp
      
      - Change PATH_MAX to FN_REFLEN (MDEV-7036)
      modified:
        storage/connect/os.h
        storage/connect/tabmul.cpp
      
      - Fix bug by adding a void argument for OP_NOT in Makefilter.
      modified:
        storage/connect/filter.cpp
      
      - Begin implementing XMSG style
        Two new system variables are defined:
        msg_lang ENUM session
        errmsg_dir_path STR global readonly
        This is a work in progress.
      modified:
        storage/connect/ha_connect.cc
        storage/connect/plgdbutl.cpp
        storage/connect/plugutil.c
        storage/connect/rcmsg.c
        storage/connect/resource.h
      bd481432
  17. 01 Nov, 2014 1 commit
  18. 31 Oct, 2014 3 commits
    • Olivier Bertrand's avatar
      - Add the new files to the source list · ea5d7a5c
      Olivier Bertrand authored
      modified:
        storage/connect/CMakeLists.txt
      
      - Check VIR columns when creating the table
      modified:
        storage/connect/ha_connect.cc
        
      - Add VirColumns declaration to avoid gcc warning
      modified:
        storage/connect/tabvir.h
      ea5d7a5c
    • Olivier Bertrand's avatar
      - Adding the VIR table type implementation files · 160708e1
      Olivier Bertrand authored
      added:
        storage/connect/tabvir.cpp
        storage/connect/tabvir.h
      160708e1
    • Olivier Bertrand's avatar
      - Add new table type VIR and virtual index · 4a17149b
      Olivier Bertrand authored
      modified:
        storage/connect/connect.cc
        storage/connect/ha_connect.cc
        storage/connect/ha_connect.h
        storage/connect/mycat.cc
        storage/connect/plgdbsem.h
      
      - Get good message when calling ColDB
      modified:
        storage/connect/connect.cc
      
      - Fix buffer preparation for BIN files
      modified:
        storage/connect/filamfix.cpp
      
      fix error while updating (force fseek)
      modified:
        storage/connect/filamfix.cpp
      
      fix error of XCOL column when filtered (typo)
      modified:
        storage/connect/tabdos.cpp
        storage/connect/tabxcl.cpp
      
      fix error when indexing on special column
      modified:
        storage/connect/tabdos.cpp
      4a17149b
  19. 24 Oct, 2014 2 commits
  20. 22 Oct, 2014 2 commits
  21. 21 Oct, 2014 1 commit
    • Olivier Bertrand's avatar
      1) Handling string memory allocation with a new STRING class. This is only · 56e27713
      Olivier Bertrand authored
         the beginning. Defining the STRING class and begining to use it (MYSQL)
      
      2) Change the xtrace, use_tempfile and exact_info connect variables from
         GLOBAL to SESSION. Remaining GLOBAL variables have been made readonly.
      
      3) Take care of LEX_STRING variables. The .str should not be regarded as
         allways being 0 terminated. This is handled by the Strz functions that
         make sure to return 0 terminated strings.
      
      Bug fix:
      - When inserting in MYSQL table with special column(s) a query such as:
      insert into t2 values(0,4,'new04'),(0,5,'new05');
      failed saying: column id (the special column) not found in t2.
      It is now accepted but must be counted in values (these 0 are ignored)
      - ROWID was returning row numbers based 0. Now it is from base 1.
      
      modified:
        storage/connect/array.cpp
        storage/connect/blkfil.cpp
        storage/connect/colblk.cpp
        storage/connect/connect.cc
        storage/connect/filamap.cpp
        storage/connect/filamdbf.cpp
        storage/connect/filamfix.cpp
        storage/connect/filamtxt.cpp
        storage/connect/filamvct.cpp
        storage/connect/filamzip.cpp
        storage/connect/filamzip.h
        storage/connect/filter.cpp
        storage/connect/global.h
        storage/connect/ha_connect.cc
        storage/connect/ha_connect.h
        storage/connect/libdoc.cpp
        storage/connect/mycat.cc
        storage/connect/myconn.cpp
        storage/connect/odbconn.cpp
        storage/connect/plgdbutl.cpp
        storage/connect/plugutil.c
        storage/connect/reldef.cpp
        storage/connect/tabcol.cpp
        storage/connect/tabdos.cpp
        storage/connect/tabfix.cpp
        storage/connect/tabfmt.cpp
        storage/connect/table.cpp
        storage/connect/tabmul.cpp
        storage/connect/tabmysql.cpp
        storage/connect/tabmysql.h
        storage/connect/taboccur.cpp
        storage/connect/tabodbc.cpp
        storage/connect/tabpivot.cpp
        storage/connect/tabsys.cpp
        storage/connect/tabtbl.cpp
        storage/connect/tabutil.cpp
        storage/connect/tabvct.cpp
        storage/connect/tabwmi.cpp
        storage/connect/tabwmi.h
        storage/connect/tabxcl.cpp
        storage/connect/tabxml.cpp
        storage/connect/user_connect.cc
        storage/connect/valblk.cpp
        storage/connect/value.cpp
        storage/connect/value.h
        storage/connect/xindex.cpp
        storage/connect/xobject.cpp
        storage/connect/xobject.h
        storage/connect/xtable.h
      56e27713
  22. 14 Oct, 2014 2 commits
    • Olivier Bertrand's avatar
      - Commit merged change · c65a9fb4
      Olivier Bertrand authored
      removed:
        extra/yassl/certs/dsa512.der
        extra/yassl/certs/dsa512.pem
      added:
        extra/yassl/certs/dsa1024.der
        extra/yassl/certs/dsa1024.pem
        mysql-test/r/ctype_cp932.result
        mysql-test/r/log_errchk.result
        mysql-test/r/show_bad_definer-5553.result
        mysql-test/suite/heap/btree_varchar_null.result
        mysql-test/suite/heap/btree_varchar_null.test
        mysql-test/suite/innodb/r/foreign-keys.result
        mysql-test/suite/innodb/t/foreign-keys.test
        mysql-test/t/ctype_cp932.test
        mysql-test/t/log_errchk.test
        mysql-test/t/show_bad_definer-5553.test
        storage/tokudb/mysql-test/rpl/disabled.def
        storage/tokudb/mysql-test/tokudb_mariadb/r/mdev6519.result
        storage/tokudb/mysql-test/tokudb_mariadb/t/mdev6519.test
      modified:
        client/mysql.cc
        cmake/install_layout.cmake
        config.h.cmake
        debian/dist/Debian/control
        debian/dist/Ubuntu/control
        extra/yassl/README
        extra/yassl/certs/ca-cert.pem
        extra/yassl/certs/client-cert.der
        extra/yassl/certs/client-cert.pem
        extra/yassl/certs/client-key.der
        extra/yassl/certs/client-keyEnc.pem
        extra/yassl/certs/server-cert.pem
        extra/yassl/certs/server-keyEnc.pem
        extra/yassl/include/buffer.hpp
        extra/yassl/include/openssl/ssl.h
        extra/yassl/src/buffer.cpp
        extra/yassl/src/handshake.cpp
        extra/yassl/src/yassl_imp.cpp
        extra/yassl/src/yassl_int.cpp
        extra/yassl/taocrypt/include/asn.hpp
        extra/yassl/taocrypt/include/block.hpp
        extra/yassl/taocrypt/include/integer.hpp
        extra/yassl/taocrypt/include/pwdbased.hpp
        extra/yassl/taocrypt/include/runtime.hpp
        extra/yassl/taocrypt/include/sha.hpp
        extra/yassl/taocrypt/src/aes.cpp
        extra/yassl/taocrypt/src/algebra.cpp
        extra/yassl/taocrypt/src/arc4.cpp
        extra/yassl/taocrypt/src/asn.cpp
        extra/yassl/taocrypt/src/blowfish.cpp
        extra/yassl/taocrypt/src/des.cpp
        extra/yassl/taocrypt/src/integer.cpp
        extra/yassl/taocrypt/src/md5.cpp
        extra/yassl/taocrypt/src/misc.cpp
        extra/yassl/taocrypt/src/rabbit.cpp
        extra/yassl/taocrypt/src/random.cpp
        extra/yassl/taocrypt/src/ripemd.cpp
        extra/yassl/taocrypt/src/sha.cpp
        extra/yassl/taocrypt/src/twofish.cpp
        mysql-test/lib/My/Platform.pm
        mysql-test/r/selectivity_innodb.result
        mysql-test/r/type_newdecimal.result
        mysql-test/r/type_time.result
        mysql-test/t/selectivity_innodb.test
        mysql-test/t/type_newdecimal.test
        mysql-test/t/type_time.test
        packaging/rpm-oel/mysql.spec.in
        plugin/auth_socket/auth_socket.c
        plugin/handler_socket/handlersocket/database.cpp
        plugin/handler_socket/handlersocket/handlersocket.cpp
        plugin/handler_socket/handlersocket/hstcpsvr.cpp
        plugin/handler_socket/libhsclient/hstcpcli.cpp
        plugin/handler_socket/libhsclient/socket.cpp
        plugin/handler_socket/perl-Net-HandlerSocket/HandlerSocket.xs
        plugin/metadata_lock_info/metadata_lock_info.cc
        plugin/server_audit/server_audit.c
        scripts/comp_sql.c
        scripts/mysql_system_tables_fix.sql
        sql-common/client.c
        sql/event_scheduler.cc
        sql/item.cc
        sql/log.cc
        sql/mysqld.cc
        sql/mysqld.h
        sql/opt_range.cc
        sql/sql_acl.cc
        sql/sql_cache.cc
        sql/sql_priv.h
        sql/sql_select.cc
        sql/sql_show.cc
        sql/sql_statistics.cc
        sql/sys_vars.cc
        storage/cassandra/ha_cassandra.cc
        storage/connect/inihandl.c
        storage/connect/libdoc.cpp
        storage/connect/mycat.cc
        storage/connect/tabxml.cpp
        storage/example/ha_example.cc
        storage/federatedx/ha_federatedx.cc
        storage/heap/hp_hash.c
        storage/innobase/api/api0misc.cc
        storage/mroonga/mrn_table.cpp
        storage/oqgraph/ha_oqgraph.cc
        storage/sequence/sequence.cc
        storage/sphinx/snippets_udf.cc
        storage/tokudb/CMakeLists.txt
        storage/tokudb/ft-index/ft/bndata.cc
        storage/tokudb/ft-index/ft/cachetable/cachetable.cc
        storage/tokudb/ft-index/ft/cachetable/checkpoint.cc
        storage/tokudb/ft-index/ft/cursor.cc
        storage/tokudb/ft-index/ft/ft-cachetable-wrappers.cc
        storage/tokudb/ft-index/ft/ft-flusher.cc
        storage/tokudb/ft-index/ft/ft-hot-flusher.cc
        storage/tokudb/ft-index/ft/ft-ops.cc
        storage/tokudb/ft-index/ft/ft-test-helpers.cc
        storage/tokudb/ft-index/ft/ft-verify.cc
        storage/tokudb/ft-index/ft/ft.cc
        storage/tokudb/ft-index/ft/le-cursor.cc
        storage/tokudb/ft-index/ft/loader/dbufio.cc
        storage/tokudb/ft-index/ft/loader/loader.cc
        storage/tokudb/ft-index/ft/loader/pqueue.cc
        storage/tokudb/ft-index/ft/logger/log_upgrade.cc
        storage/tokudb/ft-index/ft/logger/logcursor.cc
        storage/tokudb/ft-index/ft/logger/logfilemgr.cc
        storage/tokudb/ft-index/ft/logger/logformat.cc
        storage/tokudb/ft-index/ft/logger/logger.cc
        storage/tokudb/ft-index/ft/logger/recover.cc
        storage/tokudb/ft-index/ft/node.cc
        storage/tokudb/ft-index/ft/pivotkeys.cc
        storage/tokudb/ft-index/ft/serialize/block_table.cc
        storage/tokudb/ft-index/ft/serialize/compress.cc
        storage/tokudb/ft-index/ft/serialize/ft-node-deserialize.cc
        storage/tokudb/ft-index/ft/serialize/ft-serialize.cc
        storage/tokudb/ft-index/ft/serialize/ft_node-serialize.cc
        storage/tokudb/ft-index/ft/serialize/sub_block.cc
        storage/tokudb/ft-index/ft/txn/roll.cc
        storage/tokudb/ft-index/ft/txn/rollback-apply.cc
        storage/tokudb/ft-index/ft/txn/rollback-ct-callbacks.cc
        storage/tokudb/ft-index/ft/txn/rollback.cc
        storage/tokudb/ft-index/ft/txn/rollback_log_node_cache.cc
        storage/tokudb/ft-index/ft/txn/txn.cc
        storage/tokudb/ft-index/ft/txn/txn_child_manager.cc
        storage/tokudb/ft-index/ft/txn/txn_manager.cc
        storage/tokudb/ft-index/ft/ule.cc
        storage/tokudb/ft-index/src/errors.cc
        storage/tokudb/ft-index/src/indexer-undo-do.cc
        storage/tokudb/ft-index/src/indexer.cc
        storage/tokudb/ft-index/src/loader.cc
        storage/tokudb/ft-index/src/ydb.cc
        storage/tokudb/ft-index/src/ydb_cursor.cc
        storage/tokudb/ft-index/src/ydb_db.cc
        storage/tokudb/ft-index/src/ydb_env_func.cc
        storage/tokudb/ft-index/src/ydb_row_lock.cc
        storage/tokudb/ft-index/src/ydb_txn.cc
        storage/tokudb/ft-index/src/ydb_write.cc
        storage/tokudb/ft-index/tools/ftverify.cc
        storage/tokudb/ft-index/tools/tdb_logprint.cc
        storage/tokudb/ft-index/tools/tokuftdump.cc
        storage/tokudb/ha_tokudb.cc
        storage/tokudb/mysql-test/tokudb/disabled.def
        storage/tokudb/mysql-test/tokudb/t/i_s_tokudb_lock_waits_released.test
        storage/tokudb/mysql-test/tokudb/t/i_s_tokudb_locks_released.test
        storage/xtradb/api/api0misc.cc
        storage/xtradb/buf/buf0buf.cc
        strings/ctype-mb.c
        strings/decimal.c
        support-files/mysql.spec.sh
        tests/async_queries.c
        unittest/sql/my_apc-t.cc
      c65a9fb4
    • Olivier Bertrand's avatar
      - Add Sergei fix to enable loading OEM table libs · 0a913e20
      Olivier Bertrand authored
      modified:
        storage/connect/ha_connect.cc
        storage/connect/reldef.cpp
      0a913e20
  23. 13 Oct, 2014 1 commit
  24. 12 Oct, 2014 1 commit