1. 21 Apr, 2014 1 commit
  2. 27 Apr, 2014 1 commit
  3. 25 Apr, 2014 2 commits
    • Alexander Barkov's avatar
    • unknown's avatar
      MDEV-6156: Parallel replication incorrectly caches charset between worker threads · 64923bb6
      unknown authored
      The previous patch for this bug was unfortunately completely wrong.
      
      The purpose of cached_charset is to remember which character set we
      have installed currently in the THD, so that in the common case where
      charset does not change between queries, we do not need to update it
      in the THD. Thus, it is important that the cached_charset field is
      tightly coupled to the THD for which it handles caching.
      
      Thus the right place to put cached_charset seems to be in the THD.
      This patch introduces a field THD:system_thread_info where such info
      in general can be placed without further inflating the THD with unused
      data for other threads (THD is already far too big as it is). It then
      moves the cached_charset into this slot for the SQL driver thread and
      for the parallel replication worker threads.
      
      The THD::rpl_filter field is also moved inside system_thread_info, to
      keep the size of THD unchanged. Moving further fields in to reduce the
      size of THD is a separate task, filed as MDEV-6164.
      64923bb6
  4. 24 Apr, 2014 3 commits
  5. 23 Apr, 2014 2 commits
  6. 22 Apr, 2014 3 commits
    • Igor Babaev's avatar
      Merge. · bcf16fa6
      Igor Babaev authored
      bcf16fa6
    • Igor Babaev's avatar
      Fixed the problem of mdev-5947. · 3e0f63c1
      Igor Babaev authored
      Back-ported from the mysql 5.6 code line the patch with
      the following comment:
      
        Fix for Bug#11757108 CHANGE IN EXECUTION PLAN FOR COUNT_DISTINCT_GROUP_ON_KEY
                             CAUSES PEFORMANCE REGRESSION
      
        The cause for the performance regression is that the access strategy for the
        GROUP BY query is changed form using "index scan" in mysql-5.1 to use "loose
        index scan" in mysql-5.5. The index used for group by is unique and thus each
        "loose scan" group will only contain one record. Since loose scan needs to
        re-position on each "loose scan" group this query will do a re-position for
        each index entry. Compared to just reading the next index entry as a normal
        index scan does, the use of loose scan for this query becomes more expensive.
      
        The cause for selecting to use loose scan for this query is that in the current
        code when the size of the "loose scan" group is one, the formula for
        calculating the cost estimates becomes almost identical to the cost of using
        normal index scan. Differences in use of integer versus floating point arithmetic
        can cause one or the other access strategy to be selected.
      
        The main issue with the formula for estimating the cost of using loose scan is
        that it does not take into account that it is more costly to do a re-position
        for each "loose scan" group compared to just reading the next index entry.
        Both index scan and loose scan estimates the cpu cost as:
      
          "number of entries needed too read/scan" * ROW_EVALUATE_COST
      
        The results from testing with the query in this bug indicates that the real
        cost for doing re-position four to eight times higher than just reading the
        next index entry. Thus, the cpu cost estimate for loose scan should be increased.
        To account for the extra work to re-position in the index we increase the
        cost for loose index scan to include the cost of navigating the index.
        This is modelled as a function of the height of the b-tree:
      
          navigation cost= ceil(log(records in table)/log(indexes per block))
                         * ROWID_COMPARE_COST;
      
        This will avoid loose index scan being used for indexes where the "loose scan"
        group contains very few index entries.
      3e0f63c1
    • Alexander Barkov's avatar
  7. 21 Apr, 2014 2 commits
  8. 19 Apr, 2014 1 commit
    • Olivier Bertrand's avatar
      - Implement "remote" index (similar to FEDERATED ones) for MYSQL tables. · 187e4169
      Olivier Bertrand authored
        Not yet done for ODBC tables.
      modified:
        storage/connect/connect.cc
        storage/connect/ha_connect.cc
        storage/connect/ha_connect.h
        storage/connect/mycat.cc
        storage/connect/plgdbsem.h
        storage/connect/reldef.h
        storage/connect/tabdos.h
        storage/connect/tabmysql.cpp
        storage/connect/tabmysql.h
        storage/connect/tabodbc.cpp
        storage/connect/tabodbc.h
        storage/connect/xindex.cpp
        storage/connect/xtable.h
      
      - Return error in "info" on Cardinality error.
      modified:
        storage/connect/ha_connect.cc
      187e4169
  9. 18 Apr, 2014 1 commit
  10. 17 Apr, 2014 1 commit
    • Igor Babaev's avatar
      Fixed the problem of mdev-5970: · 12eb6d88
      Igor Babaev authored
      back-ported the patch for bug #13256831 from mysql-5.6 code line.
      
        Here's the comment this patch was provided with:
      
        Fixed bug#13256831 - ERROR 1032 (HY000): CAN'T FIND RECORD.
      
        This bug only occurs if a user tries to update a base table using
        an updatable view and this view was created as a join for which
        the clause 'WITH CHECK OPTION' was specified.
      
        The reason for the bug was that when such an update was
        executed, row positions were not properly handled for tables
        that were not updated but had constraints that had to be
        checked due to the 'WITH CHECK OPTION' clause.
      
        The reason for the bug was that when such update is executed
        then for tables specified in the view definition and
        also listed in the 'WITH CHECK OPTION' clause the positioning to
        row being updated is not performed.
      12eb6d88
  11. 16 Apr, 2014 1 commit
  12. 15 Apr, 2014 1 commit
  13. 14 Apr, 2014 1 commit
    • Olivier Bertrand's avatar
      - In info, the file length sometimes could not be caculated because the · 213ecbbb
      Olivier Bertrand authored
        catalog data path had not been set. This was added into ha_connect::info.
      modified:
        storage/connect/ha_connect.cc
      
      - All the functions querying table options could return information from the wrong
        table when several CONNECT tables were used in the same query (for instance joined
        together) This was because they belonged to the catalog class that is shared between
        all tables in the same query. They have been moved from the catalog class to the
        TABDEF/RELDEF class that is attached to each table. This was a major potential bug.
      modified:
        storage/connect/catalog.h
        storage/connect/filamvct.cpp
        storage/connect/filamzip.cpp
        storage/connect/mycat.cc
        storage/connect/mycat.h
        storage/connect/reldef.cpp
        storage/connect/reldef.h
        storage/connect/tabdos.cpp
        storage/connect/tabfmt.cpp
        storage/connect/tabmul.cpp
        storage/connect/tabmysql.cpp
        storage/connect/taboccur.cpp
        storage/connect/tabodbc.cpp
        storage/connect/tabpivot.cpp
        storage/connect/tabsys.cpp
        storage/connect/tabtbl.cpp
        storage/connect/tabutil.cpp
        storage/connect/tabvct.cpp
        storage/connect/tabwmi.cpp
        storage/connect/tabxcl.cpp
        storage/connect/tabxml.cpp
        storage/connect/xindex.cpp
      
      - Prepare indexing of MYSQL/ODBC tables (as does FEDERATED) (Not implemented yet)
      modified:
        storage/connect/ha_connect.cc
        storage/connect/ha_connect.h
        storage/connect/mycat.cc
        storage/connect/mycat.h
      
      - Typo
      modified:
        storage/connect/plgdbutl.cpp
      213ecbbb
  14. 11 Apr, 2014 1 commit
    • Sergey Petrunya's avatar
      MDEV-6081: ORDER BY+ref(const): selectivity is very incorrect (MySQL Bug#14338686) · 244d4b53
      Sergey Petrunya authored
      Add a testcase and backport this fix:
      
      Bug#14338686: MYSQL IS GENERATING DIFFERENT AND SLOWER
                    (IN NEWER VERSIONS) EXECUTION PLAN
      PROBLEM:
      While checking for an index to sort for the order by clause
      in this query
      "SELECT datestamp FROM contractStatusHistory WHERE
      contract_id = contracts.id ORDER BY datestamp asc limit 1;"
      
      we do not calculate the number of rows to be examined correctly.
      As a result we choose index 'idx_contractStatusHistory_datestamp'
      defined on the 'datestamp' field, rather than choosing index
      'contract_id'. And hence the lower performance.
      
      ANALYSIS:
      While checking if an index is present to give the records in
      sorted order(datestamp), we consider the selectivity of the
      'ref_key'(contract_id here) using 'table->quick_condition_rows'.
      'ref_key' here can be an index from 'REF_ACCESS' or from 'RANGE'.
      
      As this is a 'REF_ACCESS', 'table->quick_condition_rows' is not
      set to the actual value which is 2. Instead is set to the number
      of tuples present in the table indicating that every row that
      is selected would be satisfying the condition present in the query.
      
      Hence, the selectivity becomes 1 even when we choose the index
      on the order by column instead of the join_condition.
      
      But, in reality as only 2 rows satisy the condition, we need to
      examine half of the entire data set to get one tuple when we
      choose index on the order by column.
      Had we chosen the 'REF_ACCESS' we would have examined only 2 tuples.
      Hence the delay in executing the query specified.
        
      FIX:
      While calculating the selectivity of the ref_key:
      For REF_ACCESS consider quick_rows[ref_key] if range 
      optimizer has an estimate for this key. Else consider 
      'rec_per_key' statistic.
      For RANGE ACCESS consider 'table->quick_condition_rows'.
      244d4b53
  15. 08 Apr, 2014 2 commits
    • Olivier Bertrand's avatar
      - Add the "skipcol" option to Pivot tables. · be1ee90b
      Olivier Bertrand authored
      modified:
        storage/connect/ha_connect.cc
        storage/connect/tabpivot.cpp
        storage/connect/tabpivot.h
      be1ee90b
    • Olivier Bertrand's avatar
      - Add index read previous capacity. · 16893bc0
      Olivier Bertrand authored
      modified:
        storage/connect/ha_connect.cc
        storage/connect/ha_connect.h
        storage/connect/xindex.cpp
      
      - Optimize retrieving numeric values in scan_record. Was previously
        translating numeric values to character representation back and forth.
      modified:
        storage/connect/ha_connect.cc
        storage/connect/mysql-test/connect/r/xml.result
      
      - Modify Pivot table creation to avoid reading the entire source table
        when making columns from Discovery. MDEV-6024
      modified:
        storage/connect/tabpivot.cpp
      16893bc0
  16. 07 Apr, 2014 1 commit
  17. 10 Apr, 2014 4 commits
    • Elena Stepanova's avatar
      MDEV-6068 Upgrade removes all changes to 'mysql' database · a7962ea5
      Elena Stepanova authored
      10.0 variation of the problem was that system tables were altered
      during mysql_upgrade process using old (smaller) column lengths. 
      At the end the tables were altered again, so the structure was restored,
      but if there were long values before the upgrade, they were truncated.
      Fixed by using correct column length in alter statements.
      a7962ea5
    • Alexander Barkov's avatar
      Fixing compilation problem on AIX. · 5fffa449
      Alexander Barkov authored
      5fffa449
    • unknown's avatar
      MDEV-5401: Wrong result (missing row) on a 2nd execution of PS with... · 39afdcdd
      unknown authored
      MDEV-5401: Wrong result (missing row) on a 2nd execution of PS with exists_to_in=on, MERGE view or a SELECT SQ
      
      The problem was that the view substitute its fields (on prepare) with reverting the change after execution. After prepare on optimization exists2in convertion substituted arguments of '=' with constsnt '1', but then one of the arguments of '=' was reverted to the view field reference.This lead to incorrect WHERE condition on the second execution.
      
      To fix the problem we replace whole '=' with '1' permannently.
      39afdcdd
    • unknown's avatar
      MDEV-6040: MariaDB hangs if terminated quickly after start · 584c2d0a
      unknown authored
      We need to use mysql_cond_broadcast() rather than _signal for
      COND_thread_count, as there can be multiple waiters.
      
      Thanks to Pavel Ivanov for reporting both the problem and the
      solution.
      584c2d0a
  18. 09 Apr, 2014 1 commit
  19. 05 Apr, 2014 1 commit
    • Olivier Bertrand's avatar
      - Make memory allocation of VALBLK's more flexible (can be allocated · b43e82dc
      Olivier Bertrand authored
        normally when too big to be suballocated) to handle big results.
      modified:
        storage/connect/valblk.cpp
        storage/connect/valblk.h
      
      - Add system variable connect_work_size giving the size of the CONNECT
        work area used for memory allocation.
      modified:
        storage/connect/ha_connect.cc
        storage/connect/plugutil.c
        storage/connect/user_connect.cc
      b43e82dc
  20. 03 Apr, 2014 1 commit
    • Olivier Bertrand's avatar
      - FIX MDEV-6019 and MDEV-6021 · d95e797c
      Olivier Bertrand authored
        Exhausted memory cause un-prepared long jump
        Issue proper message when PIVOT column is nullable
      modified:
        storage/connect/mysql-test/connect/r/pivot.result
        storage/connect/mysql-test/connect/t/pivot.test
        storage/connect/plgdbsem.h
        storage/connect/tabpivot.cpp
      
      - Prepare adding index_prev (not used yet)
      modified:
        storage/connect/plgdbsem.h
        storage/connect/xindex.cpp
        storage/connect/xindex.h
      d95e797c
  21. 02 Apr, 2014 1 commit
  22. 01 Apr, 2014 2 commits
    • Sergey Petrunya's avatar
      MDEV-5992: EITS: Selectivity of non-indexed condition is counted twice in table's fanout · 26a3d567
      Sergey Petrunya authored
      MDEV-5984: EITS: Incorrect filtered% value for single-table select with range access
      - Fix calculate_cond_selectivity_for_table() to work correctly with range accesses 
        over multi-component keys:
        = First, take selectivity of all possible range scans into account. Remember which 
          fields were used bt the range scans.
        = Then, calculate selectivity produced by sargable predicates on fields. If a 
          field was used in a possible range access, assume its selectivity is already
          taken into account.
      - Fix table_cond_selectivity(): when quick select is used, selectivity of
        COND(table) is taken into account in matching_candidates_in_table(). In
        table_cond_selectivity() we should not apply it for the second time.
      26a3d567
    • Olivier Bertrand's avatar
      - FIX MDEV-5989 (max(indexed) doesn't work) · 3f361af7
      Olivier Bertrand authored
        By implementing index_last
      modified:
        storage/connect/ha_connect.cc
        storage/connect/ha_connect.h
        storage/connect/xindex.cpp
      
      - Adding the TYPE_BIN Connect internal type
        (not tested and not used yet)
      modified:
        storage/connect/global.h
        storage/connect/value.cpp
        storage/connect/value.h
      3f361af7
  23. 31 Mar, 2014 2 commits
  24. 30 Mar, 2014 2 commits
    • Olivier Bertrand's avatar
      - Fix using ~ in file name on Linux · b1ae8341
      Olivier Bertrand authored
      modified:
        storage/connect/osutil.c
        storage/connect/plugutil.c
        
      - Fix using fmt uninitialized in Tabcolumns
      modified:
        storage/connect/tabutil.cpp
      
      - Suppress gcc warning
      modified:
        storage/connect/ha_connect.cc
      b1ae8341
    • Olivier Bertrand's avatar
      - Add system variables type_conv and conv_size. This addresses the eventual · fe3cbcdf
      Olivier Bertrand authored
        conversion from TEXT to VARCHAR  in PROXY and MYSQL tables.
      modified:
        storage/connect/ha_connect.cc
        storage/connect/myconn.cpp
        storage/connect/myconn.h
        storage/connect/myutil.cpp
        storage/connect/tabmysql.cpp
        storage/connect/tabutil.cpp
      
      - Add the xmap system variable addressing whether file mapping should be used
        to handle indexing.
      modified:
        storage/connect/CMakeLists.txt
        storage/connect/ha_connect.cc
        storage/connect/xindex.cpp
        storage/connect/xindex.h
      
      - Do take care of ~ in Linux version of _fullpath (not tested yet)
      modified:
        storage/connect/osutil.c
      fe3cbcdf
  25. 29 Mar, 2014 2 commits