An error occurred fetching the project authors.
  1. 26 Mar, 2011 1 commit
  2. 19 Mar, 2011 1 commit
  3. 18 Mar, 2011 2 commits
  4. 17 Mar, 2011 1 commit
  5. 08 Mar, 2011 1 commit
  6. 07 Mar, 2011 1 commit
    • Sergei Golubchik's avatar
      lp:730637 - Valgrind warnings in 5.1-micro · 30e5b4d7
      Sergei Golubchik authored
      sql/field.cc:
        initialize ltime completely
      sql/filesort.cc:
        don't pack MYSQL_TIME if it's not initialized
        (safe here, but valgrind complains)
      sql/item_cmpfunc.cc:
        don't pack MYSQL_TIME if it's not initialized
        (safe here, but valgrind complains)
      sql/item_timefunc.cc:
        don't check MYSQL_TIME members if it's uninitialized
        (safe here, but valgrind complains)
      sql/time.cc:
        use c_ptr_safe() instead of c_ptr()
        (make valgrind happy)
      30e5b4d7
  7. 01 Mar, 2011 1 commit
    • Sergei Golubchik's avatar
      wl#173 - temporal types with sub-second resolution · a8a757c6
      Sergei Golubchik authored
               and collateral changes.
      
      * introduce my_hrtime_t, my_timediff_t, and conversion macros
      * inroduce TIME_RESULT, but it can only be returned from Item::cmp_type(),
        never from Item::result_type()
      * pack_time/unpack_time function for "packed" representation of
        MYSQL_TIME in a longlong that can be compared
      * ADDTIME()/SUBTIME()/+- INTERVAL now work with TIME values
      * numbers aren't quoted in EXPLAIN EXTENDED
      * new column I_S.COLUMNS.DATETIME_PRECISION
      * date/time values are compares to anything as date/time, not as strings or numbers.
      * old timestamp(X) is no longer supported
      * MYSQL_TIME to string conversion functions take precision as an argument
      * unified the warnings from Field_timestamp/datetime/time/date/newdate store methods
      * Field_timestamp_hires, Field_datetime_hires, Field_time_hires
      * Field_temporal
      * Lazy_string class to pass a value (string, number, time) polymorphically down the stack
      * make_truncated_value_warning and Field::set_datetime_warning use Lazy_string as an argument, removed char*/int/double variants
      * removed Field::can_be_compared_as_longlong(). Use Field::cmp_type() == INT_RESULT instead
      * introduced Item::cmp_result() instead of Item::is_datetime() and Item::result_as_longlong()
      * in many cases date/time types are treated like other types, not as special cases
      * greatly simplified Arg_comparator (regarding date/time/year code)
      * SEC_TO_TIME is real function, not integer.
      * microsecond precision in NOW, CURTIME, etc
      * Item_temporal. All items derived from it only provide get_date, but no val* methods
      * replication of NOW(6)
      * Protocol::store(time) now takes the precision as an argument
      * @@TIMESTAMP is a double
      
      client/mysqlbinlog.cc:
        remove unneded casts
      include/my_sys.h:
        introduce my_hrtime_t, my_timediff_t, and conversion macros
      include/my_time.h:
        pack_time/unpack_time, etc.
        convenience functions to work with MYSQL_TIME::second_part
      libmysql/libmysql.c:
        str_to_time() is gone. str_to_datetime() does it now.
        my_TIME_to_str() takes the precision as an argument
      mysql-test/include/ps_conv.inc:
        time is not equal to datetime anymore
      mysql-test/r/distinct.result:
        a test for an old MySQL bug
      mysql-test/r/explain.result:
        numbers aren't quoted in EXPLAIN EXTENDED
      mysql-test/r/func_default.result:
        numbers aren't quoted in EXPLAIN EXTENDED
      mysql-test/r/func_sapdb.result:
        when decimals=NOT_FIXED_DEC it means "not fixed" indeed
      mysql-test/r/func_test.result:
        numbers aren't quoted in EXPLAIN EXTENDED
      mysql-test/r/func_time.result:
        ADDTIME()/SUBTIME()/+- INTERVAL now work with TIME values
      mysql-test/r/having.result:
        numbers aren't quoted in EXPLAIN EXTENDED
      mysql-test/r/information_schema.result:
        new column I_S.COLUMNS.DATETIME_PRECISION
      mysql-test/r/join_outer.result:
        numbers aren't quoted in EXPLAIN EXTENDED
      mysql-test/r/metadata.result:
        TIMESTAMP no longer has zerofill flag
      mysql-test/r/range.result:
        invalid datetime is not compared with as a string
      mysql-test/r/select.result:
        NO_ZERO_IN_DATE, etc only affect storage - according to the manual
        numbers aren't quoted in EXPLAIN EXTENDED
      mysql-test/r/subselect.result:
        numbers aren't quoted in EXPLAIN EXTENDED
      mysql-test/r/sysdate_is_now.result:
        when decimals=NOT_FIXED_DEC it means "not fixed" indeed
      mysql-test/r/type_blob.result:
        TIMESTAMP(N) is not deprecated
      mysql-test/r/type_timestamp.result:
        old TIMESTAMP(X) semantics is not supported anymore
      mysql-test/r/union.result:
        numbers aren't quoted in EXPLAIN EXTENDED
      mysql-test/r/varbinary.result:
        numbers aren't quoted in EXPLAIN EXTENDED
      mysql-test/t/distinct.test:
        test for an old MySQL bug
      mysql-test/t/func_time.test:
        +- INTERVAL now works with TIME values
      mysql-test/t/select.test:
        typo
      mysql-test/t/subselect.test:
        only one error per statement, please
      mysql-test/t/system_mysql_db_fix40123.test:
        old timestamp(X) is no longer supported
      mysql-test/t/system_mysql_db_fix50030.test:
        old timestamp(X) is no longer supported
      mysql-test/t/system_mysql_db_fix50117.test:
        old timestamp(X) is no longer supported
      mysql-test/t/type_blob.test:
        old timestamp(X) is no longer supported
      mysql-test/t/type_timestamp.test:
        old timestamp(X) is no longer supported
      mysys/my_getsystime.c:
        functions to get the time with microsecond precision
      mysys/my_init.c:
        move the my_getsystime.c initialization code to my_getsystime.c
      mysys/my_static.c:
        no need to make these variables extern
      mysys/my_static.h:
        no need to make these variables extern
      scripts/mysql_system_tables.sql:
        old timestamp(X) is no longer supported
      scripts/mysql_system_tables_fix.sql:
        old timestamp(X) is no longer supported
      scripts/mysqlhotcopy.sh:
        old timestamp(X) is no longer supported
      sql-common/my_time.c:
        * call str_to_time from str_to_datetime, as appropriate
        * date/time to string conversions take precision as an argument
        * number_to_time()
        * TIME_to_double()
        * pack_time() and unpack_time()
      sql/event_data_objects.cc:
        cast is not needed
        my_datetime_to_str() takes precision as an argument
      sql/event_db_repository.cc:
        avoid dangerous downcast (because the pointer is
        not always Field_timestamp, see events_1.test)
      sql/event_queue.cc:
        avoid silly double-work for cond_wait
        (having an endpoint of wait, subtract the current time to get the timeout,
        and use set_timespec() macro to fill in struct timespec, by adding the current
        time to the timeout)
      sql/field.cc:
        * remove virtual Field::get_time(), everyone should use only Field::get_date()
        * remove lots of #ifdef WORDS_BIGENDIAN
        * unified the warnings from Field_timestamp/datetime/time/date/newdate store methods
        * Field_timestamp_hires, Field_datetime_hires, Field_time_hires
        * Field_temporal
        * make_truncated_value_warning and Field::set_datetime_warning use Lazy_string as an argument, removed char*/int/double variants
      sql/field.h:
        * remove virtual Field::get_time(), everyone should use only Field::get_date()
        * remove lots of #ifdef WORDS_BIGENDIAN
        * unified the warnings from Field_timestamp/datetime/time/date/newdate store methods
        * Field_timestamp_hires, Field_datetime_hires, Field_time_hires
        * Field_temporal
        * make_truncated_value_warning and Field::set_datetime_warning use Lazy_string as an argument, removed char*/int/double variants
        * removed Field::can_be_compared_as_longlong(). Use Field::cmp_type() == INT_RESULT instead
      sql/filesort.cc:
        TIME_RESULT, cmp_time()
      sql/item.cc:
        * numbers aren't quoted in EXPLAIN EXTENDED
        * Item::cmp_result() instead of Item::is_datetime() and Item::result_as_longlong()
        * virtual Item::get_time() is gone
        * Item_param::field_type() is set correctly
        * Item_datetime, for a datetime constant
        * time to anything is compared as a time
        * Item_cache::print() prints the value is available
        * bug fixed in Item_cache_int::val_str()
      sql/item.h:
        * Item::print_value(), to be used from Item_xxx::print() when needed
        * Item::cmp_result() instead of Item::is_datetime() and Item::result_as_longlong()
        * virtual Item::get_time() is gone
        * Item_datetime, for a datetime constant
        * better default for cast_to_int_type()
        * Item_cache objects now *always* have the field_type() set
      sql/item_cmpfunc.cc:
        * get_year_value, get_time_value are gone. get_datetime_value does it all
        * get_value_a_func, get_value_b_func are gone
        * can_compare_as_dates() is gone too, TIME_RESULT is used instead
        * cmp_type() instead or result_type() when doing a comparison
        * compare_datetime and compate_e_datetime in the comparator_matrix, is_nulls_eq is gone
        * Item::cmp_result() instead of Item::is_datetime() and Item::result_as_longlong()
      sql/item_cmpfunc.h:
        greatly simplified Arg_comparator
      sql/item_create.cc:
        * fix a bug in error messages in CAST
      sql/item_func.cc:
        Item::cmp_result() instead of Item::is_datetime() and Item::result_as_longlong()
        mention all possibitiles in switch over Item_result values, or use default:
      sql/item_row.h:
        overwrite the default cmp_type() for Item_row,
        as no MYSQL_TYPE_xxx value corresponds to ROW_RESULT
      sql/item_timefunc.cc:
        rewrite make_datetime to support precision argument
        SEC_TO_TIME is real function, not integer.
        many functions that returned temporal values had duplicate code in val_* methods,
        some of them did not have get_date() which resulted in unnecessary date->str->date conversions. 
        Now they all are derived from Item_temporal_func and *only* provide get_date, not val* methods.
        many fixes to set decimals (datetime precision) correctly.
      sql/item_timefunc.h:
        SEC_TO_TIME is real function, not integer.
        many functions that returned temporal values had duplicate code in val_* methods,
        some of them did not have get_date() which resulted in unnecessary date->str->date conversions. 
        Now they all are derived from Item_temporal_func and *only* provide get_date, not val* methods.
        many fixes to set decimals (datetime precision) correctly.
      sql/log_event.cc:
        replication of NOW(6)
      sql/log_event.h:
        replication of NOW(6)
      sql/mysql_priv.h:
        Lazy_string class to pass a value (string, number, time) polymorphically down the stack.
        make_truncated_value_warning() that uses it.
      sql/mysqld.cc:
        datetime in Arg_comparator::comparator_matrix
      sql/opt_range.cc:
        cleanup: don't disable warnings before calling save_in_field_no_warnings()
      sql/protocol.cc:
        Protocol::store(time) now takes the precision as an argument
      sql/protocol.h:
        Protocol::store(time) now takes the precision as an argument
      sql/rpl_rli.cc:
        small cleanup
      sql/set_var.cc:
        SET TIMESTAMP=double
      sql/set_var.h:
        @@TIMESTAMP is a double
      sql/share/errmsg.txt:
        precision and scale are unsigned
      sql/slave.cc:
        replication of NOW(6)
      sql/sp_head.cc:
        cleanup
      sql/sql_class.cc:
        support for NOW(6)
      sql/sql_class.h:
        support for NOW(6)
      sql/sql_insert.cc:
        support for NOW(6)
      sql/sql_select.cc:
        use item->cmp_type().
        move a comment where it belongs
      sql/sql_show.cc:
        new column I_S.COLUMNS.DATETIME_PRECISION
      sql/sql_yacc.yy:
        TIME(X), DATETIME(X), cast, NOW(X), CURTIME(X), etc
      sql/time.cc:
        fix date_add_interval() to support MYSQL_TIMESTAMP_TIME argument
      storage/myisam/ha_myisam.cc:
        TIMESTAMP no longer carries ZEROFIELD flag, still we keep MYI file compatible.
      strings/my_vsnprintf.c:
        warnings
      tests/mysql_client_test.c:
        old timestamp(X) does not work anymore
        datetime is no longer equal to time
      a8a757c6
  8. 22 Nov, 2010 1 commit
    • Gleb Shchepa's avatar
      backport: Bug #55568 from 5.1-security to 5.0-security · 47bb750c
      Gleb Shchepa authored
      > revision-id: alexey.kopytov@sun.com-20100824103548-ikm79qlfrvggyj9h
      > parent: sunny.bains@oracle.com-20100816001222-xqc447tr6jwh8c53
      > committer: Alexey Kopytov <Alexey.Kopytov@Sun.com>
      > branch nick: 5.1-security
      > timestamp: Tue 2010-08-24 14:35:48 +0400
      > message:
      >   Bug #55568: user variable assignments crash server when used
      >               within query
      >   
      >   The server could crash after materializing a derived table
      >   which requires a temporary table for grouping.
      >   
      >   When destroying the temporary table used to execute a query for
      >   a derived table, JOIN::destroy() did not clean up Item_fields
      >   pointing to fields in the temporary table. This led to
      >   dereferencing a dangling pointer when printing out the items
      >   tree later in the outer SELECT.
      >   
      >   The solution is an addendum to the patch for bug37362: in
      >   addition to cleaning up items in tmp_all_fields3, do the same
      >   for items in tmp_all_fields1, since now we have an example
      >   where this is necessary.
      
      
      sql/field.cc:
        Make sure field->table_name is not set to NULL in
        Field::make_field() to avoid assertion failure in 
        Item_field::make_field() after cleaning up items
        (the assertion fired in udf.test when running
        the test suite with the patch applied).
      sql/sql_select.cc:
        In addition to cleaning up items in tmp_all_fields3, do the
        same for items in tmp_all_fields1.
        Introduce a new helper function to avoid code duplication.
      sql/sql_select.h:
        Introduce a new helper function to avoid code duplication in
        JOIN::destroy().
      47bb750c
  9. 07 Sep, 2010 1 commit
    • Kristofer Pettersson's avatar
      Bug#55531 crash with conversions of geometry types / strings · 9a4a7cf1
      Kristofer Pettersson authored
      Convertion from a floating point number to a string caused a
      crash.
      
      During rare circumstances a String object could crash when
      it was requested to allocate new memory.
      A crash could occcur in Field_double::val_str() because of
      a pointer referencing memory inside a String object which was
      of unknown size.
      And finally, the geometric collection should not accept
      arguments which are non geometric.
      
      
      mysql-test/r/gis.result:
        * Test cases change because we intercept the error behind the
        previous crashes much earlier.
      sql/field.cc:
        * It makes no sense to impose a lower limit on the length
        and not setting a upper limit will cause crashes later.
      sql/item_geofunc.h:
        * Disallow for binding with field- and item types which
        differ from MYSQL_TYPE_GEOMETRY types.
      9a4a7cf1
  10. 24 Aug, 2010 1 commit
    • Alexey Kopytov's avatar
      Bug #55568: user variable assignments crash server when used · cd4ca4b7
      Alexey Kopytov authored
                  within query
      
      The server could crash after materializing a derived table
      which requires a temporary table for grouping.
      
      When destroying the temporary table used to execute a query for
      a derived table, JOIN::destroy() did not clean up Item_fields
      pointing to fields in the temporary table. This led to
      dereferencing a dangling pointer when printing out the items
      tree later in the outer SELECT.
      
      The solution is an addendum to the patch for bug37362: in
      addition to cleaning up items in tmp_all_fields3, do the same
      for items in tmp_all_fields1, since now we have an example
      where this is necessary.
      
      
      mysql-test/r/join.result:
        Added test cases for bug#55568 and a duplicate bug #54468.
      mysql-test/t/join.test:
        Added test cases for bug#55568 and a duplicate bug #54468.
      sql/field.cc:
        Make sure field->table_name is not set to NULL in
        Field::make_field() to avoid assertion failure in 
        Item_field::make_field() after cleaning up items
        (the assertion fired in udf.test when running
        the test suite with the patch applied).
      sql/sql_select.cc:
        In addition to cleaning up items in tmp_all_fields3, do the
        same for items in tmp_all_fields1.
        Introduce a new helper function to avoid code duplication.
      sql/sql_select.h:
        Introduce a new helper function to avoid code duplication in
        JOIN::destroy().
      cd4ca4b7
  11. 20 Jul, 2010 1 commit
    • Davi Arnaut's avatar
      Bug#45288: pb2 returns a lot of compilation warnings on linux · 9a5fa17f
      Davi Arnaut authored
      Fix warnings flagged by the new warning option -Wunused-but-set-variable
      that was added to GCC 4.6 and that is enabled by -Wunused and -Wall. The
      option causes a warning whenever a local variable is assigned to but is
      later unused. It also warns about meaningless pointer dereferences.
      
      client/mysql.cc:
        Meaningless pointer dereferences.
      client/mysql_upgrade.c:
        Check whether reading from the file succeeded.
      extra/comp_err.c:
        Unused.
      extra/yassl/src/yassl_imp.cpp:
        Skip instead of reading data that is discarded.
      include/my_pthread.h:
        Variable is only used in debug builds.
      include/mysys_err.h:
        Add new error messages.
      mysys/errors.c:
        Add new error message for permission related functions.
      mysys/mf_iocache.c:
        Variable is only checked under THREAD.
      mysys/my_copy.c:
        Raise a error if chmod or chown fails.
      mysys/my_redel.c:
        Raise a error if chmod or chown fails.
      regex/engine.c:
        Use a equivalent variable for the assert.
      server-tools/instance-manager/instance_options.cc:
        Unused.
      sql/field.cc:
        Unused.
      sql/item.cc:
        Unused.
      sql/log.cc:
        Do not ignore the return value of freopen: only set buffer if
        reopening succeeds.
        
        Adjust doxygen comment to the right function.
        
        Pass message lenght to log function.
      sql/mysqld.cc:
        Do not ignore the return value of freopen: only set buffer if
        reopening succeeds.
      sql/partition_info.cc:
        Unused.
      sql/slave.cc:
        No need to set pointer to the address of '\0'.
      sql/spatial.cc:
        Unused. Left for historical purposes.
      sql/sql_acl.cc:
        Unused.
      sql/sql_base.cc:
        Pointers are always set to the same variables.
      sql/sql_parse.cc:
        End statement if reading fails.
        
        Store the buffer after it has actually been updated.
      sql/sql_repl.cc:
        No need to set pointer to the address of '\0'.
      sql/sql_show.cc:
        Put variable under the same ifdef block.
      sql/udf_example.c:
        Set null pointer flag appropriately.
      storage/csv/ha_tina.cc:
        Meaningless dereferences.
      storage/example/ha_example.cc:
        Return the error since it's available.
      storage/myisam/mi_locking.c:
        Remove unused and dead code.
      9a5fa17f
  12. 09 Jul, 2010 1 commit
    • Davi Arnaut's avatar
      Bug#45288: pb2 returns a lot of compilation warnings on linux · 11fae045
      Davi Arnaut authored
      Although the C standard mandates that sprintf return the number
      of bytes written, some very ancient systems (i.e. SunOS 4)
      returned a pointer to the buffer instead. Since these systems
      are not supported anymore and are hopefully long dead by now,
      simply remove the portability wrapper that dealt with this
      discrepancy. The autoconf check was causing trouble with GCC.
      11fae045
  13. 02 Jul, 2010 1 commit
    • Davi Arnaut's avatar
      Bug#53445: Build with -Wall and fix warnings that it generates · 0eb26fdf
      Davi Arnaut authored
      Apart strict-aliasing warnings, fix the remaining warnings
      generated by GCC 4.4.4 -Wall and -Wextra flags.
      
      One major source of warnings was the in-house function my_bcmp
      which (unconventionally) took pointers to unsigned characters
      as the byte sequences to be compared. Since my_bcmp and bcmp
      are deprecated functions whose only difference with memcmp is
      the return value, every use of the function is replaced with
      memcmp as the special return value wasn't actually being used
      by any caller.
      
      There were also various other warnings, mostly due to type
      mismatches, missing return values, missing prototypes, dead
      code (unreachable) and ignored return values.
      
      BUILD/SETUP.sh:
        Remove flags that are implied by -Wall and -Wextra.
        Do not warn about unused parameters in C++.
      BUILD/check-cpu:
        Print only the compiler version instead of verbose banner.
        Although the option is gcc specific, the check was only
        being used for GCC specific checks anyway.
      client/mysql.cc:
        bcmp is no longer defined.
      client/mysqltest.cc:
        Pass a string to function expecting a format string.
        Replace use of bcmp with memcmp.
      cmd-line-utils/readline/Makefile.am:
        Always define _GNU_SOURCE when compiling GNU readline.
        Required to make certain prototypes visible.
      cmd-line-utils/readline/input.c:
        Condition for the code to be meaningful.
      configure.in:
        Remove check for bcmp.
      extra/comp_err.c:
        Use appropriate type.
      extra/replace.c:
        Replace use of bcmp with memcmp.
      extra/yassl/src/crypto_wrapper.cpp:
        Do not ignore the return value of fgets. Retrieve the file
        position if fgets succeed -- if it fails, the function will
        bail out and return a error.
      extra/yassl/taocrypt/include/blowfish.hpp:
        Use a single array instead of accessing positions of the sbox_
        through a subscript to pbox_.
      extra/yassl/taocrypt/include/runtime.hpp:
        One definition of such functions is enough.
      extra/yassl/taocrypt/src/aes.cpp:
        Avoid potentially ambiguous conditions.
      extra/yassl/taocrypt/src/algebra.cpp:
        Rename arguments to avoid shadowing related warnings.
      extra/yassl/taocrypt/src/blowfish.cpp:
        Avoid potentially ambiguous conditions.
      extra/yassl/taocrypt/src/integer.cpp:
        Do not define type within a anonymous union.
        Use a variable to return a value instead of
        leaving the result in a register -- compiler
        does not know the logic inside the asm.
      extra/yassl/taocrypt/src/misc.cpp:
        Define handler for pure virtual functions.
        Remove unused code.
      extra/yassl/taocrypt/src/twofish.cpp:
        Avoid potentially ambiguous conditions.
      extra/yassl/testsuite/test.hpp:
        Function must have C language linkage.
      include/m_string.h:
        Remove check which relied on bcmp being defined -- they weren't
        being used as bcmp is only visible when _BSD_SOURCE is defined.
      include/my_bitmap.h:
        Remove bogus helpers which were used only in a few files and
        were causing warnings about dead code.
      include/my_global.h:
        Due to G++ bug, always silence false-positive uninitialized
        variables warnings when compiling C++ code with G++.
        Remove bogus helper.
      libmysql/Makefile.shared:
        Remove built-in implementation of bcmp.
      mysql-test/lib/My/SafeProcess/safe_process.cc:
        Cast pid to largest possible type for a process identifier.
      mysys/mf_loadpath.c:
        Leave space of the ending nul.
      mysys/mf_pack.c:
        Replace bcmp with memcmp.
      mysys/my_bitmap.c:
        Dead code removal.
      mysys/my_gethwaddr.c:
        Remove unused variable.
      mysys/my_getopt.c:
        Silence bogus uninitialized variable warning.
        Do not cast away the constant qualifier.
      mysys/safemalloc.c:
        Cast to expected type.
      mysys/thr_lock.c:
        Silence bogus uninitialized variable warning.
      sql/field.cc:
        Replace bogus helper with a more appropriate logic which is
        used throughout the code.
      sql/item.cc:
        Remove bogus logical condition which always evaluates to TRUE.
      sql/item_create.cc:
        Simplify code to avoid signedness related warnings.
      sql/log_event.cc:
        Replace use of bcmp with memcmp.
        No need to use helpers for simple bit operations.
      sql/log_event_old.cc:
        Replace bmove_align with memcpy.
      sql/mysqld.cc:
        Move use declaration of variable to the ifdef block where it
        is used. Remove now-unnecessary casts and arguments.
      sql/set_var.cc:
        Replace bogus helpers with simple and classic bit operations.
      sql/slave.cc:
        Cast to expected type and silence bogus warning.
      sql/sql_class.h:
        Don't use enum values as bit flags, the supposed type safety is
        bogus as the combined bit flags are not a value in the enumeration.
      sql/udf_example.c:
        Only declare variable when necessary.
      sql/unireg.h:
        Replace use of bmove_align with memcpy.
      storage/innobase/os/os0file.c:
        Silence bogus warning.
      storage/myisam/mi_open.c:
        Remove bogus cast, DBUG_DUMP expects a pointer to unsigned
        char.
      storage/myisam/mi_page.c:
        Remove bogus cast, DBUG_DUMP expects a pointer to unsigned
        char.
      strings/bcmp.c:
        Remove built-in bcmp.
      strings/ctype-ucs2.c:
        Silence bogus warning.
      tests/mysql_client_test.c:
        Use a appropriate type as expected by simple_command().
      0eb26fdf
  14. 31 May, 2010 1 commit
  15. 25 Apr, 2010 1 commit
    • Ramil Kalimullin's avatar
      Fix for bug#50946: fast index creation still seems to copy the table · 6595861f
      Ramil Kalimullin authored
      Problem: ALTER TABLE ADD INDEX may lead to table copying if there's
      numeric field(s) with non-default display width modificator specified.
      
      Fix: compare numeric field's storage lenghts when we decide whether 
      they can be considered 'equal' for table alteration purposes.
      
      
      mysql-test/r/error_simulation.result:
        Fix for bug#50946: fast index creation still seems to copy the table
          - test result.
      mysql-test/t/error_simulation.test:
        Fix for bug#50946: fast index creation still seems to copy the table
          - test case.
      sql/field.cc:
        Fix for bug#50946: fast index creation still seems to copy the table
          - check numeric field's pack lengths instead of it's display lenghts
        comparing fields equality for table alteration purposes.
      sql/sql_table.cc:
        Fix for bug#50946: fast index creation still seems to copy the table
          - check compare_tables() result for testing purposes.
      6595861f
  16. 17 Mar, 2010 1 commit
    • Mats Kindahl's avatar
      BUG#49618: Field length stored incorrectly in binary log · 2c5f439d
      Mats Kindahl authored
                 for InnoDB
                  
      The class Field_bit_as_char stores the metadata for the
      field incorrecly because bytes_in_rec and bit_len are set
      to (field_length + 7 ) / 8 and 0 respectively, while
      Field_bit has the correct values field_length / 8 and
      field_length % 8.
                  
      Solved the problem by re-computing the values for the
      metadata based on the field_length instead of using the
      bytes_in_rec and bit_len variables.
                  
      To handle compatibility with old server, a table map
      flag was added to indicate that the bit computation is
      exact. If the flag is clear, the slave computes the
      number of bytes required to store the bit field and
      compares that instead, effectively allowing replication
      *without conversion* from any field length that require
      the same number of bytes to store.
      
      
      mysql-test/suite/rpl/t/rpl_typeconv_innodb.test:
        Adding test to check compatibility for bit field
        replication when using InnoDB
      sql/field.cc:
        Extending compatible_field_size() with flags from
        table map to allow fields to check master info.
      sql/field.h:
        Extending compatible_field_size() with flags from
        table map to allow fields to check master info.
      sql/log.cc:
        Removing table map flags since they are not used
        outside table map class.
      sql/log_event.cc:
        Removing flags parameter from table map constructor
        since it is not used and does not have to be exposed.
      sql/log_event.h:
        Adding flag to denote that bit length for bit field type
        is exact and not potentially rounded to even bytes.
      sql/rpl_utility.cc:
        Adding fields to table_def to store table map flags.
      sql/rpl_utility.h:
        Removing obsolete comment and adding flags to store
        table map flags from master.
      2c5f439d
  17. 14 Mar, 2010 1 commit
    • Staale Smedseng's avatar
      Bug #49829 Many "hides virtual function" warnings with · c7fad393
      Staale Smedseng authored
      SunStudio
            
      SunStudio compilers of late warn about methods that might hide
      methods in base classes due to the use of overloading combined
      with overriding. SunStudio also warns about variables defined
      in local socpe or method arguments that have the same name as
      a member attribute of the class.
            
      This patch renames methods that might hide base class methods,
      to make it easier both for humans and compilers to see what is
      actually called. It also renames variables in local scope.
      
      
      sql/field.cc:
        Local scope variable or method argument same as class 
        attribute.
      sql/item_cmpfunc.cc:
        Local scope variable or method argument same as class 
        attribute.
      sql/item_create.cc:
        Renaming base class create() to create_func().
      sql/item_create.h:
        Renaming base class create() to create_func().
      sql/protocol.cc:
        Local scope variable or method argument same as class 
        attribute.
      sql/sql_profile.cc:
        Local scope variable or method argument same as class 
        attribute.
      sql/sql_select.cc:
        Local scope variable or method argument same as class 
        attribute.
      sql/sql_yacc.yy:
        Renaming base class create() to create_func().
      storage/federated/ha_federated.cc:
        Local scope variable or method argument same as class 
        attribute.
      storage/myisammrg/ha_myisammrg.cc:
        Local scope variable or method argument same as class 
        attribute.
      c7fad393
  18. 10 Feb, 2010 1 commit
    • Sergey Glukhov's avatar
      Bug#45195 valgrind warnings about uninitialized values in store_record_in_cache() · f2aee237
      Sergey Glukhov authored
      The problem becomes apparent only if HAVE_purify is undefined.
      It related to the part of code placed in open_table_from_share() fuction
      where we initialize record buffer only if HAVE_purify is enabled.
      So in case of HAVE_purify=OFF record buffer is not initialized
      on open table stage.
      Next we read key, find NULL value and update appropriate null bit
      but do not update record buffer. After that the record is stored
      in the join cache(store_record_in_cache). For CHAR fields we
      strip trailing spaces and in our case this procedure uses
      uninitialized record buffer.
      The fix is to skip stripping space procedure in case of null values
      for CHAR fields(partially based on 6.0 JOIN_CACHE implementation).
      
      
      mysql-test/r/join.result:
        test case
      mysql-test/t/join.test:
        test case
      sql/field.cc:
        code updated according to new CACHE_FIELD struct
      sql/sql_select.cc:
        code updated according to new CACHE_FIELD struct
      sql/sql_select.h:
        CACHE_FIELD struct:
        added new fields: Field *field, uint type;
        removed fields: Field_blob *blob_field, bool strip;
      f2aee237
  19. 18 Dec, 2009 1 commit
  20. 25 Nov, 2009 1 commit
    • MySQL Build Team's avatar
      Backport into build-200911241145-5.1.40sp1 · ffea9806
      MySQL Build Team authored
      > ------------------------------------------------------------
      > revno: 3148.8.5
      > revision-id: davi.arnaut@sun.com-20091102112139-pztthzy6qj8jzomn
      > parent: svoj@sun.com-20091103091902-vwszwwpfi1f4zrpn
      > committer: Davi Arnaut <Davi.Arnaut@Sun.COM>
      > branch nick: 48370-5.1
      > timestamp: Mon 2009-11-02 09:21:39 -0200
      > message:
      >   Bug#48370: Absolutely wrong calculations with GROUP BY and decimal fields when using IF
      >   Bug#45261: Crash, stored procedure + decimal
      >   
      >   Revert fix for Bug#45261 due to unforeseen bugs.
      ffea9806
  21. 20 Nov, 2009 1 commit
    • Georgi Kodinov's avatar
      Bug #45261 : Crash, stored procedure + decimal · a21cd97c
      Georgi Kodinov authored
      Bug #48370  Absolutely wrong calculations with GROUP BY and
        decimal fields when using IF
      
      Added the test cases in the above two bugs for regression
      testing.
      Added additional tests that demonstrate a incomplete fix.
      Added a new factory method for Field_new_decimal to 
      create a field from an (decimal returning) Item.
      In the new method made sure that all the precision and 
      length variables are capped in a proper way. 
      This is required because Item's can have larger precision
      than the decimal fields and thus need to be capped when
      creating a field based on an Item type.
      Fixed the wrong typecast to Item_decimal.
      a21cd97c
  22. 02 Nov, 2009 1 commit
  23. 29 Sep, 2009 1 commit
    • Davi Arnaut's avatar
      Bug#45567: Fast ALTER TABLE broken for enum and set · 8d3d35ea
      Davi Arnaut authored
      The problem was that appending values to the end of an existing
      ENUM or SET column was being treated as table data modification,
      preventing a immediately (fast) table alteration that occurs when
      only table metadata is being modified.
      
      The cause was twofold: adding a enumeration or set members to the 
      end of the list of valid member values was not being considered
      a "compatible" table alteration, and for SET columns, the check
      was being done upon the max display length and not the underlying
      (pack) length of the field.
      
      The solution is to augment the function that checks wether two ENUM
      or SET fields are compatible -- by comparing the pack lengths and
      performing a limited comparison of the member values.
      
      mysql-test/r/alter_table.result:
        Add test case result for Bug#45567
      mysql-test/t/alter_table.test:
        Add test case for Bug#45567
      sql/field.cc:
        Check whether two fields can be considered 'equal' for table
        alteration purposes. Fields are equal if they retain the same
        pack length and if new members are added to the end of the list.
      sql/field.h:
        Add comment and remove method.
      8d3d35ea
  24. 28 Aug, 2009 1 commit
    • Staale Smedseng's avatar
      Bug #43414 Parenthesis (and other) warnings compiling MySQL · 1ba25ae4
      Staale Smedseng authored
      with gcc 4.3.2
            
      This patch fixes a number of GCC warnings about variables used
      before initialized. A new macro UNINIT_VAR() is introduced for
      use in the variable declaration, and LINT_INIT() usage will be
      gradually deprecated. (A workaround is used for g++, pending a
      patch for a g++ bug.)
            
      GCC warnings for unused results (attribute warn_unused_result)
      for a number of system calls (present at least in later
      Ubuntus, where the usual void cast trick doesn't work) are
      also fixed.
      
      
      client/mysqlmanager-pwgen.c:
        A fix for warn_unused_result, adding fallback to use of
        srand()/rand() if /dev/random cannot be used. Also actually
        adds calls to rand() in the second branch so that it actually
        creates a random password.
      1ba25ae4
  25. 24 Aug, 2009 1 commit
    • Davi Arnaut's avatar
      Bug#45261: Crash, stored procedure + decimal · fc394595
      Davi Arnaut authored
      The problem was that creating a DECIMAL column from a decimal
      value could lead to a failed assertion as decimal values can
      have a higher precision than those attached to a table. The
      assert could be triggered by creating a table from a decimal
      with a large (> 30) scale. Also, there was a problem in
      calculating the number of digits in the integral and fractional
      parts if both exceeded the maximum number of digits permitted
      by the new decimal type.
      
      The solution is to ensure that truncation procedure is executed
      when deducing a DECIMAL column from a decimal value of higher
      precision. If the integer part is equal to or bigger than the
      maximum precision for the DECIMAL type (65), the integer part
      is truncated to fit and the fractional becomes zero. Otherwise,
      the fractional part is truncated to fit into the space left
      after the integer part is copied.
      
      This patch borrows code and ideas from Martin Hansson's patch.
      
      mysql-test/r/type_newdecimal.result:
        Add test case result for Bug#45261. Also, update test case to
        reflect that an additive operation increases the precision of
        the resulting type by 1.
      mysql-test/t/type_newdecimal.test:
        Add test case for Bug#45261
      sql/field.cc:
        Added DBUG_ASSERT to ensure object's invariant is maintained.
        Implement method to create a field to hold a decimal value
        from an item.
      sql/field.h:
        Explain member variable. Add method to create a new decimal field.
      sql/item.cc:
        The precision should only be capped when storing the value
        on a table. Also, this makes it impossible to calculate the
        integer part if Item::decimals (the scale) is larger than the
        precision.
      sql/item.h:
        Simplify calculation of integer part.
      sql/item_cmpfunc.cc:
        Do not limit the precision. It will be capped later.
      sql/item_func.cc:
        Use new method for allocating a new decimal field.
        Add a specialized method for retrieving the precision
        of a user variable item.
      sql/item_func.h:
        Add method to return the precision of a user variable.
      sql/item_sum.cc:
        Use new method for allocating a new decimal field.
      sql/my_decimal.h:
        The integer part could be improperly calculated for a decimal
        with 31 digits in the fractional part.
      sql/sql_select.cc:
        Use new method which truncates the integer or decimal parts
        as needed.
      fc394595
  26. 06 Aug, 2009 1 commit
    • Satya B's avatar
      Fix for BUG#45816 - assertion failure with index containing double · d933cb16
      Satya B authored
                          column on partitioned table
            
            
      An assertion 'ASSERT_COULUMN_MARKED_FOR_READ' is failed if the query 
      is executed with index containing double column on partitioned table.
      The problem is that assertion expects all the fields which are read,
      to be in the read_set.
            
      In this query only the field 'a' is in the readset as the tables in
      the query are joined by the field 'a' and so the assertion fails 
      expecting other field 'b'.
            
      Since the function cmp() is just comparison of two parameters passed, 
      the assertion is not required.
            
      Fixed by removing the assertion in the double fields comparision
      function and also fixed the index initialization to do ordered
      index scan with RW LOCK which ensures all the fields from a key are in
      the read_set.
       
      
      Note: this bug is not reproducible with other datatypes because the
            assertion doesn't exist in comparision function for other 
            datatypes.
      
      mysql-test/r/partition.result:
        Testcase for BUG#45816
      mysql-test/t/partition.test:
        Testcase for BUG#45816
      sql/field.cc:
        Removed the assertion ASSERT_COLUMN_MARED_FOR_READ in Field_double::cmp()
        function
      sql/ha_partition.cc:
        Fixed index_int() method to make it initialize the read_set properly if
        ordered index scan with RW lock is requested.
      d933cb16
  27. 31 Jul, 2009 1 commit
    • Gleb Shchepa's avatar
      Bug# 30946: mysqldump silently ignores --default-character-set · 4e95179a
      Gleb Shchepa authored
                  when used with --tab
      
      1) New syntax: added CHARACTER SET clause to the
        SELECT ... INTO OUTFILE (to complement the same clause in
        LOAD DATA INFILE).
        mysqldump is updated to use this in --tab mode.
      
      2) ESCAPED BY/ENCLOSED BY field parameters are documented as
         accepting CHAR argument, however SELECT .. INTO OUTFILE
         silently ignored rests of multisymbol arguments.
         For the symmetrical behavior with LOAD DATA INFILE the
         server has been modified to fail with the same error:
      
           ERROR 42000: Field separator argument is not what is
                        expected; check the manual
      
      3) Current LOAD DATA INFILE recognizes field/line separators
         "as is" without converting from client charset to data
         file charset. So, it is supposed, that input file of
         LOAD DATA INFILE consists of data in one charset and
         separators in other charset. For the compatibility with
         that [buggy] behaviour SELECT INTO OUTFILE implementation
         has been saved "as is" too, but the new warning message
         has been added:
      
           Non-ASCII separator arguments are not fully supported
      
         This message warns on field/line separators that contain
         non-ASCII symbols.
      
      
      client/mysqldump.c:
        mysqldump has been updated to call SELECT ... INTO OUTFILE
        statement with a charset from the --default-charset command
        line parameter.
      mysql-test/r/mysqldump.result:
        Added test case for bug #30946.
      mysql-test/r/outfile_loaddata.result:
        Added test case for bug #30946.
      mysql-test/t/mysqldump.test:
        Added test case for bug #30946.
      mysql-test/t/outfile_loaddata.test:
        Added test case for bug #30946.
      sql/field.cc:
        String conversion code has been moved from check_string_copy_error()
        to convert_to_printable() for reuse.
      sql/share/errmsg.txt:
        New WARN_NON_ASCII_SEPARATOR_NOT_IMPLEMENTED message has been added.
      sql/sql_class.cc:
        The select_export::prepare() method has been modified to:
        
          1) raise the ER_WRONG_FIELD_TERMINATORS error on multisymbol
             ENCLOSED BY/ESCAPED BY field arguments like LOAD DATA INFILE;
        
          2) warn with a new WARN_NON_ASCII_SEPARATOR_NOT_IMPLEMENTED
             message on non-ASCII field or line separators.
        
        The select_export::send_data() merhod has been modified to
        convert item data to output charset (see new SELECT INTO OUTFILE
        syntax). By default the BINARY charset is used for backward
        compatibility.
      sql/sql_class.h:
        The select_export::write_cs field added to keep output
        charset.
      sql/sql_load.cc:
        mysql_load has been modified to warn on non-ASCII field or
        line separators with a new WARN_NON_ASCII_SEPARATOR_NOT_IMPLEMENTED
        message.
      sql/sql_string.cc:
        New global function has been added: convert_to_printable()
        (common code has been moved from check_string_copy_error()).
      sql/sql_string.h:
        New String::is_ascii() method and new global convert_to_printable()
        function have been added.
      sql/sql_yacc.yy:
        New syntax: added CHARACTER SET clause to the
        SELECT ... INTO OUTFILE (to complement the same clause in
        LOAD DATA INFILE). By default the BINARY charset is used for
        backward compatibility.
      4e95179a
  28. 24 Jun, 2009 2 commits
    • MySQL Build Team's avatar
      Backport into build-200906240007-5.1.34sp1 · 4ce94d93
      MySQL Build Team authored
      > ------------------------------------------------------------
      > revno: 2852.1.10
      > revision-id: sergey.glukhov@sun.com-20090409093850-z3vgmz8fqogv8o1o
      > parent: v.narayanan@sun.com-20090409081823-zsw611isjcorl63b
      > parent: sergey.glukhov@sun.com-20090409091931-2zhtgonllfmsxjex
      > committer: Sergey Glukhov <Sergey.Glukhov@sun.com>
      > branch nick: mysql-5.1-bugteam
      > timestamp: Thu 2009-04-09 14:38:50 +0500
      > message:
      >   5.0-bugteam->5.1-bugteam merge
      >     ------------------------------------------------------------
      >     revno: 1810.3882.6
      >     revision-id: sergey.glukhov@sun.com-20090409091931-2zhtgonllfmsxjex
      >     parent: anurag.shekhar@sun.com-20090409080004-xvxy663jan45tb3c
      >     committer: Sergey Glukhov <Sergey.Glukhov@sun.com>
      >     branch nick: mysql-5.0-bugteam
      >     timestamp: Thu 2009-04-09 14:19:31 +0500
      >     message:
      >       Bug#43833 Simple INSERT crashes the server
      >       The crash happens due to wrong 'digits' variable value(0),
      >       'digits' can not be 0, so the fix is use 1 as min allowed value.
      4ce94d93
    • Tatiana A. Nurnberg's avatar
      Bug#43508: Renaming timestamp or date column triggers table copy · 74deaae9
      Tatiana A. Nurnberg authored
      Altering a table to update a column with types DATE or TIMESTAMP
      would incorrectly be seen as a significant change that necessitates
      a slow copy+rename operation instead of a fast update.
      
      There were two problems:
      
      The character set is magically set for TIMESTAMP to be "binary",
      but that was done too deep in field use code for ALTER TABLE to
      know of it.  Now, put that in the constructor for Field_timestamp.
      
      Also, when we set the character set for the new replacement/
      comparison field, also raise the "binary" field flag that tells us
      we should compare it exactly.  That is necessary to match the old
      stored definition.
      
      Next is the problem that the default length for TIMESTAMP and DATE
      fields is different than the length read from the .frm .  The
      compressed size is written to the file, but the human-readable,
      part-delimited length is used as default length.  IIRC, for
      timestamp it was 19!=14, and for date it was 8!=10.  Length
      mismatch causes a table copy.
      
      Also, clean up a place where a comparison function alters one of its
      parameters and replace it with an assertion of the condition it
      mutates.
      74deaae9
  29. 09 Jun, 2009 2 commits
    • Staale Smedseng's avatar
      Bug #43414 Parenthesis (and other) warnings compiling MySQL · a073ee45
      Staale Smedseng authored
      with gcc 4.3.2
            
      Compiling MySQL with gcc 4.3.2 and later produces a number of 
      warnings, many of which are new with the recent compiler
      versions.
            
      This bug will be resolved in more than one patch to limit the
      size of changesets. This is the first patch, fixing a number 
      of the warnings, predominantly "suggest using parentheses 
      around && in ||", and empty for and while bodies.
      a073ee45
    • Staale Smedseng's avatar
      Bug #43414 Parenthesis (and other) warnings compiling MySQL · a092ed1a
      Staale Smedseng authored
      with gcc 4.3.2
      
      Compiling MySQL with gcc 4.3.2 and later produces a number of 
      warnings, many of which are new with the recent compiler
      versions.
      
      This bug will be resolved in more than one patch to limit the
      size of changesets. This is the first patch, fixing a number 
      of the warnings, predominantly "suggest using parentheses 
      around && in ||", and empty for and while bodies.
      a092ed1a
  30. 15 May, 2009 1 commit
    • Alexey Kopytov's avatar
      Bug #44792: valgrind warning when casting from time to time · 22e840d7
      Alexey Kopytov authored
       
      Field_time::get_time() did not initialize some members of 
      MYSQL_TIME which led to valgrind warnings when those members 
      were accessed in Protocol_simple::store_time(). 
       
      It is unlikely that this bug could result in wrong data 
      being returned, since Field_time::get_time() initializes the 
      'day' member of MYSQL_TIME to 0, so the value of 'day' 
      in Protocol_simple::store_time() would be 0 regardless 
      of the values for 'year' and 'month'.
      
      mysql-test/r/type_time.result:
        Added a test case for bug #44792.
      mysql-test/t/type_time.test:
        Added a test case for bug #44792.
      sql/field.cc:
        Field_time::get_time() did not initialize some members of 
        MYSQL_TIME which led to valgrind warnings when those members 
        were accessed in Protocol_simple::store_time().
      22e840d7
  31. 09 Apr, 2009 1 commit
    • Sergey Glukhov's avatar
      Bug#43833 Simple INSERT crashes the server · 920abd58
      Sergey Glukhov authored
      The crash happens due to wrong 'digits' variable value(0),
      'digits' can not be 0, so the fix is use 1 as min allowed value.
      
      
      mysql-test/r/insert.result:
        test result
      mysql-test/t/insert.test:
        test case
      sql/field.cc:
        The crash happens due to wrong 'digits' variable value(0),
        'digits' can not be 0, so the fix is use 1 as min allowed value.
      920abd58
  32. 27 Mar, 2009 1 commit
    • Alexey Kopytov's avatar
      Fix for bug #43432: Union on floats does unnecessary rounding · 0b60184b
      Alexey Kopytov authored
        
      UNION could convert fixed-point FLOAT(M,D)/DOUBLE(M,D) columns  
      to FLOAT/DOUBLE when aggregating data types from the SELECT  
      substatements. While there is nothing particularly wrong with  
      this behavior, especially when M is greater than the hardware  
      precision limits, it could be confusing in cases when all  
      SELECT statements in a union have the same  
      FLOAT(M,D)/DOUBLE(M,D) columns with equal precision  
      specifications listed in the same position.  
        
      Since the manual is quite vague on what data type should be  
      returned in such cases, the bug was fixed by implementing the  
      most 'expected' behavior: do not convert FLOAT(M,D)/DOUBLE(M,D)  
      to anything else if all SELECT statements in a UNION have the  
      same precision for that column.  
      
      mysql-test/r/union.result:
        Added a test case for bug #43432.
      mysql-test/t/union.test:
        Added a test case for bug #43432.
      sql/field.cc:
        Replaced FLT_DIG+6 and DBL_DIG+7 with a symbolic constant.
      sql/item.cc:
        Do not convert FLOAT(M,D)/DOUBLE(M,D) 
        to anything else if all SELECT statements in a UNION have the 
        same precision for that column.
      sql/mysql_priv.h:
        Added a symbolic constant for FLT_DIG+6 and DBL_DIG+7.
      0b60184b
  33. 09 Dec, 2008 1 commit
  34. 27 Nov, 2008 1 commit
  35. 10 Nov, 2008 1 commit
  36. 24 Oct, 2008 1 commit
    • Ramil Kalimullin's avatar
      Fix for bug#23113: Different behavior on altering ENUM fields between 5.0 and 5.1 · 256f41ed
      Ramil Kalimullin authored
      Problem: mysqld doesn't detect that enum data must be reinserted performing
      'ALTER TABLE' in some cases.
      
      Fix: reinsert data altering an enum field if enum values are changed.
      
      
      mysql-test/r/alter_table.result:
        Fix for bug#23113: Different behavior on altering ENUM fields between 5.0 and 5.1
          - test result.
      mysql-test/t/alter_table.test:
        Fix for bug#23113: Different behavior on altering ENUM fields between 5.0 and 5.1
          - test case.
      sql/field.cc:
        Fix for bug#23113: Different behavior on altering ENUM fields between 5.0 and 5.1
          - Field_enum::is_equal() introduced, which is called to detect that a field
        is changing by 'ALTER TABLE'.
      sql/field.h:
        Fix for bug#23113: Different behavior on altering ENUM fields between 5.0 and 5.1
          - Field_enum::is_equal() introduced, which is called to detect that a field
        is changing by 'ALTER TABLE'.
      256f41ed
  37. 20 Sep, 2008 1 commit
    • Kristofer Pettersson's avatar
      Bug#38469 invalid memory read and/or crash with utf8 text field, stored procedure, uservar · f0352e34
      Kristofer Pettersson authored
                  
      A stored procedure involving substrings could crash the server on certain
      platforms because of invalid memory reads.
                
      During storing the new blob-field value, the cached value's address range
      overlapped that of the new field value. This caused problems when the 
      cached value storage was reallocated to provide access for a new 
      characater set representation. The patch checks the address ranges, and if
      they overlap, the new field value is copied to a new storage before it is
      converted to the new character set.
      
      
      mysql-test/r/sp.result:
        Added result set
      mysql-test/t/sp.test:
        Added test case
      sql/field.cc:
        The source and destination address ranges of a character conversion must not overlap or the 'from' address will be invalidated as the temporary value-
        object is re-allocated to fit the new character set.
      sql/field.h:
        Added comments
      f0352e34