- 22 Mar, 2016 1 commit
-
-
Sergei Golubchik authored
delete deferred events after they're executed (otherwise they can be executed again for a sub-statement) See also commit 0e78d1d Author: Venkatesh Duggirala <venkatesh.duggirala@oracle.com> Date: Wed Mar 20 11:20:47 2013 +0530 BUG#15850951-DUPLICATE ERROR IN REPLICATION WITH SLAVE TRIGGERS AND AUTO INCREMENT
-
- 21 Mar, 2016 17 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
10.1 part of the fix
-
Sergei Golubchik authored
-
Sergei Golubchik authored
10.0 part of the fix
-
Sergei Golubchik authored
-
Sergei Golubchik authored
update main.delayed test after 38b89a61 ALTER TABLE ... COMMENT is no longer blocking, use a different ALTER TABLE variant.
-
Sergei Golubchik authored
Fixed more cases for MDEV-6282
-
Sergei Golubchik authored
don't strcpy a string to itself
-
Sergei Golubchik authored
s/Execute/Query/ to account for --ps-protocol
-
Sergei Golubchik authored
-
Sergei Golubchik authored
typo. the code was not matching the comment
-
Sergei Golubchik authored
fix a buffer overflow in extension_based_table_discovery (that only happens in debug builds)
-
Bernard Spil authored
Remove Linuxism. Works fine with a POSIX-compat shell
-
Sergei Golubchik authored
don't crash in debug builds. issue an error message on corrupt event
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
MariaDB-server-10.1 should obsolete MariaDB-Galera-server
-
- 19 Mar, 2016 4 commits
-
-
Sergei Golubchik authored
when creating shadow nullable fields, preserve all original field flags (because we swap flags back and forth in not_null_fields_have_null_values())
-
Sergei Golubchik authored
in particular, don't do ExternalProject_Add() that starts creating build directories for a disabled plugin
-
Sergei Golubchik authored
MDEV-9739 Assertion `m_status == DA_ERROR || m_status == DA_OK' failed in Diagnostics_area::message() ; connect.xml* tests fail in buildbot
-
Olivier Bertrand authored
modified: storage/connect/value.cpp - Fix compile error of MDEV-9603 modified: storage/connect/tabmysql.cpp
-
- 18 Mar, 2016 12 commits
-
-
Sergei Golubchik authored
don't fail if cracklib_password_check is statically compiled in
-
Sergei Golubchik authored
-
Jan Lindström authored
Fix incorrectly merged files on innodb_plugin.
-
Oleksandr Byelkin authored
Fixed printing integer constant in the ORDER clause (MySQL solution) Removed workaround for double resolving counter in the ORDER.
-
Sergei Golubchik authored
5.5 part of the fix
-
Alexander Barkov authored
MDEV-9653 Assertion `length || !scale' failed in uint my_decimal_length_to_precision(uint, uint, bool) MDEV-9752 Wrong data type for COALEASCE(?,1) in prepared statements
-
Sergey Vojtovich authored
In RHEL7/RHEL7.1 libcrack behavior seem to have been modified so that "foobar" password is considered bad (due to descending "ba") earlier than expected. For details google for cracklib-2.9.0-simplistic.patch. Adjusted affected passwords not to have descending and ascending sequences.
-
Akira Higuchi authored
-
Akira Higuchi authored
-
Jan Lindström authored
-
Sergey Vojtovich authored
-
Jan Lindström authored
Analysis: -- InnoDB has n (>0) redo-log files. -- In the first page of redo-log there is 2 checkpoint records on fixed location (checkpoint is not encrypted) -- On every checkpoint record there is up to 5 crypt_keys containing the keys used for encryption/decryption -- On crash recovery we read all checkpoints on every file -- Recovery starts by reading from the latest checkpoint forward -- Problem is that latest checkpoint might not always contain the key we need to decrypt all the redo-log blocks (see MDEV-9422 for one example) -- Furthermore, there is no way to identify is the log block corrupted or encrypted For example checkpoint can contain following keys : write chk: 4 [ chk key ]: [ 5 1 ] [ 4 1 ] [ 3 1 ] [ 2 1 ] [ 1 1 ] so over time we could have a checkpoint write chk: 13 [ chk key ]: [ 14 1 ] [ 13 1 ] [ 12 1 ] [ 11 1 ] [ 10 1 ] killall -9 mysqld causes crash recovery and on crash recovery we read as many checkpoints as there is log files, e.g. read [ chk key ]: [ 13 1 ] [ 12 1 ] [ 11 1 ] [ 10 1 ] [ 9 1 ] read [ chk key ]: [ 14 1 ] [ 13 1 ] [ 12 1 ] [ 11 1 ] [ 10 1 ] [ 9 1 ] This is problematic, as we could still scan log blocks e.g. from checkpoint 4 and we do not know anymore the correct key. CRYPT INFO: for checkpoint 14 search 4 CRYPT INFO: for checkpoint 13 search 4 CRYPT INFO: for checkpoint 12 search 4 CRYPT INFO: for checkpoint 11 search 4 CRYPT INFO: for checkpoint 10 search 4 CRYPT INFO: for checkpoint 9 search 4 (NOTE: NOT FOUND) For every checkpoint, code generated a new encrypted key based on key from encryption plugin and random numbers. Only random numbers are stored on checkpoint. Fix: Generate only one key for every log file. If checkpoint contains only one key, use that key to encrypt/decrypt all log blocks. If checkpoint contains more than one key (this is case for databases created using MariaDB server version 10.1.0 - 10.1.12 if log encryption was used). If looked checkpoint_no is found from keys on checkpoint we use that key to decrypt the log block. For encryption we use always the first key. If the looked checkpoint_no is not found from keys on checkpoint we use the first key. Modified code also so that if log is not encrypted, we do not generate any empty keys. If we have a log block and no keys is found from checkpoint we assume that log block is unencrypted. Log corruption or missing keys is found by comparing log block checksums. If we have a keys but current log block checksum is correct we again assume log block to be unencrypted. This is because current implementation stores checksum only before encryption and new checksum after encryption but before disk write is not stored anywhere.
-
- 17 Mar, 2016 4 commits
-
-
Elena Stepanova authored
-
Sergei Golubchik authored
don't allocate all the stack, leave some stack for function calls. To test I added the following line: alloca_size = available_stack_size() - X at X=4096 or less mysqld crashed, at 8192 mtr test passed.
-
Vladislav Vaintroub authored
-
Sergei Golubchik authored
remove erroneous free() call
-
- 16 Mar, 2016 2 commits
-
-
Olivier Bertrand authored
This was because Tablist can be NULL when no lacal tables are in the list. modified: storage/connect/tabtbl.cpp modified: storage/connect/mysql-test/connect/r/tbl.result modified: storage/connect/mysql-test/connect/t/tbl.test
-
Olivier Bertrand authored
modified: storage/connect/tabmysql.cpp - Test invalid CSV separator when creating the table (MDEV-9714) modified: storage/connect/ha_connect.cc - Stop using SQLDescribeParam anymore modified: storage/connect/odbconn.cpp - Fix MDEV-9723 Regression due to calling Cardinality instead of GetMaxSize in info. modified: storage/connect/tabtbl.h modified: storage/connect/mysql-test/connect/r/tbl.result modified: storage/connect/mysql-test/connect/t/tbl.test - Typo modified: storage/connect/tabodbc.cpp
-