1. 23 May, 2013 1 commit
  2. 22 May, 2013 1 commit
    • Chaithra Gopalareddy's avatar
      Bug#11766191:INVALID MEMORY READ IN DO_DIV_MOD WITH DOUBLY ASSIGNED VARIABLES · 0c903fb5
      Chaithra Gopalareddy authored
      Bug#12608543: CRASHES WITH DECIMALS AND STATEMENT NEEDS TO BE REPREPARED ERRORS
      
      Backporting these two fixes to 5.1 
      Added unittest to test my_decimal construtor and assignment operators
      
      sql/my_decimal.h:
        Added constructor and assignment operators for my_decimal
      unittest/my_decimal/my_decimal-t.cc:
        Added test to check constructor and assignment operators for my_decimal
      0c903fb5
  3. 20 May, 2013 1 commit
  4. 19 May, 2013 1 commit
    • Ashish Agarwal's avatar
      Bug#16194302: SUPPORT FOR FLOATING-POINT SYSTEM VARIABLES · 0c4f4ff0
      Ashish Agarwal authored
                    USING THE PLUGIN INTERFACE.
      
      ISSUE: No support for floating-point plugin
             system variables.
      
      SOLUTION: Allowing plugins to define and expose floating-point
                system variables of type double. MYSQL_SYSVAR_DOUBLE
                and MYSQL_THDVAR_DOUBLE are added.
      
      ISSUE: Fractional part of the def, min, max values of system
             variables are ignored.
      
      SOLUTION: Adding functions that are used to store the raw
                representation of a double in the raw bits of unsigned
                longlong in a way that the binary representation
                remains the same.
      0c4f4ff0
  5. 18 May, 2013 1 commit
    • Annamalai Gurusami's avatar
      Bug #12762377 FOREIGN KEYS NOT CONSTRUCTED WHEN APOSTROPHES ARE · 5ca36b3b
      Annamalai Gurusami authored
      ESCAPED WITH BACKSLASH
      
      Problem:
      
      When the CREATE TABLE statement used COMMENTS with escape sequences like
      'foo\'s', InnoDB did not parse is correctly when trying to extract the
      foreign key information.  Because of this, the foreign keys specified
      in the CREATE TABLE statement were not created.
      
      Solution:
      
      Make the InnoDB internal parser aware of escape sequences. 
      
      rb#2457 approved by Kevin.
      
      5ca36b3b
  6. 17 May, 2013 2 commits
    • Venkatesh Duggirala's avatar
      Bug#14236170 MYSQLDUMP 5.5.25 CLIENT FAILS TO DUMP · 7397aa91
      Venkatesh Duggirala authored
      MYSQL DB FROM REMOTE 5.0.96 SERVER
      
      Problem: mysqldump tool assumes the existence of
      general_log and slow_log tables in the server.
      If mysqldump tool executes on a old server where
      there are no log tables like these, mysqldump tool
      fails.
      
      Analysis: general_log and slow_log tables are added
      in the ignore-table list as part of bug-26121 fix
      causes bug-45740 (MYSQLDUMP DOESN'T DUMP GENERAL_LOG
      AND SLOW_QUERY CAUSES RESTORE PROBLEM). As part of
      the bug-45740 fix, mysqldump tool adds create table
      queries for these two tables. But the fix assumes
      that on all the servers, general_log and slow_log
      will be there. If the new mysqldump tool is executed
      against a old server where there are no general_log
      and slow_log, the mysqldump tool fails with an error
      that 'there is no general_log table'.
      
      Fix: When mysqldump tool is trying to retrieve general_log
      and slow_log table structures, first the tool should
      check their existence of these tables in the server
      instead of trying to dump it blindly.
      7397aa91
    • unknown's avatar
      No commit message · 53f57ab2
      unknown authored
      No commit message
      53f57ab2
  7. 16 May, 2013 15 commits
  8. 15 May, 2013 4 commits
  9. 14 May, 2013 1 commit
    • Shubhangi Garg's avatar
      Bug#16607258 :Linker Errors Due To Inclusion Of An Implementation File · b25d5cff
      Shubhangi Garg authored
                                 In log_event.h
            
      DESCRIPTION:
      Due to inclusion of an implementation file, namely 'rpl_tblmap.cc'
      in a header file, namely 'log_event.h'; linker errors occur if
      log_event.h is included in an application containing multiple source
      files, such as in the case of Binlog API.
            
      Binlog API requires including log_event.h in its source files;
      which leads to multiple definition errors, for functions defined
      in rpl_tblmap.cc for class 'table_mapping'.
                  
      FIX:
      Change the inclusion from header file(log_event.h) to source files
      using this header and have flag MYSQL_CLIENT set. The only file in
      the current server repository is mysqlbinlog.cc.
      
      client/mysqlbinlog.cc:
        Pulled in code of rpl_tblmap.cc
      sql/log_event.h:
        Removed inclusion of the implementation file from this header file
      b25d5cff
  10. 13 May, 2013 4 commits
    • unknown's avatar
      Bug#14529666 INNODB_BUFFER_PAGE DOES NOT MARK CHANGE BUFFER PAGES APPROPRIATELY · 0d31c13e
      unknown authored
      == Analysis == 
      Both change buffer pages and on-disk indexes pages are marked as
      FIL_PAGE_INDEX. So all ibuf index pages will classify as INDEX with NULL
      table_name and index_name.
      
      == Solution ==
      A new page type for ibuf data pages named I_S_PAGE_TYPE_IBUF is defined. All
      these pages whose index_id equal (DICT_IBUF_ID_MIN + IBUF_SPACE_ID) will 
      classify as IBUF_DATA instead of INDEX in INNODB_BUFFER_PAGE 
      and INNODB_BUFFER_PAGE_LRU.
      
      This fix is only for IS reporting, both on-disk and buffer pool structures
      keep unchanged.
      
      Approved by both Marko and Jimmy. rb#2334
      0d31c13e
    • Neeraj Bisht's avatar
      Bug#12328597 - MULTIPLE COUNT(DISTINCT) IN SAME SELECT FALSE · 35a3f9d7
      Neeraj Bisht authored
                     WITH COMPOSITE KEY COLUMNS
      
      Problem:-
      While running a SELECT query with several AGGR(DISTINCT) function 
      and these are referring to different field of same composite key, 
      Returned incorrect value.
      
      Analysis:-
      
      In a table, where we have composite key like (a,b,c)
      and when we give a query like
      
      select COUNT(DISTINCT b), SUM(DISTINCT a) from ....
      
      here, we first make a list of items in Aggr(distinct) function
      (which is a, b), where order of item doesn't matter. 
      and then we see, whether we have a composite key where the prefix 
      of index columns matches the items of the aggregation function.
      (in this case we have a,b,c).
      
      if yes, so we can use loose index scan and we need not perform 
      duplicate removal to distinct in our aggregate function.
      
      In our table, we traverse column marked with <-- and get the result as
      (a,b,c)      count(distinct b)           sum(distinct a)
                   treated as count b          treated as sum(a)
      (1,1,2)<--              1                      1		
      (1,2,2)<--              1++=2                  1+1=2
      (1,2,3)		
      (2,1,2)<--              2++=3                  1+1+2=4
      (2,2,2)<--              3++=4                  1+1+2+2=6
      (2,2,3)
      
      result will be 4,6, but it should be (2,3)
      
      As in this case, our assumption is incorrect. If we have
      query like 
      select count(distinct a,b), sum(distinct a,b)from ..
      then we can use loose index scan
      
      Solution:-
      In our query, when we have more then one aggr(distinct) function 
      then they should refer to same  fields like
      
      select count(distinct a,b), sum(distinct a,b) from .. 
      
      -->we can use loose scan index as both aggr(distinct) refer to same fields a,b.
      
      If they are referring to different field like
      
      select count(distinct a), sum(distinct b) from .. 
      
      -->will not use loose scan index as both aggr(distinct) refer to different fields.
      35a3f9d7
    • Annamalai Gurusami's avatar
      05111d32
    • unknown's avatar
      No commit message · 1eb7e211
      unknown authored
      No commit message
      1eb7e211
  11. 12 May, 2013 2 commits
  12. 10 May, 2013 4 commits
  13. 09 May, 2013 1 commit
  14. 08 May, 2013 1 commit
    • Jon Olav Hauglid's avatar
      Bug#16779374: NEW ERROR MESSAGE ADDED TO 5.5 AFTER 5.6 GA - REUSING · 7df0ee6c
      Jon Olav Hauglid authored
                    NUMBER ALREADY USED BY 5.6
      
      The problem was that the patch for Bug#13004581 added a new error
      message to 5.5. This causes it to use an error number already used
      in 5.6 by ER_CANNOT_LOAD_FROM_TABLE_V2. Which means that error
      message number stability between GA releases is broken.
      
      This patch fixes the problem by removing the error message and
      using ER_UNKNOWN_ERROR instead.
      7df0ee6c
  15. 07 May, 2013 1 commit