1. 05 Jul, 2007 4 commits
  2. 04 Jul, 2007 1 commit
    • unknown's avatar
      Bug#26827 - table->read_set is set incorrectly, · 435df185
      unknown authored
                causing update of a different column
      
      For efficiency some storage engines do not read a complete record
      for update, but only the columns required for selecting the rows.
      
      When updating a row of a partitioned table, modifying a column
      that is part of the partition or subpartition expression, then
      the row may need to move from one [sub]partition to another one.
      This is done by inserting the new row into the target
      [sub]partition and deleting the old row from the originating one.
      For the insert we need a complete record.
      
      If an above mentioned engine was used for a partitioned table, we
      did not have a complete record in update_row(). The implicitly
      executed write_row() got an incomplete record.
      
      This is solved by instructing the engine to read a complete record
      if one of the columns of the partition or subpartiton is to be
      updated.
      
      No testcase. This can be reproduced with Falcon only. The engines
      contained in standard 5.1 do always return complete records on
      update.
      
      
      sql/ha_partition.cc:
        Bug#26827 - table->read_set is set incorrectly,
                    causing update of a different column
        Setting partition field bits in read_set if a writing
        operation is going on. This replaces the old function
        include_partition_fields_in_used_fields().
        Setting all bits in read_set if write_set contains a column
        used in a partition or subpartition expression.
        Removed include_partition_fields_in_used_fields().
      sql/ha_partition.h:
        Bug#26827 - table->read_set is set incorrectly,
                    causing update of a different column
        Removed declaration of
        include_partition_fields_in_used_fields().
      sql/partition_info.h:
        Bug#26827 - table->read_set is set incorrectly,
                    causing update of a different column
        Added a bitmap to partition_info for a quick check of
        columns used in a partition or subpartition expression.
      sql/sql_partition.cc:
        Bug#26827 - table->read_set is set incorrectly,
                    causing update of a different column
        Initializing the new bitmap with all columns used in a
        partition or subpartition expression.
      435df185
  3. 03 Jul, 2007 2 commits
    • unknown's avatar
      move test for bug29299 into seperate file as it requires charset gbk · 1490e79d
      unknown authored
      fixes test breakage on sles10-ia64-a which omits charset.
      
      
      mysql-test/r/fulltext2.result:
        move test for bug29299 into seperate file as it requires charset gbk
      mysql-test/t/fulltext2.test:
        move test for bug29299 into seperate file as it requires charset gbk
      mysql-test/r/fulltext3.result:
        move test for bug29299 into seperate file as it requires charset gbk
      mysql-test/t/fulltext3.test:
        move test for bug29299 into seperate file as it requires charset gbk
      1490e79d
    • unknown's avatar
      fix bad merge · 63e03007
      unknown authored
      63e03007
  4. 02 Jul, 2007 3 commits
  5. 01 Jul, 2007 5 commits
    • unknown's avatar
      Corrected a test case. · de0ba5c8
      unknown authored
      de0ba5c8
    • unknown's avatar
      Post.merge fixes · 1cd1f7d0
      unknown authored
      Fixed warnings
      Fixed error numbers
      
      
      mysql-test/extra/rpl_tests/rpl_loaddata.test:
        Fixed warnings
      mysql-test/r/ndb_single_user.result:
        Post-merge fixes
        Changed error numbers
      mysql-test/t/bigint.test:
        Fixed warnings
      mysql-test/t/ndb_single_user.test:
        Post-merge fixes
        Changed error numbers
      1cd1f7d0
    • unknown's avatar
      Made test case platform independent. · e63f6f32
      unknown authored
      e63f6f32
    • unknown's avatar
      Post-merge fix. · f9d36194
      unknown authored
      f9d36194
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 26a2b004
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.1-opt
      
      
      mysql-test/r/binary.result:
        Auto merged
      mysql-test/r/ctype_collate.result:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/t/binary.test:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      sql/field_conv.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/table.cc:
        Auto merged
      storage/myisam/mi_open.c:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      mysql-test/r/create.result:
        Manual merge.
      mysql-test/r/subselect.result:
        Manual merge.
      mysql-test/r/type_enum.result:
        Manual merge.
      mysql-test/t/type_enum.test:
        Manual merge.
      mysql-test/include/mix1.inc:
        Manual merge.
      mysql-test/r/innodb_mysql.result:
        Manual merge.
      mysql-test/t/subselect.test:
        Manual merge.
      sql/sql_parse.cc:
        Manual merge.
      storage/myisam/mi_key.c:
        Manual merge.
      26a2b004
  6. 30 Jun, 2007 5 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · 8dcd5fca
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/type_enum.result:
        Auto merged
      mysql-test/t/type_enum.test:
        Auto merged
      sql/field_conv.cc:
        SCCS merged
      8dcd5fca
    • unknown's avatar
      Post-merge fixes. · b83c28b2
      unknown authored
      
      sql/ha_partition.cc:
        Post-merge fixes.
        The new function HA_EXTRA_INSERT_WITH_UPDATE needs to be handled in
        ha_partition::extra().
      storage/federated/ha_federated.cc:
        Post-merge fixes.
        Removed leftover characters.
        Added a missing brace.
        Fixed and improved parenthesis handling in ha_federated::append_stmt_insert().
        Moved code from HA_EXTRA_RESET to ha_federated::reset().
      storage/federated/ha_federated.h:
        Post-merge fixes.
        Changed byte to uchar.
        Added declaration for ha_federated::reset().
      b83c28b2
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 2ca2b232
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29157-5.1-opt
      
      
      2ca2b232
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-axmrg · 6b125058
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/federated.result:
        Auto merged
      mysql-test/t/federated.test:
        Auto merged
      include/my_base.h:
        Manual merge
      sql/sql_insert.cc:
        Manual merge
      storage/federated/ha_federated.cc:
        Manual merge
      storage/federated/ha_federated.h:
        Manual merge
      6b125058
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-ateam · ffe19f62
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      
      ffe19f62
  7. 29 Jun, 2007 20 commits
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-axmrg · 241088c5
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      241088c5
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.1-amain · ca731030
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      configure.in:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      ca731030
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.1-ateam · a9e5e4c5
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      a9e5e4c5
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/p2-bug25513.5 · 97139ca5
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/5.0-engines-merge
      
      
      97139ca5
    • unknown's avatar
      fix Visual Studio build - strictness of compiler could not cast · c268fd77
      unknown authored
      pointer into a BOOL type.
      
      
      c268fd77
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29205 · a89259fa
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      a89259fa
    • unknown's avatar
      Fixed bug #29205. · db397d16
      unknown authored
      When a UNION statement forced conversion of an UTF8
      charset value to a binary charset value, the byte
      length of the result values was truncated to the
      CHAR_LENGTH of the original UTF8 value.
      
      
      sql/item.cc:
        Fixed bug #29205.
        The calculation of data length was modified in
        the Item_type_holder::join_types method to take into
        account possible conversion of a multibyte charset
        value to a binary charset value, when each
        multibyte character is converted into a sequence
        of bytes (not to a single byte of binary charset).
      mysql-test/t/ctype_utf8.test:
        Updated test case for bug #29205.
      mysql-test/r/ctype_utf8.result:
        Updated test case for bug #29205.
      db397d16
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/mysql-5.0-engines · eda9c97e
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/5.0-engines-merge
      
      
      eda9c97e
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/p2-bug25511.5 · 495dfde5
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/p2-bug25513.5
      
      
      sql/ha_federated.cc:
        Auto merged
      495dfde5
    • unknown's avatar
      add and amend comments for clarity · b4fe5e44
      unknown authored
      
      include/my_base.h:
        amend comment for clarity
      sql/ha_federated.cc:
        add comment
      b4fe5e44
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-amain · 29d2edfa
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      
      29d2edfa
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-ateam · b6fbbc9b
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      
      b6fbbc9b
    • unknown's avatar
      Merge mysqldev@production:/data0/mysqldev/my/mysql-5.1-release · 15575443
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      15575443
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 6a00ce71
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29261-bug-5.0-opt-mysql
      
      
      6a00ce71
    • unknown's avatar
      Bug#29261: Sort order of the collation wasn't used when comparing trailing · 4772a012
      unknown authored
      spaces.
      
      When the my_strnncollsp_simple function compares two strings and one is a prefix
      of another then this function compares characters in the rest of longer key
      with the space character to find whether the longer key is greater or less.
      But the sort order of the collation isn't used in this comparison. This may
      lead to a wrong comparison result, wrongly created index or wrong order of the
      result set of a query with the ORDER BY clause.
      
      Now the my_strnncollsp_simple function uses collation sort order to compare
      the characters in the rest of longer key with the space character.
      
      
      mysql-test/t/ctype_collate.test:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      mysql-test/r/ctype_collate.result:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      strings/ctype-simple.c:
        Bug#29261: Sort order of the collation wasn't used when comparing trailing
        spaces.
        Now the my_strnncollsp_simple function uses collation sort order to compare
        the characters in the rest of longer key with the space character.
      4772a012
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 33eb22a3
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27333-gcov-5.0-opt
      
      
      33eb22a3
    • unknown's avatar
      Bug#27333: subquery grouped for aggregate of outer · c2e961cf
      unknown authored
      query / no aggregate of subquery
       The optimizer counts the aggregate functions that 
       appear as top level expressions (in all_fields) in 
       the current subquery. Later it makes a list of these
       that it uses to actually execute the aggregates in
       end_send_group().
       That count is used in several places as a flag whether
       there are aggregates functions.
       While collecting the above info it must not consider
       aggregates that are not aggregated in the current 
       context. It must treat them as normal expressions 
       instead. Not doing that leads to incorrect data about
       the query, e.g. running a query that actually has no
       aggregate functions as if it has some (and hence is
       expected to return only one row).
       Fixed by ignoring the aggregates that are not aggregated
       in the current context. 
       One other smaller omission discovered and fixed in the 
       process : the place of aggregation was not calculated for
       user defined functions. Fixed by calling 
       Item_sum::init_sum_func_check() and 
       Item_sum::check_sum_func() as it's done for the rest of 
       the aggregate functions.
      
      
      mysql-test/r/subselect.result:
        Bug #27333: test case
      mysql-test/t/subselect.test:
        Bug #27333: test case
      sql/item_subselect.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.h:
        Bug#27333: calculate the place of 
         aggregation for user defined functions.
      sql/sql_select.cc:
        Bug#27333: When counting the aggregated functions
         and collecting a list of them we must not consider
         the aggregates that are not aggregated in the local
         context as "local" : i.e. we must treat them as 
         normal functions and not add them to the aggregate
         functions list.
      sql/sql_select.h:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      c2e961cf
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · b70c486e
      unknown authored
      into  mysql.com:/home/hf/work/29247/my51-29247
      
      
      sql-common/client.c:
        Auto merged
      sql/handler.h:
        Auto merged
      b70c486e
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 73023608
      unknown authored
      into  mysql.com:/home/hf/work/29247/my50-29247
      
      
      sql-common/client.c:
        Auto merged
      73023608
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29252/my51-29252 · 3e7f28ed
      unknown authored
      into  mysql.com:/home/hf/work/29247/my51-29247
      
      
      3e7f28ed