An error occurred fetching the project authors.
  1. 20 Nov, 2015 1 commit
  2. 25 Oct, 2015 1 commit
  3. 05 Oct, 2015 2 commits
  4. 02 Oct, 2015 1 commit
  5. 22 Sep, 2015 1 commit
  6. 12 Sep, 2015 1 commit
  7. 27 Aug, 2015 2 commits
    • Monty's avatar
      MDEV-6152: Remove calls to current_thd while creating Item · 3bca8db4
      Monty authored
      - Part 4: Removing calls to sql_alloc() and sql_calloc()
      
      Other things:
      - Added current_thd in some places to make it clear that it's called (easier to remove later)
      - Move memory allocation from Item_func_case::fix_length_and_dec() to Item_func_case::fix_fields()
      - Added mem_root to some new calls
      - Fixed some wrong UNINIT_VAR() calls
      - Fixed a bug in generate_partition_syntax() in case of errors
      - Added mem_root to argument to new thread_info
      - Simplified my_parse_error() call in sql_yacc.yy
      3bca8db4
    • Monty's avatar
      MDEV-6152: Remove calls to current_thd while creating Item · 3cb578c0
      Monty authored
      - Part 3: Adding mem_root to push_back() and push_front()
      
      Other things:
      - Added THD as an argument to some partition functions.
      - Added memory overflow checking for XML tag's in read_xml()
      3cb578c0
  8. 21 Aug, 2015 2 commits
    • Monty's avatar
      Stage 2 of MDEV-6152: · 1bae0d9e
      Monty authored
      - Added mem_root to all calls to new Item
      - Added private method operator new(size_t size) to Item to ensure that
        we always use a mem_root when creating an item.
      
      This saves use once call to current_thd per Item creation
      1bae0d9e
    • Sergey Vojtovich's avatar
      MDEV-8010 - Avoid sql_alloc() in Items (Patch #1) · 31e365ef
      Sergey Vojtovich authored
      Added mandatory thd parameter to Item (and all derivative classes) constructor.
      Added thd parameter to all routines that may create items.
      Also removed "current_thd" from Item::Item. This reduced number of
      pthread_getspecific() calls from 290 to 177 per OLTP RO transaction.
      31e365ef
  9. 18 Aug, 2015 1 commit
    • Monty's avatar
      Ensure that fields declared with NOT NULL doesn't have DEFAULT values if not... · 6b203426
      Monty authored
      Ensure that fields declared with NOT NULL doesn't have DEFAULT values if not specified and if not timestamp or auto_increment
      
      In original code, sometimes one got an automatic DEFAULT value in some cases, in other cases not.
      
      For example:
      create table t1 (a int primary key)      - No default
      create table t2 (a int, primary key(a))  - DEFAULT 0
      create table t1 SELECT ....              - Default for all fields, even if they where defined as NOT NULL
      ALTER TABLE ... MODIFY could sometimes add an unexpected DEFAULT value.
      
      The patch is quite big because we had some many test cases that used
      CREATE ... SELECT or CREATE ... (...PRIMARY KEY(xxx)) which doesn't have an automatic DEFAULT anymore.
      
      Other things:
      - Removed warnings from InnoDB when waiting from semaphore (got this when testing things with --big)
      6b203426
  10. 10 Aug, 2015 1 commit
  11. 08 Aug, 2015 1 commit
  12. 07 Aug, 2015 1 commit
  13. 26 Jul, 2015 1 commit
    • Monty's avatar
      Fixed MDEV-8428: Mangled DML statements on 2nd level slave when enabling binlog checksums · f3e578ab
      Monty authored
      Fix was to add a test in Query_log_event::Query_log_event() if we are using
      CREATE ... SELECT and in this case use trans cache, like we do on the master.
      This avoid using (with doesn't have checksum)
      
      Other things:
      - Removed dummy call my_checksum(0L, NULL, 0)
      - More DBUG_PRINT
      - Cleaned up Log_event::need_checksum() to make it more readable (similar as in MySQL 5.6)
      - Renamed variable that was hiding another one in create_table_imp()
      f3e578ab
  14. 14 Jul, 2015 1 commit
  15. 06 Jul, 2015 1 commit
    • Monty's avatar
      - Renaming variables so that they don't shadow others (After this patch one... · 7332af49
      Monty authored
      - Renaming variables so that they don't shadow others (After this patch one can compile with -Wshadow and get much fewer warnings)
      - Changed ER(ER_...) to ER_THD(thd, ER_...) when thd was known or if there was many calls to current_thd in the same function.
      - Changed ER(ER_..) to ER_THD_OR_DEFAULT(current_thd, ER...) in some places where current_thd is not necessary defined.
      - Removing calls to current_thd when we have access to thd
      
      Part of this is optimization (not calling current_thd when not needed),
      but part is bug fixing for error condition when current_thd is not defined
      (For example on startup and end of mysqld)
      
      Notable renames done as otherwise a lot of functions would have to be changed:
      - In JOIN structure renamed:
         examined_rows -> join_examined_rows
         record_count -> join_record_count
      - In Field, renamed new_field() to make_new_field()
      
      Other things:
      - Added DBUG_ASSERT(thd == tmp_thd) in Item_singlerow_subselect() just to be safe.
      - Removed old 'tab' prefix in JOIN_TAB::save_explain_data() and use members directly
      - Added 'thd' as argument to a few functions to avoid calling current_thd.
      7332af49
  16. 26 Jun, 2015 1 commit
  17. 24 Jun, 2015 1 commit
    • Debarun Banerjee's avatar
      BUG#20310212 PARTITION DDL- CRASH AFTER THD::NOCHECK_REGISTER_ITEM_ · 0eadadad
      Debarun Banerjee authored
      Problem :
      ---------
      Issue-1: The root cause for the issues is that (col1 > 1) is not a
      valid partition function and we should have thrown error at much early
      stage [partition_info::check_partition_info]. We are not checking
      sub-partition expression when partition expression is NULL.
      
      Issue-2: Potential issue for future if any partition function needs to
      change item tree during open/fix_fields. We should release changed
      items, if any, before doing closefrm when we open the partitioned table
      during creation in create_table_impl.
      
      Solution :
      ----------
      1.check_partition_info() - Check for sub-partition expression even if no
      partition expression.
      [partition by ... columns(...) subpartition by hash(<expr>)]
      
      2.create_table_impl() - Assert that the change list is empty before doing
      closefrm for partitioned table. Currently no supported partition function
      seems to be changing item tree during open.
      Reviewed-by: default avatarMattias Jonsson <mattias.jonsson@oracle.com>
      
      RB: 9345
      0eadadad
  18. 16 Jun, 2015 3 commits
    • Sergei Golubchik's avatar
      MDEV-8287 DROP TABLE suppresses all engine errors · b56ad494
      Sergei Golubchik authored
      in ha_delete_table()
      * only convert ENOENT and HA_ERR_NO_SUCH_TABLE to warnings
      * only return real error codes (that is, not ENOENT and
        not HA_ERR_NO_SUCH_TABLE)
      * intercept HA_ERR_ROW_IS_REFERENCED to generate backward
        compatible ER_ROW_IS_REFERENCED
      
      in mysql_rm_table_no_locks()
      * no special code to handle HA_ERR_ROW_IS_REFERENCED
      * no special code to handle ENOENT and HA_ERR_NO_SUCH_TABLE
      * return multi-table error ER_BAD_TABLE_ERROR <table list> only
        when there were many errors, not when there were many
        tables to drop (but only one table generated an error)
      b56ad494
    • Sergei Golubchik's avatar
      after-merge fixes · 985e430c
      Sergei Golubchik authored
      in innobase: compilation error on windows
      other changes: perfschema merge followup
      985e430c
    • Sergey Vojtovich's avatar
      MDEV-5309 - RENAME TABLE does not check for existence of the table's engine · 909f7607
      Sergey Vojtovich authored
      When RENAME TABLE is executed, it apparently does not check whether the engine
      is available (unlike ALTER TABLE .. RENAME, which does). It means that if the
      engine in question was not loaded on some reason, the table might become
      unusable, since the engine won't know about the change.
      
      With this patch RENAME TABLE fails if storage engine is not available.
      909f7607
  19. 14 Jun, 2015 1 commit
  20. 13 May, 2015 1 commit
    • Sergey Vojtovich's avatar
      MDEV-7951 - sql_alloc() takes 0.25% in OLTP RO · 4d1ccc42
      Sergey Vojtovich authored
      sql_alloc() has additional costs compared to direct mem_root allocation:
      - function call: it is defined in a separate translation unit and can't be
        inlined
      - it needs to call pthread_getspecific() to get THD::mem_root
      
      It is called dozens of times implicitely at least by:
      - List<>::push_back()
      - List<>::push_front()
      - new (for Sql_alloc derived classes)
      - sql_memdup()
      
      Replaced lots of implicit sql_alloc() calls with direct mem_root allocation,
      passing through THD pointer whenever it is needed.
      
      Number of sql_alloc() calls reduced 345 -> 41 per OLTP RO transaction.
      pthread_getspecific() overhead dropped 0.76 -> 0.59
      sql_alloc() overhed dropped 0.25 -> 0.06
      4d1ccc42
  21. 08 May, 2015 1 commit
  22. 03 May, 2015 1 commit
  23. 30 Apr, 2015 1 commit
  24. 13 Apr, 2015 2 commits
  25. 12 Apr, 2015 2 commits
  26. 10 Apr, 2015 1 commit
  27. 03 Apr, 2015 1 commit
  28. 25 Mar, 2015 1 commit
  29. 20 Mar, 2015 1 commit
  30. 13 Mar, 2015 2 commits
    • Venkatesh Duggirala's avatar
      Bug #20439913 CREATE TABLE DB.TABLE LIKE TMPTABLE IS · 59142d9a
      Venkatesh Duggirala authored
      BINLOGGED INCORRECTLY - BREAKS A SLAVE
      
      Submitted a incomplete patch with my previous push,
      re submitting the extra changes the required to make
      the patch complete.
      59142d9a
    • Venkatesh Duggirala's avatar
      Bug #20439913 CREATE TABLE DB.TABLE LIKE TMPTABLE IS BINLOGGED INCORRECTLY - BREAKS A SLAVE · 151b8ec4
      Venkatesh Duggirala authored
      Analysis:
      In row based replication, Master does not send temp table information
      to Slave. If there are any DDLs that involves in regular table that needs
      to be sent to Slave and a temp tables (which will not be available at Slave),
      the Master rewrites the query replacing temp table with it's defintion.
      Eg: create table regular_table like temptable.
      In rewrite logic, server is ignoring the database of regular table
      which can cause problems mentioned in this bug.
      
      Fix: dont ignore database information (if available) while
      rewriting the query
      151b8ec4
  31. 12 Mar, 2015 1 commit
    • Jan Lindström's avatar
      MDEV-6858: enforce_storage_engine option · 8249dcaa
      Jan Lindström authored
      Merge from Percona Server enforced use of a specific storage engine
      authored by Stewart Smith.
      
      Modified to be session variable and modifiable only by SUPER. Use
      similar implementation as default_storage_engine.
      8249dcaa
  32. 11 Mar, 2015 1 commit