1. 07 Dec, 2009 1 commit
    • Sergey Vojtovich's avatar
      WL#2511 - Add a new table to the Information Schema for TABLESPACE's · e8d01684
      Sergey Vojtovich authored
      Implemented a new INFORMATION_SCHEMA table, which is intended to
      provide information about tablespaces.
      
      mysql-test/r/information_schema.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      mysql-test/r/information_schema_db.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      mysql-test/r/mysqlshow.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      mysql-test/suite/funcs_1/r/is_columns_is.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      mysql-test/suite/funcs_1/r/is_tables_is.result:
        Updated test result according to WL#2511. With this WL
        I_S has new TABLESPACES schema.
      sql/handler.h:
        Added SCH_TABLESPACES to enum_schema_tables.
      sql/mysql_priv.h:
        Added human readable definitions for I_S.TABLESPACES field
        identifiers.
      sql/sql_show.cc:
        Added I_S.TABLESPACES schema. The code which handles I_S.FILES
        is capable to handle I_S.TABLESPACES as well. Thus we reuse
        this code and let functions/variables have more generic names.
      e8d01684
  2. 03 Dec, 2009 1 commit
    • V Narayanan's avatar
      WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table · e86daf9b
      V Narayanan authored
      The attached patch adds a method
      handlerton::fill_is_table that can be used
      instead of having to create specific
      handlerton::fill_*_table methods.
      
      sql/ha_ndbcluster.cc:
        WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table
        
        Implemented the method ndbcluster_fill_is_table
        that uses the supplied table id to switch to the
        appropriate fill_*_table method.
      sql/handler.h:
        WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table
        
        Moved the enum_schema_table enumeration
        from table.h to here. 
        
        contains the declaration for the new method
        fill_is_tables.
      sql/sql_show.cc:
        WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table
        
        calls the fill_is_table method instead of the
        fill_files_table method.
      sql/table.h:
        WL#4448 Generalize the handlerton::fill_files_table call with handlerton::fill_is_table
        
        removed the earlier definition of enum_schema_tables.
      e86daf9b
  3. 25 Nov, 2009 1 commit
    • Sergey Vojtovich's avatar
      Backport from 6.0-codebase. · 40ec012c
      Sergey Vojtovich authored
      WL#3951 - MyISAM: Additional Error Logs for Data Corruption
      
      When table corruption is detected, in addition to current error message
      provide following information:
      - list of threads (and queries) accessing a table;
      - thread_id of a thread that detected corruption;
      - source file name and line number where this corruption was detected;
      - optional extra information (string).
      
      mysql-test/r/myisam_crash_before_flush_keys.result:
        Adjusted a test case according to WL#3951.
      mysql-test/t/myisam_crash_before_flush_keys.test:
        Adjusted a test case according to WL#3951.
      storage/myisam/CMakeLists.txt:
        Added mi_extrafunc.h to myisam sources list.
      storage/myisam/Makefile.am:
        Added mi_extrafunc.h to myisam headers list.
      storage/myisam/ha_myisam.cc:
        Added _mi_report_crashed() function (reports additional information
        whenever table corruption is detected).
      storage/myisam/mi_extrafunc.h:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisam/mi_locking.c:
        For every call to mi_lock_database(F_[RD|WR|EXTRA_]LCK) - add
        current thread to the list of threads accessing this table.
        
        For every call to mi_lock_database(F_UNLCK) - remove current
        thread from the list of threads accessing this table.
      storage/myisam/mi_test1.c:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisam/mi_test2.c:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisam/mi_test3.c:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisam/myisam_ftdump.c:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisam/myisamchk.c:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisam/myisamdef.h:
        Extra elements are added to MI_INFO and MYISAM_SHARE structures.
        MI_INFO is extended with LIST element, that holds a pointer to
        THD object accessing a table. MYISAM_SHARE is extended with LIST
        (list of threads accessing a table).
        
        Whenever table is marked as crashed, call mi_report_crashed() macro
        to provide useful information.
      storage/myisam/myisamlog.c:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisam/myisampack.c:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisam/rt_test.c:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisam/sp_test.c:
        All standalone programs must define their version of _mi_report_crashed()
        by including mi_extrafunc.h.
      storage/myisammrg/ha_myisammrg.cc:
        For each unedrlying table initialize `in_use' variable.
      40ec012c
  4. 23 Nov, 2009 1 commit
  5. 20 Nov, 2009 1 commit
  6. 19 Nov, 2009 1 commit
  7. 18 Nov, 2009 4 commits
  8. 16 Nov, 2009 2 commits
  9. 13 Nov, 2009 1 commit
    • Davi Arnaut's avatar
      Post-merge fixes for backports. · 5128b54c
      Davi Arnaut authored
      mysql-test/r/sp-error.result:
        Update test case result.
      mysql-test/t/dirty_close.test:
        Dirty close does not work under embedded.
      mysql-test/t/sp-error.test:
        Use the specific error number so it won't catch
        other non-fatal errors.
      5128b54c
  10. 12 Nov, 2009 6 commits
  11. 11 Nov, 2009 10 commits
  12. 10 Nov, 2009 11 commits
    • Alexey Botchkov's avatar
      Bug #47139 Test "merge" crashes in "embedded" run · c868e89f
      Alexey Botchkov authored
        In fact this crashes in normal (not embedded) run also.
        The problem is in the memory mapping. Handling the ha_myisammrg::extra(MMAP)
        the MERGE engine tries to mmap all the tables it unites.
        Though some can be empty and then in the mi_dynmap_file()
        we call the my_mmap(0). Normally this call returns MAP_FAILED,
        but not on FreeBSD. There it returns like a 'normal' value,
        and after the consequitive munmap systems gets unstable and
        crashes on some system call later.
      
      per-file comments:
        storage/myisam/mi_dynrec.c
      Bug #47139      Test "merge" crashes in "embedded" run
          don't try to mmap zero-length area, just return at once.
      c868e89f
    • Alexey Botchkov's avatar
      Bug#42520 killing load .. infile Assertion failed: ! is_set(), file .\sql_error.cc, line 8 · 6388a132
      Alexey Botchkov authored
         The additional patch. That 'loadxml.test' failure was actually about our testing system,
         not the code.
         Firstly we need a new mysqltest command, wich i called 'send_eval'. So the expression
         can be evaluated, then started in a parallel thread. We only have separane 'send' and
         'eval' commands at the moment.
         Then we need to add the waiting code after the 'KILL' to our test, so the thread will be killed
         before the test goes further. The present 'reap' command doesn't handle the killed threads
         well.
            
      per-file comments:
        client/mysqltest.cc
      Bug#42520      killing load .. infile Assertion failed: ! is_set(), file .\sql_error.cc, line 8
          The 'send_eval' command implemented.
      
        mysql-test/r/loadxml.result
      Bug#42520      killing load .. infile Assertion failed: ! is_set(), file .\sql_error.cc, line 8
         test result updated.
      
        mysql-test/t/loadxml.test
      Bug#42520      killing load .. infile Assertion failed: ! is_set(), file .\sql_error.cc, line 8
         test case added.
      6388a132
    • Davi Arnaut's avatar
      Backport of Bug#45767 to mysql-next-mr · 891dffa3
      Davi Arnaut authored
      ------------------------------------------------------------
      revno: 3405
      revision-id: davi.arnaut@sun.com-20090626124624-m4wolyo5193j4cu7
      parent: luis.soares@sun.com-20090626113019-1j4mn1jos480u9f3
      committer: Davi Arnaut <Davi.Arnaut@Sun.COM>
      branch nick: mysql-pe
      timestamp: Fri 2009-06-26 09:46:24 -0300
      message:
        Bug#45767: deprecate/remove Field::pack_key, Field::unpack_key, Field::pack_cmp
        
        Remove unused and dead code.
        
        Parts of the patch contributed by Zardosht Kasheff
      891dffa3
    • Davi Arnaut's avatar
      Backport of Bug#27249 to mysql-next-mr · ff847056
      Davi Arnaut authored
      ------------------------------------------------------------
      revno: 2476.784.4
      revision-id: sp1r-davi@moksha.local-20071008114751-46069
      parent: sp1r-davi@moksha.local-20071003002731-48537
      committer: davi@moksha.local
      timestamp: Mon 2007-10-08 08:47:51 -0300
      message:
        Bug#27249 table_wild with alias: select t1.* as something
      
        Aliases to table wildcards are silently ignored, but they should
        not be allowed as it is non-standard and currently useless. There
        is not point in having a alias to a wildcard of column names.
      
        The solution is to rewrite the select_item rule so that aliases
        for table wildcards are not accepted.
      
        Contribution by Martin Friebe
      
      mysql-test/r/alias.result:
        Add test case result for Bug#27249
      mysql-test/t/alias.test:
        Add test case for Bug#27249
      sql/sql_yacc.yy:
        Split up select_item rule so that aliases for table wildcards
        are not accepted by the parser.
      ff847056
    • Davi Arnaut's avatar
      Backport of Bug#15192 to mysql-next-mr · e879919a
      Davi Arnaut authored
      ------------------------------------------------------------
      revno: 2597.4.17
      revision-id: sp1r-davi@mysql.com/endora.local-20080328174753-24337
      parent: sp1r-anozdrin/alik@quad.opbmk-20080328140038-16479
      committer: davi@mysql.com/endora.local
      timestamp: Fri 2008-03-28 14:47:53 -0300
      message:
        Bug#15192 "fatal errors" are caught by handlers in stored procedures
      
        The problem is that fatal errors (e.g.: out of memory) were being
        caught by stored procedure exception handlers which could cause
        the execution to not be stopped due to a continue handler.
      
        The solution is to not call any exception handler if the error is
        fatal and send the fatal error to the client.
      
      mysql-test/r/sp-error.result:
        Add test case result for Bug#15192
      mysql-test/t/sp-error.test:
        Add test case for Bug#15192
      mysys/my_alloc.c:
        Pass flag to signal fatal error in memory root allocations.
      sql/event_data_objects.cc:
        Use init_sql_alloc to initialize memory roots, which uses
        the sql error handler to push errors.
      sql/ha_partition.cc:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/item_func.cc:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/item_subselect.cc:
        Remove redundant fatal error, memory root already pushes error.
      sql/opt_sum.cc:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/sp_head.cc:
        Allocator already sets fatal error.
      sql/sql_class.h:
        A error must exist for it to be fatal. Pass flag to signal fatal
        error instead of calling fatal_error.
      sql/sql_insert.cc:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/sql_list.h:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/sql_parse.cc:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/sql_partition.cc:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/sql_select.cc:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/sql_servers.cc:
        Use init_sql_alloc to initialize memory roots, which uses
        the sql error handler to push errors.
      sql/sql_show.cc:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/sql_trigger.cc:
        Use init_sql_alloc to initialize memory roots, which uses
        the sql error handler to push errors.
      sql/sql_update.cc:
        Pass flag to signal fatal error instead of calling fatal_error.
      sql/tztime.cc:
        Use init_sql_alloc to initialize memory roots, which uses
        the sql error handler to push errors.
      e879919a
    • Davi Arnaut's avatar
      Backport of Bug#41860 to mysql-next-mr · 17871ade
      Davi Arnaut authored
      ------------------------------------------------------------
      revno: 3317
      revision-id: davi.arnaut@sun.com-20090522170916-fzc5ca3tjs9roy1t
      parent: patrick.crews@sun.com-20090522152933-ole8s3suy4zqyvku
      committer: Davi Arnaut <Davi.Arnaut@Sun.COM>
      branch nick: 41860-6.0
      timestamp: Fri 2009-05-22 14:09:16 -0300
      message:
        Bug#41860: Without Windows named pipe
      
        The problem was that the patch for Bug#10374 broke named pipe
        and shared memory transports on Windows due to a failure to
        implement a dummy poll method for transports other than BSD
        sockets. Another problem was that mysqltest lacked support
        for named pipe and shared memory connections, which lead to
        misleading test cases that were supposed run common queries
        over both transports.
      
        The solution is to properly implement, at the VIO layer, the
        poll and is_connected methods. The is_connected method is
        implemented for every suppported transport and the poll one
        only where it makes sense. Furthermore, support for named pipe
        and shared memory connections is added to mysqltest as to
        enable testing of both transports using the test suite.
      
      client/mysqltest.cc:
        Add support for named pipe and shared memory connections.
      include/violite.h:
        Move private functions to vio/vio_priv.h
        Add poll_read and is_connected methods.
      mysql-test/t/named_pipe.test:
        Run tests over a named pipe connection.
      mysql-test/t/shm.test:
        Run tests over a shared memory connection.
      sql/item_func.cc:
        Rename method.
      sql/sql_class.cc:
        Remove higher-level vio_is_connected implementation.
      sql/sql_class.h:
        Rename vio_is_connected to not conflict with the vio one.
        Verify that there is a valid vio.
      vio/vio.c:
        Add poll_read and is_connected methods.
      vio/vio_priv.h:
        Add private functions.
      vio/viosocket.c:
        Implement the is_connected method for the various transports.
      17871ade
    • Davi Arnaut's avatar
      Backport of Bug#10374 to mysql-next-mr · 80582b00
      Davi Arnaut authored
      ------------------------------------------------------------
      revno: 2597.37.3
      revision-id: sp1r-davi@mysql.com/endora.local-20080328123626-16430
      parent: sp1r-anozdrin/alik@quad.opbmk-20080327125300-11290
      committer: davi@mysql.com/endora.local
      timestamp: Fri 2008-03-28 09:36:26 -0300
      message:
        Bug#10374 GET_LOCK does not let connection to close on the server side if it's aborted
      
        The problem is that the server doesn't detect aborted connections which
        are waiting on a lock or sleeping (user sleep), wasting system resources
        for a connection that is already dead.
      
        The solution is to peek at the connection every five seconds to verify if
        the connection is not aborted. A aborted connection is detect by polling
        the connection socket for available data to be read or end of file and in
        case of eof, the wait is aborted and the connection killed.
      
      include/violite.h:
        Export vio_peek_read function.
      mysql-test/r/dirty_close.result:
        Add test case result for Bug#10374
      mysql-test/t/dirty_close.test:
        Add test case for Bug#10374
      sql/item_func.cc:
        While waiting for a condition to be signaled, check if the connection
        is not broken every INTERRUPT_INTERVAL seconds.
      sql/sql_class.cc:
        Add function which checks if the client connection was aborted.
      sql/sql_class.h:
        Add function prototype.
      vio/viosocket.c:
        Add poll and peek functions for Windows and Unix.
      80582b00
    • Davi Arnaut's avatar
      Backport of Bug#27525 to mysql-next-mr · e26de1ca
      Davi Arnaut authored
      ------------------------------------------------------------
      revno: 2572.2.1
      revision-id: sp1r-davi@mysql.com/endora.local-20080227225948-16317
      parent: sp1r-anozdrin/alik@quad.-20080226165712-10409
      committer: davi@mysql.com/endora.local
      timestamp: Wed 2008-02-27 19:59:48 -0300
      message:
        Bug#27525 table not found when using multi-table-deletes with aliases over several databas
        Bug#30234 Unexpected behavior using DELETE with AS and USING
      
        The multi-delete statement has a documented limitation that
        cross-database multiple-table deletes using aliases are not
        supported because it fails to find the tables by alias if it
        belongs to a different database. The problem is that when
        building the list of tables to delete from, if a database
        name is not specified (maybe an alias) it defaults to the
        name of the current selected database, making impossible to
        to properly resolve tables by alias later. Another problem
        is a inconsistency of the multiple table delete syntax that
        permits ambiguities in a delete statement (aliases that refer
        to multiple different tables or vice-versa).
      
        The first step for a solution and proper implementation of
        the cross-databse multiple table delete is to get rid of any
        ambiguities in a multiple table statement. Currently, the parser
        is accepting multiple table delete statements that have no obvious
        meaning, such as:
      
        DELETE a1 FROM db1.t1 AS a1, db2.t2 AS a1;
        DELETE a1 AS a1 FROM db1.t1 AS a1, db2.t2 AS a1;
      
        The solution is to resolve the left part of a delete statement
        using the right part, if the a table on right has an alias,
        it must be referenced in the left using the given alias. Also,
        each table on the left side must match unambiguously only one
        table in the right side.
      
      mysql-test/r/delete.result:
        Add test case result for Bug#27525 and Bug#21148
      mysql-test/r/derived.result:
        Update error.
      mysql-test/suite/rpl/r/rpl_multi_delete2.result:
        Update syntax.
      mysql-test/suite/rpl/t/rpl_multi_delete2.test:
        Update syntax.
      mysql-test/t/delete.test:
        Add test case for Bug#27525 and Bug#21148
      mysql-test/t/derived.test:
        Update statement error, alias is properly resolved now.
      sql/sql_parse.cc:
        Implement new algorithm for the resolution of alias in
        a multiple table delete statement.
      sql/sql_yacc.yy:
        Rework multi-delete parser rules to not accept table alias
        for the table source list.
      sql/table.h:
        Add flag to signal that the table has a alias set or
        that fully qualified table name was given.
      e26de1ca
    • Davi Arnaut's avatar
      Backport of Bug#37843 to mysql-next-mr · c809048c
      Davi Arnaut authored
      sql/sql_cache.cc:
        Swap return value description.
      c809048c
    • Davi Arnaut's avatar
      Backport of Bug#36785 to mysql-next-mr · 4297dcaa
      Davi Arnaut authored
      ------------------------------------------------------------
      revno: 2630.2.13
      revision-id: davi@mysql.com-20080612190452-cx6h7rm557bcq7sa
      parent: davi@mysql.com-20080611124915-csejwrxfdga9upho
      committer: Davi Arnaut <davi@mysql.com>
      branch nick: 36785-6.0
      timestamp: Thu 2008-06-12 16:04:52 -0300
      message:
        Bug#36785: Wrong error message when group_concat() exceeds max length
      
        The problem is that when ER_CUT_VALUE_GROUP_CONCAT is elevated
        to a error, the message does not get updated with the number of
        cut lines when group_concat() exceeds max length.
      
        The solution is to modify the warning message to be more meaningful
        by giving the number of the line that was cut and to issue the warning
        for each line that is cut. This approach is inline with how other
        per-row truncated data warnings are issued avoids violating the warning
        internal interface.
      
      mysql-test/suite/sys_vars/r/group_concat_max_len_func.result:
        Update result to reflect the new warning message
      sql/share/errmsg.txt:
        Update warning message ER_CUT_VALUE_GROUP_CONCAT.
      4297dcaa
    • Davi Arnaut's avatar
      Backport of Bug#32140 to mysql-next-mr · c34c6665
      Davi Arnaut authored
      ------------------------------------------------------------
      revno: 2618
      revision-id: sp1r-davi@mysql.com/endora.local-20080418131946-26951
      parent: sp1r-davi@mysql.com/endora.local-20080417190810-26185
      committer: davi@mysql.com/endora.local
      timestamp: Fri 2008-04-18 10:19:46 -0300
      message:
        Bug#32140: wrong error code caught when an SF() call is interruped with KILL query
      
        The problem is that killing a query which calls a stored function
        could return a wrong error (table corrupt) instead of the query
        interrupted error message.
      
        The solution is to not set the table corrupt error if the query
        is killed, the query interrupted error message will be set  later
        when the query is finished.
      
      sql/sp.cc:
        Don't set a error if the thread was killed, the query
        interrupted error will be set later.
      c34c6665