1. 16 May, 2007 1 commit
  2. 15 May, 2007 3 commits
  3. 14 May, 2007 4 commits
  4. 12 May, 2007 2 commits
    • ibabaev@bk-internal.mysql.com's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0 · 7d006ee5
      ibabaev@bk-internal.mysql.com authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.0-opt
      7d006ee5
    • igor@olga.mysql.com's avatar
      Fixed bug #28375: a query with an NOT IN subquery predicate may cause · 11d5f7ee
      igor@olga.mysql.com authored
      a crash when the left operand of the predicate is evaluated to NULL.
      It happens when the rows from the inner tables (tables from the subquery)
      are accessed by index methods with key values obtained by evaluation of
      the left operand of the subquery predicate. When this predicate is
      evaluated to NULL an alternative access with full table scan is used
      to check whether the result set returned by the subquery is empty or not.
      The crash was due to the fact the info about the access methods used for
      regular key values was not properly restored after a switch back from the
      full scan access method had occurred.
      The patch restores this info properly.
      The same problem existed for queries with IN subquery predicates if they
      were used not at the top level of the queries.
      11d5f7ee
  5. 11 May, 2007 12 commits
    • evgen@moonbone.local's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e3bd20b6
      evgen@moonbone.local authored
      into  moonbone.local:/mnt/gentoo64/work/27878-bug-5.0-opt-mysql
      e3bd20b6
    • evgen@moonbone.local's avatar
      grant.result, grant.test: · 6c8f5476
      evgen@moonbone.local authored
        Corrected test case for the bug#27878.
      6c8f5476
    • dlenev@mockturtle.local's avatar
    • holyfoot/hf@mysql.com/hfmain.(none)'s avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 6fe0f52d
      holyfoot/hf@mysql.com/hfmain.(none) authored
      into  mysql.com:/home/hf/work/27957/my50-27957
      6fe0f52d
    • evgen@moonbone.local's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 9a427d8d
      evgen@moonbone.local authored
      into  moonbone.local:/mnt/gentoo64/work/27878-bug-5.0-opt-mysql
      9a427d8d
    • evgen@moonbone.local's avatar
      Bug#27878: Unchecked privileges on a view referring to a table from another · 34f47812
      evgen@moonbone.local authored
      database.
      
      If a user has a right to update anything in the current database then the 
      access was granted and further checks of access rights for underlying tables
      wasn't done correctly. The check is done before a view is opened and thus no
      check of access rights for underlying tables can be carried out.
      This allows a user to update through a view a table from another database for
      which he hasn't enough rights.
      
      Now the mysql_update() and the mysql_test_update() functions are forces
      re-checking of access rights after a view is opened.
      34f47812
    • dlenev@mockturtle.local's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · d5dbdd98
      dlenev@mockturtle.local authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.0-cts-3
      d5dbdd98
    • dlenev@mockturtle.local's avatar
      Fix for: · 8b93e52e
      dlenev@mockturtle.local authored
        Bug #20662 "Infinite loop in CREATE TABLE IF NOT EXISTS ... SELECT
                    with locked tables"
        Bug #20903 "Crash when using CREATE TABLE .. SELECT and triggers"
        Bug #24738 "CREATE TABLE ... SELECT is not isolated properly"
        Bug #24508 "Inconsistent results of CREATE TABLE ... SELECT when
                    temporary table exists"
       
      Deadlock occured when one tried to execute CREATE TABLE IF NOT
      EXISTS ... SELECT statement under LOCK TABLES which held
      read lock on target table.
      Attempt to execute the same statement for already existing
      target table with triggers caused server crashes.
      Also concurrent execution of CREATE TABLE ... SELECT statement
      and other statements involving target table suffered from
      various races (some of which might've led to deadlocks).
      Finally, attempt to execute CREATE TABLE ... SELECT in case
      when a temporary table with same name was already present
      led to the insertion of data into this temporary table and
      creation of empty non-temporary table.
       
      All above problems stemmed from the old implementation of CREATE
      TABLE ... SELECT in which we created, opened and locked target
      table without any special protection in a separate step and not
      with the rest of tables used by this statement.
      This underminded deadlock-avoidance approach used in server
      and created window for races. It also excluded target table
      from prelocking causing problems with trigger execution.
        
      The patch solves these problems by implementing new approach to
      handling of CREATE TABLE ... SELECT for base tables.
      We try to open and lock table to be created at the same time as
      the rest of tables used by this statement. If such table does not
      exist at this moment we create and place in the table cache special
      placeholder for it which prevents its creation or any other usage
      by other threads.
      
      We still use old approach for creation of temporary tables.
      
      Also note that we decided to postpone introduction of some tests
      for concurrent behaviour of CREATE TABLE ... SELECT till 5.1.
      The main reason for this is absence in 5.0 ability to set @@debug
      variable at runtime, which can be circumvented only by using several
      test files with individual .opt files. Since the latter is likely
      to slowdown test-suite unnecessary we chose not to push this tests
      into 5.0, but run them manually for this version and later push
      their optimized version into 5.1
      8b93e52e
    • holyfoot/hf@mysql.com/hfmain.(none)'s avatar
      merging fixes · 17265468
      holyfoot/hf@mysql.com/hfmain.(none) authored
      17265468
    • kostja@vajra.(none)'s avatar
      Cleanup: now that we have Lex_input_stream, finish the transition · ad609d6e
      kostja@vajra.(none) authored
      by moving yet another relevant flag to it from struct LEX.
      ad609d6e
    • holyfoot/hf@mysql.com/hfmain.(none)'s avatar
      Merge mysql.com:/home/hf/work/27921/my50-27921 · 069314ea
      holyfoot/hf@mysql.com/hfmain.(none) authored
      into  mysql.com:/home/hf/work/27957/my50-27957
      069314ea
    • holyfoot/hf@mysql.com/hfmain.(none)'s avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 8df08a2d
      holyfoot/hf@mysql.com/hfmain.(none) authored
      into  mysql.com:/home/hf/work/27957/my50-27957
      8df08a2d
  6. 10 May, 2007 10 commits
  7. 09 May, 2007 6 commits
  8. 08 May, 2007 2 commits
    • evgen@moonbone.local's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · b45ef06e
      evgen@moonbone.local authored
      into  moonbone.local:/mnt/gentoo64/work/27670-bug-5.0-opt-mysql
      b45ef06e
    • evgen@moonbone.local's avatar
      Bug#27670: LOAD DATA does not set CURRENT_TIMESTAMP default value for a · 98fa542a
      evgen@moonbone.local authored
      TIMESTAMP field when no value has been provided.
      
      The LOAD DATA sets the current time in the TIMESTAMP field with
      CURRENT_TIMESTAMP default value when the field is detected as a null.
      But when the LOAD DATA command loads data from a file that doesn't contain
      enough data for all fields then the rest of fields are simply set to null
      without any check. This leads to no value being inserted to such TIMESTAMP
      field.
      
      Now the read_sep_field() and the read_fixed_length() functions set current
      time to the TIMESTAMP field with CURRENT_TIMESTAMP default value in all cases
      when a NULL value is loaded to the field.
      98fa542a