An error occurred fetching the project authors.
  1. 10 Feb, 2006 1 commit
    • unknown's avatar
      Bug#14013 mysql_stmt_store_result() bombs if a cursor is open · 101e618f
      unknown authored
       - Add code to 'mysql_stmt_store_result' to allow it to be called on 
         a prepared statement with open server side cursor.
       - Add tests to mysql_client_test that uses 'mysql_stmt_store_result'
      
      
      client/mysqltest.c:
        Enable cursor protocol(remove the ifdef BUG14013_FIXED)
        When running in cursor mode, the warnings from execute needs 
        to be extracted after mysql_stmt_execute, put them in a dynamic string 
        for later use.
        Untabify some tabs.
      libmysql/libmysql.c:
        Allow 'mysql_stmt_store_result' to be called on a statement with an open server side cursor.
        Detect that a server side cursor is open and send a "fetch" to ask for all rows to be sent to the client.
        Read all binary rows as normal store.
        Check that server said last row was sent after all binary rows has been sent.
      tests/mysql_client_test.c:
        Update 'fetch_n' function to take parameter indicating if 'mysql_stmt_store_result' should be used on the statement.
        Call fetch_n with parameter set to use 'mysql_stmt_store_result'
      101e618f
  2. 01 Feb, 2006 1 commit
    • unknown's avatar
      fix for bug #12744 (MYSQL_STMT operations cause seg fault after connection reset) · 1e686ae7
      unknown authored
      libmysql/libmysql.c:
        stmt->mysql could be 0x0 if the connection has failed between prepare and execute
        or any other operation. thus if the user decides to use mysql_stmt_reset()
        we should not segfault.
      tests/mysql_client_test.c:
        test for bug #12744 (MYSQL_STMT operations cause seg fault after connection reset)
      1e686ae7
  3. 17 Jan, 2006 1 commit
  4. 03 Jan, 2006 1 commit
    • unknown's avatar
      many warnings (practically safe but annoying) corrected · 307c0b77
      unknown authored
      client/mysqladmin.cc:
        don't use the handler after it's closed
      client/mysqlbinlog.cc:
        memory leak
      client/mysqldump.c:
        many "ignore return value" warnings, one "NULL dereference"
      cmd-line-utils/libedit/history.c:
        memory leak
      include/my_base.h:
        cleanup
      libmysql/libmysql.c:
        "return value ignored" warning
      myisam/mi_delete.c:
        "return value ignored" warning
      myisam/myisampack.c:
        "out-of-bound access" warning
      myisam/sort.c:
        "double free" warning
      mysys/default_modify.c:
        "double free" warning
      mysys/mf_iocache2.c:
        "return value ignored" warnings
      mysys/my_bitmap.c:
        s/return/DBUG_RETURN/
      mysys/my_error.c:
        memory leak
      server-tools/instance-manager/parse.cc:
        "NULL dereference" warning
      sql-common/client.c:
        "NULL dereference" warning
      sql/field.cc:
        deadcode, "NULL dereference", "uninitialized" warnings
      sql/field.h:
        unused parameters removed from constructor
      sql/ha_myisam.cc:
        "return value ignored" warnings
      sql/item.cc:
        "return value ignored" warnings
        changed constructor
      sql/item_func.cc:
        "return value ignored" warnings
      sql/log_event.cc:
        uninitialized warning
      sql/opt_range.cc:
        "double free" and uninitialized warnings
      sql/opt_range.h:
        "return value ignored" warning
      sql/repl_failsafe.cc:
        "return value ignored" warning
      sql/set_var.cc:
        "return value ignored" warning
      sql/slave.cc:
        "return value ignored" warnings
      sql/slave.h:
        new prototype
      sql/sql_acl.cc:
        deadcode and "NULL dereference" warnings
      sql/sql_db.cc:
        "return value ignored" warning
      sql/sql_handler.cc:
        "NULL dereference" warning
      sql/sql_help.cc:
        "NULL dereference" warning
      sql/sql_insert.cc:
        "return value ignored" warning
      sql/sql_parse.cc:
        "return value ignored" warning
        one more DBUG_ASSERT
      sql/sql_repl.cc:
        "return value ignored" and memory leak warnings
      sql/sql_show.cc:
        "return value ignored" and "NULL dereference"  warnings
      sql/sql_test.cc:
        "return value ignored" warning
      sql/table.cc:
        memory leak
      sql/uniques.cc:
        "return value ignored" warning
        endspaces deleted
      307c0b77
  5. 04 Aug, 2005 1 commit
  6. 28 Jul, 2005 1 commit
    • unknown's avatar
      Cleanups during review of new code · 79f75d8f
      unknown authored
      Ensure mysql_close() is called if mysql_set_character_set() fails
      
      
      libmysql/libmysql.c:
        Indentation cleanup
      mysql-test/r/select.result:
        Fix bad merge & align code with 4.1
      mysql-test/r/type_newdecimal.result:
        Added test of extreme case
      mysql-test/t/select.test:
        Fix bad merge & align code with 4.1
      mysql-test/t/type_newdecimal.test:
        Added test of extreme case
      mysys/charset.c:
        Removed not used variable
      mysys/default.c:
        Simplify code
      sql-common/client.c:
        Ensure mysql_close() is called if mysql_set_character_set() fails
      sql/log.cc:
        strmov(strmov())  -> strxmov()
      sql/sp.cc:
        Indentation fixes
      sql/sql_acl.cc:
        Indentation fixes
      sql/sql_base.cc:
        Added commments
        Moved variable to inner block
      sql/sql_show.cc:
        Simple optimization (removed loop variable)
      sql/sql_trigger.cc:
        strmov(strmov())  -> strxmov()
      strings/decimal.c:
        Indentation fixes
      79f75d8f
  7. 19 Jul, 2005 1 commit
  8. 18 Jul, 2005 1 commit
    • unknown's avatar
      Fix number to date conversion so it always honors the NO_ZERO_DATE, · 5958f22a
      unknown authored
      NO_ZERO_IN_DATE, and INVALID_DATES bits of SQL_MODE. (Bug #5906)
      
      
      include/my_time.h:
        Pass flags to number_to_datetime() so it can check things
        like NO_ZERO_DATE.
      libmysql/libmysql.c:
        Enable fuzzy date handling when converting strings and numbers
        to datetime fields.
      mysql-test/r/ps_2myisam.result:
        Update results
      mysql-test/r/ps_3innodb.result:
        Update results
      mysql-test/r/ps_4heap.result:
        Update results
      mysql-test/r/ps_5merge.result:
        Update results
      mysql-test/r/ps_6bdb.result:
        Update results
      mysql-test/r/ps_7ndb.result:
        Update results
      mysql-test/r/strict.result:
        Update results
      mysql-test/r/timezone2.result:
        Update results
      mysql-test/r/type_datetime.result:
        Update results
      mysql-test/t/strict.test:
        Add new regression test
      mysql-test/t/timezone2.test:
        Add new test of timestamp values in DST gap
      sql-common/my_time.c:
        Expand check_date() to check NO_ZERO_DATE and NO_ZERO_IN_DATE, and
        use it from number_to_datetime() as well as str_to_datetime(). Also,
        make number_to_datetime() return -1 on error so we can distinguish
        between a violation of NO_ZERO_DATE and other errors.
      sql/field.cc:
        Update conversion of numbers to date, datetime, and timestamp to
        use number_to_datetime() and report errors and warnings correctly
        and consistently.
      5958f22a
  9. 16 Jul, 2005 1 commit
    • unknown's avatar
      Restore previous used client charset in mysql_reconnect · 90002cdc
      unknown authored
      Moved mysql_set_character_set function to client.c
      Changed function prototype for mysql_set_character_set (as suggested
      by Konstantin)
      
      
      include/mysql.h:
        Changed function prototype
      libmysql/libmysql.c:
        moved mysql_set_character_set to client.c
      sql-common/client.c:
        moved mysql_set_character_set to client.c
      90002cdc
  10. 15 Jul, 2005 1 commit
    • unknown's avatar
      Fix for bug #11037. · 6fcb9c8e
      unknown authored
      When all rows are fetched subsequent calls to mysql_stmt_fetch return
      now MYSQL_NO_DATA instead of errorcode 1.
      
      
      libmysql/libmysql.c:
        fix for bug#11037
      tests/mysql_client_test.c:
        added new testcase for bug #11037
      6fcb9c8e
  11. 14 Jul, 2005 2 commits
    • unknown's avatar
      A fix and a test case for Bug#11183 "mysql_stmt_reset() doesn't reset · bd44c99b
      unknown authored
      information about error".
      
      
      libmysql/libmysql.c:
        Clear the last error on the statement if mysql_stmt_reset succeeded.
      tests/mysql_client_test.c:
        A test case for Bug#11183 "mysql_stmt_reset() doesn't reset information 
        about error"
      bd44c99b
    • unknown's avatar
      Implement MarkM optimization request to avoid redundnat packet exchange · fd9f67f8
      unknown authored
      in cursors.
      
      
      libmysql/libmysql.c:
        - reset_stmt_handle(): don't reset the server side just because we have 
          an open cursor: the server will close the cursor automatically if 
          needed
      sql/sql_prepare.cc:
        - implement Prepared_statement::close_cursor,
        - implicitly close an open cursor in mysql_stmt_execute instead of 
          issuing an error (to reduce the need to explicitly close cursors
          and save network bandwidth).
        - cleanup
      sql/sql_select.cc:
        Remove a destructor: cursor destruction can not be done by simply
        calling a destructor, because of cross-references between cursor
        and statement memory.
      sql/sql_select.h:
        - add an empty Cursor destructor
      tests/mysql_client_test.c:
        - remove a test for dropped functionality
      fd9f67f8
  12. 12 Jul, 2005 2 commits
    • unknown's avatar
    • unknown's avatar
      New attempt after Bar's review · c5e573da
      unknown authored
      Added api function mysql_get_character_set_info which provides
      information about the current client character set.
      
      
      include/mysql.h:
        Added api function mysql_get_character_set_info which provides
        information about the current client character set.
      libmysql/libmysql.c:
        Added api function mysql_get_character_set_info which provides
        information about the current client character set.
      libmysql/libmysql.def:
        Added api function mysql_get_character_set_info which provides
        information about the current client character set.
      tests/mysql_client_test.c:
        Added api function mysql_get_character_set_info which provides
        information about the current client character set.
      c5e573da
  13. 30 Jun, 2005 1 commit
    • unknown's avatar
      A fix and a test case for Bug#10794 "mysql_stmt_attr_set no · ec9ac3fe
      unknown authored
      open cursor after mysql_stmt_execute" + post-review fixes.
      The bug was caused by wrong flags in stmt->server_status on the client
      side: if there was no cursor, the server didn't send server_status
      flags to the client, and the old flags were used to set up the
      fetch function of a statement. Consequently, stmt_read_row_from_cursor was
      used when there was no cursor. The fix fixes the server to always
      send server flags to the client.
      
      
      include/mysql_com.h:
        Update stale comments.
      libmysql/libmysql.c:
        Remove an extra assignment.
      libmysqld/lib_sql.cc:
        Update to correspond to the changed signature of send_eof
      sql/protocol.cc:
        Actual fix for bug#10794: create a function that writes the eof
        packet to network and use it from send_fields. We need to send
        a full eof packet from send_fields to inform the client about
        the cursor status (that there is no cursor in this case).
      sql/protocol.h:
        Remove an unused parameter for send_eof.
      tests/mysql_client_test.c:
        A test case for Bug#10794 "mysql_stmt_attr_set no open cursor 
        after mysql_stmt_execute"
      ec9ac3fe
  14. 24 Jun, 2005 1 commit
    • unknown's avatar
      Make status of NO_BACKSLASH_ESCAPES mode known to the client so · 86d8abdb
      unknown authored
      it can use it to switch to only quoting apostrophes by doubling
      them when it is in effect. (Bug #10214)
      
      
      include/my_sys.h:
        Add new escape_quotes_for_mysql() function
      include/mysql_com.h:
        Add SERVER_STATUS_NO_BACKSLASH_ESCAPES
      libmysql/libmysql.c:
        Use SERVER_STATUS_NO_BACKSLASH_ESCAPES in server_status to determine
        how mysql_real_escape_string() should do quoting.
      mysys/charset.c:
        Add new escape_quotes_for_mysql() function that only quotes
        apostrophes by doubling them up.
      sql/set_var.cc:
        Set SERVER_STATUS_NO_BACKSLASH_ESCAPES when MODE_NO_BACKSLASH_ESCAPES
        changes.
      sql/sql_class.cc:
        Set SERVER_STATUS_NO_BACKSLASH_ESCAPES when necessary on thread creation.
      tests/mysql_client_test.c:
        Add new test for sending NO_BACKSLASH_ESCAPES as part of server_status.
      86d8abdb
  15. 17 Jun, 2005 1 commit
    • unknown's avatar
      Rename all prepared statements COM_ commands to prefix with COM_STMT_ · 63c21c07
      unknown authored
      libmysql/libmysql.c:
        Rename.
      libmysqld/lib_sql.cc:
        Rename.
      sql/item_cmpfunc.cc:
        Use proper method to check for stmt prepare, only_prepare is removed.
      sql/mysql_priv.h:
        Remove an obsolete define. Rename mysql_stmt_free to mysql_stmt_close.
      sql/sql_class.h:
        Remove THD::only_prepare.
        Rename.
      sql/sql_lex.cc:
        Rename COM_PREPARE -> COM_STMT_PREPARE
      sql/sql_parse.cc:
        Rename.
      sql/sql_prepare.cc:
        Rename.
      sql/sql_yacc.yy:
        Rename.
      tests/mysql_client_test.c:
        Rename.
      63c21c07
  16. 05 Jun, 2005 1 commit
    • unknown's avatar
      Cleanup during review · b08b3a15
      unknown authored
      Simple optimization for 2 argument usage to function of variable arguments
      Fix stack overrun when using 1+1+1+1+1+1+1+....
      Update crash-me results for 5.0
      Don't call post_open if pre_open() fails (optimization)
      
      
      
      sql-bench/limits/mysql-4.1.cfg:
        Rename: sql-bench/limits/mysql.cfg -> sql-bench/limits/mysql-4.1.cfg
      libmysql/libmysql.c:
        More portable define
      mysql-test/mysql-test-run.sh:
        Write also InnoDB warnings to warnings.log
      mysql-test/t/type_newdecimal.test:
        Don't get errors if innodb is not defined
      mysys/my_alloc.c:
        Cleanup comments
      mysys/thr_lock.c:
        Cleanup comments
      sql/item.h:
        Remove not needed initializer
      sql/item_func.cc:
        Simple optimization for 2 argument usage to function of variable arguments
      sql/mysql_priv.h:
        We use more stackspace with the introduction of int_op() etc.
        This change ensures we don't run out of stack when doing 1+1+1+1...
        (Tested on x86, 32 bit)
      sql/sp_head.cc:
        Don't call post_open if pre_open() fails
      sql/sp_rcontext.cc:
        More comments
        Change so that post_open() doesn't have to be called if pre_open() fails
      sql/sql_parse.cc:
        Fold long lines
      sql/sql_select.cc:
        Simple reorganization to reduce number of if's
        Ensure that table_map is updated for where clause (fixed warning from valgrind)
      b08b3a15
  17. 04 Jun, 2005 1 commit
  18. 16 May, 2005 1 commit
    • unknown's avatar
      A fix and a test case for Bug#9643 " CURSOR_TYPE_SCROLLABLE dos not work" · 1bb1bc69
      unknown authored
      - check on the client the unsupported feature and return 
      an error message if it's been requested.
      Additionally added API support for STMT_ATTR_PREFETCH_ROWS.
      Post-review fixes.
      
      
      include/errmsg.h:
        Add a new error code for "Not implemented" client-side error message.
      include/mysql.h:
        Add a statement attribute STMT_ATTR_PREFETCH_ROWS - unsigned long
        number of rows to fetch per one COM_FETCH command, used when there
        is a read-only cursor.
        Note, that we don't break compatibility by adding this new member
        because MYSQL_STMT is always allocated inside the client library by
        mysql_stmt_init.
      libmysql/errmsg.c:
        Text for the error message CR_NOT_IMPLEMENTED
      libmysql/libmysql.c:
        Implement support for STMT_ATTR_PREFETCH_ROWS
        Return an error message on attempt to set an attribute of a prepared
        statement which is not implemented yet. We probably should be doing
        it in the server: currently the server just ignores unknown attributes.
      tests/mysql_client_test.c:
        A test case for Bug#9643 "CURSOR_TYPE_SCROLLABLE dos not work"
        - check that an error message is returned for CURSOR_TYPE_SCROLLABLE.
        Additionally, check setting of STMT_ATTR_PREFETCH_ROWS.
      1bb1bc69
  19. 14 May, 2005 1 commit
    • unknown's avatar
      After merge fixes · 2059908b
      unknown authored
      BitKeeper/deleted/.del-outfile2.result~fb702ee2518d8e6d:
        Delete: mysql-test/r/outfile2.result
      libmysql/libmysql.c:
        Fix indentation for new function mysql_set_character_set()
      mysql-test/r/alter_table.result:
        Fix test to be in same order as in 4.0
      mysql-test/r/innodb.result:
        After merge fix
      mysql-test/r/insert_update.result:
        Add extra test for insert into ... on duplicate key upate
      mysql-test/r/outfile.result:
        After merge fix
      mysql-test/t/alter_table.test:
        Fix test to be in same order as in 4.0
      mysql-test/t/insert_update.test:
        Add extra test for insert into ... on duplicate key upate
      mysql-test/t/outfile.test:
        After merge fix
      sql/item_func.cc:
        After merge fix
      sql/sql_table.cc:
        After merge fix
      2059908b
  20. 13 May, 2005 2 commits
  21. 12 May, 2005 1 commit
    • unknown's avatar
      A fix and test case for Bug#9478 "mysql_stmt_attr_set mysql_stmt_execute" · 2a8556f3
      unknown authored
      (crash on attempt to re-execute a statement with an open cursor) + 
      post-review fixes.
      
      
      include/errmsg.h:
        Add a special error message when we attempt to mysql_stmt_fetch
        from a statement which has no result set.
      libmysql/errmsg.c:
        Error message text for CR_NO_RESULT_SET
      libmysql/libmysql.c:
        Move the code which frees result sets on client and closes the cursor
        on server, resets long data state on client and server.
        This makes one function out of two (mysql_stmt_reset and
        mysql_stmt_free_result), thus aggregating all related reset work
        in one place.
      sql-common/client.c:
        Fix one place where we flushed the pending result set of a statement,
        but didn't set unbuffered_fetch_cancelled flag.
      sql/share/errmsg.txt:
        Fix format of ER_UNKNOWN_STMT_HANDLER error message (needs to
        be fixed separately in 4.1). Add two new error messages 
        for the case when we fetch from when there is no cursor
        and for the case when we attempt to execute a statement while there is
        a cursor.
      sql/sql_prepare.cc:
        Return error when we fetch while there is no open cursor and
        when we call execute while there is a pending cursor.
        Fix mysql_stmt_reset to close the open cursor if there is any.
      sql/sql_select.cc:
        free_items and free_root moved to Cursor::close().
      sql/sql_select.h:
        A comment added.
      tests/mysql_client_test.c:
        A test case for Bug#9478, test the case of mysql_stmt_reset
        called for client-side cached result set and for the case with open cursor.
        All strcpy replaced with strmov (review request).
      2a8556f3
  22. 07 May, 2005 1 commit
  23. 21 Apr, 2005 1 commit
  24. 12 Apr, 2005 1 commit
  25. 11 Apr, 2005 1 commit
  26. 04 Apr, 2005 1 commit
  27. 24 Mar, 2005 1 commit
    • unknown's avatar
      Fixes and test cases for Bug#8880 "Commands out of sync error with cursors" · 3b236b1d
      unknown authored
       and Bug#9159 "Server crash during mysql_stmt_close".
      The patch adds support for single-row result sets in cursors.
      
      
      libmysql/libmysql.c:
        If we wanted a cursor, and the server wasn't able to create one,
        buffer all rows on client. Currently this is possible only for
        single row result sets and some SHOW commands.
      sql/sql_prepare.cc:
        Properly free resources if there was a request to open a cursor which
        wasn't fullfilled.
        Give error on attempt to open a cursor for a statement not returning
        a result set.
      sql/sql_select.h:
        Initialize Item_arena of Cursor object. A case when a cursor object
        is created but not used is possible with single-row result sets.
      tests/mysql_client_test.c:
        Test cases for Bug#8880 and Bug#9159
      3b236b1d
  28. 19 Mar, 2005 1 commit
    • unknown's avatar
      Eliminate warnings noticed by VC7. This includes fixing my_mmap() on · 892a6138
      unknown authored
      Windows to call CreateFileMapping() with correct arguments, and
      propogating the introduction of query_id_t to everywhere query ids are
      passed around. (Bug #8826)
      
      
      libmysql/libmysql.c:
        Make implicit cast explicit
      myisam/mi_open.c:
        Make cast of value to smaller data size explicit
      myisam/mi_packrec.c:
        Cast file size (my_off_t) to size_t for mmap
      mysys/my_mmap.c:
        Fix Windows version of my_mmap() to use the right parameters
        for call to CreateFileMapping()
      sql/field.cc:
        Use temporary value of correct type
      sql/field.h:
        Use query_id_t for query_id value
      sql/ha_berkeley.cc:
        Fix flag check
      sql/ha_innodb.h:
        Use query_id_t for query_id value
      sql/handler.cc:
        Explain opt_using_transactions calculation, and add cast
      sql/handler.h:
        Fix forward declaration of COND
      sql/item.cc:
        Fix val_bool() tests of val_int() to avoid implicit cast
      sql/item_cmpfunc.cc:
        Fix typo in switch label
      sql/item_func.cc:
        Make implicit cast explicit
      sql/item_strfunc.cc:
        Now that query_id is a query_id_t, need to cast it to a ulong here
      sql/item_subselect.cc:
        Fix test of value
      sql/log.cc:
        Cast my_off_t used for file size to size_t for memory allocation
        Also cast my_off_t when using it to calculate the number of pages for TC log
        Cast total_ha_2pc to uchar when saving it
      sql/mysql_priv.h:
        Move up query_id definition so it can be used more widely
      sql/opt_range.cc:
        Add unused delete operator to prevent compiler warning
      sql/set_var.cc:
        Cast value for max_user_connections
      sql/sql_cache.cc:
        Remove unused label
      sql/sql_class.h:
        Fix query id values to be of type query_id_t
      sql/sql_db.cc:
        Move variable only used inside #ifdef within the #ifdef
      sql/sql_help.cc:
        Remove unused label
      sql/sql_insert.cc:
        Use query_id_t for query id values
      sql/sql_lex.h:
        Add unused delete operator to prevent compiler warning
      sql/sql_select.cc:
        Remove unused variable
        Make cast of value explicit
      sql/sql_select.h:
        Use query_id_t for query id values
      sql/sql_table.cc:
        Make comparison to function pointer explicit
      sql/sql_update.cc:
        Use query_id_t for query id values
      sql/table.h:
        Use query_id_t for query id values
      strings/ctype-simple.c:
        Add cast of long value to (char) in expression
      strings/ctype-ucs2.c:
        Add cast of long value to (char) in expression
      strings/ctype-utf8.c:
        Make cast to smaller size explicit
      892a6138
  29. 17 Mar, 2005 2 commits
    • unknown's avatar
      Fix HP/UX debug compile error. (Bug #8679) · 2ad50a50
      unknown authored
      libmysql/libmysql.c:
        Break up variable definitions to appease HP/UX compiler.
      2ad50a50
    • unknown's avatar
      Field::quote_data(): · b6e29d09
      unknown authored
        don't call escape_string_for_mysql() unnecesary
        don't overwrite local buffer
      escape_string_for_mysql():
        take a length of the destination buffer as an argument
      
      
      include/my_sys.h:
        prototype changed
      libmysql/libmysql.c:
        prototype changed
      mysys/charset.c:
        escape_string_for_mysql():
          take a length of the destination buffer as an argument
      sql/field.cc:
        Field::quote_data():
          don't call escape_string_for_mysql() unnecesary
          don't overwrite local buffer
      sql/item.cc:
        prototype changed
      sql/sql_prepare.cc:
        prototype changed
      b6e29d09
  30. 23 Feb, 2005 1 commit
    • unknown's avatar
      WL #2094 Federated Storage Handler · aec30267
      unknown authored
      This is the first changeset of suggested changes recommended in Kostja's 
      review of my patch, 1.1846, which includes only functionality changes. 
      Style changes/Documentation patch to follow.
      
      
      include/mysql.h:
        removed declaration of cli_fetch_lengths per Kostja's suggestion
      libmysql/libmysql.c:
        moved mysql_fetch_lengths to client.c (for server to access) per Kostja's
        suggestion
      sql-common/client.c:
        added back 'static' to function definition, added mysql_fetch_lengths
      sql/ha_federated.cc:
        changed to use defines as opposed to hardcoded values
      sql/ha_federated.h:
        took out duplicate table_flag, fixed a resolve mistake
      aec30267
  31. 22 Feb, 2005 1 commit
  32. 17 Feb, 2005 1 commit
  33. 10 Feb, 2005 3 commits
    • unknown's avatar
      Follow-up for bug#7990 · d9039e87
      unknown authored
      libmysql/libmysql.c:
        And now put it to the proper place and make it work (Bug#7990)
      tests/mysql_client_test.c:
        Enable the test for bug#7990
      d9039e87
    • unknown's avatar
      A fix and test case for Bug#7990 "mysql_stmt_close doesn't · a26ce94f
      unknown authored
      reset mysql->net.last_error": the solution is to clear
      MYSQL->net error before performing COM_CLOSE: if the call
      succeeds, the connection is usable for other statements.
      More comprehensive fix is to clear MYSQL->net for all
      recoverable errors at the time they happen, it will be
      implemented in 5.0 as it introduces incompatibility in behavior.
      
      
      libmysql/libmysql.c:
        A simple fix for Bug#7990 "mysql_stmt_close doesn't reset 
        mysql->net.last_error"
      tests/mysql_client_test.c:
        A test case for Bug#7990 " mysql_stmt_close doesn't reset 
        mysql->net.last_error"
      a26ce94f
    • unknown's avatar
      A fix and test case for Bug#8330 "mysql_stmt_execute crashes" (libmysql). · fca90750
      unknown authored
      libmysql/libmysql.c:
        Fix for bug#8330 "mysql_stmt_execute crashes": we need to bail out
        from mysql_stmt_execute if mysql->net is occupied with a result set of
        another statement. Otherwise on the next attempt to use net we get
        a crash, as it's freed in case of error.
      tests/mysql_client_test.c:
        A test case for Bug#8330 "mysql_stmt_execute craches" (libmysql)
      fca90750
  34. 08 Feb, 2005 1 commit
    • unknown's avatar
      Precision Math implementation · 91db48e3
      unknown authored
      BitKeeper/etc/ignore:
        Added client/decimal.c client/my_decimal.cc client/my_decimal.h to the ignore list
      91db48e3