1. 06 Dec, 2006 1 commit
    • unknown's avatar
      bug #22372 (LOAD DATA crashes the table with the geometry field) · ea7d3db0
      unknown authored
      The problem is that the GEOMETRY NOT NULL can't automatically set
      any value as a default one. We always tried to complete LOAD DATA
      command even if there's not enough data in file. That doesn't work
      for GEOMETRY NOT NULL. Now Field_*::reset() returns an error sign
      and it's checked in mysql_load()
      
      
      mysql-test/r/gis.result:
        test result
      mysql-test/t/gis.test:
        testcase
      sql/field.cc:
        reset() now returns error sign
      sql/field.h:
        Field_*::reset() now returns error sign if the field can't be reset
      sql/sql_load.cc:
        check if field can't be reset and return error if it's so
      ea7d3db0
  2. 29 Nov, 2006 1 commit
    • unknown's avatar
      Added back sql-bench directory, so that one can more easily run benchmarks on... · 5d2412b0
      unknown authored
      Added back sql-bench directory, so that one can more easily run benchmarks on a server and add new benchmarks for new optimizations
      Fixed memory leak in _db_set() (Bug#24497 Valgrind warning: get_one_option)
      Don't call net_clear() on COM_QUIT. This avoids a warning from net_clear() after shutdown: "skipped ## bytes from file"
      BUG#21428: skipped 9 bytes from file: socket (3)" on "mysqladmin shutdown"
      
      
      sql-bench/test-wisconsin.sh:
        Rename: BitKeeper/deleted/.del-test-wisconsin.sh~c0b86821b5f95f26 -> sql-bench/test-wisconsin.sh
      sql-bench/test-transactions.sh:
        Rename: BitKeeper/deleted/.del-test-transactions.sh~c1c892f10c40caf -> sql-bench/test-transactions.sh
      sql-bench/test-insert.sh:
        Rename: BitKeeper/deleted/.del-test-insert.sh~893bfac9dedb79a7 -> sql-bench/test-insert.sh
      sql-bench/test-select.sh:
        Rename: BitKeeper/deleted/.del-test-select.sh~6d5cc770acf11be6 -> sql-bench/test-select.sh
      sql-bench/test-create.sh:
        Rename: BitKeeper/deleted/.del-test-create.sh~f9a1ea38c191b17a -> sql-bench/test-create.sh
      sql-bench/test-big-tables.sh:
        Rename: BitKeeper/deleted/.del-test-big-tables.sh~5b1b0c5fb623565a -> sql-bench/test-big-tables.sh
      sql-bench/test-connect.sh:
        Rename: BitKeeper/deleted/.del-test-connect.sh~382a728c949ee075 -> sql-bench/test-connect.sh
      sql-bench/test-ATIS.sh:
        Rename: BitKeeper/deleted/.del-test-ATIS.sh~e8ebff7086c95773 -> sql-bench/test-ATIS.sh
      sql-bench/test-alter-table.sh:
        Rename: BitKeeper/deleted/.del-test-alter-table.sh~eba6cfa9972fcced -> sql-bench/test-alter-table.sh
      sql-bench/innotest2b.sh:
        Rename: BitKeeper/deleted/.del-innotest2b.sh~7b99ece835e8dff3 -> sql-bench/innotest2b.sh
      sql-bench/run-all-tests.sh:
        Rename: BitKeeper/deleted/.del-run-all-tests.sh~41d6da1cf211ee95 -> sql-bench/run-all-tests.sh
      sql-bench/innotest2.sh:
        Rename: BitKeeper/deleted/.del-innotest2.sh~9c14df528285603 -> sql-bench/innotest2.sh
      sql-bench/innotest2a.sh:
        Rename: BitKeeper/deleted/.del-innotest2a.sh~e01d016a7cafdc0b -> sql-bench/innotest2a.sh
      sql-bench/innotest1a.sh:
        Rename: BitKeeper/deleted/.del-innotest1a.sh~c64f4610ae1e26fe -> sql-bench/innotest1a.sh
      sql-bench/innotest1b.sh:
        Rename: BitKeeper/deleted/.del-innotest1b.sh~aafd0819ae84da7b -> sql-bench/innotest1b.sh
      sql-bench/innotest1.sh:
        Rename: BitKeeper/deleted/.del-innotest1.sh~aa36bce09ca783c7 -> sql-bench/innotest1.sh
      sql-bench/crash-me.sh:
        Rename: BitKeeper/deleted/.del-crash-me.sh~2fa881d0b40339c8 -> sql-bench/crash-me.sh
      sql-bench/graph-compare-results.sh:
        Rename: BitKeeper/deleted/.del-graph-compare-results.sh~7e4e28b3591b4542 -> sql-bench/graph-compare-results.sh
      sql-bench/copy-db.sh:
        Rename: BitKeeper/deleted/.del-copy-db.sh~e8116afb93144ccd -> sql-bench/copy-db.sh
      sql-bench/compare-results.sh:
        Rename: BitKeeper/deleted/.del-compare-results.sh~a9e26e2644c694b3 -> sql-bench/compare-results.sh
      sql-bench/bench-count-distinct.sh:
        Rename: BitKeeper/deleted/.del-bench-count-distinct.sh~a92f174271a831d7 -> sql-bench/bench-count-distinct.sh
      sql-bench/as3ap.sh:
        Rename: BitKeeper/deleted/.del-as3ap.sh~f54eebbd8d34c9b6 -> sql-bench/as3ap.sh
      sql-bench/Comments/Informix.crash-me:
        Rename: BitKeeper/deleted/.del-Informix.crash-me~51ab5b717cefe74 -> sql-bench/Comments/Informix.crash-me
      sql-bench/Comments/postgres.crash-me:
        Rename: BitKeeper/deleted/.del-postgres.crash-me~eacac145c3e30f17 -> sql-bench/Comments/postgres.crash-me
      sql-bench/Comments/Empress.crash-me:
        Rename: BitKeeper/deleted/.del-Empress.crash-me~bdaff0c68ce10f02 -> sql-bench/Comments/Empress.crash-me
      sql-bench/Comments/Adabas.crash-me:
        Rename: BitKeeper/deleted/.del-Adabas.crash-me~ce88ba1a540971ac -> sql-bench/Comments/Adabas.crash-me
      sql-bench/Comments/Access.crash-me:
        Rename: BitKeeper/deleted/.del-Access.crash-me~bb457ec282d939b6 -> sql-bench/Comments/Access.crash-me
      sql-bench/Comments/postgres.benchmark:
        Rename: BitKeeper/deleted/.del-postgres.benchmark~4d30890732b784a -> sql-bench/Comments/postgres.benchmark
      sql-bench/Comments/mysql.benchmark:
        Rename: BitKeeper/deleted/.del-mysql.benchmark~4d8729c0937456fc -> sql-bench/Comments/mysql.benchmark
      sql-bench/Comments/FrontBase.benchmark:
        Rename: BitKeeper/deleted/.del-FrontBase.benchmark~217041ef18274c2e -> sql-bench/Comments/FrontBase.benchmark
      sql-bench/Comments/interbase:
        Rename: BitKeeper/deleted/.del-interbase~cdad59622b4d6f3 -> sql-bench/Comments/interbase
      sql-bench/uname.bat:
        Rename: BitKeeper/deleted/.del-uname.bat~a6d933d2ee9314c -> sql-bench/uname.bat
      sql-bench/pwd.bat:
        Rename: BitKeeper/deleted/.del-pwd.bat~9b64050849abf51 -> sql-bench/pwd.bat
      sql-bench/example.bat:
        Rename: BitKeeper/deleted/.del-example.bat~22d0170bccf0f030 -> sql-bench/example.bat
      sql-bench/Makefile.am:
        Rename: BitKeeper/deleted/.del-Makefile.am~7b07da85b2e9375 -> sql-bench/Makefile.am
      sql-bench/Data/ATIS/transport.txt:
        Rename: BitKeeper/deleted/.del-transport.txt~fa4ca40735f8354c -> sql-bench/Data/ATIS/transport.txt
      sql-bench/Data/ATIS/time_zone.txt:
        Rename: BitKeeper/deleted/.del-time_zone.txt~4171f9ca732f65c0 -> sql-bench/Data/ATIS/time_zone.txt
      sql-bench/Data/Wisconsin/tenk.data:
        Rename: BitKeeper/deleted/.del-tenk.data~6aeaebdd534e458e -> sql-bench/Data/Wisconsin/tenk.data
      sql-bench/Data/Wisconsin/onek.data:
        Rename: BitKeeper/deleted/.del-onek.data~6cd1edaf596a7f7 -> sql-bench/Data/Wisconsin/onek.data
      sql-bench/Data/ATIS/stop1.txt:
        Rename: BitKeeper/deleted/.del-stop1.txt~f09ba164ad44a288 -> sql-bench/Data/ATIS/stop1.txt
      sql-bench/Data/ATIS/time_interval.txt:
        Rename: BitKeeper/deleted/.del-time_interval.txt~a1def62e267a59b2 -> sql-bench/Data/ATIS/time_interval.txt
      sql-bench/Data/ATIS/stop.txt:
        Rename: BitKeeper/deleted/.del-stop.txt~31fb564e1f415e34 -> sql-bench/Data/ATIS/stop.txt
      sql-bench/Data/ATIS/restriction.txt:
        Rename: BitKeeper/deleted/.del-restriction.txt~6ae208924617784a -> sql-bench/Data/ATIS/restriction.txt
      sql-bench/Data/ATIS/state.txt:
        Rename: BitKeeper/deleted/.del-state.txt~9dd470ce14075b90 -> sql-bench/Data/ATIS/state.txt
      sql-bench/Data/ATIS/restrict_class.txt:
        Rename: BitKeeper/deleted/.del-restrict_class.txt~2f741bf0ea498f84 -> sql-bench/Data/ATIS/restrict_class.txt
      sql-bench/Data/ATIS/month_name.txt:
        Rename: BitKeeper/deleted/.del-month_name.txt~4c44f7a323d57d92 -> sql-bench/Data/ATIS/month_name.txt
      sql-bench/Data/ATIS/restrict_carrier.txt:
        Rename: BitKeeper/deleted/.del-restrict_carrier.txt~925b5492f3f9cba3 -> sql-bench/Data/ATIS/restrict_carrier.txt
      sql-bench/Data/ATIS/ground_service.txt:
        Rename: BitKeeper/deleted/.del-ground_service.txt~1087e477e86e84c -> sql-bench/Data/ATIS/ground_service.txt
      sql-bench/Data/ATIS/food_service.txt:
        Rename: BitKeeper/deleted/.del-food_service.txt~66d95a150c28458 -> sql-bench/Data/ATIS/food_service.txt
      sql-bench/Data/ATIS/flight_day.txt:
        Rename: BitKeeper/deleted/.del-flight_day.txt~76868d6d265d441e -> sql-bench/Data/ATIS/flight_day.txt
      sql-bench/Data/ATIS/flight_fare.txt:
        Rename: BitKeeper/deleted/.del-flight_fare.txt~d7322593c8530487 -> sql-bench/Data/ATIS/flight_fare.txt
      sql-bench/Data/ATIS/flight_class.txt:
        Rename: BitKeeper/deleted/.del-flight_class.txt~1801101474c29098 -> sql-bench/Data/ATIS/flight_class.txt
      sql-bench/Data/ATIS/fconnection.txt:
        Rename: BitKeeper/deleted/.del-fconnection.txt~e0ef6a8b5560a713 -> sql-bench/Data/ATIS/fconnection.txt
      sql-bench/Data/ATIS/flight.txt:
        Rename: BitKeeper/deleted/.del-flight.txt~e5065423760e99eb -> sql-bench/Data/ATIS/flight.txt
      sql-bench/Data/ATIS/fare.txt:
        Rename: BitKeeper/deleted/.del-fare.txt~ea0652f490bc24a6 -> sql-bench/Data/ATIS/fare.txt
      sql-bench/Data/ATIS/day_name.txt:
        Rename: BitKeeper/deleted/.del-day_name.txt~f813b215955d894c -> sql-bench/Data/ATIS/day_name.txt
      sql-bench/Data/ATIS/dual_carrier.txt:
        Rename: BitKeeper/deleted/.del-dual_carrier.txt~a7dd776224fbd92b -> sql-bench/Data/ATIS/dual_carrier.txt
      sql-bench/Data/ATIS/date_day.txt:
        Rename: BitKeeper/deleted/.del-date_day.txt~4e9a282fcf54cfd8 -> sql-bench/Data/ATIS/date_day.txt
      sql-bench/Data/ATIS/compound_class.txt:
        Rename: BitKeeper/deleted/.del-compound_class.txt~d4a2f1b7f96340b9 -> sql-bench/Data/ATIS/compound_class.txt
      sql-bench/Data/ATIS/connect_leg.txt:
        Rename: BitKeeper/deleted/.del-connect_leg.txt~f97b6e94e108bb36 -> sql-bench/Data/ATIS/connect_leg.txt
      sql-bench/Data/ATIS/code_description.txt:
        Rename: BitKeeper/deleted/.del-code_description.txt~f9117373e438b0e2 -> sql-bench/Data/ATIS/code_description.txt
      sql-bench/Data/ATIS/city.txt:
        Rename: BitKeeper/deleted/.del-city.txt~d96dd6d073344d2e -> sql-bench/Data/ATIS/city.txt
      sql-bench/Data/ATIS/class_of_service.txt:
        Rename: BitKeeper/deleted/.del-class_of_service.txt~21f6b9848b8c76d -> sql-bench/Data/ATIS/class_of_service.txt
      sql-bench/Data/ATIS/airport_service.txt:
        Rename: BitKeeper/deleted/.del-airport_service.txt~6ee6d5b852b3e38 -> sql-bench/Data/ATIS/airport_service.txt
      sql-bench/Data/ATIS/airline.txt:
        Rename: BitKeeper/deleted/.del-airline.txt~a79f8eadf853f2c8 -> sql-bench/Data/ATIS/airline.txt
      sql-bench/Data/ATIS/airport.txt:
        Rename: BitKeeper/deleted/.del-airport.txt~59c78514130e1f45 -> sql-bench/Data/ATIS/airport.txt
      sql-bench/Data/ATIS/aircraft.txt:
        Rename: BitKeeper/deleted/.del-aircraft.txt~15e4de7ab37c92d3 -> sql-bench/Data/ATIS/aircraft.txt
      sql-bench/TODO:
        Rename: BitKeeper/deleted/.del-TODO~cac6d7a63c426ae5 -> sql-bench/TODO
      sql-bench/limits/sybase.cfg:
        Rename: BitKeeper/deleted/.del-sybase.cfg~c4636b12767b3f14 -> sql-bench/limits/sybase.cfg
      sql-bench/limits/solid-nt4.cfg:
        Rename: BitKeeper/deleted/.del-solid-nt4.cfg~cca779f0c9e29d31 -> sql-bench/limits/solid-nt4.cfg
      sql-bench/limits/solid.cfg:
        Rename: BitKeeper/deleted/.del-solid.cfg~5ae0e4342eadb0fb -> sql-bench/limits/solid.cfg
      sql-bench/limits/pg.cfg:
        Rename: BitKeeper/deleted/.del-pg.cfg~db59cf39a5d417be -> sql-bench/limits/pg.cfg
      sql-bench/limits/mysql.cfg:
        Rename: BitKeeper/deleted/.del-mysql.cfg~9cab20a8771b93cf -> sql-bench/limits/mysql.cfg
      sql-bench/limits/oracle.cfg:
        Rename: BitKeeper/deleted/.del-oracle.cfg~affab21af8f438fd -> sql-bench/limits/oracle.cfg
      sql-bench/limits/mysql-4.1.cfg:
        Rename: BitKeeper/deleted/.del-mysql-4.1.cfg~b6c5e74aefc99e3c -> sql-bench/limits/mysql-4.1.cfg
      sql-bench/limits/mysql-3.23.cfg:
        Rename: BitKeeper/deleted/.del-mysql-3.23.cfg~3cf9d6be54b77a3c -> sql-bench/limits/mysql-3.23.cfg
      sql-bench/limits/mysql-4.0.cfg:
        Rename: BitKeeper/deleted/.del-mysql-4.0.cfg~6c9d63c85b5ef574 -> sql-bench/limits/mysql-4.0.cfg
      sql-bench/limits/mysql-3.22.cfg:
        Rename: BitKeeper/deleted/.del-mysql-3.22.cfg~e706f26a161175cd -> sql-bench/limits/mysql-3.22.cfg
      sql-bench/limits/msql.cfg:
        Rename: BitKeeper/deleted/.del-msql.cfg~52710b12932cceb9 -> sql-bench/limits/msql.cfg
      sql-bench/limits/ms-sql65.cfg:
        Rename: BitKeeper/deleted/.del-ms-sql65.cfg~6b9bc3c460dbee05 -> sql-bench/limits/ms-sql65.cfg
      sql-bench/limits/mimer.cfg:
        Rename: BitKeeper/deleted/.del-mimer.cfg~234e6c1c3c47b612 -> sql-bench/limits/mimer.cfg
      sql-bench/limits/ms-sql.cfg:
        Rename: BitKeeper/deleted/.del-ms-sql.cfg~1907964264d2786a -> sql-bench/limits/ms-sql.cfg
      sql-bench/limits/interbase.cfg:
        Rename: BitKeeper/deleted/.del-interbase.cfg~c6951a0376cc6ff3 -> sql-bench/limits/interbase.cfg
      sql-bench/limits/interbase-dialect3.cfg:
        Rename: BitKeeper/deleted/.del-interbase-dialect3.cfg~46277bdfc74c667a -> sql-bench/limits/interbase-dialect3.cfg
      sql-bench/limits/interbase-superserver.cfg:
        Rename: BitKeeper/deleted/.del-interbase-superserver.cfg~22501198689243b0 -> sql-bench/limits/interbase-superserver.cfg
      sql-bench/limits/interbase-dialect1.cfg:
        Rename: BitKeeper/deleted/.del-interbase-dialect1.cfg~659206b5b9a11036 -> sql-bench/limits/interbase-dialect1.cfg
      sql-bench/limits/empress.cfg:
        Rename: BitKeeper/deleted/.del-empress.cfg~1f97f34d6560a499 -> sql-bench/limits/empress.cfg
      sql-bench/limits/frontbase.cfg:
        Rename: BitKeeper/deleted/.del-frontbase.cfg~71369e9c002696e -> sql-bench/limits/frontbase.cfg
      sql-bench/limits/db2.cfg:
        Rename: BitKeeper/deleted/.del-db2.cfg~711099b4d7906959 -> sql-bench/limits/db2.cfg
      sql-bench/limits/access.cfg:
        Rename: BitKeeper/deleted/.del-access.cfg~5239ea3655b7bba0 -> sql-bench/limits/access.cfg
      sql-bench/limits/access_odbc.cfg:
        Rename: BitKeeper/deleted/.del-access_odbc.cfg~34b4cf0eda56c4b1 -> sql-bench/limits/access_odbc.cfg
      sql-bench/limits/Informix.cfg:
        Rename: BitKeeper/deleted/.del-Informix.cfg~b94188e1ececb51b -> sql-bench/limits/Informix.cfg
      sql-bench/limits/Adabas.cfg:
        Rename: BitKeeper/deleted/.del-Adabas.cfg~343ed4e7f8b02111 -> sql-bench/limits/Adabas.cfg
      sql-bench/README:
        Rename: BitKeeper/deleted/.del-README~b1aa0c1bf9f5eb5e -> sql-bench/README
      BitKeeper/deleted/.del-create-pg_fast-Linux_2.2.14_my_SMP_i686-crashed:
        Delete: sql-bench/Results/create-pg_fast-Linux_2.2.14_my_SMP_i686-crashed
      Makefile.am:
        Added back sql-bench
      configure.in:
        Added back sql-bench
      dbug/dbug.c:
        Fixed memory leak in _db_set()
        This is not a complete fix as we can still get memory leaks if we do any of the following:
        mysqld --debug --debug
        CAll DBUG_SET or DBUG_SET_INITIAL more than once in a program
        Use SET @@global.debug=xxxx
        
        At some point we should fix the above, but this is not critical for normal operation (only for debugging)
        
        Bug #24497 Valgrind warning: get_one_option
        
        Note that all changes to _db_set_ is only a variable access change, and can be ignored while reviewing the bug fix.
      mysql-test/t/flush_read_lock_kill-master.opt:
        Added '+' to option, to be able to use this together with --debug
      mysql-test/valgrind.supp:
        Removed warning that is now fixed
      mysys/ptr_cmp.c:
        Fixed wrong pointer read (probably never used)
      scripts/make_binary_distribution.sh:
        Added back sql_bench
      sql/field.h:
        Removed class function that was identical in parent class
      sql/mysqld.cc:
        Removed some calls to my_thread_init() / my_thread_end() that was not needed.
        Only call DBUG_SET_INITAL, not DBUG_SET
        (Fixes memory leak in dbug)
        Mark some code as deadcode
      sql/net_serv.cc:
        Add information about from where error comes
      sql-bench/bench-init.pl.sh:
        Cleaned up help text
      sql-bench/server-cfg.sh:
        Don't write '/' after server name of no ssl version
      sql-common/client.c:
        Don't call net_clear() on COM_QUIT. This avoids a warning from net_clear() after shutdown: "skipped ## bytes from file"
        BUG#21428: skipped 9 bytes from file: socket (3)" on "mysqladmin shutdown"
      sql/sql_parse.cc:
        Added comment
      sql/table.h:
        Removed compiler warning
      5d2412b0
  3. 27 Nov, 2006 1 commit
    • unknown's avatar
      Removed compiler warnings · 4555818f
      unknown authored
      Ensure that my_size_t is always unsigned (to get predictiable results from system to system)
      Removed some %lld, as these are not portable
      
      
      BUILD/FINISH.sh:
        Remove configure files from storage engines (as some of them may be old versions and may cause conflicts)
      client/mysqldump.c:
        Removed compiler warning
      client/mysqlslap.c:
        Removed compiler warning
      client/mysqltest.c:
        Removed compiler warning
      cmd-line-utils/readline/bind.c:
        Removed compiler warning
      cmd-line-utils/readline/histfile.c:
        Removed compiler warning
      include/my_global.h:
        Ensure that my_size_t is always unsigned (to get predictiable results from system to system)
        Moved my_offset_t here from parse_file.h
      sql/event_data_objects.cc:
        Removed compiler warning
      sql/event_scheduler.cc:
        Removed compiler warning
      sql/field.h:
        Removed compiler warning
      sql/ha_ndbcluster_binlog.cc:
        Removed compiler warning
      sql/ha_partition.cc:
        Removed compiler warning
      sql/item_strfunc.cc:
        Removed compiler warning
      sql/log_event.cc:
        Removed compiler warning
      sql/mysqld.cc:
        Removed compiler warning
      sql/parse_file.h:
        Moved my_offset_t to my_global.h
      sql/rpl_utility.cc:
        Removed compiler warning
      sql/sql_binlog.cc:
        Removed compiler warning
      sql/sql_cache.cc:
        Removed compiler warning
      sql/tztime.cc:
        Removed compiler warning
      storage/archive/ha_archive.cc:
        Removed compiler warning
        Removed %lld as it's not portable
      storage/heap/hp_write.c:
        Removed compiler warning
      storage/innobase/os/os0file.c:
        Removed compiler warning
      storage/myisam/myisampack.c:
        Removed compiler warning
      storage/myisammrg/myrg_rkey.c:
        Removed compiler warning
      storage/ndb/include/kernel/signaldata/DictTabInfo.hpp:
        Use my_offsetof instead of offsetof to get rid of compiler warnings
      storage/ndb/src/kernel/blocks/dbdict/printSchemaFile.cpp:
        Removed compiler warning
      storage/ndb/src/kernel/blocks/dbtup/DbtupRoutines.cpp:
        Removed compiler warning
        Note: Someone from NDB team should check this fix!
      storage/ndb/src/kernel/vm/Rope.cpp:
        Removed compiler warning
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/Ndb.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/NdbEventOperationImpl.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/NdbTransaction.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/Ndblist.cpp:
        Removed compiler warning
      4555818f
  4. 21 Nov, 2006 1 commit
    • unknown's avatar
      Added --debug-info to most clients to detect memory leaks in mysql-test-run · 22b80d14
      unknown authored
      Moved .progress files into the log directory
      Moved 'cluster' database tables into the MySQL database, to not have 'cluster' beeing a reserved database name
      Fixed bug where mysqld got a core dump when trying to use a table created by MySQL 3.23
      Fixed some compiler warnings
      Fixed small memory leak in libmysql
      Note that this doesn't changeset doesn't include the new mysqldump.c code required to run some tests. This will be added when I merge 5.0 to 5.1
      
      
      client/client_priv.h:
        Added OPT_DEBUG_INFO and OPT_COLUMN_TYPES
      client/mysql.cc:
        Split --debug-info into --debug-info and --column-type-info
      client/mysql_upgrade.c:
        Give only error info at end if using --debug-info
      client/mysqladmin.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlbinlog.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlcheck.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlimport.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlshow.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqltest.c:
        Added --debug-info to detect memory leaks in mysqltest
        Added option --logdir to force .progress files in a specific directory
      libmysql/libmysql.c:
        Fixed memory leak
      mysql-test/include/ndb_setup_slave.inc:
        Moved cluster tables under 'mysql'
      mysql-test/include/query_cache.inc:
        Added more tests for query cache
      mysql-test/lib/init_db.sql:
        Move cluster.binlog_index -> mysql.binlog_index
      mysql-test/lib/mtr_report.pl:
        Find memory leaks
      mysql-test/mysql-test-run-shell.sh:
        Added --debug-info to programs to detect memory leaks
      mysql-test/mysql-test-run.pl:
        Added --debug-info to programs to detect memory leaks
        Force log files to var/log
        cluster tables moved under 'mysql'
      mysql-test/r/cache_innodb.result:
        New query cache test with innodb
      mysql-test/r/connect.result:
        binlog_index is now in mysql
      mysql-test/r/drop.result:
        Removed 'cluster' database
      mysql-test/r/information_schema.result:
        Removed 'cluster' database
      mysql-test/r/mysqlcheck.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_basic.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_ddl_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_discover.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_restore_compat.result:
        cluster -> mysql
      mysql-test/r/ps_1general.result:
        Removed cluster database
      mysql-test/r/rpl_create_database.result:
        Removed cluster database
      mysql-test/r/rpl_load_from_master.result:
        Removed cluster database
      mysql-test/r/rpl_loaddata_m.result:
        Removed cluster database
      mysql-test/r/rpl_ndb_bank.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_advance.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_basic.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_idempotent.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_log.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_multi.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_sync.result:
        cluster -> mysql
      mysql-test/r/rpl_row_basic_11bugs.result:
        Removed cluster database
      mysql-test/r/rpl_truncate_7ndb.result:
        Position have changed
      mysql-test/r/rpl_truncate_7ndb_2.result:
        cluster -> mysql
      mysql-test/r/schema.result:
        Removed cluster database
      mysql-test/r/show_check.result:
        Removed cluster database
      mysql-test/r/system_mysql_db.result:
        binlog_index moved under mysql
      mysql-test/r/upgrade.result:
        More tests
      mysql-test/t/information_schema.test:
        cluster -> mysql
      mysql-test/t/mysqldump.test:
        More test to detect memory leaks
      mysql-test/t/ndb_binlog_basic.test:
        cluster -> mysql
      mysql-test/t/ndb_binlog_multi.test:
        cluster -> mysql
      mysql-test/t/ndb_restore_compat.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_bank.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_dd_advance.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_idempotent.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_multi.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_sync.test:
        cluster -> mysql
      mysql-test/t/system_mysql_db_fix.test:
        Drop also binlog_index
      mysql-test/t/upgrade.test:
        Check that tables created with 3.23 works
      mysys/my_error.c:
        Remove all registered errors (to avoid memory leaks)
      mysys/my_init.c:
        call my_error_unregister_all() to avoid some possible memory leaks
      mysys/mysys_priv.h:
        Added prototype
      scripts/mysql_create_system_tables.sh:
        cluster -> mysql
      scripts/mysql_fix_privilege_tables.sql:
        Changed -- to #
        Create binlog_index table if it dosesn't exist
      sql/field.cc:
        Made offset() inline
      sql/field.h:
        Changed prototype of offset() to not make it depending on TABLE structure
      sql/field_conv.cc:
        Removed some usage of current_thd
      sql/ha_ndbcluster_tables.h:
        cluster -> mysql
      sql/item_sum.cc:
        Usage of new 'offset' parameters
      sql/key.cc:
        Changed 'find_ref_key' to not be dependent on field->table
        (This fixed a crash when using a table created in MySQL 3.23)
      sql/mysql_priv.h:
        Changed find_ref_key() to not use field->table
      sql/mysqld.cc:
        Fix that plugin_init() works properly on bootstrap
        (Previously we got warnings from plugin_init)
      sql/sql_class.cc:
        new 'field->offset()'
      sql/sql_select.cc:
        New field->offset()
      sql/table.cc:
        We don't need field->table to be set in find_ref_key() or find_field() anymore.
      storage/archive/ha_archive.cc:
        New field->offset()
      storage/federated/ha_federated.cc:
        New field->offset()
      storage/innobase/handler/ha_innodb.cc:
        Fixed compiler warnings
      storage/myisam/ha_myisam.cc:
        Fixed compiler warnings (Wrong paramter to sprintf())
        New field->offset()
      storage/myisam/ha_myisam.h:
        Fixed wrong type of table_flags
      storage/ndb/tools/restore/Restore.cpp:
        Fixed compiler warning
      mysql-test/r/1st.result:
        New BitKeeper file ``mysql-test/r/1st.result''
      mysql-test/std_data/old_table-323.frm:
        New BitKeeper file ``mysql-test/std_data/old_table-323.frm''
      mysql-test/t/1st.test:
        New BitKeeper file ``mysql-test/t/1st.test''
      22b80d14
  5. 16 Nov, 2006 1 commit
    • unknown's avatar
      This finished the bzero() on varchar patch I wrote a few months ago. It also... · ef260512
      unknown authored
      This finished the bzero() on varchar patch I wrote a few months ago. It also completes the data_length() method I added to Fields to determine the length of data for a particular data type. I have many uses for this :)
      
      
      mysql-test/r/archive.result:
        Added test case results.
      mysql-test/t/archive.test:
        Added varchar specifc test case.
      sql/field.cc:
        Just corrected interface.
      sql/field.h:
        Completed data_length() call.
      storage/archive/ha_archive.cc:
        Corrected warnings, and finished bzero() patch
      ef260512
  6. 09 Nov, 2006 1 commit
    • unknown's avatar
      Bug#21505 Create view - illegal mix of collation for operation 'UNION' · 7856d3fd
      unknown authored
        
        The problem was that any VIEW columns had always implicit derivation.
        Fix: derivation is now copied from the original expression
        given in VIEW definition.
        For example:
        - a VIEW column which comes from a string constant
          in CREATE VIEW definition have now coercible derivation.
        - a VIEW column having COLLATE clause
          in CREATE VIEW definition have now explicit derivation.
      
      
      mysql-test/r/ctype_utf8.result:
        Adding test case
      mysql-test/t/ctype_utf8.test:
        Adding test case
      sql/field.cc:
        Copying derivation from item to field.
      sql/field.h:
        Adding derivation and methods to get/set it into Field.
      sql/item.cc:
        Copying derivation from field to item.
      sql/item.h:
        Moving "enum Derivation" declaration from item.h to mysql_priv.h
      sql/mysql_priv.h:
        Moving "enum Derivation" declaration from item.h to mysql_priv.h
      sql/sql_select.cc:
        Copying derivation from item to field in
        create_tmp_field_from_item() and create_tmp_field().
      7856d3fd
  7. 25 Oct, 2006 1 commit
    • unknown's avatar
      bug #19491 (CAST do DATETIME wrong result) · 8361922e
      unknown authored
      mysql-test/r/type_datetime.result:
        result fixed
      mysql-test/r/type_newdecimal.result:
        result fixed
      mysql-test/t/type_datetime.test:
        testcase
      mysql-test/t/type_newdecimal.test:
        testcase
      sql/field.cc:
        Field_new_decimal::store_time implemented
      sql/field.h:
        Field_new_decimal::store_time added
      sql/item.cc:
        auxiliary methods implemented to operate with datatimes
      sql/item.h:
        auxiliary methods declared in Item to operate with datatimes
      sql/item_timefunc.cc:
        Item_date::save_in_field old implementation removed
      sql/item_timefunc.h:
        my_decimal and save_in_field methods implemented for datetime items
      sql/my_decimal.cc:
        date2my_decimal implemented
      sql/my_decimal.h:
        date2my_decimal declared
      8361922e
  8. 20 Sep, 2006 1 commit
    • unknown's avatar
      Fixed bug #20108. · 4017a533
      unknown authored
      Any default value for a enum fields over UCS2 charsets was corrupted
      when we put it into the frm file, as it had been overwritten by its
      HEX representation.
      To fix it now we save a copy of structure that represents the enum
      type and when putting the default values we use this copy. 
      
      
      mysql-test/r/ctype_ucs.result:
        Added a test case for bug #20108.
      mysql-test/t/ctype_ucs.test:
        Added a test case for bug #20108.
      4017a533
  9. 13 Sep, 2006 1 commit
    • unknown's avatar
      WL#3259 (RBR with more columns on slave than master): · 240218e9
      unknown authored
      Incorporating changes from review.
      Fixing one bug that surfaced.
      
      
      mysql-test/extra/rpl_tests/rpl_row_tabledefs.test:
        Adding tests that UPDATE and DELETE does not generate an error.
      mysql-test/r/rpl_row_tabledefs_2myisam.result:
        Result change.
      mysql-test/r/rpl_row_tabledefs_3innodb.result:
        Result change.
      mysql-test/t/disabled.def:
        Enabling rpl_sp_effects (even though it gives a result mismatch currently).
      sql/field.cc:
        Using constant to denote undefined last null byte.
      sql/field.h:
        Using constant to denote undefined last null byte.
        Adding documentation.
      sql/log_event.cc:
        Not generating error for non-NULL no-DEFAULT columns when updating or deleting row.
        Better documentation and comments.
      sql/rpl_utility.cc:
        Moving documentation to header file.
      sql/rpl_utility.h:
        Documenting class and members.
      240218e9
  10. 16 Aug, 2006 1 commit
    • unknown's avatar
      Cheery picked Antony's patch to allow for Window's builds in 5.1 · e1df39a5
      unknown authored
      BitKeeper/deleted/.del-bt_compact.c:
        Delete: storage/bdb/btree/bt_compact.c
      BitKeeper/deleted/.del-bt_compare.c:
        Delete: storage/bdb/btree/bt_compare.c
      BitKeeper/deleted/.del-bt_conv.c:
        Delete: storage/bdb/btree/bt_conv.c
      BitKeeper/deleted/.del-bt_curadj.c:
        Delete: storage/bdb/btree/bt_curadj.c
      BitKeeper/deleted/.del-bt_cursor.c:
        Delete: storage/bdb/btree/bt_cursor.c
      BitKeeper/deleted/.del-bt_delete.c:
        Delete: storage/bdb/btree/bt_delete.c
      BitKeeper/deleted/.del-bt_method.c:
        Delete: storage/bdb/btree/bt_method.c
      BitKeeper/deleted/.del-bt_open.c:
        Delete: storage/bdb/btree/bt_open.c
      BitKeeper/deleted/.del-bt_put.c:
        Delete: storage/bdb/btree/bt_put.c
      BitKeeper/deleted/.del-bt_rec.c:
        Delete: storage/bdb/btree/bt_rec.c
      BitKeeper/deleted/.del-bt_reclaim.c:
        Delete: storage/bdb/btree/bt_reclaim.c
      BitKeeper/deleted/.del-bt_recno.c:
        Delete: storage/bdb/btree/bt_recno.c
      BitKeeper/deleted/.del-bt_rsearch.c:
        Delete: storage/bdb/btree/bt_rsearch.c
      BitKeeper/deleted/.del-bt_search.c:
        Delete: storage/bdb/btree/bt_search.c
      BitKeeper/deleted/.del-bt_split.c:
        Delete: storage/bdb/btree/bt_split.c
      BitKeeper/deleted/.del-bt_stat.c:
        Delete: storage/bdb/btree/bt_stat.c
      BitKeeper/deleted/.del-.IGNORE_ME:
        Delete: storage/bdb/build_unix/.IGNORE_ME
      BitKeeper/deleted/.del-Berkeley_DB.dsw:
        Delete: storage/bdb/build_win32/Berkeley_DB.dsw
      BitKeeper/deleted/.del-app_dsp.src:
        Delete: storage/bdb/build_win32/app_dsp.src
      BitKeeper/deleted/.del-app_dsp.src~dcf703e0c9c72e4a:
        Delete: storage/bdb/build_win64/app_dsp.src
      BitKeeper/deleted/.del-bt_upgrade.c:
        Delete: storage/bdb/btree/bt_upgrade.c
      BitKeeper/deleted/.del-bt_verify.c:
        Delete: storage/bdb/btree/bt_verify.c
      BitKeeper/deleted/.del-btree.src:
        Delete: storage/bdb/btree/btree.src
      BitKeeper/deleted/.del-db_java_xaj.mak:
        Delete: storage/bdb/build_win32/db_java_xaj.mak
      BitKeeper/deleted/.del-db_test.src:
        Delete: storage/bdb/build_win32/db_test.src
      BitKeeper/deleted/.del-dbkill.cpp:
        Delete: storage/bdb/build_win32/dbkill.cpp
      BitKeeper/deleted/.del-dllmain.c:
        Delete: storage/bdb/build_win32/dllmain.c
      BitKeeper/deleted/.del-dynamic_dsp.src:
        Delete: storage/bdb/build_win32/dynamic_dsp.src
      BitKeeper/deleted/.del-java_dsp.src:
        Delete: storage/bdb/build_win32/java_dsp.src
      BitKeeper/deleted/.del-libdb_tcl.def:
        Delete: storage/bdb/build_win32/libdb_tcl.def
      BitKeeper/deleted/.del-libdbrc.src:
        Delete: storage/bdb/build_win32/libdbrc.src
      BitKeeper/deleted/.del-small_dsp.src:
        Delete: storage/bdb/build_win32/small_dsp.src
      BitKeeper/deleted/.del-srcfile_dsp.src:
        Delete: storage/bdb/build_win32/srcfile_dsp.src
      BitKeeper/deleted/.del-static_dsp.src:
        Delete: storage/bdb/build_win32/static_dsp.src
      BitKeeper/deleted/.del-tcl_dsp.src:
        Delete: storage/bdb/build_win32/tcl_dsp.src
      BitKeeper/deleted/.del-db_test.src~2521827764f86c53:
        Delete: storage/bdb/build_win64/db_test.src
      BitKeeper/deleted/.del-dynamic_dsp.src~95360632a65b4e62:
        Delete: storage/bdb/build_win64/dynamic_dsp.src
      BitKeeper/deleted/.del-ex_repquote.src:
        Delete: storage/bdb/build_win64/ex_repquote.src
      BitKeeper/deleted/.del-getcwd.c:
        Delete: storage/bdb/clib/getcwd.c
      BitKeeper/deleted/.del-getopt.c:
        Delete: storage/bdb/clib/getopt.c
      BitKeeper/deleted/.del-java_dsp.src~e42f32427327f5b5:
        Delete: storage/bdb/build_win64/java_dsp.src
      BitKeeper/deleted/.del-libdbrc.src~d22fea70774c5e98:
        Delete: storage/bdb/build_win64/libdbrc.src
      BitKeeper/deleted/.del-memcmp.c:
        Delete: storage/bdb/clib/memcmp.c
      BitKeeper/deleted/.del-memmove.c:
        Delete: storage/bdb/clib/memmove.c
      BitKeeper/deleted/.del-raise.c:
        Delete: storage/bdb/clib/raise.c
      BitKeeper/deleted/.del-small_dsp.src~96bb604dd8041058:
        Delete: storage/bdb/build_win64/small_dsp.src
      BitKeeper/deleted/.del-snprintf.c:
        Delete: storage/bdb/clib/snprintf.c
      BitKeeper/deleted/.del-srcfile_dsp.src~45382c1414b89bb1:
        Delete: storage/bdb/build_win64/srcfile_dsp.src
      BitKeeper/deleted/.del-static_dsp.src~3f1945d094870d53:
        Delete: storage/bdb/build_win64/static_dsp.src
      BitKeeper/deleted/.del-strcasecmp.c:
        Delete: storage/bdb/clib/strcasecmp.c
      BitKeeper/deleted/.del-strdup.c:
        Delete: storage/bdb/clib/strdup.c
      BitKeeper/deleted/.del-strerror.c:
        Delete: storage/bdb/clib/strerror.c
      BitKeeper/deleted/.del-strtol.c:
        Delete: storage/bdb/clib/strtol.c
      BitKeeper/deleted/.del-tcl_dsp.src~7fd8c5914db07070:
        Delete: storage/bdb/build_win64/tcl_dsp.src
      BitKeeper/deleted/.del-aes_method.c:
        Delete: storage/bdb/crypto/aes_method.c
      BitKeeper/deleted/.del-crypto.c:
        Delete: storage/bdb/crypto/crypto.c
      BitKeeper/deleted/.del-crypto.html:
        Delete: storage/bdb/crypto/crypto.html
      BitKeeper/deleted/.del-crypto_stub.c:
        Delete: storage/bdb/common/crypto_stub.c
      BitKeeper/deleted/.del-db_byteorder.c:
        Delete: storage/bdb/common/db_byteorder.c
      BitKeeper/deleted/.del-db_clock.c:
        Delete: storage/bdb/common/db_clock.c
      BitKeeper/deleted/.del-db_err.c:
        Delete: storage/bdb/common/db_err.c
      BitKeeper/deleted/.del-db_getlong.c:
        Delete: storage/bdb/common/db_getlong.c
      BitKeeper/deleted/.del-db_idspace.c:
        Delete: storage/bdb/common/db_idspace.c
      BitKeeper/deleted/.del-db_log2.c:
        Delete: storage/bdb/common/db_log2.c
      BitKeeper/deleted/.del-mt19937db.c:
        Delete: storage/bdb/crypto/mersenne/mt19937db.c
      BitKeeper/deleted/.del-rijndael-alg-fst.c:
        Delete: storage/bdb/crypto/rijndael/rijndael-alg-fst.c
      BitKeeper/deleted/.del-rijndael-alg-fst.h:
        Delete: storage/bdb/crypto/rijndael/rijndael-alg-fst.h
      BitKeeper/deleted/.del-strtoul.c:
        Delete: storage/bdb/clib/strtoul.c
      BitKeeper/deleted/.del-util_arg.c:
        Delete: storage/bdb/common/util_arg.c
      BitKeeper/deleted/.del-util_cache.c:
        Delete: storage/bdb/common/util_cache.c
      BitKeeper/deleted/.del-util_log.c:
        Delete: storage/bdb/common/util_log.c
      BitKeeper/deleted/.del-util_sig.c:
        Delete: storage/bdb/common/util_sig.c
      BitKeeper/deleted/.del-vsnprintf.c:
        Delete: storage/bdb/clib/vsnprintf.c
      BitKeeper/deleted/.del-crdel.src:
        Delete: storage/bdb/db/crdel.src
      BitKeeper/deleted/.del-crdel_rec.c:
        Delete: storage/bdb/db/crdel_rec.c
      BitKeeper/deleted/.del-cxx_db.cpp:
        Delete: storage/bdb/cxx/cxx_db.cpp
      BitKeeper/deleted/.del-cxx_dbc.cpp:
        Delete: storage/bdb/cxx/cxx_dbc.cpp
      BitKeeper/deleted/.del-cxx_dbt.cpp:
        Delete: storage/bdb/cxx/cxx_dbt.cpp
      BitKeeper/deleted/.del-cxx_env.cpp:
        Delete: storage/bdb/cxx/cxx_env.cpp
      BitKeeper/deleted/.del-cxx_except.cpp:
        Delete: storage/bdb/cxx/cxx_except.cpp
      BitKeeper/deleted/.del-cxx_lock.cpp:
        Delete: storage/bdb/cxx/cxx_lock.cpp
      BitKeeper/deleted/.del-cxx_logc.cpp:
        Delete: storage/bdb/cxx/cxx_logc.cpp
      BitKeeper/deleted/.del-cxx_mpool.cpp:
        Delete: storage/bdb/cxx/cxx_mpool.cpp
      BitKeeper/deleted/.del-cxx_multi.cpp:
        Delete: storage/bdb/cxx/cxx_multi.cpp
      BitKeeper/deleted/.del-cxx_seq.cpp:
        Delete: storage/bdb/cxx/cxx_seq.cpp
      BitKeeper/deleted/.del-cxx_txn.cpp:
        Delete: storage/bdb/cxx/cxx_txn.cpp
      BitKeeper/deleted/.del-db.c:
        Delete: storage/bdb/db/db.c
      BitKeeper/deleted/.del-rijndael-api-fst.c:
        Delete: storage/bdb/crypto/rijndael/rijndael-api-fst.c
      BitKeeper/deleted/.del-rijndael-api-fst.h:
        Delete: storage/bdb/crypto/rijndael/rijndael-api-fst.h
      BitKeeper/deleted/.del-db.src:
        Delete: storage/bdb/db/db.src
      BitKeeper/deleted/.del-db_am.c:
        Delete: storage/bdb/db/db_am.c
      BitKeeper/deleted/.del-db_cam.c:
        Delete: storage/bdb/db/db_cam.c
      BitKeeper/deleted/.del-db_conv.c:
        Delete: storage/bdb/db/db_conv.c
      BitKeeper/deleted/.del-db_dispatch.c:
        Delete: storage/bdb/db/db_dispatch.c
      BitKeeper/deleted/.del-db_dup.c:
        Delete: storage/bdb/db/db_dup.c
      BitKeeper/deleted/.del-db_iface.c:
        Delete: storage/bdb/db/db_iface.c
      BitKeeper/deleted/.del-db_join.c:
        Delete: storage/bdb/db/db_join.c
      BitKeeper/deleted/.del-db_meta.c:
        Delete: storage/bdb/db/db_meta.c
      BitKeeper/deleted/.del-db_method.c:
        Delete: storage/bdb/db/db_method.c
      BitKeeper/deleted/.del-db_open.c:
        Delete: storage/bdb/db/db_open.c
      BitKeeper/deleted/.del-db_overflow.c:
        Delete: storage/bdb/db/db_overflow.c
      BitKeeper/deleted/.del-db_ovfl_vrfy.c:
        Delete: storage/bdb/db/db_ovfl_vrfy.c
      BitKeeper/deleted/.del-db_pr.c:
        Delete: storage/bdb/db/db_pr.c
      BitKeeper/deleted/.del-db_rec.c:
        Delete: storage/bdb/db/db_rec.c
      BitKeeper/deleted/.del-db_reclaim.c:
        Delete: storage/bdb/db/db_reclaim.c
      BitKeeper/deleted/.del-db_remove.c:
        Delete: storage/bdb/db/db_remove.c
      BitKeeper/deleted/.del-db_rename.c:
        Delete: storage/bdb/db/db_rename.c
      BitKeeper/deleted/.del-db_ret.c:
        Delete: storage/bdb/db/db_ret.c
      BitKeeper/deleted/.del-db185.c:
        Delete: storage/bdb/db185/db185.c
      BitKeeper/deleted/.del-db185_int.in:
        Delete: storage/bdb/db185/db185_int.in
      BitKeeper/deleted/.del-db_archive.c:
        Delete: storage/bdb/db_archive/db_archive.c
      BitKeeper/deleted/.del-db_checkpoint.c:
        Delete: storage/bdb/db_checkpoint/db_checkpoint.c
      BitKeeper/deleted/.del-db_deadlock.c:
        Delete: storage/bdb/db_deadlock/db_deadlock.c
      BitKeeper/deleted/.del-db_dump.c:
        Delete: storage/bdb/db_dump/db_dump.c
      BitKeeper/deleted/.del-db_dump185.c:
        Delete: storage/bdb/db_dump185/db_dump185.c
      BitKeeper/deleted/.del-db_hotbackup.c:
        Delete: storage/bdb/db_hotbackup/db_hotbackup.c
      BitKeeper/deleted/.del-db_load.c:
        Delete: storage/bdb/db_load/db_load.c
      BitKeeper/deleted/.del-db_setid.c:
        Delete: storage/bdb/db/db_setid.c
      BitKeeper/deleted/.del-db_setlsn.c:
        Delete: storage/bdb/db/db_setlsn.c
      BitKeeper/deleted/.del-db_stati.c:
        Delete: storage/bdb/db/db_stati.c
      BitKeeper/deleted/.del-db_truncate.c:
        Delete: storage/bdb/db/db_truncate.c
      BitKeeper/deleted/.del-db_upg.c:
        Delete: storage/bdb/db/db_upg.c
      BitKeeper/deleted/.del-db_upg_opd.c:
        Delete: storage/bdb/db/db_upg_opd.c
      BitKeeper/deleted/.del-db_vrfy.c:
        Delete: storage/bdb/db/db_vrfy.c
      BitKeeper/deleted/.del-db_vrfy_stub.c:
        Delete: storage/bdb/db/db_vrfy_stub.c
      BitKeeper/deleted/.del-db_vrfyutil.c:
        Delete: storage/bdb/db/db_vrfyutil.c
      BitKeeper/deleted/.del-README:
        Delete: storage/bdb/db_printlog/README
      BitKeeper/deleted/.del-btree.h:
        Delete: storage/bdb/dbinc/btree.h
      BitKeeper/deleted/.del-commit.awk:
        Delete: storage/bdb/db_printlog/commit.awk
      BitKeeper/deleted/.del-count.awk:
        Delete: storage/bdb/db_printlog/count.awk
      BitKeeper/deleted/.del-db_printlog.c:
        Delete: storage/bdb/db_printlog/db_printlog.c
      BitKeeper/deleted/.del-db_recover.c:
        Delete: storage/bdb/db_recover/db_recover.c
      BitKeeper/deleted/.del-db_stat.c:
        Delete: storage/bdb/db_stat/db_stat.c
      BitKeeper/deleted/.del-db_upgrade.c:
        Delete: storage/bdb/db_upgrade/db_upgrade.c
      BitKeeper/deleted/.del-db_verify.c:
        Delete: storage/bdb/db_verify/db_verify.c
      BitKeeper/deleted/.del-dbname.awk:
        Delete: storage/bdb/db_printlog/dbname.awk
      BitKeeper/deleted/.del-dd.sh:
        Delete: storage/bdb/db_stat/dd.sh
      BitKeeper/deleted/.del-fileid.awk:
        Delete: storage/bdb/db_printlog/fileid.awk
      BitKeeper/deleted/.del-logstat.awk:
        Delete: storage/bdb/db_printlog/logstat.awk
      BitKeeper/deleted/.del-pgno.awk:
        Delete: storage/bdb/db_printlog/pgno.awk
      BitKeeper/deleted/.del-range.awk:
        Delete: storage/bdb/db_printlog/range.awk
      BitKeeper/deleted/.del-rectype.awk:
        Delete: storage/bdb/db_printlog/rectype.awk
      BitKeeper/deleted/.del-status.awk:
        Delete: storage/bdb/db_printlog/status.awk
      BitKeeper/deleted/.del-txn.awk:
        Delete: storage/bdb/db_printlog/txn.awk
      BitKeeper/deleted/.del-crypto.h:
        Delete: storage/bdb/dbinc/crypto.h
      BitKeeper/deleted/.del-cxx_common.h:
        Delete: storage/bdb/dbinc/cxx_common.h
      BitKeeper/deleted/.del-cxx_except.h:
        Delete: storage/bdb/dbinc/cxx_except.h
      BitKeeper/deleted/.del-cxx_int.h:
        Delete: storage/bdb/dbinc/cxx_int.h
      BitKeeper/deleted/.del-db.in:
        Delete: storage/bdb/dbinc/db.in
      BitKeeper/deleted/.del-db_185.in:
        Delete: storage/bdb/dbinc/db_185.in
      BitKeeper/deleted/.del-db_am.h:
        Delete: storage/bdb/dbinc/db_am.h
      BitKeeper/deleted/.del-db_cxx.in:
        Delete: storage/bdb/dbinc/db_cxx.in
      BitKeeper/deleted/.del-db_dispatch.h:
        Delete: storage/bdb/dbinc/db_dispatch.h
      BitKeeper/deleted/.del-db_int.in:
        Delete: storage/bdb/dbinc/db_int.in
      BitKeeper/deleted/.del-db_join.h:
        Delete: storage/bdb/dbinc/db_join.h
      BitKeeper/deleted/.del-db_page.h:
        Delete: storage/bdb/dbinc/db_page.h
      BitKeeper/deleted/.del-db_server_int.h:
        Delete: storage/bdb/dbinc/db_server_int.h
      BitKeeper/deleted/.del-db_shash.h:
        Delete: storage/bdb/dbinc/db_shash.h
      BitKeeper/deleted/.del-db_swap.h:
        Delete: storage/bdb/dbinc/db_swap.h
      BitKeeper/deleted/.del-db_upgrade.h:
        Delete: storage/bdb/dbinc/db_upgrade.h
      BitKeeper/deleted/.del-db_verify.h:
        Delete: storage/bdb/dbinc/db_verify.h
      BitKeeper/deleted/.del-debug.h:
        Delete: storage/bdb/dbinc/debug.h
      BitKeeper/deleted/.del-fop.h:
        Delete: storage/bdb/dbinc/fop.h
      BitKeeper/deleted/.del-globals.h:
        Delete: storage/bdb/dbinc/globals.h
      BitKeeper/deleted/.del-hash.h:
        Delete: storage/bdb/dbinc/hash.h
      BitKeeper/deleted/.del-hmac.h:
        Delete: storage/bdb/dbinc/hmac.h
      BitKeeper/deleted/.del-lock.h:
        Delete: storage/bdb/dbinc/lock.h
      BitKeeper/deleted/.del-log.h:
        Delete: storage/bdb/dbinc/log.h
      BitKeeper/deleted/.del-mp.h:
        Delete: storage/bdb/dbinc/mp.h
      BitKeeper/deleted/.del-mutex.h:
        Delete: storage/bdb/dbinc/mutex.h
      BitKeeper/deleted/.del-mutex_int.h:
        Delete: storage/bdb/dbinc/mutex_int.h
      BitKeeper/deleted/.del-os.h:
        Delete: storage/bdb/dbinc/os.h
      BitKeeper/deleted/.del-qam.h:
        Delete: storage/bdb/dbinc/qam.h
      BitKeeper/deleted/.del-queue.h:
        Delete: storage/bdb/dbinc/queue.h
      BitKeeper/deleted/.del-region.h:
        Delete: storage/bdb/dbinc/region.h
      BitKeeper/deleted/.del-rep.h:
        Delete: storage/bdb/dbinc/rep.h
      BitKeeper/deleted/.del-shqueue.h:
        Delete: storage/bdb/dbinc/shqueue.h
      BitKeeper/deleted/.del-tcl_db.h:
        Delete: storage/bdb/dbinc/tcl_db.h
      BitKeeper/deleted/.del-txn.h:
        Delete: storage/bdb/dbinc/txn.h
      BitKeeper/deleted/.del-xa.h:
        Delete: storage/bdb/dbinc/xa.h
      BitKeeper/deleted/.del-.empty:
        Delete: storage/bdb/dbinc_auto/.empty
      BitKeeper/deleted/.del-Makefile.in~c0ea38ee72675ab4:
        Delete: storage/bdb/dist/Makefile.in
      BitKeeper/deleted/.del-RELEASE:
        Delete: storage/bdb/dist/RELEASE
      BitKeeper/deleted/.del-buildrel:
        Delete: storage/bdb/dist/buildrel
      BitKeeper/deleted/.del-config.guess:
        Delete: storage/bdb/dist/config.guess
      BitKeeper/deleted/.del-config.sub:
        Delete: storage/bdb/dist/config.sub
      BitKeeper/deleted/.del-configure.ac:
        Delete: storage/bdb/dist/configure.ac
      BitKeeper/deleted/.del-db.ecd.in:
        Delete: storage/bdb/dist/db.ecd.in
      BitKeeper/deleted/.del-db.spec.in:
        Delete: storage/bdb/dist/db.spec.in
      BitKeeper/deleted/.del-dbm.c:
        Delete: storage/bdb/dbm/dbm.c
      BitKeeper/deleted/.del-dbreg.c:
        Delete: storage/bdb/dbreg/dbreg.c
      BitKeeper/deleted/.del-dbreg.src:
        Delete: storage/bdb/dbreg/dbreg.src
      BitKeeper/deleted/.del-dbreg_rec.c:
        Delete: storage/bdb/dbreg/dbreg_rec.c
      BitKeeper/deleted/.del-dbreg_stat.c:
        Delete: storage/bdb/dbreg/dbreg_stat.c
      BitKeeper/deleted/.del-dbreg_util.c:
        Delete: storage/bdb/dbreg/dbreg_util.c
      BitKeeper/deleted/.del-gen_inc.awk:
        Delete: storage/bdb/dist/gen_inc.awk
      BitKeeper/deleted/.del-gen_rec.awk:
        Delete: storage/bdb/dist/gen_rec.awk
      BitKeeper/deleted/.del-gen_rpc.awk:
        Delete: storage/bdb/dist/gen_rpc.awk
      BitKeeper/deleted/.del-install-sh:
        Delete: storage/bdb/dist/install-sh
      BitKeeper/deleted/.del-ltmain.sh:
        Delete: storage/bdb/dist/ltmain.sh
      BitKeeper/deleted/.del-pubdef.in:
        Delete: storage/bdb/dist/pubdef.in
      BitKeeper/deleted/.del-s_all:
        Delete: storage/bdb/dist/s_all
      BitKeeper/deleted/.del-s_config:
        Delete: storage/bdb/dist/s_config
      BitKeeper/deleted/.del-s_crypto:
        Delete: storage/bdb/dist/s_crypto
      BitKeeper/deleted/.del-s_dir:
        Delete: storage/bdb/dist/s_dir
      BitKeeper/deleted/.del-s_include:
        Delete: storage/bdb/dist/s_include
      BitKeeper/deleted/.del-s_java_const:
        Delete: storage/bdb/dist/s_java_const
      BitKeeper/deleted/.del-s_java_stat:
        Delete: storage/bdb/dist/s_java_stat
      BitKeeper/deleted/.del-s_java_swig:
        Delete: storage/bdb/dist/s_java_swig
      BitKeeper/deleted/.del-s_javah:
        Delete: storage/bdb/dist/s_javah
      BitKeeper/deleted/.del-s_java:
        Delete: storage/bdb/dist/s_java
      BitKeeper/deleted/.del-s_je2db:
        Delete: storage/bdb/dist/s_je2db
      BitKeeper/deleted/.del-s_perm:
        Delete: storage/bdb/dist/s_perm
      BitKeeper/deleted/.del-s_readme:
        Delete: storage/bdb/dist/s_readme
      BitKeeper/deleted/.del-s_recover:
        Delete: storage/bdb/dist/s_recover
      BitKeeper/deleted/.del-s_rpc:
        Delete: storage/bdb/dist/s_rpc
      BitKeeper/deleted/.del-s_symlink:
        Delete: storage/bdb/dist/s_symlink
      BitKeeper/deleted/.del-config.ac:
        Delete: storage/bdb/dist/aclocal/config.ac
      BitKeeper/deleted/.del-cxx.ac:
        Delete: storage/bdb/dist/aclocal/cxx.ac
      BitKeeper/deleted/.del-gcc.ac:
        Delete: storage/bdb/dist/aclocal/gcc.ac
      BitKeeper/deleted/.del-libtool.ac:
        Delete: storage/bdb/dist/aclocal/libtool.ac
      BitKeeper/deleted/.del-mutex.ac:
        Delete: storage/bdb/dist/aclocal/mutex.ac
      BitKeeper/deleted/.del-options.ac:
        Delete: storage/bdb/dist/aclocal/options.ac
      BitKeeper/deleted/.del-programs.ac:
        Delete: storage/bdb/dist/aclocal/programs.ac
      BitKeeper/deleted/.del-s_tags:
        Delete: storage/bdb/dist/s_tags
      BitKeeper/deleted/.del-s_test:
        Delete: storage/bdb/dist/s_test
      BitKeeper/deleted/.del-s_vxworks:
        Delete: storage/bdb/dist/s_vxworks
      BitKeeper/deleted/.del-s_win32_dsp:
        Delete: storage/bdb/dist/s_win32_dsp
      BitKeeper/deleted/.del-s_win32:
        Delete: storage/bdb/dist/s_win32
      BitKeeper/deleted/.del-s_winmsi:
        Delete: storage/bdb/dist/s_winmsi
      BitKeeper/deleted/.del-srcfiles.in:
        Delete: storage/bdb/dist/srcfiles.in
      BitKeeper/deleted/.del-vx_buildcd:
        Delete: storage/bdb/dist/vx_buildcd
      BitKeeper/deleted/.del-vx_config.in:
        Delete: storage/bdb/dist/vx_config.in
      BitKeeper/deleted/.del-win_config.in:
        Delete: storage/bdb/dist/win_config.in
      BitKeeper/deleted/.del-win_db.in:
        Delete: storage/bdb/dist/win_db.in
      BitKeeper/deleted/.del-win_exports.in:
        Delete: storage/bdb/dist/win_exports.in
      BitKeeper/deleted/.del-ac_check_class.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_check_class.ac
      BitKeeper/deleted/.del-ac_check_classpath.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_check_classpath.ac
      BitKeeper/deleted/.del-ac_check_junit.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_check_junit.ac
      BitKeeper/deleted/.del-ac_check_rqrd_class.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_check_rqrd_class.ac
      BitKeeper/deleted/.del-ac_java_options.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_java_options.ac
      BitKeeper/deleted/.del-ac_jni_include_dirs.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_jni_include_dirs.ac
      BitKeeper/deleted/.del-ac_prog_jar.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_prog_jar.ac
      BitKeeper/deleted/.del-ac_prog_java.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_prog_java.ac
      BitKeeper/deleted/.del-ac_prog_java_works.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_prog_java_works.ac
      BitKeeper/deleted/.del-ac_prog_javac.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_prog_javac.ac
      BitKeeper/deleted/.del-ac_prog_javac_works.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_prog_javac_works.ac
      BitKeeper/deleted/.del-ac_prog_javadoc.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_prog_javadoc.ac
      BitKeeper/deleted/.del-ac_prog_javah.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_prog_javah.ac
      BitKeeper/deleted/.del-rpc.ac:
        Delete: storage/bdb/dist/aclocal/rpc.ac
      BitKeeper/deleted/.del-sequence.ac:
        Delete: storage/bdb/dist/aclocal/sequence.ac
      BitKeeper/deleted/.del-sosuffix.ac:
        Delete: storage/bdb/dist/aclocal/sosuffix.ac
      BitKeeper/deleted/.del-tcl.ac:
        Delete: storage/bdb/dist/aclocal/tcl.ac
      BitKeeper/deleted/.del-types.ac:
        Delete: storage/bdb/dist/aclocal/types.ac
      BitKeeper/deleted/.del-BerkeleyDB.wpj:
        Delete: storage/bdb/dist/vx_2.0/BerkeleyDB.wpj
      BitKeeper/deleted/.del-BerkeleyDB.wpj~320150f7956cd770:
        Delete: storage/bdb/dist/vx_2.2/BerkeleyDB.wpj
      BitKeeper/deleted/.del-BerkeleyDBsmall.wpj:
        Delete: storage/bdb/dist/vx_2.0/BerkeleyDBsmall.wpj
      BitKeeper/deleted/.del-BerkeleyDBsmall.wpj~4c4d7f40dbf1664d:
        Delete: storage/bdb/dist/vx_2.2/BerkeleyDBsmall.wpj
      BitKeeper/deleted/.del-Makefile.custom:
        Delete: storage/bdb/dist/vx_3.1/Makefile.custom
      BitKeeper/deleted/.del-ac_try_compile_java.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_try_compile_java.ac
      BitKeeper/deleted/.del-ac_try_run_javac.ac:
        Delete: storage/bdb/dist/aclocal_java/ac_try_run_javac.ac
      BitKeeper/deleted/.del-cdf.1:
        Delete: storage/bdb/dist/vx_3.1/cdf.1
      BitKeeper/deleted/.del-cdf.2:
        Delete: storage/bdb/dist/vx_3.1/cdf.2
      BitKeeper/deleted/.del-cdf.3:
        Delete: storage/bdb/dist/vx_3.1/cdf.3
      BitKeeper/deleted/.del-component.cdf:
        Delete: storage/bdb/dist/vx_3.1/component.cdf
      BitKeeper/deleted/.del-component.wpj:
        Delete: storage/bdb/dist/vx_3.1/component.wpj
      BitKeeper/deleted/.del-rec_ctemp:
        Delete: storage/bdb/dist/template/rec_ctemp
      BitKeeper/deleted/.del-rec_rep:
        Delete: storage/bdb/dist/template/rec_rep
      BitKeeper/deleted/.del-wpj.1:
        Delete: storage/bdb/dist/vx_3.1/wpj.1
      BitKeeper/deleted/.del-wpj.2:
        Delete: storage/bdb/dist/vx_3.1/wpj.2
      BitKeeper/deleted/.del-wpj.in:
        Delete: storage/bdb/dist/vx_2.0/wpj.in
      BitKeeper/deleted/.del-wpj.in~cd8fd754cedb37b2:
        Delete: storage/bdb/dist/vx_2.2/wpj.in
      BitKeeper/deleted/.del-CONFIG.in:
        Delete: storage/bdb/dist/vx_setup/CONFIG.in
      BitKeeper/deleted/.del-LICENSE.TXT:
        Delete: storage/bdb/dist/vx_setup/LICENSE.TXT
      BitKeeper/deleted/.del-MESSAGES.TCL:
        Delete: storage/bdb/dist/vx_setup/MESSAGES.TCL
      BitKeeper/deleted/.del-README.in:
        Delete: storage/bdb/dist/vx_setup/README.in
      BitKeeper/deleted/.del-SETUP.BMP:
        Delete: storage/bdb/dist/vx_setup/SETUP.BMP
      BitKeeper/deleted/.del-dbcorewix.in:
        Delete: storage/bdb/dist/winmsi/dbcorewix.in
      BitKeeper/deleted/.del-dbvarsbat.in:
        Delete: storage/bdb/dist/winmsi/dbvarsbat.in
      BitKeeper/deleted/.del-dbwix.m4:
        Delete: storage/bdb/dist/winmsi/dbwix.m4
      BitKeeper/deleted/.del-environment.in:
        Delete: storage/bdb/dist/winmsi/environment.in
      BitKeeper/deleted/.del-features.in:
        Delete: storage/bdb/dist/winmsi/features.in
      BitKeeper/deleted/.del-files.in:
        Delete: storage/bdb/dist/winmsi/files.in
      BitKeeper/deleted/.del-links.in:
        Delete: storage/bdb/dist/winmsi/links.in
      BitKeeper/deleted/.del-s_winmsi.fcn:
        Delete: storage/bdb/dist/winmsi/s_winmsi.fcn
      BitKeeper/deleted/.del-vx_allfile.in:
        Delete: storage/bdb/dist/vx_setup/vx_allfile.in
      BitKeeper/deleted/.del-vx_demofile.in:
        Delete: storage/bdb/dist/vx_setup/vx_demofile.in
      BitKeeper/deleted/.del-vx_setup.in:
        Delete: storage/bdb/dist/vx_setup/vx_setup.in
      BitKeeper/deleted/.del-wpj.3:
        Delete: storage/bdb/dist/vx_3.1/wpj.3
      BitKeeper/deleted/.del-wpj.4:
        Delete: storage/bdb/dist/vx_3.1/wpj.4
      BitKeeper/deleted/.del-wpj.5:
        Delete: storage/bdb/dist/vx_3.1/wpj.5
      BitKeeper/deleted/.del-caticon.ibd:
        Delete: storage/bdb/dist/winmsi/images/caticon.ibd
      BitKeeper/deleted/.del-db_salloc.c:
        Delete: storage/bdb/env/db_salloc.c
      BitKeeper/deleted/.del-db_shash.c:
        Delete: storage/bdb/env/db_shash.c
      BitKeeper/deleted/.del-env_failchk.c:
        Delete: storage/bdb/env/env_failchk.c
      BitKeeper/deleted/.del-env_file.c:
        Delete: storage/bdb/env/env_file.c
      BitKeeper/deleted/.del-env_method.c.b:
        Delete: storage/bdb/env/env_method.c.b
      BitKeeper/deleted/.del-env_method.c:
        Delete: storage/bdb/env/env_method.c
      BitKeeper/deleted/.del-env_open.c:
        Delete: storage/bdb/env/env_open.c
      BitKeeper/deleted/.del-env_recover.c:
        Delete: storage/bdb/env/env_recover.c
      BitKeeper/deleted/.del-env_region.c:
        Delete: storage/bdb/env/env_region.c
      BitKeeper/deleted/.del-env_register.c:
        Delete: storage/bdb/env/env_register.c
      BitKeeper/deleted/.del-env_stat.c:
        Delete: storage/bdb/env/env_stat.c
      BitKeeper/deleted/.del-fileops.src:
        Delete: storage/bdb/fileops/fileops.src
      BitKeeper/deleted/.del-foldernew.ibd:
        Delete: storage/bdb/dist/winmsi/images/foldernew.ibd
      BitKeeper/deleted/.del-folderup.ibd:
        Delete: storage/bdb/dist/winmsi/images/folderup.ibd
      BitKeeper/deleted/.del-sleepycat.jpg:
        Delete: storage/bdb/dist/winmsi/images/sleepycat.jpg
      BitKeeper/deleted/.del-topstripe.ibd:
        Delete: storage/bdb/dist/winmsi/images/topstripe.ibd
      BitKeeper/deleted/.del-webicon.ico:
        Delete: storage/bdb/dist/winmsi/images/webicon.ico
      BitKeeper/deleted/.del-winbuild.bat:
        Delete: storage/bdb/dist/winmsi/winbuild.bat
      BitKeeper/deleted/.del-fop_basic.c:
        Delete: storage/bdb/fileops/fop_basic.c
      BitKeeper/deleted/.del-fop_rec.c:
        Delete: storage/bdb/fileops/fop_rec.c
      BitKeeper/deleted/.del-fop_util.c:
        Delete: storage/bdb/fileops/fop_util.c
      BitKeeper/deleted/.del-hash.c:
        Delete: storage/bdb/hash/hash.c
      BitKeeper/deleted/.del-hash.src:
        Delete: storage/bdb/hash/hash.src
      BitKeeper/deleted/.del-hash_conv.c:
        Delete: storage/bdb/hash/hash_conv.c
      BitKeeper/deleted/.del-hash_dup.c:
        Delete: storage/bdb/hash/hash_dup.c
      BitKeeper/deleted/.del-hash_func.c:
        Delete: storage/bdb/hash/hash_func.c
      BitKeeper/deleted/.del-hash_meta.c:
        Delete: storage/bdb/hash/hash_meta.c
      BitKeeper/deleted/.del-hash_method.c:
        Delete: storage/bdb/hash/hash_method.c
      BitKeeper/deleted/.del-hash_open.c:
        Delete: storage/bdb/hash/hash_open.c
      BitKeeper/deleted/.del-hash_page.c:
        Delete: storage/bdb/hash/hash_page.c
      BitKeeper/deleted/.del-hash_rec.c:
        Delete: storage/bdb/hash/hash_rec.c
      BitKeeper/deleted/.del-hash_reclaim.c:
        Delete: storage/bdb/hash/hash_reclaim.c
      BitKeeper/deleted/.del-hash_stat.c:
        Delete: storage/bdb/hash/hash_stat.c
      BitKeeper/deleted/.del-hash_stub.c:
        Delete: storage/bdb/hash/hash_stub.c
      BitKeeper/deleted/.del-hash_upgrade.c:
        Delete: storage/bdb/hash/hash_upgrade.c
      BitKeeper/deleted/.del-hash_verify.c:
        Delete: storage/bdb/hash/hash_verify.c
      BitKeeper/deleted/.del-Design:
        Delete: storage/bdb/lock/Design
      BitKeeper/deleted/.del-hmac.c:
        Delete: storage/bdb/hmac/hmac.c
      BitKeeper/deleted/.del-hsearch.c:
        Delete: storage/bdb/hsearch/hsearch.c
      BitKeeper/deleted/.del-lock.c:
        Delete: storage/bdb/lock/lock.c
      BitKeeper/deleted/.del-lock_deadlock.c:
        Delete: storage/bdb/lock/lock_deadlock.c
      BitKeeper/deleted/.del-lock_failchk.c:
        Delete: storage/bdb/lock/lock_failchk.c
      BitKeeper/deleted/.del-lock_id.c:
        Delete: storage/bdb/lock/lock_id.c
      BitKeeper/deleted/.del-lock_list.c:
        Delete: storage/bdb/lock/lock_list.c
      BitKeeper/deleted/.del-lock_method.c:
        Delete: storage/bdb/lock/lock_method.c
      BitKeeper/deleted/.del-lock_region.c:
        Delete: storage/bdb/lock/lock_region.c
      BitKeeper/deleted/.del-lock_stat.c:
        Delete: storage/bdb/lock/lock_stat.c
      BitKeeper/deleted/.del-lock_timer.c:
        Delete: storage/bdb/lock/lock_timer.c
      BitKeeper/deleted/.del-lock_util.c:
        Delete: storage/bdb/lock/lock_util.c
      BitKeeper/deleted/.del-log.c:
        Delete: storage/bdb/log/log.c
      BitKeeper/deleted/.del-log_archive.c:
        Delete: storage/bdb/log/log_archive.c
      BitKeeper/deleted/.del-log_compare.c:
        Delete: storage/bdb/log/log_compare.c
      BitKeeper/deleted/.del-log_debug.c:
        Delete: storage/bdb/log/log_debug.c
      BitKeeper/deleted/.del-log_get.c:
        Delete: storage/bdb/log/log_get.c
      BitKeeper/deleted/.del-sha1.c:
        Delete: storage/bdb/hmac/sha1.c
      BitKeeper/deleted/.del-README~cce8f408842aa70c:
        Delete: storage/bdb/mutex/README
      BitKeeper/deleted/.del-log_method.c:
        Delete: storage/bdb/log/log_method.c
      BitKeeper/deleted/.del-log_put.c:
        Delete: storage/bdb/log/log_put.c
      BitKeeper/deleted/.del-log_stat.c:
        Delete: storage/bdb/log/log_stat.c
      BitKeeper/deleted/.del-mp_alloc.c:
        Delete: storage/bdb/mp/mp_alloc.c
      BitKeeper/deleted/.del-mp_bh.c:
        Delete: storage/bdb/mp/mp_bh.c
      BitKeeper/deleted/.del-mp_fget.c:
        Delete: storage/bdb/mp/mp_fget.c
      BitKeeper/deleted/.del-mp_fmethod.c:
        Delete: storage/bdb/mp/mp_fmethod.c
      BitKeeper/deleted/.del-mp_fopen.c:
        Delete: storage/bdb/mp/mp_fopen.c
      BitKeeper/deleted/.del-mp_fput.c:
        Delete: storage/bdb/mp/mp_fput.c
      BitKeeper/deleted/.del-mp_fset.c:
        Delete: storage/bdb/mp/mp_fset.c
      BitKeeper/deleted/.del-mp_method.c:
        Delete: storage/bdb/mp/mp_method.c
      BitKeeper/deleted/.del-mp_region.c:
        Delete: storage/bdb/mp/mp_region.c
      BitKeeper/deleted/.del-mp_register.c:
        Delete: storage/bdb/mp/mp_register.c
      BitKeeper/deleted/.del-mp_stat.c:
        Delete: storage/bdb/mp/mp_stat.c
      BitKeeper/deleted/.del-mp_sync.c:
        Delete: storage/bdb/mp/mp_sync.c
      BitKeeper/deleted/.del-mp_trickle.c:
        Delete: storage/bdb/mp/mp_trickle.c
      BitKeeper/deleted/.del-mut_alloc.c:
        Delete: storage/bdb/mutex/mut_alloc.c
      BitKeeper/deleted/.del-mut_fcntl.c:
        Delete: storage/bdb/mutex/mut_fcntl.c
      BitKeeper/deleted/.del-mut_method.c:
        Delete: storage/bdb/mutex/mut_method.c
      BitKeeper/deleted/.del-mut_pthread.c:
        Delete: storage/bdb/mutex/mut_pthread.c
      BitKeeper/deleted/.del-mut_region.c:
        Delete: storage/bdb/mutex/mut_region.c
      BitKeeper/deleted/.del-mut_stat.c:
        Delete: storage/bdb/mutex/mut_stat.c
      BitKeeper/deleted/.del-mut_tas.c:
        Delete: storage/bdb/mutex/mut_tas.c
      BitKeeper/deleted/.del-mut_win32.c:
        Delete: storage/bdb/mutex/mut_win32.c
      BitKeeper/deleted/.del-os_abs.c:
        Delete: storage/bdb/os/os_abs.c
      BitKeeper/deleted/.del-os_alloc.c:
        Delete: storage/bdb/os/os_alloc.c
      BitKeeper/deleted/.del-os_clock.c:
        Delete: storage/bdb/os/os_clock.c
      BitKeeper/deleted/.del-os_config.c:
        Delete: storage/bdb/os/os_config.c
      BitKeeper/deleted/.del-os_dir.c:
        Delete: storage/bdb/os/os_dir.c
      BitKeeper/deleted/.del-os_errno.c:
        Delete: storage/bdb/os/os_errno.c
      BitKeeper/deleted/.del-os_fid.c:
        Delete: storage/bdb/os/os_fid.c
      BitKeeper/deleted/.del-os_flock.c:
        Delete: storage/bdb/os/os_flock.c
      BitKeeper/deleted/.del-tm.c:
        Delete: storage/bdb/mutex/tm.c
      BitKeeper/deleted/.del-uts4_cc.s:
        Delete: storage/bdb/mutex/uts4_cc.s
      BitKeeper/deleted/.del-os_fsync.c:
        Delete: storage/bdb/os/os_fsync.c
      BitKeeper/deleted/.del-os_handle.c:
        Delete: storage/bdb/os/os_handle.c
      BitKeeper/deleted/.del-os_id.c:
        Delete: storage/bdb/os/os_id.c
      BitKeeper/deleted/.del-os_map.c:
        Delete: storage/bdb/os/os_map.c
      BitKeeper/deleted/.del-os_method.c:
        Delete: storage/bdb/os/os_method.c
      BitKeeper/deleted/.del-os_mkdir.c:
        Delete: storage/bdb/os/os_mkdir.c
      BitKeeper/deleted/.del-os_oflags.c:
        Delete: storage/bdb/os/os_oflags.c
      BitKeeper/deleted/.del-os_open.c:
        Delete: storage/bdb/os/os_open.c
      BitKeeper/deleted/.del-os_region.c:
        Delete: storage/bdb/os/os_region.c
      BitKeeper/deleted/.del-os_rename.c:
        Delete: storage/bdb/os/os_rename.c
      BitKeeper/deleted/.del-os_root.c:
        Delete: storage/bdb/os/os_root.c
      BitKeeper/deleted/.del-os_rpath.c:
        Delete: storage/bdb/os/os_rpath.c
      BitKeeper/deleted/.del-os_rw.c:
        Delete: storage/bdb/os/os_rw.c
      BitKeeper/deleted/.del-os_seek.c:
        Delete: storage/bdb/os/os_seek.c
      BitKeeper/deleted/.del-os_sleep.c:
        Delete: storage/bdb/os/os_sleep.c
      BitKeeper/deleted/.del-os_spin.c:
        Delete: storage/bdb/os/os_spin.c
      BitKeeper/deleted/.del-os_stat.c:
        Delete: storage/bdb/os/os_stat.c
      BitKeeper/deleted/.del-os_tmpdir.c:
        Delete: storage/bdb/os/os_tmpdir.c
      BitKeeper/deleted/.del-os_truncate.c:
        Delete: storage/bdb/os/os_truncate.c
      BitKeeper/deleted/.del-os_abs.c~ad5b599d8bf6549f:
        Delete: storage/bdb/os_win32/os_abs.c
      BitKeeper/deleted/.del-os_clock.c~2add52eff231a274:
        Delete: storage/bdb/os_win32/os_clock.c
      BitKeeper/deleted/.del-os_config.c~53e193a5e5e97cfd:
        Delete: storage/bdb/os_win32/os_config.c
      BitKeeper/deleted/.del-os_dir.c~99fbc266717a871a:
        Delete: storage/bdb/os_win32/os_dir.c
      BitKeeper/deleted/.del-os_errno.c~44204df07323cffb:
        Delete: storage/bdb/os_win32/os_errno.c
      BitKeeper/deleted/.del-os_fid.c~8f922f06a0fa5a0:
        Delete: storage/bdb/os_win32/os_fid.c
      BitKeeper/deleted/.del-os_flock.c~cc35099adbda7408:
        Delete: storage/bdb/os_win32/os_flock.c
      BitKeeper/deleted/.del-os_fsync.c~eebb7e558dacef1c:
        Delete: storage/bdb/os_win32/os_fsync.c
      BitKeeper/deleted/.del-os_handle.c~281e6b79ac5147f1:
        Delete: storage/bdb/os_win32/os_handle.c
      BitKeeper/deleted/.del-os_map.c~e8726a67b9abaa30:
        Delete: storage/bdb/os_win32/os_map.c
      BitKeeper/deleted/.del-os_open.c~996e9987793f8dbc:
        Delete: storage/bdb/os_win32/os_open.c
      BitKeeper/deleted/.del-os_rename.c~1c318d0b60c977bd:
        Delete: storage/bdb/os_win32/os_rename.c
      BitKeeper/deleted/.del-os_rw.c~7ec61bd993fe999f:
        Delete: storage/bdb/os_win32/os_rw.c
      BitKeeper/deleted/.del-os_seek.c~2b5bef3cccfa60c:
        Delete: storage/bdb/os_win32/os_seek.c
      BitKeeper/deleted/.del-os_sleep.c~d0512f5626e7c40b:
        Delete: storage/bdb/os_win32/os_sleep.c
      BitKeeper/deleted/.del-os_spin.c~e2abf23edb5bac39:
        Delete: storage/bdb/os_win32/os_spin.c
      BitKeeper/deleted/.del-os_stat.c~b7aea1c8fe0bc4c4:
        Delete: storage/bdb/os_win32/os_stat.c
      BitKeeper/deleted/.del-os_truncate.c~9761b239f54b2d96:
        Delete: storage/bdb/os_win32/os_truncate.c
      BitKeeper/deleted/.del-os_unlink.c:
        Delete: storage/bdb/os/os_unlink.c
      BitKeeper/deleted/.del-os_type.c:
        Delete: storage/bdb/os_win32/os_type.c
      BitKeeper/deleted/.del-os_unlink.c~6dee667279d01609:
        Delete: storage/bdb/os_win32/os_unlink.c
      BitKeeper/deleted/.del-qam.c:
        Delete: storage/bdb/qam/qam.c
      BitKeeper/deleted/.del-qam.src:
        Delete: storage/bdb/qam/qam.src
      BitKeeper/deleted/.del-qam_conv.c:
        Delete: storage/bdb/qam/qam_conv.c
      BitKeeper/deleted/.del-qam_files.c:
        Delete: storage/bdb/qam/qam_files.c
      BitKeeper/deleted/.del-qam_method.c:
        Delete: storage/bdb/qam/qam_method.c
      BitKeeper/deleted/.del-qam_open.c:
        Delete: storage/bdb/qam/qam_open.c
      BitKeeper/deleted/.del-qam_rec.c:
        Delete: storage/bdb/qam/qam_rec.c
      BitKeeper/deleted/.del-qam_stat.c:
        Delete: storage/bdb/qam/qam_stat.c
      BitKeeper/deleted/.del-qam_stub.c:
        Delete: storage/bdb/qam/qam_stub.c
      BitKeeper/deleted/.del-qam_upgrade.c:
        Delete: storage/bdb/qam/qam_upgrade.c
      BitKeeper/deleted/.del-qam_verify.c:
        Delete: storage/bdb/qam/qam_verify.c
      BitKeeper/deleted/.del-rep.src:
        Delete: storage/bdb/rep/rep.src
      BitKeeper/deleted/.del-rep_backup.c:
        Delete: storage/bdb/rep/rep_backup.c
      BitKeeper/deleted/.del-rep_elect.c:
        Delete: storage/bdb/rep/rep_elect.c
      BitKeeper/deleted/.del-rep_log.c:
        Delete: storage/bdb/rep/rep_log.c
      BitKeeper/deleted/.del-rep_method.c:
        Delete: storage/bdb/rep/rep_method.c
      BitKeeper/deleted/.del-rep_record.c:
        Delete: storage/bdb/rep/rep_record.c
      BitKeeper/deleted/.del-rep_region.c:
        Delete: storage/bdb/rep/rep_region.c
      BitKeeper/deleted/.del-rep_stat.c:
        Delete: storage/bdb/rep/rep_stat.c
      BitKeeper/deleted/.del-rep_stub.c:
        Delete: storage/bdb/rep/rep_stub.c
      BitKeeper/deleted/.del-rep_util.c:
        Delete: storage/bdb/rep/rep_util.c
      BitKeeper/deleted/.del-rep_verify.c:
        Delete: storage/bdb/rep/rep_verify.c
      BitKeeper/deleted/.del-seq_stat.c:
        Delete: storage/bdb/sequence/seq_stat.c
      BitKeeper/deleted/.del-sequence.c:
        Delete: storage/bdb/sequence/sequence.c
      BitKeeper/deleted/.del-txn.c:
        Delete: storage/bdb/txn/txn.c
      BitKeeper/deleted/.del-txn.src:
        Delete: storage/bdb/txn/txn.src
      BitKeeper/deleted/.del-txn_chkpt.c:
        Delete: storage/bdb/txn/txn_chkpt.c
      BitKeeper/deleted/.del-txn_failchk.c:
        Delete: storage/bdb/txn/txn_failchk.c
      BitKeeper/deleted/.del-txn_method.c:
        Delete: storage/bdb/txn/txn_method.c
      BitKeeper/deleted/.del-txn_rec.c:
        Delete: storage/bdb/txn/txn_rec.c
      BitKeeper/deleted/.del-txn_recover.c:
        Delete: storage/bdb/txn/txn_recover.c
      BitKeeper/deleted/.del-txn_region.c:
        Delete: storage/bdb/txn/txn_region.c
      BitKeeper/deleted/.del-txn_stat.c:
        Delete: storage/bdb/txn/txn_stat.c
      BitKeeper/deleted/.del-txn_util.c:
        Delete: storage/bdb/txn/txn_util.c
      BitKeeper/deleted/.del-xa.c:
        Delete: storage/bdb/xa/xa.c
      BitKeeper/deleted/.del-xa_db.c:
        Delete: storage/bdb/xa/xa_db.c
      BitKeeper/deleted/.del-xa_map.c:
        Delete: storage/bdb/xa/xa_map.c
      sql/field.cc:
        Antony's patch
      sql/field.h:
        Antony's patch
      e1df39a5
  11. 15 Aug, 2006 1 commit
  12. 14 Aug, 2006 1 commit
    • unknown's avatar
      Fix for bug#20648 We introduce a new field method for knowing "real size", and... · 60861521
      unknown authored
      Fix for bug#20648 We introduce a new field method for knowing "real size", and we now in archive null unused bits of a row to null before writing. 
      
      
      sql/field.cc:
        data_length for field needs to be calculated directly.
      sql/field.h:
        The new method data_length() returns the "real" length of the field.
      sql/ha_archive.cc:
        Before a write_row() archive nulls space beyond the size of the row in varchars to make sure that compression only sees NULL.
      60861521
  13. 01 Aug, 2006 1 commit
  14. 25 Jul, 2006 1 commit
    • unknown's avatar
      Bug #21284: Add Field::needs_quote() method and use it in Federated · 204f6c93
      unknown authored
        The fix for bug 17608 removed the behavior of only adding quotes to values
        that needed it when constructing the queries sent by the federated storage
        engine. This restores that behavior, but using a new virtual Field method.
        (The old one had a hardcoded list of field types.)
      
        No test included. The behavior can be verified by inspecting the query log
        on the slave in the federated test.
      
      
      sql/field.h:
        Add str_needs_quotes() method to indicate whether the results of val_str()
        requires quoting when used in constructing an SQL query.
      sql/ha_federated.cc:
        Restore behavior of only quoting values that need it, using the new
        Field::str_needs_quotes() method.
      204f6c93
  15. 22 Jul, 2006 1 commit
    • unknown's avatar
      field.h: · 9e5d47e5
      unknown authored
        Fixed typo.
      
      
      sql/field.h:
        Fixed typo.
      9e5d47e5
  16. 21 Jul, 2006 1 commit
    • unknown's avatar
      Fixed bug#12185: Data type aggregation may produce wrong result · a05809b6
      unknown authored
      The Item::tmp_table_field_from_field_type() function creates Field_datetime
      object instead of Field_timestamp object for timestamp field thus always
      changing data type is a tmp table is used.
      
      The Field_blob object constructor which is used in the 
      Item::tmp_table_field_from_field_type() is always setting packlength field of
      newly created blob to 4. This leads to changing fields data type for example
      from the blob to the longblob if a temporary table is used.
      
      The Item::make_string_field() function always converts Field_string objects 
      to Field_varstring objects. This leads to changing data type from the 
      char/binary to varchar/varbinary.
      
      Added appropriate Field_timestamp object constructor for using in the 
      Item::tmp_table_field_from_field_type() function.
      
      Added Field_blob object constructor which sets pack length according to
      max_length argument.
      
      The Item::tmp_table_field_from_field_type() function now creates
      Field_timestamp object for a timestamp field.
      
      The Item_type_holder::display_length() now returns correct NULL length NULL
      length. 
      
      The Item::make_string_field() function now doesn't change Field_string to
      Field_varstring in the case of Item_type_holder. 
      
      The Item::tmp_table_field_from_field_type() function now uses the Field_blob
      constructor which sets packlength according to max_length.
      
      
      mysql-test/t/union.test:
        Added test case for bug#12185: Data type aggregation may produce wrong result
        Corrected test case after fix for bug#12185
      mysql-test/t/innodb.test:
        Corrected test case after fix for bug#12185
      mysql-test/r/union.result:
        Added test case for bug#12185: Data type aggregation may produce wrong result
         Corrected test case after fix for bug#12185
      mysql-test/r/innodb.result:
        Corrected test case after fix for bug#12185
      mysql-test/r/create.result:
        Corrected the test case after fixing bug#12185
      sql/field.h:
        Fixed bug#12185: Data type aggregation may produce wrong result
        Added Field_blob object constructor which sets packlength according to
        max_length argument.
      sql/item.cc:
        Fixed bug#12185: Data type aggregation may produce wrong result
        The Item::make_string_field() function now doesn't change Field_string to
        Field_varstring in the case of Item_type_holder.
        The Item::tmp_table_field_from_field_type() function now creates
        Field_timestamp object for a timestamp field.
        The Item::tmp_table_field_from_field_type() function now uses the Field_blob
        constructor which sets packlength according to max_length.
        The Item_type_holder::display_length() now returns correct NULL length NULL
        length.
      sql/field.cc:
        Fixed bug#12185: Data type aggregation may produce wrong result
        Added appropriate Field_timestamp object constructor for using in the 
        Item::tmp_table_field_from_field_type() function.
      a05809b6
  17. 19 Jul, 2006 1 commit
    • unknown's avatar
      Bug #21135 Crash in test "func_time" · 0794dc71
      unknown authored
       - backport patch from 5.0
       - "table" can be NULL in temporary fields used for type conversion
      
      
      sql/field.cc:
        table can be NULL in temporary fields used for type conversion.
        Store value in field as if db_low_byte_first was set.
      sql/field.h:
        table can be NULL in temporary fields used for type conversion.
        Store value in field as if db_low_byte_first was set.
      0794dc71
  18. 12 Jul, 2006 1 commit
    • unknown's avatar
      Bug #17608: String literals lost during INSERT query on FEDERATED table · 1f36d330
      unknown authored
        The Federated storage engine used Field methods that had arbitrary limits on
        the amount of data they could process, which caused problems with data
        over that limit (4K). By removing those Field methods and just using
        features of the String class, we can avoid this problem.
      
      
      mysql-test/r/federated.result:
        Add new results
      mysql-test/t/federated.test:
        Add new regression test
      sql/field.cc:
        Remove unnecessary methods
      sql/field.h:
        Remove unnecessary methods
      sql/ha_federated.cc:
        Remove use of quote_data, use String::print() to get escaping of strings,
        and don't bother with needs_quotes, just always quote values.
      1f36d330
  19. 27 Jun, 2006 1 commit
    • unknown's avatar
      Fix for bug #18014: data loss caused by altering decimal fields. · cc1b32ad
      unknown authored
      mysql-test/r/type_newdecimal.result:
        Fix for bug #18014: data loss caused by altering decimal fields.
          - test result
      mysql-test/t/type_newdecimal.test:
        Fix for bug #18014: data loss caused by altering decimal fields.
          - test case
      sql/field.cc:
        Fix for bug #18014: data loss caused by altering decimal fields.
          - Field_new_decimal::is_equal() introduced for proper comparisons of the decimal field definitions.
      sql/field.h:
        Fix for bug #18014: data loss caused by altering decimal fields.
          - Field_new_decimal::is_equal() introduced for proper comparisons of the decimal field definitions.
      cc1b32ad
  20. 26 Jun, 2006 1 commit
    • unknown's avatar
      Bug#16218 - Crash on insert delayed · 27fb95bc
      unknown authored
      Bug#17294 - INSERT DELAYED puting an \n before data
      Bug#16611 - INSERT DELAYED corrupts data
      Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
      Combined as Bug#16218.
      
      INSERT DELAYED crashed in 5.0 on a table with a varchar that 
      could be NULL and was created pre-5.0 (Bugs 16218 and 13707).
      INSERT DELAYED corrupted data in 5.0 on a table with varchar 
      fields that was created pre-5.0 (Bugs 17294 and 16611).
      
      In case of INSERT DELAYED the open table is copied from the
      delayed insert thread to be able to create a record for the 
      queue. When copying the fields, a method was used that did 
      convert old varchar to new varchar fields and did not set up 
      some pointers into the record buffer of the table.
      
      The field conversion was guilty for the misinterpretation of 
      the record contents by the delayed insert thread. The wrong
      pointer setup was guilty for the crashes.
      
      For Bug 13707 (Server crash with INSERT DELAYED on MyISAM table)
      I fixed the above mentioned method to set up one of the pointers.
      For Bug 16218 I set up the other pointers too.
      
      But when looking at the corruptions I got aware that converting
      the field type was totally wrong for INSERT DELAYED. The copied
      table is used to create a record that is to be sent to the
      delayed insert thread. Of course it can interpret the record
      correctly only if all field types are the same in both table
      objects.
      
      So I revoked the fix for Bug 13707 and changed the new_field() 
      method so that it can suppress conversions.
      
      No test case as this is a migration problem. One needs to
      create a table with 4.x and use it with 5.x. I added two
      test scripts to the bug report.
      
      
      sql/field.cc:
        Bug#16218 - Crash on insert delayed
        Bug#17294 - INSERT DELAYED puting an \n before data
        Bug#16611 - INSERT DELAYED corrupts data
        Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
        Combined as Bug#16218.
        
        Added parameter 'keep_type' to Field::new_field().
        
        Undid the change from Bug 13707 (Server crash with INSERT 
        DELAYED on MyISAM table).
        I solved all four bugs in sql/sql_insert.cc by making exact
        duplicates of the fields. The new_field() method converts
        certain field types, which is wrong for INSERT DELAYED.
      sql/field.h:
        Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
        Combined as Bug#16218.
        
        Added parameter 'keep_type' to Field::new_field().
      sql/sql_insert.cc:
        Bug#16218 - Crash on insert delayed
        Bug#17294 - INSERT DELAYED puting an \n before data
        Bug#16611 - INSERT DELAYED corrupts data
        Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
        Combined as Bug#16218.
        
        Added comments. Made small style fixes.
        Used the new parameter 'keep_type' of Field::new_field()
        to avoid field type conversion. The table copy must have
        exactly the same types of fields as the original table.
        Otherwise the record contents created by the foreground 
        thread could be misinterpreted by the delayed insert thread.
      sql/sql_select.cc:
        Bug#16218 - Crash on insert delayed
        Bug#17294 - INSERT DELAYED puting an \n before data
        Bug#16611 - INSERT DELAYED corrupts data
        Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
        Combined as Bug#16218.
        
        Added parameter 'keep_type' to Field::new_field().
        
        Undid the change from Bug 13707 (Server crash with INSERT 
        DELAYED on MyISAM table).
        I solved all four bugs in sql/sql_insert.cc by making exact
        duplicates of the fields. The new_field() method converts
        certain field types, which is wrong for INSERT DELAYED.
      sql/sql_trigger.cc:
        Bug#16218 - Crash on insert delayed
        Bug#17294 - INSERT DELAYED puting an \n before data
        Bug#16611 - INSERT DELAYED corrupts data
        Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
        Combined as Bug#16218.
        
        Added parameter 'keep_type' to Field::new_field().
        
        Undid the change from Bug 13707 (Server crash with INSERT 
        DELAYED on MyISAM table).
        I solved all four bugs in sql/sql_insert.cc by making exact
        duplicates of the fields. The new_field() method converts
        certain field types, which is wrong for INSERT DELAYED.
      sql/table.cc:
        Bug#16218 - Crash on insert delayed
        Bug#17294 - INSERT DELAYED puting an \n before data
        Bug#16611 - INSERT DELAYED corrupts data
        Bug#13707 - Server crash with INSERT DELAYED on MyISAM table
        Combined as Bug#16218.
        
        Added parameter 'keep_type' to Field::new_field().
        
        Undid the change from Bug 13707 (Server crash with INSERT 
        DELAYED on MyISAM table).
        I solved all four bugs in sql/sql_insert.cc by making exact
        duplicates of the fields. The new_field() method converts
        certain field types, which is wrong for INSERT DELAYED.
      27fb95bc
  21. 21 Jun, 2006 1 commit
    • unknown's avatar
      Bug#20086: Can't get data from key partitioned tables with VARCHAR key · c0fbdf6c
      unknown authored
      The problem appeared because the same values produced different hash
      during INSERT and SELECT for VARCHAR data type.
      Fix:
      VARCHAR required special treatment to avoid hashing of length bytes
      (leftmost one or two bytes) as well as trailing bytes beyond real length,
      which could contain garbage. Fix is done by introducing hash() - new method
      in the Field class.
      
      
      mysql-test/r/partition_innodb.result:
        Adding test case
      mysql-test/r/partition_pruning.result:
        Fixing test results (results differ due to changes in hash function)
      mysql-test/t/partition_innodb.test:
        Adding test case
      sql/field.cc:
        Adding generic hash() method, and a special
        method for VARCHAR.
      sql/field.h:
        Adding prototypes for new methods
      sql/key.cc:
        Mark columns for write before executinf of set_key_image().
        Thanks for Mikael for suggesting this fix.
      sql/sql_partition.cc:
        Removing old hash code.
        Using new methid field->hash() instead.
      c0fbdf6c
  22. 20 Jun, 2006 1 commit
    • unknown's avatar
      field.cc, field.h: · 6ddd15ad
      unknown authored
        Additional fix for #16377 for bigendian platforms
      sql_select.cc, select.result, select.test:
        After merge fix
      
      
      mysql-test/t/select.test:
        After merge fix
      mysql-test/r/select.result:
        After merge fix
      sql/sql_select.cc:
        After merge fix
      sql/field.h:
        Additional fix for #16377 for bigendian platforms
      sql/field.cc:
        Additional fix for #16377 for bigendian platforms
      6ddd15ad
  23. 14 Jun, 2006 1 commit
    • unknown's avatar
      Bug #18895: BIT values cause joins to fail · d496b16d
      unknown authored
      The Field::eq() considered instances of Field_bit that differ only in 
      bit_ptr/bit_ofs equal. This caused equality conditions optimization 
      (build_equal_items_for_cond()) to make bad field substitutions that result
      in wrong predicates. 
      Field_bit requires an overloaded eq() function that checks the bit_ptr/bit_ofs
      in addition to Field::eq().
      
      
      mysql-test/r/select.result:
        Bug #18895: BIT values cause joins to fail
        
        - test case
      mysql-test/t/select.test:
        Bug #18895: BIT values cause joins to fail
        
        - test case
      sql/field.h:
        Bug #18895: BIT values cause joins to fail
        
        - eq() method overloaded for Field_bit
      d496b16d
  24. 04 Jun, 2006 1 commit
    • unknown's avatar
      This changeset is largely a handler cleanup changeset (WL#3281), but includes... · 85a8e6ab
      unknown authored
      This changeset is largely a handler cleanup changeset (WL#3281), but includes fixes and cleanups that was found necessary while testing the handler changes
      
      Changes that requires code changes in other code of other storage engines.
      (Note that all changes are very straightforward and one should find all issues
      by compiling a --debug build and fixing all compiler errors and all
      asserts in field.cc while running the test suite),
      
      - New optional handler function introduced: reset()
        This is called after every DML statement to make it easy for a handler to
        statement specific cleanups.
        (The only case it's not called is if force the file to be closed)
      
      - handler::extra(HA_EXTRA_RESET) is removed. Code that was there before
        should be moved to handler::reset()
      
      - table->read_set contains a bitmap over all columns that are needed
        in the query.  read_row() and similar functions only needs to read these
        columns
      - table->write_set contains a bitmap over all columns that will be updated
        in the query. write_row() and update_row() only needs to update these
        columns.
        The above bitmaps should now be up to date in all context
        (including ALTER TABLE, filesort()).
      
        The handler is informed of any changes to the bitmap after
        fix_fields() by calling the virtual function
        handler::column_bitmaps_signal(). If the handler does caching of
        these bitmaps (instead of using table->read_set, table->write_set),
        it should redo the caching in this code. as the signal() may be sent
        several times, it's probably best to set a variable in the signal
        and redo the caching on read_row() / write_row() if the variable was
        set.
      
      - Removed the read_set and write_set bitmap objects from the handler class
      
      - Removed all column bit handling functions from the handler class.
        (Now one instead uses the normal bitmap functions in my_bitmap.c instead
        of handler dedicated bitmap functions)
      
      - field->query_id is removed. One should instead instead check
        table->read_set and table->write_set if a field is used in the query.
      
      - handler::extra(HA_EXTRA_RETRIVE_ALL_COLS) and
        handler::extra(HA_EXTRA_RETRIEVE_PRIMARY_KEY) are removed. One should now
        instead use table->read_set to check for which columns to retrieve.
      
      - If a handler needs to call Field->val() or Field->store() on columns
        that are not used in the query, one should install a temporary
        all-columns-used map while doing so. For this, we provide the following
        functions:
      
        my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
        field->val();
        dbug_tmp_restore_column_map(table->read_set, old_map);
      
        and similar for the write map:
      
        my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
        field->val();
        dbug_tmp_restore_column_map(table->write_set, old_map);
      
        If this is not done, you will sooner or later hit a DBUG_ASSERT
        in the field store() / val() functions.
        (For not DBUG binaries, the dbug_tmp_restore_column_map() and
        dbug_tmp_restore_column_map() are inline dummy functions and should
        be optimized away be the compiler).
      
      - If one needs to temporary set the column map for all binaries (and not
        just to avoid the DBUG_ASSERT() in the Field::store() / Field::val()
        methods) one should use the functions tmp_use_all_columns() and
        tmp_restore_column_map() instead of the above dbug_ variants.
      
      - All 'status' fields in the handler base class (like records,
        data_file_length etc) are now stored in a 'stats' struct. This makes
        it easier to know what status variables are provided by the base
        handler.  This requires some trivial variable names in the extra()
        function.
      
      - New virtual function handler::records().  This is called to optimize
        COUNT(*) if (handler::table_flags() & HA_HAS_RECORDS()) is true.
        (stats.records is not supposed to be an exact value. It's only has to
        be 'reasonable enough' for the optimizer to be able to choose a good
        optimization path).
      
      - Non virtual handler::init() function added for caching of virtual
        constants from engine.
      
      - Removed has_transactions() virtual method. Now one should instead return
        HA_NO_TRANSACTIONS in table_flags() if the table handler DOES NOT support
        transactions.
      
      - The 'xxxx_create_handler()' function now has a MEM_ROOT_root argument
        that is to be used with 'new handler_name()' to allocate the handler
        in the right area.  The xxxx_create_handler() function is also
        responsible for any initialization of the object before returning.
      
        For example, one should change:
      
        static handler *myisam_create_handler(TABLE_SHARE *table)
        {
          return new ha_myisam(table);
        }
      
        ->
      
        static handler *myisam_create_handler(TABLE_SHARE *table, MEM_ROOT *mem_root)
        {
          return new (mem_root) ha_myisam(table);
        }
      
      - New optional virtual function: use_hidden_primary_key().
        This is called in case of an update/delete when
        (table_flags() and HA_PRIMARY_KEY_REQUIRED_FOR_DELETE) is defined
        but we don't have a primary key. This allows the handler to take precisions
        in remembering any hidden primary key to able to update/delete any
        found row. The default handler marks all columns to be read.
      
      - handler::table_flags() now returns a ulonglong (to allow for more flags).
      
      - New/changed table_flags()
        - HA_HAS_RECORDS	    Set if ::records() is supported
        - HA_NO_TRANSACTIONS	    Set if engine doesn't support transactions
        - HA_PRIMARY_KEY_REQUIRED_FOR_DELETE
                                  Set if we should mark all primary key columns for
      			    read when reading rows as part of a DELETE
      			    statement. If there is no primary key,
      			    all columns are marked for read.
        - HA_PARTIAL_COLUMN_READ  Set if engine will not read all columns in some
      			    cases (based on table->read_set)
       - HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
         			    Renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
       - HA_DUPP_POS              Renamed to HA_DUPLICATE_POS
       - HA_REQUIRES_KEY_COLUMNS_FOR_DELETE
      			    Set this if we should mark ALL key columns for
      			    read when when reading rows as part of a DELETE
      			    statement. In case of an update we will mark
      			    all keys for read for which key part changed
      			    value.
        - HA_STATS_RECORDS_IS_EXACT
      			     Set this if stats.records is exact.
      			     (This saves us some extra records() calls
      			     when optimizing COUNT(*))
      			    
      
      - Removed table_flags()
        - HA_NOT_EXACT_COUNT     Now one should instead use HA_HAS_RECORDS if
      			   handler::records() gives an exact count() and
      			   HA_STATS_RECORDS_IS_EXACT if stats.records is exact.
        - HA_READ_RND_SAME	   Removed (no one supported this one)
      
      - Removed not needed functions ha_retrieve_all_cols() and ha_retrieve_all_pk()
      
      - Renamed handler::dupp_pos to handler::dup_pos
      
      - Removed not used variable handler::sortkey
      
      
      Upper level handler changes:
      
      - ha_reset() now does some overall checks and calls ::reset()
      - ha_table_flags() added. This is a cached version of table_flags(). The
        cache is updated on engine creation time and updated on open.
      
      
      MySQL level changes (not obvious from the above):
      
      - DBUG_ASSERT() added to check that column usage matches what is set
        in the column usage bit maps. (This found a LOT of bugs in current
        column marking code).
      
      - In 5.1 before, all used columns was marked in read_set and only updated
        columns was marked in write_set. Now we only mark columns for which we
        need a value in read_set.
      
      - Column bitmaps are created in open_binary_frm() and open_table_from_share().
        (Before this was in table.cc)
      
      - handler::table_flags() calls are replaced with handler::ha_table_flags()
      
      - For calling field->val() you must have the corresponding bit set in
        table->read_set. For calling field->store() you must have the
        corresponding bit set in table->write_set. (There are asserts in
        all store()/val() functions to catch wrong usage)
      
      - thd->set_query_id is renamed to thd->mark_used_columns and instead
        of setting this to an integer value, this has now the values:
        MARK_COLUMNS_NONE, MARK_COLUMNS_READ, MARK_COLUMNS_WRITE
        Changed also all variables named 'set_query_id' to mark_used_columns.
      
      - In filesort() we now inform the handler of exactly which columns are needed
        doing the sort and choosing the rows.
      
      - The TABLE_SHARE object has a 'all_set' column bitmap one can use
        when one needs a column bitmap with all columns set.
        (This is used for table->use_all_columns() and other places)
      
      - The TABLE object has 3 column bitmaps:
        - def_read_set     Default bitmap for columns to be read
        - def_write_set    Default bitmap for columns to be written
        - tmp_set          Can be used as a temporary bitmap when needed.
        The table object has also two pointer to bitmaps read_set and write_set
        that the handler should use to find out which columns are used in which way.
      
      - count() optimization now calls handler::records() instead of using
        handler->stats.records (if (table_flags() & HA_HAS_RECORDS) is true).
      
      - Added extra argument to Item::walk() to indicate if we should also
        traverse sub queries.
      
      - Added TABLE parameter to cp_buffer_from_ref()
      
      - Don't close tables created with CREATE ... SELECT but keep them in
        the table cache. (Faster usage of newly created tables).
      
      
      New interfaces:
      
      - table->clear_column_bitmaps() to initialize the bitmaps for tables
        at start of new statements.
      
      - table->column_bitmaps_set() to set up new column bitmaps and signal
        the handler about this.
      
      - table->column_bitmaps_set_no_signal() for some few cases where we need
        to setup new column bitmaps but don't signal the handler (as the handler
        has already been signaled about these before). Used for the momement
        only in opt_range.cc when doing ROR scans.
      
      - table->use_all_columns() to install a bitmap where all columns are marked
        as use in the read and the write set.
      
      - table->default_column_bitmaps() to install the normal read and write
        column bitmaps, but not signaling the handler about this.
        This is mainly used when creating TABLE instances.
      
      - table->mark_columns_needed_for_delete(),
        table->mark_columns_needed_for_delete() and
        table->mark_columns_needed_for_insert() to allow us to put additional
        columns in column usage maps if handler so requires.
        (The handler indicates what it neads in handler->table_flags())
      
      - table->prepare_for_position() to allow us to tell handler that it
        needs to read primary key parts to be able to store them in
        future table->position() calls.
        (This replaces the table->file->ha_retrieve_all_pk function)
      
      - table->mark_auto_increment_column() to tell handler are going to update
        columns part of any auto_increment key.
      
      - table->mark_columns_used_by_index() to mark all columns that is part of
        an index.  It will also send extra(HA_EXTRA_KEYREAD) to handler to allow
        it to quickly know that it only needs to read colums that are part
        of the key.  (The handler can also use the column map for detecting this,
        but simpler/faster handler can just monitor the extra() call).
      
      - table->mark_columns_used_by_index_no_reset() to in addition to other columns,
        also mark all columns that is used by the given key.
      
      - table->restore_column_maps_after_mark_index() to restore to default
        column maps after a call to table->mark_columns_used_by_index().
      
      - New item function register_field_in_read_map(), for marking used columns
        in table->read_map. Used by filesort() to mark all used columns
      
      - Maintain in TABLE->merge_keys set of all keys that are used in query.
        (Simplices some optimization loops)
      
      - Maintain Field->part_of_key_not_clustered which is like Field->part_of_key
        but the field in the clustered key is not assumed to be part of all index.
        (used in opt_range.cc for faster loops)
      
      -  dbug_tmp_use_all_columns(), dbug_tmp_restore_column_map()
         tmp_use_all_columns() and tmp_restore_column_map() functions to temporally
         mark all columns as usable.  The 'dbug_' version is primarily intended
         inside a handler when it wants to just call Field:store() & Field::val()
         functions, but don't need the column maps set for any other usage.
         (ie:: bitmap_is_set() is never called)
      
      - We can't use compare_records() to skip updates for handlers that returns
        a partial column set and the read_set doesn't cover all columns in the
        write set. The reason for this is that if we have a column marked only for
        write we can't in the MySQL level know if the value changed or not.
        The reason this worked before was that MySQL marked all to be written
        columns as also to be read. The new 'optimal' bitmaps exposed this 'hidden
        bug'.
      
      - open_table_from_share() does not anymore setup temporary MEM_ROOT
        object as a thread specific variable for the handler. Instead we
        send the to-be-used MEMROOT to get_new_handler().
        (Simpler, faster code)
      
      
      
      Bugs fixed:
      
      - Column marking was not done correctly in a lot of cases.
        (ALTER TABLE, when using triggers, auto_increment fields etc)
        (Could potentially result in wrong values inserted in table handlers
        relying on that the old column maps or field->set_query_id was correct)
        Especially when it comes to triggers, there may be cases where the
        old code would cause lost/wrong values for NDB and/or InnoDB tables.
      
      - Split thd->options flag OPTION_STATUS_NO_TRANS_UPDATE to two flags:
        OPTION_STATUS_NO_TRANS_UPDATE and OPTION_KEEP_LOG.
        This allowed me to remove some wrong warnings about:
        "Some non-transactional changed tables couldn't be rolled back"
      
      - Fixed handling of INSERT .. SELECT and CREATE ... SELECT that wrongly reset
        (thd->options & OPTION_STATUS_NO_TRANS_UPDATE) which caused us to loose
        some warnings about
        "Some non-transactional changed tables couldn't be rolled back")
      
      - Fixed use of uninitialized memory in ha_ndbcluster.cc::delete_table()
        which could cause delete_table to report random failures.
      
      - Fixed core dumps for some tests when running with --debug
      
      - Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
        (This has probably caused us to not properly remove temporary files after
        crash)
      
      - slow_logs was not properly initialized, which could maybe cause
        extra/lost entries in slow log.
      
      - If we get an duplicate row on insert, change column map to read and
        write all columns while retrying the operation. This is required by
        the definition of REPLACE and also ensures that fields that are only
        part of UPDATE are properly handled.  This fixed a bug in NDB and
        REPLACE where REPLACE wrongly copied some column values from the replaced
        row.
      
      - For table handler that doesn't support NULL in keys, we would give an error
        when creating a primary key with NULL fields, even after the fields has been
        automaticly converted to NOT NULL.
      
      - Creating a primary key on a SPATIAL key, would fail if field was not
        declared as NOT NULL.
      
      
      Cleanups:
      
      - Removed not used condition argument to setup_tables
      
      - Removed not needed item function reset_query_id_processor().
      
      - Field->add_index is removed. Now this is instead maintained in
        (field->flags & FIELD_IN_ADD_INDEX)
      
      - Field->fieldnr is removed (use field->field_index instead)
      
      - New argument to filesort() to indicate that it should return a set of
        row pointers (not used columns). This allowed me to remove some references
        to sql_command in filesort and should also enable us to return column
        results in some cases where we couldn't before.
      
      - Changed column bitmap handling in opt_range.cc to be aligned with TABLE
        bitmap, which allowed me to use bitmap functions instead of looping over
        all fields to create some needed bitmaps. (Faster and smaller code)
      
      - Broke up found too long lines
      
      - Moved some variable declaration at start of function for better code
        readability.
      
      - Removed some not used arguments from functions.
        (setup_fields(), mysql_prepare_insert_check_table())
      
      - setup_fields() now takes an enum instead of an int for marking columns
         usage.
      
      - For internal temporary tables, use handler::write_row(),
        handler::delete_row() and handler::update_row() instead of
        handler::ha_xxxx() for faster execution.
      
      - Changed some constants to enum's and define's.
      
      - Using separate column read and write sets allows for easier checking
        of timestamp field was set by statement.
      
      - Remove calls to free_io_cache() as this is now done automaticly in ha_reset()
      
      - Don't build table->normalized_path as this is now identical to table->path
        (after bar's fixes to convert filenames)
      
      - Fixed some missed DBUG_PRINT(.."%lx") to use "0x%lx" to make it easier to
        do comparision with the 'convert-dbug-for-diff' tool.
      
      
      Things left to do in 5.1:
      
      - We wrongly log failed CREATE TABLE ... SELECT in some cases when using
        row based logging (as shown by testcase binlog_row_mix_innodb_myisam.result)
        Mats has promised to look into this.
      
      - Test that my fix for CREATE TABLE ... SELECT is indeed correct.
        (I added several test cases for this, but in this case it's better that
        someone else also tests this throughly).
        Lars has promosed to do this.
      
      
      BitKeeper/etc/ignore:
        added mysys/test_bitmap
      include/base64.h:
        Removed my_global.h, as this must be included first in any program
      include/heap.h:
        Added heap_reset() (Required by new handler interface)
      include/my_base.h:
        Removed HA_EXTRA_RESET. MySQL will now call ::reset() instead of ::extra(HA_EXTRA_RESET).
        HA_EXTRA_RETRIVE_ALL_COLS and HA_EXTRA_RETRIVE_PRIMARY key are deleted as the column bitmaps makes these unnecessary
      include/my_bitmap.h:
        Remove my_pthread.h (should be included at upper level)
        Introduced my_bitmap_map typedef to make it the bitmap handling more like a black box
        Added bitmap_is_overlapping(), bitmap_test_and_clear(), bitmap_copy() and bitmap_cmp()
        Made bitmap_set_bit(), bitmap_flip_bit(), bitmap_clear_bit() return void
      include/myisam.h:
        Added mi_reset() (Required by new handler interface)
      include/myisammrg.h:
        Added myrg_reset() (Required by new handler interface)
      include/mysql_com.h:
        Added flag FIELD_IN_ADD_INDEX to be able to remove Field->add_index
      mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
        Added testing of CREATE ... SELECT in a mixed environment
        (This found some bugs that Mats is going to fix shortly)
      mysql-test/install_test_db.sh:
        Simplify ldata usage
        Added --tmpdir=. option to mysqld bootstrap (Removed some warnings when TMPDIR was wrongly set)
      mysql-test/mysql-test-run.pl:
        Added --tmpdir=. to bootstrap
      mysql-test/mysql-test-run.sh:
        Use copy instead of INSTALL_DB for master and slave databases.
        (Speeds up startup time a lot!)
        Remove snapshot directories at startup (removes some strange warnings)
      mysql-test/r/binlog_row_mix_innodb_myisam.result:
        Added testing of CREATE ... SELECT in a mixed environment
        (This found some bugs that Mats is going to fix shortly)
      mysql-test/r/binlog_stm_mix_innodb_myisam.result:
        Added testing of CREATE ... SELECT in a mixed environment
      mysql-test/r/create.result:
        Some extra tests of warnings and number of tables opened by CREATE ... SELECT
      mysql-test/r/federated.result:
        Drop some left over tables
        Added testing of multiple table update and multiple table delete (with and without keys)
      mysql-test/r/func_gconcat.result:
        Enable some disabled tests (converted them slightly to be predictable)
      mysql-test/r/func_time.result:
        Added drop of test function
      mysql-test/r/innodb_mysql.result:
        Added tests for CREATE ... SELECT
      mysql-test/r/insert.result:
        More tests
        Added testing of duplicate columns in insert
      mysql-test/r/loaddata.result:
        Added testing LOAD DATA ... SET ...
      mysql-test/r/multi_update.result:
        Test multi updates and deletes using primary key and without
      mysql-test/r/ndb_index_unique.result:
        Better error message
      mysql-test/r/ndb_replace.result:
        New correct result after fixing REPLACE handling with NDB
      mysql-test/r/rpl_ddl.result:
        Now we don't get these (wrong) warnings anymore
      mysql-test/r/view_grant.result:
        Drop used views
      mysql-test/t/create.test:
        Some extra tests of warnings and number of tables opened by CREATE ... SELECT
      mysql-test/t/federated.test:
        Drop some left over tables
        Added testing of multiple table update and multiple table delete (with and without keys)
      mysql-test/t/func_gconcat.test:
        Enable some disabled tests (converted them slightly to be predictable)
      mysql-test/t/func_time.test:
        Added drop of test function
      mysql-test/t/innodb_mysql.test:
        Added tests for CREATE ... SELECT
      mysql-test/t/insert.test:
        More tests
        Added testing of duplicate columns in insert
      mysql-test/t/loaddata.test:
        Added testing LOAD DATA ... SET ...
      mysql-test/t/multi_update.test:
        Test multi updates and deletes using primary key and without
      mysql-test/t/view_grant.test:
        Drop used views
      mysql-test/valgrind.supp:
        Added supression of not needed warnings when printing stack trace
      mysys/base64.c:
        Include my_global.h first
      mysys/my_bitmap.c:
        Added bitmap_is_overlapping(), bitmap_test_and_clear() and bitmap_copy()
        Changed logic of bitmap handling to be a bit more efficent (Did this together with Mikael Ronström)
        Now the 'extra, not used bits' in the bitmap are assumed to have a 'random value' and the bitmap functions are free to change them whenever needed.
        Changed how mutex is allocated to make 'bitmap_free()' function simpler.
      mysys/thr_lock.c:
        Added 0x before thread pointers (for easier comparison of DBUG traces)
      sql/event.cc:
        Ensure 'use_all_columns()' is used for event tables
        Don't print warning that event table is damaged if it doesn't exists.
      sql/field.cc:
        Added ASSERT_COLUMN_MARKED_FOR_WRITE in all store() methods and ASSERT_COLUMN_MARKED_FOR_READ in all val() methods to catch wrong setting if table->read_set and table->write_set
        (Rest of changes are only indentation cleanups)
      sql/field.h:
        Removed Field->query_id (replaced by table->read_set and table->write_set)
        Removed Field->fieldnr (use Field->field_index instead)
        Removed Field->add_index (Use Field->flags instead)
        Add Field->part_of_key_not_clustered (for usage in opt_range.cc)
      sql/filesort.cc:
        Added paramater sort_postion to filesort() to force sorting by position instead of storing all fields in the result set.
        This allowed me to remove checking of sql_command.
        Create a temporary column bitmap for fields that are used by the sorting process.
        Use column bitmaps instead of query_id
      sql/ha_berkeley.cc:
        Update to 'newer' table handler interface
      sql/ha_berkeley.h:
        Update to 'newer' table handler interface
      sql/ha_federated.cc:
        Update to 'newer' table handler interface
        Only read columns that are needed from remote server.
        In case of eq ranges, don't generate two conditions in the WHERE clause
        (this can still be optimized, but would require a bigger code change)
        Use 'simpler to use' XXXX_LEN' macros
        A bit simpler logic in ::write_row() when creating statements.
        In update, only include test of fields actually read.
        (This greatly simplifies the queries sent by the federated engine)
        Similar changes done for delete_row()
      sql/ha_federated.h:
        Update to 'newer' table handler interface
        Changed XXX_LEN macros to use sizeof(...)-1, to simplify usage in ha_federated.cc
        Added HA_PRIMARY_KEY_REQUIRED_FOR_DELETE to tell MySQL to read all primary key columns in case of DELETE
      sql/ha_heap.cc:
        Update to 'newer' table handler interface
      sql/ha_heap.h:
        Update to 'newer' table handler interface
      sql/ha_innodb.cc:
        Update to 'newer' table handler interface
        - Update innobase_create_handler() to new interface
        - Removed HA_NOT_EXACT_COUNT (not needed)
        - Renamed HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
        - Prefixed base status variables with 'stats'
        - Use table column bitmaps instead of ha_get_bit_in_read_set()
        - Added ::reset(), with code from ::extra(HA_EXTRA_RESET)
        - Removed HA_EXTRA_RETRIVE_ALL_COLS and HA_EXTRA_RETRIEVE_PRIMARY_KEY as
          the table->read_set and table->write_set bitmaps now are accurate
      sql/ha_innodb.h:
        Update to 'newer' table handler interface
        - table_flags are now ulonglong
        - Added reset() method
        - Removed not needed ha_retrieve_all_cols() and ha_retrieve_all_pk() columns.
        - Made build_template() a class function to be able to easier access class variables
      sql/ha_myisam.cc:
        Update to 'newer' table handler interface
      sql/ha_myisam.h:
        Update to 'newer' table handler interface
      sql/ha_myisammrg.cc:
        Update to 'newer' table handler interface
      sql/ha_myisammrg.h:
        Update to 'newer' table handler interface
      sql/ha_ndbcluster.cc:
        Update to 'newer' table handler interface
        Fixed use_blob_value() to be accurate
        In ::complemented_read() we have to check both the read and write bitmap as the old code did mark all changed columns also in the read map
        Correct dumping of field data with DBUG_DUMP
        Prefix addresses in DBUG_PRINT with 0x
        Fixed usage of not initialized memory
        Update to use field->flags & FIELD_IN_ADD_INDEX instead of field->add_index.
      sql/ha_ndbcluster.h:
        Update to 'newer' table handler interface
      sql/ha_ndbcluster_binlog.cc:
        Mark usage of all columns in ndbcluster binlog tables
        false -> FALSE, true -> TRUE
        Use table->s->all_set instead of creating a temporary bitmap.
      sql/ha_partition.cc:
        Update to 'newer' table handler interface
        Added memroot to initialise_partitions() and related functions to get faster memory allocation.
        partition_create_handler() is now responsible for initialisation of the partition object
        Some trivial optimizations and indentation fixes
        Ensure that table_flags() are up to date
        Removed documentation for removed HA_EXTRA flags
        Fixed 'strange' usage of m_file[i] in new_handlers_from_part_info()that worked in current code 'by chance'
      sql/ha_partition.h:
        Update to 'newer' table handler interface
      sql/handler.cc:
        create_xxx handler now takes MEMROOT as an argument to simplify memory allocation.
        Much simpler get_new_handler()
        (Initialization of the object is now handled by the create method for the engine)
        Moved all allocation of bitmap handling to the TABLE object (in table.cc)
        Added column_bitmaps_signal() to signal column usage changes.
        Changed binlog_log_row() to use the exiusting all_set bitmap in the table object.
        Added ha_reset() function to test that the file object is ok at end of statement and call handler::reset()
        Added use_hidden_primary_key() to signal handler that we we are going to read and update + delete the row and the handler should thus remember the position for the row
      sql/handler.h:
        Added HA_NO_TRANSACTIONS, HA_PARTIAL_COLUMN_READ, HA_REQUIRES_KEY_COLUMNS_FOR_DELETE,HA_PRIMARY_KEY_REQUIRED_FOR_DELETE and HA_HAS_RECORDS
        Removed HA_NOT_EXACT_COUNT, HA_READ_RND_SAME
        HA_DUPP_POS -> HA_DUPLICATE_POS
        HA_NOT_EXACT_COUNT replaced by HA_STATS_RECORDS_IS_EXACT, HA_HAS_RECORDS and records()
        HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION
        Added future row type 'ROW_TYPE_PAGES'
        Added MEM_ROOT to handlerton 'create' function
        Added ha_statistics, a structure for all status variable in the base handler class.
        Moved all status variables in the handler class into a stats structs to improve readability.
        ha_table_flags() is now a cached (not virtual) version of table_flags()
        reset() doesn't anymore call extra(HA_EXTRA_RESET) but is a function of it's own.
        Renamed dupp_ref to dup_ref
        Renamed not used handler::sortkey
        Moved read_set and write_set to TABLE structure
        handler::init() function added for cacheing of virtual constants from engine.
      sql/item.cc:
        Added register_field_in_read_map() for marking used columns in expression.
        This is used by filesort() for creating an optimal column bitmap while retrieving columns for sorting.
        Initalize value.cs_info.character_set_client to fix core dump bug with --debug
        set_query_id -> mark_used_columns
        Mark used columns in read_set OR write_set.
      sql/item.h:
        Removed reset_query_id_processor() as it's not needed anymore.
        Added register_field_in_read_map()
        Added extra argument to Item::walk() to indicate if we should also
        traverse sub queries.
      sql/item_cmpfunc.cc:
        Temporary mark used columns to be read/writable
        Update Item::walk to new interface
      sql/item_cmpfunc.h:
        Added extra argument to Item::walk() to indicate if we should also traverse sub queries.
      sql/item_func.cc:
        Update Item::walk() to new interface
        table_flags() -> ha_table_flags()
      sql/item_func.h:
        Update Item::walk() to new interface
      sql/item_row.cc:
        Update Item::walk() to new interface
      sql/item_row.h:
        Update Item::walk() to new interface
      sql/item_strfunc.h:
        Update Item::walk() to new interface
      sql/item_subselect.cc:
        Added Item_subselect::walk()
        (It was a bug it was missing before. Not sure what kind of bugs this could have caused)
      sql/item_subselect.h:
        Update Item::walk() to new interface
      sql/item_sum.cc:
        Update Item::walk() to new interface
        Updates for new handler interace
      sql/item_sum.h:
        Update Item::walk() to new interface
      sql/key.cc:
        Updates for new handler interace
      sql/log.cc:
        Mark all columns used for log tables
        Split options flag
        Ensured that second argument to trans_register_ha is a bool
      sql/log_event.cc:
        Fixed comments to be withing 79 characters
        Use OPTION_KEEP_LOG instead of OPTION_STATUS_NO_TRANS_UPDATE to remove wrong warnings
        Updates for new handler interface
        Use 0x%lx instead of %p (portability problem)
      sql/mysql_priv.h:
        Added OPTION_KEEP_LOG to indicate that we should replicate the binlog even on rollback
        Removed not used 'conds' argument to setup_tables
      sql/mysqld.cc:
        Indentation fixes and removed old comment
      sql/opt_range.cc:
        Update to new handler and bitmap interface.
        Fixed calls to cp_buffer_from_ref() and walk() (new argument).
        Create new temporary bitmaps for ror scans.
        (Needed because of handler changes and to get more accurate column bitmaps than before)
        Remove not needed file->ha_reset() call before file->close().
        Some trivial optimization and indentation fixes.
        Use Field->part_of_key_not_clustered() to check if field is part of a key, instead of looping over all key parts.
        
        Added flag 'in_ror_merged_scan' to allow ::get_next() to know that we need a special column bitmap to only fetch pointer to record.
        This is needed because ror scan uses the same TABLE object but different file objects, which creates problem for the column bitmap handling.
        (This is a temporary solution. A better one would be to allocate an own TABLE object for ROR scans)
        
        Optimized bitmap handling in ror scans:
        - Start bitmap at position 0, not 1
        - Use same bitmap size as in TABLE
        - Use table->read_set and table->write_set to create column bitmaps instead of looping over all fields in table
      sql/opt_range.h:
        Added 'in_ror_merged_scan' to indicate if we are doing a ROR scan
        Added temporary column bitmaps used in ROR scans
      sql/opt_sum.cc:
        Added get_ext_record_count() which is used in COUNT() optimization if handler has HA_HAS_RECORDS
        Note that we don't call this if handler has HA_STATS_RECORDS_IS_EXACT set.
      sql/protocol.cc:
        We need to mark columns as readable in ::store() as we sometimes return default value for fields to the user
      sql/records.cc:
        Updates for new handler interface
      sql/set_var.cc:
        Handle splitting OPTION_STATUS_NO_TRANS_UPDATE to two flags
      sql/share/errmsg.txt:
        Fixed wrong
      sql/sp.cc:
        Mark that we are using all columns for the proc table
        Update call to setup_tables() to use new prototype
      sql/sp_head.cc:
        Removed QQ comment
      sql/spatial.cc:
        Removed wrong QQ comment
      sql/sql_acl.cc:
        Mark that we need all columns for acl tables
        Supply memroot to some 'new' calls.
        Indentation fixes
      sql/sql_base.cc:
        set_query_id removed
        Ensure we call ha_reset() at end of each statement
        Mark read columns in read_set and changed columns in write_set (Before all columns was marked in read set)
        Fixed marking of some columns that was not proplerly marked before
        Maintain in TABLE->merge_keys set of all keys that are used in some way
        Removed not used 'conds' argument from setup_tables()
        Remove not used setting of 'dupp_field' in insert_fields()
        Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
        (This has probably caused us to not properly remove temporary files after crash)
      sql/sql_bitmap.h:
        Added is_overlapping()
      sql/sql_class.cc:
        Slow_logs was not properly initialized, which could maybe cause extra/lost entries in slow log.
        set_query_id -> mark_used_columns
        Simpler variable usage in pack_row()  (cleanup)
        Moved some variable declartion at start of function for better code readability
      sql/sql_class.h:
        Added enum_mark_columns
        Updated comments
        Renamed dupp_field -> dup_field
        Added virtual function 'can_rollback_data()' to select_insert() to be used in CREATE ... SELECT to optimize use of OPTION_STATUS_NO_TRANS_UPDATE.
        (This fixes a bug in CREATE ... SELECT where we did give wrong warnings when using non transacational tables)
      sql/sql_delete.cc:
        Updates to new handler interface
        Call table->mark_columns_needed_for_delete() to allow us to put additional columns in column usage maps if handler so requires.
        Call table->prepare_for_position() to tell handler that we are going to call ha_position().
        Removed call to free_io_cache(). (io_cache is now removed in ha_reset()).
        Fixed calls to setup_tables()
      sql/sql_do.cc:
        Update call to setup_fields()
      sql/sql_handler.cc:
        Tell handler tables to always read all columns.
        Use temporary column map when storing value in field for later index usage
      sql/sql_help.cc:
        Makr all used fields to be read
        Update call to setup_fields()
      sql/sql_insert.cc:
        Tell handler we are going to update the auto_increment column
        dupp_field -> dup_field
        Set column usage bits for timestamp field.
        Call table->mark_columns_needed_for_insert() and table->mark_auto_increment_column()
        Removed not used argument from mysql_prepare_insert_check_table().
        
        If we get an duplicate row on insert, change column map to read and write all columns while retrying the operatation.
        This is required by the definition of REPLACE and also ensures that fields that are only part of UPDATE are properly handled.
        This fixed a bug in NDB and REPLACE where REPLACE wrongly copied some column values from the replaced row.
        
        Setup new bitmaps for delayed insert rows
        Remove reseting of next_number_fields as it will be reset on next call to handler_insert()
        
        Fixed usage of thd->options and OPTION_STATUS_NO_TRANS_UPDATE.
        The issue was that one should not to reset this flag as it may be set by a previous statement.
        The way it was now used caused us to loose some warnings and get other wrong warnings when using non transactional tables mixed with transactional.
        I fixed it by introducing 'select_insert::can_rollback_data' to inform send_error() that the given statement can be rolled back (which in case of CREATE TABLE can always be done)
        Don't close tables created with CREATE ... SELECT but keep them in the table cache.
        
        Moved out MY_HOOKS from inside function (better readability)
      sql/sql_load.cc:
        Update to use new handler and column marking interface
        Update using setup_tables()
      sql/sql_olap.cc:
        Update calls to setup_tables
        Use enums instead of constants to setup_fields()
      sql/sql_parse.cc:
        Handle OPTION_KEEP_LOG:
        - Set it on CREATE TEMPORARY TABLE / DROP TABLE
        - Reset it when OPTION_STATUS_NO_TRANS_UPDATE is reset
        - Don't set it for CREATE ... SELECT (this is handled in select_create class)
        Remove reseting of OPTION_STATUS_NO_TRANS_UPDATE in begin_trans() as this should already be reset.
        If in autocommit mode, reset OPTION_KEEP_LOG and OPTION_STATUS_NO_TRANS_UPDATE to not give warnings in future commands
      sql/sql_partition.cc:
        Update walk() usage
        Trivial indentation fixes
      sql/sql_plugin.cc:
        Mark all columns as used for plugins
      sql/sql_prepare.cc:
        Added assert to find out hidden bugs in character_set_client (got an error in debug binary when this not set correctly)
        Updates for new handler interface
        Update calls to setup_fields()
      sql/sql_repl.cc:
        Indentation fixes
      sql/sql_select.cc:
        Update call to setup_tables() and setup_fields()
        Remove some old disabled code
        Update to new hadler interface
        Indentation cleanups
        Added column bitmaps for temporary tables.
        Remove updating of the removed slots in the Field class
        Added TABLE argument to cp_buffer_from_ref() (To be able to install temporary column maps)
        For internal temporary tables, use handler::write_row(), handler::delete_row() and handler::update_row() instead of handler::ha_xxxx() for faster execution.
      sql/sql_select.h:
        Indentaition fixes.
        Install temporary column usage maps when needed
        Added TABLE element to cp_buffer_from_ref()
      sql/sql_show.cc:
        Update to new handler interface
        Mark all columns used for internal tables.
        Style fixes.
        Added support for 'future' ROW_TYPE_PAGES.
        Don't allocate TMP_TABLE_PARAM with calloc. The 'init()' function will initialize the structure properly.
      sql/sql_table.cc:
        Update to new handler interface
        Simple my_snprintf -> strmake()
        Changed some constants to defines
        Don't test for NULL in primary key (as we a couple of line above force the PRIMARY KEY to be NOT NULL)
        Change field->add_index to use field->flags & FIELD_IN_ADD_INDEX
        Mark all columns as used for ALTER TABLE
        Style fixes
        Update call to filesort()
      sql/sql_trigger.h:
        Added friend functions to be able to test if triggers exists for table we are going to insert/update or delete in.
      sql/sql_udf.cc:
        Mark all columns as used for udf system table.
      sql/sql_union.cc:
        Update call to walk()
        Update to new handler interface
      sql/sql_update.cc:
        Remove query_id argument from compare_record()
        Use column bitmaps instead of query_id.
        We can't use compare_records() to skip updates for handlers that returns a partial column set and the read_set doesn't cover all columns in the write set, because compare_record() can't in this case know if a not read column changed value.
        Update call to setup_fields()
        Using separate column read and write sets allows for easier checking of timestamp field was set by statement.
        Removed call to free_io_cache() as this is now done in ha_reset()
        Call table->mark_columns_needed_for_update() and table->prepare_for_position()
        Style fixes
      sql/sql_view.cc:
        Style fixes
      sql/table.cc:
        Remove implicitely include 'errno.h'
        Remove code for building normalized path, as this is now identical to 'path'
        Remove field->fieldnr
        Added update of field->part_of_key_not_clustered()
        Create column bitmaps in TABLE and TABLE_SHARE
        Don't setup a temporary MEM_ROOT object as a thread specific variable for the handler. Instead we send the to-be-used MEMROOT to get_new_handler()
        Update to new handler interface
        Update call to walk()
        Added new functions:
        - st_table::clear_column_bitmaps()
        - st_table::prepare_for_position()
        - st_table::mark_columns_used_by_index()
        - st_table::restore_column_maps_after_mark_index()
        - st_table::mark_columns_used_by_index_no_reset()
        - st_table::mark_auto_increment_column()
        - st_table::mark_columns_needed_for_delete()
        - st_table::mark_columns_needed_for_update()
        - st_table::mark_columns_needed_for_insert()
      sql/table.h:
        Moved column usage bitmaps from handler to TABLE
        Added to TABLE_SHARE all_set and column_bitmap_size
        Added to TABLE merge_keys, bitmap_init_values, def_read_set, def_write_set, tmp_set, read_set and write_set.
        Declared all new table column bitmap functions
        Added TABLE functions column_bitmaps_set(), column_bitmaps_set_no_signal(), use_all_columns() and default_column_bitmaps()
        Added functions: tmp_use_all_columns() and tmp_restore_column_map() to temporarly switch column bitmaps
        Added functions: dbug_tmp_use_all_columns() and dbug_tmp_restore_column_map() to temporarly switch column bitmaps to avoid asserts in Field::store() and Field::val().
      sql/tztime.cc:
        Mark all columns as used for timezone tables
      storage/archive/ha_archive.cc:
        Update to new handler interface
      storage/archive/ha_archive.h:
        Update to new handler interface
      storage/blackhole/ha_blackhole.cc:
        Update to new handler interface
      storage/blackhole/ha_blackhole.h:
        Update to new handler interface
        removed not needed flag HA_DUPP_POS
      storage/csv/ha_tina.cc:
        Update to new handler interface
      storage/csv/ha_tina.h:
        Update to new handler interface
      storage/example/ha_example.cc:
        Update to new handler interface
      storage/example/ha_example.h:
        Update to new handler interface
      storage/heap/hp_extra.c:
        Added heap_reset() (Required by new handler interface)
      storage/heap/hp_test2.c:
        Use heap_reset()
      storage/myisam/ft_boolean_search.c:
        Fixed compiler warning
      storage/myisam/mi_extra.c:
        Added mi_reset() (Required by new handler interface)
      storage/myisam/mi_search.c:
        Fixed DBUG_PRINT messages to use 0x%lx instead of %lx
      storage/myisam/mi_test2.c:
        Use mi_reset()
      storage/myisam/myisampack.c:
        Use mi_reset()
      storage/myisammrg/myrg_extra.c:
        Added myrg_reset() (Required by new handler interface)
      unittest/mysys/base64.t.c:
        Include my_global.h
        Don't include implictely include file 'stdlib.h'
      85a8e6ab
  25. 24 May, 2006 1 commit
    • unknown's avatar
      Remove dflt_field from field structure as this was only needed when createing... · 57f138f7
      unknown authored
      Remove dflt_field from field structure as this was only needed when createing temporary table and I found another soultion that doesn't increase the size of the field structure for all table instances. (Better fix for bug #19089)
      Fixed compiler warnings
      Fixed valgrind warning in Item_date_add_intervall::eq. (Recoding of bugfix #19490)
      
      
      sql/field.cc:
        remove dflt_field from field structure (not needed)
        Simple cleanup of code that been copied elsewhere
      sql/field.h:
        remove dflt_field from field structure (not needed)
      sql/item.h:
        Removed compiler warnings
      sql/item_timefunc.cc:
        Fixed Item_date_add_intervall::eq
        The problem was that when we call 'eq' 'this' is not fixed, which means we can't call const_item() or a value function.
        I fixed this so that we check eq for all arguments and that the sign and type are identical.
        (The original code gave a 'accessing uninitialized data' in valgrind.
      sql/mysql_priv.h:
        Added default fields to create_tmp_field
      sql/sql_insert.cc:
        New default_field parameter to create_tmp_field()
      sql/sql_select.cc:
        New default_field parameter to create_tmp_field()
        Use this in create_tmp_table() to set right default value for a field
      57f138f7
  26. 22 May, 2006 1 commit
    • unknown's avatar
      Post-review fixes for bug #19089 · 9f628bb2
      unknown authored
      mysql-test/r/view.result:
        Post-review fixes.
      sql/field.cc:
        Post-review fixes.
      sql/field.h:
        Post-review fixes.
      sql/sql_select.cc:
        Post-review fixes.
      9f628bb2
  27. 21 May, 2006 1 commit
    • unknown's avatar
      Fixed bug #19089. · 765a7d69
      unknown authored
      When a CREATE TABLE command created a table from a materialized
      view id does not inherit default values from the underlying table.
      Moreover the temporary table used for the view materialization
      does not inherit those default values.
      In the case when the underlying table contained ENUM fields it caused
      misleading error messages. In other cases the created table contained
      wrong default values.
      The code was modified to ensure inheritance of default values for
      materialized views.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #19089.
      mysql-test/t/view.test:
        Added a test case for bug #19089.
      sql/field.cc:
        Fixed bug ##19089.
        Added field dflt_field to the class Field.
        This field is set for temp table fields that inherits
        default values of items from which they are created.
      sql/field.h:
        Fixed bug ##19089.
        Added field dflt_field to the class Field.
        This field is set for temp table fields that inherits
        default values of items from which they are created.
      sql/sql_select.cc:
        Fixed bug #19089.
        When a CREATE TABLE command created a table from a materialized
        view id does not inherit default values from the underlying table.
        Moreover the temporary table used for the view materialization
        does not inherit those default values.
        The code was modified to ensure inheritance of default values for
        materialized views.
      765a7d69
  28. 08 May, 2006 1 commit
    • unknown's avatar
      WL#3259 (RBR with more columns on slave than on master): · 19871217
      unknown authored
      Added support for UPDATE.
      Some minor fixes.
      
      
      mysql-test/t/rpl_row_tabledefs_2myisam.test:
        Rename: mysql-test/t/rpl_row_tabledefs.test -> mysql-test/t/rpl_row_tabledefs_2myisam.test
      mysql-test/extra/rpl_tests/rpl_row_tabledefs.test:
        Extending test to ensure that there is one more null byte on slave than
        it is on the master.
        Some cleanup.
      sql/field.cc:
        Added support to find the last null byte for a field.
      sql/field.h:
        Added support to find the last null byte for a field.
      sql/log_event.cc:
        unpack_row() will now deduce the number of null bytes on the slave
        and use that when copying the null bytes from the row.
        Factored out code to copy "extra" record fields into separate function.
        Used that function to copy the "extra" fields when updating a row as well.
      mysql-test/r/rpl_row_tabledefs_2myisam.result:
        Result change
      mysql-test/r/rpl_row_tabledefs_3innodb.result:
        New BitKeeper file ``mysql-test/r/rpl_row_tabledefs_3innodb.result''
      mysql-test/r/rpl_row_tabledefs_7ndb.result:
        New BitKeeper file ``mysql-test/r/rpl_row_tabledefs_7ndb.result''
      mysql-test/t/rpl_row_tabledefs_3innodb.test:
        New BitKeeper file ``mysql-test/t/rpl_row_tabledefs_3innodb.test''
      19871217
  29. 03 May, 2006 1 commit
    • unknown's avatar
      WL#3259 (RBR with more columns on slave than on master): · ddef03c4
      unknown authored
      Extended replication to allow extra columns added last on slave
      as compared with table on master.
      
      
      mysql-test/extra/rpl_tests/rpl_row_tabledefs.test:
        Testing that replication can handle extra extra columns on slave.
      mysql-test/r/rpl_row_tabledefs.result:
        Result file change
      sql/Makefile.am:
        Adding new files.
      sql/field.cc:
        Implementing missing Field_bit::set_default()
      sql/field.h:
        Implementing missing Field_bit::set_default()
      sql/log_event.cc:
        Extending unpack_row() and replace_record() to handle the case when there are more columns
        on the slave than on the master. Especially handle BIT columns correctly.
        Using newly introduced table_def class to perform comparison.
      sql/log_event.h:
        Adding field to table_map_log_event. Changing prototype for do_prepare_row().
      sql/mysql_priv.h:
        Adding include guards
      mysql-test/t/rpl_row_tabledefs.test:
        New BitKeeper file ``mysql-test/t/rpl_row_tabledefs.test''
      sql/rpl_utility.cc:
        New BitKeeper file ``sql/rpl_utility.cc''
      sql/rpl_utility.h:
        New BitKeeper file ``sql/rpl_utility.h''
      ddef03c4
  30. 05 Apr, 2006 2 commits
    • unknown's avatar
      Fixed bug #16281: Multi-table update broken in 5.0 on tables imported from 4.1 · 6c191f7a
      unknown authored
      Mutli-table uses temporary table to store new values for fields. With the
      new values the rowid of the record to be updated is stored in a Field_string
      field. Table to be updated is set as source table of the rowid field.
      But when the temporary table creates the tmp field for the rowid field it
      converts it to a varstring field because the table to be updated was created by
      the v4.1. Due to this the stored rowids were broken and no records for 
      update were found.
      
      The flag can_alter_field_type is added to Field_string class. When it is set to
      0 the field won't be converted to varstring. The Field_string::type() function 
      now always returns MYSQL_TYPE_STRING if can_alter_field_type is set to 0.
      The multi_update::initialize_tables() function now sets can_alter_field_type
      flag to 0 for the rowid fields denying conversion of the field to a varstring
      field.
      
      
      
      sql/field.h:
        Fixed bug #16281: Multi-table update broken in 5.0 on tables imported from 4.1
        The flag can_alter_field_type is added to Field_string class. When it is set to
        0 the field won't be converted to varstring.
        The Field_string::type() function now always returns MYSQL_TYPE_STRING if 
        can_alter_field_type is set to 0.
      sql/sql_update.cc:
        Fixed bug #16281: Multi-table update broken in 5.0 on tables imported from 4.1
        The multi_update::initialize_tables() function now sets can_alter_field_type
        flag to 0 for the rowid fields denying conversion of the field to a varstring
        field.
      6c191f7a
    • unknown's avatar
      Bug #13601: Wrong int type for bit · e13642dc
      unknown authored
        The wrong value was being reported as the field_length for BIT
        fields, resulting in confusion for at least Connector/J. The
        field_length is now always the number of bits in the field, as
        it should be.
      
      
      mysql-test/r/type_bit.result:
        Add new results
      mysql-test/r/type_bit_innodb.result:
        Add new results
      mysql-test/t/type_bit.test:
        Add new regression test
      mysql-test/t/type_bit_innodb.test:
        Add new regression test
      sql/field.cc:
        Fix Field_bit->field_length to actually report the display width, and
        store the bytes stored in the rec in the new bytes_in_rec member.
      sql/field.h:
        Fix Field_bit::field_length to store the correct value, adding
        Field_bit::bytes_in_rec to remember the number of bytes used for
        storing the value. Remove Field_bit_as_char::create_length, as it
        is now redundant.
      sql/ha_ndbcluster.cc:
        Handle field_length of Field_bit actually being the display width (# of bits).
      sql/key.cc:
        Fix inappropriate use of field->field_length for BIT field.
      e13642dc
  31. 29 Mar, 2006 1 commit
  32. 28 Mar, 2006 1 commit
  33. 01 Mar, 2006 1 commit
    • unknown's avatar
      Merge error · e47c9581
      unknown authored
      sql/field.h:
        Remove multiple definition of "cmp_binary_offset"
      e47c9581
  34. 27 Feb, 2006 1 commit
  35. 24 Feb, 2006 1 commit
    • unknown's avatar
      BUG#13418 (V2): Bit columns should replicate correctly when using RBR · 8495603c
      unknown authored
      mysql-test/r/rpl_bit_npk.result:
        Updated results
      mysql-test/t/disabled.def:
        rpl_bit_npk now works
      sql/field.h:
        Field_bit::cmp_binary_offset wrongly used base class method that does not work for Field_bit
        This was discussed with Monty and should be pushed into 5.0 too
      sql/log_event.cc:
        Added checks for null bits
        Swapped use of m_after_image (was m_search_record) and table->record[1] to use record[i] 
        in the same way as other MySQL code (i.e. use record[1] for scan data).
        Removed use of cmp_binary in record_compare (it is currently wrong to use that 
        without copying the null bits to the compare data record)
      sql/log_event.h:
        Name change to indicate new semantics
      8495603c
  36. 21 Feb, 2006 1 commit
    • unknown's avatar
      A fix and a test case for Bug#13134 "Length of VARCHAR() utf8 · d0ad6d90
      unknown authored
      column is increasing when table is recreated with PS/SP":
      make use of create_field::char_length more consistent in the code.
      Reinit create_field::length from create_field::char_length
      for every execution of a prepared statement (actually fixes the 
      bug).
      
      
      mysql-test/r/ps.result:
        Test results fixed (Bug#13134)
      mysql-test/t/ps.test:
        A test case for Bug#13134 "Length of VARCHAR() utf8 column is 
        increasing when table is recreated with PS/SP"
      sql/field.cc:
        Move initialization of create_field::char_length to the constructor
        of create_field.
      sql/field.h:
        Rename chars_length to char_length (to be consistent with
        how this term is used throughout the rest of the code).
      sql/sql_parse.cc:
        Initialize char_length in add_field_to_list. This function
        effectively works as another create_field constructor.
      sql/sql_table.cc:
        Reinit length from char_length for every field in 
        mysql_prepare_table. This is not needed if we're executing
        a statement for the first time, however, at subsequent executions
        length contains the number of bytes, not characters (as it's expected 
        to).
      d0ad6d90
  37. 27 Jan, 2006 1 commit
  38. 09 Jan, 2006 1 commit
    • unknown's avatar
      This changeset adds support for autoincrements to archive. It allows it to... · 1d5a5ca8
      unknown authored
      This changeset adds support for autoincrements to archive. It allows it to have them with both unique and non-unique indexes. 
      Test cases will come in the next push (just doing this one so I can get a couple of reviews in). This is not the final patch. 
      
      
      sql/field.h:
        Added val_int() method similar to the one like val_str() that will allow you to pop in another pointer and do a test.
      sql/ha_archive.cc:
        Adds auto_increment support to archive. Cleans up a number of other small items.
      sql/ha_archive.h:
        More additions for support of autoincrements
      1d5a5ca8
  39. 03 Jan, 2006 1 commit
    • unknown's avatar
      many warnings (practically safe but annoying) corrected · 12e22065
      unknown authored
      client/mysqladmin.cc:
        don't use the handler after it's closed
      client/mysqlbinlog.cc:
        memory leak
      client/mysqldump.c:
        many "ignore return value" warnings, one "NULL dereference"
      cmd-line-utils/libedit/history.c:
        memory leak
      include/my_base.h:
        cleanup
      libmysql/libmysql.c:
        "return value ignored" warning
      myisam/mi_delete.c:
        "return value ignored" warning
      myisam/myisampack.c:
        "out-of-bound access" warning
      myisam/sort.c:
        "double free" warning
      mysys/default_modify.c:
        "double free" warning
      mysys/mf_iocache2.c:
        "return value ignored" warnings
      mysys/my_bitmap.c:
        s/return/DBUG_RETURN/
      mysys/my_error.c:
        memory leak
      server-tools/instance-manager/parse.cc:
        "NULL dereference" warning
      sql-common/client.c:
        "NULL dereference" warning
      sql/field.cc:
        deadcode, "NULL dereference", "uninitialized" warnings
      sql/field.h:
        unused parameters removed from constructor
      sql/ha_myisam.cc:
        "return value ignored" warnings
      sql/item.cc:
        "return val...
      12e22065