1. 13 Dec, 2003 13 commits
  2. 12 Dec, 2003 15 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.0 · 8c7f319f
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.0.1224
      
      
      8c7f319f
    • unknown's avatar
      btr0cur.c, row0umod.c: · 691bd823
      unknown authored
        Fix bug: if one updated a secondary index column so that its alphabetical value did not change (e.g., abc -> aBc) and rolled back the update, InnoDB failed to return the value in the secondary index to its original value
      row0upd.h:
        Correct typing error
      sync0sync.ic:
        Remove inadvertently pushed sync debug code
      
      
      innobase/include/sync0sync.ic:
        Remove inadvertently pushed sync debug code
      innobase/include/row0upd.h:
        Correct typing error
      innobase/row/row0umod.c:
        Fix bug: if one updated a secondary index column so that its alphabetical value did not change (e.g., abc -> aBc) and rolled back the update, InnoDB failed to return the value in the secondary index to its original value
      innobase/btr/btr0cur.c:
        Fix bug: if one updated a secondary index column so that its alphabetical value did not change (e.g., abc -> aBc) and rolled back the update, InnoDB failed to return the value in the secondary index to its original value
      691bd823
    • unknown's avatar
      Merge vvagin@bk-internal.mysql.com:/home/bk/mysql-4.0 · cd354858
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_1951/mysql-4.0
      
      
      cd354858
    • unknown's avatar
      - Reworked the Do-rpm build script to be more flexible · 77ca2ff1
      unknown authored
       - Reworked testing for gcc3 in the RPM spec file a bit
      
      
      Build-tools/Do-rpm:
        Big overhaul:
        
         - Give the spec file name as the option, not the version number (required
           to be able to build commercial RPMs, too)
         - Some more logging and debugging, more documentation
      support-files/mysql.spec.sh:
         - made testing for gcc3 a bit more robust and not to stomp on user
           settings for CXX
      77ca2ff1
    • unknown's avatar
      changed %ld on %lu for output of mysql_thread_id(&mysql) · 55f6e780
      unknown authored
      as is thread_id has type ulong
      (bug #1951 thread id is printed as "signed" instead of "unsigned" in 'mysql')
      
      
      55f6e780
    • unknown's avatar
      sql_delete.cc, sql_update.cc, sql_class.h: · 0a79eedb
      unknown authored
        Simplification of the previous fix for multi-update/delete.
      
      
      sql/sql_class.h:
        Simplification of the previous fix for multi-update/delete.
      sql/sql_update.cc:
        Simplification of the previous fix for multi-update/delete.
      sql/sql_delete.cc:
        Simplification of the previous fix for multi-update/delete.
      0a79eedb
    • unknown's avatar
      Fix autoincrement for signed columns (Bug #1366) · 759ea82e
      unknown authored
      Fixed problem with char > 128 in QUOTE() function. (Bug #1868)
      Disable creation of symlinks if my_disable_symlink is set
      Fixed searching of TEXT with end space. (Bug #1651)
      Fixed caching bug in multi-table-update where same table was used twice. (Bug #1711)
      Fixed problem with UNIX_TIMESTAMP() for timestamps close to 0. (Bug #1998)
      Fixed timestamp.test
      
      
      include/my_base.h:
        Add HA_END_SPACE_KEY to mark keys that has VARCHAR/TEXT fields.
      myisam/mi_check.c:
        Delete not used variable
      myisam/mi_key.c:
        Fix autoincrement for signed columns (Bug #1366). Patch by Holyfoot
      myisam/mi_open.c:
        Bug fix for future (doesn't affect current code)
      myisam/mi_search.c:
        Ignore end space for VARCHAR/TEXT columns
      mysql-test/r/auto_increment.result:
        Test auto_increment with signed numbers
      mysql-test/r/binary.result:
        Update results (old result was wrong)
      mysql-test/r/func_str.result:
        Added test of QUOTE()
      mysql-test/r/func_time.result:
        Add test of unix_timestamp()
      mysql-test/r/have_met_timezone.require:
        Fixed test
      mysql-test/r/innodb.result:
        Add test for InnoDB behaviour with TRUNCATE
      mysql-test/r/multi_update.result:
        Test of multi-update bug
      mysql-test/r/symlink.result:
        Test of ALTER TABLE and symlinks
      mysql-test/r/timezone.result:
        Test of from_unixtime()
      mysql-test/r/truncate.result:
        Test of truncate and auto_increment
      mysql-test/r/type_blob.result:
        Test of key search on TEXT/VARCHAR column with end space
      mysql-test/t/auto_increment.test:
        Test auto_increment with signed numbers
      mysql-test/t/func_str.test:
        Added test of QUOTE()
      mysql-test/t/func_time.test:
        Add test of unix_timestamp()
      mysql-test/t/innodb.test:
        Add test for InnoDB behaviour with TRUNCATE
      mysql-test/t/multi_update.test:
        Test of multi-update bug
      mysql-test/t/symlink.test:
        Test of ALTER TABLE and symlinks
      mysql-test/t/timezone.test:
        Test of from_unixtime()
      mysql-test/t/truncate.test:
        Test of truncate and auto_increment
      mysql-test/t/type_blob.test:
        Test of key search on TEXT/VARCHAR column with end space
      mysys/my_symlink2.c:
        Disable creation of symlinks if my_disable_symlink is set
      sql/field.h:
        Indentation cleanup
      sql/ha_innodb.cc:
        HA_PART_KEY -> HA_PART_KEY_SEG
      sql/item_strfunc.cc:
        Fixed problem with char > 128 in QUOTE() function. (Bug #1868)
      sql/mysql_priv.h:
        Make check_dup() external
      sql/opt_range.cc:
        Fixed searching of TEXT with end space. (Bug #1651)
      sql/records.cc:
        Fixed caching bug in multi-table-update where same table was used twice.
        (Bug #1711)
      sql/sql_acl.cc:
        Reset ip and ip_mask if hostname is NULL
      sql/sql_parse.cc:
        Make check_dup() global
      sql/sql_select.cc:
        Fixed searching of TEXT with end space. (Bug #1651)
      sql/sql_table.cc:
        Fixed searching of TEXT with end space. (Bug #1651)
      sql/sql_update.cc:
        Fixed caching bug in multi-table-update where same table was used twice.
        (Bug #1711)
      sql/table.cc:
        Fixed searching of TEXT with end space. (Bug #1651)
      sql/table.h:
        Fixed caching bug in multi-table-update where same table was used twice.
        (Bug #1711)
      sql/time.cc:
        Fixed problem with UNIX_TIMESTAMP() for timestamps close to 0. (Bug #1998)
      759ea82e
    • unknown's avatar
      Fix #2093 · e28af60a
      unknown authored
      Update after discussion with Monty
      
      
      sql/sql_select.cc:
        Wrong operation - deleted
      e28af60a
    • unknown's avatar
      Proposed fix for #2093 · 4f90f2fc
      unknown authored
      it happens because of the LEFT JOINT optimization in add_key_part()
      This optimization does exactly the same in JOIN and in WHERE conditions 
      Not right.
      I moved that optimization one level upper.
      
      
      mysql-test/r/join_outer.result:
        appropriate test result
      mysql-test/t/join_outer.test:
        test case
      sql/sql_select.cc:
        optimizing of the left_join now only for WHERE conditions
        and for first table in list
      4f90f2fc
    • unknown's avatar
      Edited fix for #1224. · 429675f4
      unknown authored
      strcpy changed to strmake
      
      
      libmysqld/lib_sql.cc:
        strcpy to strmake
      429675f4
    • unknown's avatar
      Fix for #1224 in 4.0 · 86f62a54
      unknown authored
      we didn't specify thd->priv_host properly
      
      
      libmysqld/lib_sql.cc:
        Specifying of thd->priv_host added
      86f62a54
    • unknown's avatar
      row0upd.h, row0upd.c: · d0f757c0
      unknown authored
        Remove wrong debug assertion and comment
      
      
      innobase/row/row0upd.c:
        Remove wrong debug assertion and comment
      innobase/include/row0upd.h:
        Remove wrong debug assertion and comment
      d0f757c0
    • unknown's avatar
      Many files: · fb9467a7
      unknown authored
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      
      
      innobase/row/row0ins.c:
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      innobase/row/row0sel.c:
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      innobase/row/row0upd.c:
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      innobase/row/row0vers.c:
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      innobase/btr/btr0cur.c:
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      innobase/include/btr0cur.h:
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      innobase/include/row0upd.h:
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      innobase/include/sync0sync.ic:
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      innobase/lock/lock0lock.c:
        Fix assertion failure on line 713 of row0upd.c if there is a column prefix index and the last characters in the prefix are spaces: do not assume that the length of alphabetically equal strings is the same; fix a buglet which could cause InnoDB to think that a secondary index record was not locked though it had been updated in a way which did not alpahabetically change its value, e.g., abc -> aBc
      fb9467a7
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · e0761fbc
      unknown authored
      into mysql.com:/home/dlenev/src/mysql-4.0-mydir2
      
      
      e0761fbc
    • unknown's avatar
      Fix for Bug #1952 · c545b026
      unknown authored
      "SHOW TABLE STATUS very slow w/large number of tables"
      Replaced old algorithm which were used in my_dir() and stored
      all information about directory entries in one chunk of memory
      with new one which stores file names and MY_STAT structures in
      separate memroot, so now we don't need to copy this data during
      reallocation of dir_entry array.
      
      
      include/my_dir.h:
        Changed mystat member of FILEINFO structure to pointer since 
        this prevents unneeded memory allocation and initialization.
        Added comment about new hidden members of MY_DIR structure.
      mysys/my_lib.c:
        Replaced old algorithm in my_dir() which stored all information
        about directory entries in one chunk of memory with new one 
        which stores file names and MY_STAT structures in separate
        memroot. Now we don't copy this data during reallocation of 
        array with FILEINFO structures.
        Also tuned sizes of memory chunks during first-other
        reallocations (we suppose that we either have < 100 files 
        in the directory or > 1000 of them).
      sql/sql_show.cc:
        Updated only place in code where mystat member
        of FILEINFO structure is used.
      c545b026
  3. 11 Dec, 2003 8 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.0 · b196f030
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-4.0-1
      
      
      b196f030
    • unknown's avatar
      Many files: · 9570d010
      unknown authored
        Fixed a bug causing a crash for multi-update/multi-delete
        with impossible where (bug #1860).
      
      
      sql/sql_class.h:
        Fixed a bug causing a crash for multi-update/multi-delete
        with impossible where (bug #1860).
      sql/sql_delete.cc:
        Fixed a bug causing a crash for multi-update/multi-delete
        with impossible where (bug #1860).
      sql/sql_update.cc:
        Fixed a bug causing a crash for multi-update/multi-delete
        with impossible where (bug #1860).
      mysql-test/t/multi_update.test:
        Fixed a bug causing a crash for multi-update/multi-delete
        with impossible where (bug #1860).
      mysql-test/r/multi_update.result:
        Fixed a bug causing a crash for multi-update/multi-delete
        with impossible where (bug #1860).
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      9570d010
    • unknown's avatar
      chk_del() should not check key delete-chain · 22c12eae
      unknown authored
      make a test for -inf more portable (-Inf)
      
      
      client/mysqldump.c:
        make a test for -inf more portable (-Inf)
      myisam/mi_check.c:
        chk_del() should not check key delete-chain
      22c12eae
    • unknown's avatar
      Added --comments mysqldump option (default value is 1). · ba249c10
      unknown authored
      Fixed mysqldump test.
      
      
      client/mysqldump.c:
        Added --comments option (default value is 1).
      mysql-test/r/mysqldump.result:
        fixed using --skip-comment option
      mysql-test/t/mysqldump.test:
        fixed using --skip-comment option
      ba249c10
    • unknown's avatar
      - Rather "bk cat" the files from the mysqldoc BK tree during Bootstrap · 7764d6e5
      unknown authored
         than trying to copy them (they might have been "bk clean"ed and thus
         not available for copying)
       - Brushed up the Bootstrap online help a bit
      
      
      Build-tools/Bootstrap:
         - Rather "bk cat" the files from the mysqldoc BK tree than trying to
           copy them (they might have been "bk clean"ed and thus not available
           for copying)
         - Brushed up the online help a bit
      7764d6e5
    • unknown's avatar
      e6915234
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · 28b1f63a
      unknown authored
      into mysql.com:/my/mysql-4.0
      
      
      mysys/my_thr_init.c:
        Auto merged
      28b1f63a
    • unknown's avatar
      Fixed a possible memory leak on MacOSX when using the shared libmysql.so library (Bug #2061) · 287661e6
      unknown authored
      mysql_server_init() now returns error code if something went wrong (Bug #2062)
      Don't use my_fopen() when reading symlink information as this may cause problems when a lot of files are opened.
      Free thread keys with pthread_key_delete() instead of relying on automatic free. (Bug #2062)
      Fixed bug in UNION statement with alias '*'. (Bug #1249)
      Fixed a bug in DELETE ... ORDER BY ... LIMIT where the rows where not deleted in the proper order. (Bug #1024).
      FOUND_ROWS() could return incorrect number of rows after a query with an impossible WHERE condition.
      HOW DATABASES doesn't anymore show .sym files (on windows) that doesn't point to a valid directory. (Bug #1385)
      
      
      include/config-win.h:
        Ensure that USE_SYMDIR is set for all windows versions
        (This is set in makefiles, so this is just an extra safety measure)
      include/my_pthread.h:
        Fixed a possible memory leak on MacOSX when using the shared libmysql.so library (Bug #2061)
      include/my_sys.h:
        my_init() now returns error code if something went wrong
      include/mysql.h:
        mysql_once_init() now returns error code if something went wrong
      include/mysql_com.h:
        my_init() now returns error code if something went wrong
      libmysql/libmysql.c:
        mysql_server_init() and mysql_once_init() now returns error code if something went wrong (Bug #2062)
      mysql-test/r/limit.result:
        Update results
      mysql-test/r/select_found.result:
        Update results
      mysql-test/r/union.result:
        Update results
      mysql-test/t/limit.test:
        Added test for DELETE ... ORDER BY ... LIMIT (bug #1024)
      mysql-test/t/select_found.test:
        Added test for problem with impossible WHERE (Bug #1468)
      mysql-test/t/union.test:
        Added test for problem with alias '*' (Bug #1249)
      mysys/mf_pack.c:
        Don't use my_fopen() when reading symlink information as this may cause problems when a lot of files are opened.
      mysys/my_init.c:
        my_init() now returns error code if something went wrong
      mysys/my_lib.c:
        More debug information
      mysys/my_thr_init.c:
        Free thread keys with pthread_key_delete() instead of relying on automatic free. (Bug #2062)
      sql/sql_base.cc:
        Fixed bug in UNION statement with alias '*'. (Bug #1249)
      sql/sql_delete.cc:
        Fixed a bug in DELETE ... ORDER BY ... LIMIT where the rows where not deleted in the proper order. (Bug #1024).
      sql/sql_select.cc:
        FOUND_ROWS() could return incorrect number of rows after a query with an impossible WHERE condition.
      sql/sql_show.cc:
        SHOW DATABASES doesn't anymore show .sym files (on windows) that doesn't point to a valid directory. (Bug #1385)
      sql/sql_yacc.yy:
        Allow syntax UNION DISTINCT
      287661e6
  4. 10 Dec, 2003 4 commits