1. 06 Jun, 2005 1 commit
    • unknown's avatar
      Some fixes for Netware. · f511c20d
      unknown authored
      include/my_sys.h:
        Metrowerks compiler has _alloca() nowadays.
        Netware does not have mmap()
      netware/mysql_test_run.c:
        A fix for netware mysql_test_run client.
      f511c20d
  2. 25 May, 2005 1 commit
    • unknown's avatar
      Cleanup during code review · ad519b77
      unknown authored
      Faster detection of wrong table names (like PRN) on windows
      
      
      include/my_sys.h:
        Added check_if_legal_filename()
      mysys/my_access.c:
        Added check_if_legal_filename()
        Set errno if my_access() fails
      mysys/my_fopen.c:
        USe check_if_legal_filename() instead of my_access() to detect wrong file names on windows
      mysys/my_open.c:
        USe check_if_legal_filename() instead of my_access() to detect wrong file names on windows
      sql/sql_lex.cc:
        Portability fix
      sql/sql_parse.cc:
        Simple cleanup
      sql/sql_repl.cc:
        Cleanup during code review
      ad519b77
  3. 20 May, 2005 1 commit
    • unknown's avatar
      BUG# 9148: Denial of service · d7a4a8b6
      unknown authored
      The problem was that on Windows the access method indicates that access to file 
      such as "com1" and "lpt1" is allowed (since they are device names) and
      this causes mysql to attempt to open them as databases or tables.
      
      The fix was to write our own my_access method that uses other Win32 functions
      to determine if the given argument is indeed a file and has to requested
      mode.
      
      
      VC++Files/mysys/mysys.dsp:
        added my_access
      VC++Files/mysys/mysys_ia64.dsp:
        added my_access.c
      include/my_sys.h:
        if on windows, we use my_access.
        if not on windows, then my_access points to the native access method
      mysys/Makefile.am:
        added my_access to mysys build file
      mysys/mf_pack.c:
        changed call to access to my_access
      sql/sql_db.cc:
        changed call to access to my_access
      d7a4a8b6
  4. 19 May, 2005 1 commit
    • unknown's avatar
      Change the return type back to int (modify_defaults_file). · a5949c84
      unknown authored
      This fixes a compilation failure in mysql_com.h, which doesn't have
      'uint' alias visibile. Maybe worth while changing to unsigned int, but
      the rest of functions that work with defaults files return int.
      
      
      include/my_sys.h:
        Change the return type back to int (modify_defaults_file).
      include/mysql_com.h:
        Change the return type back to int (modify_defaults_file).
      mysys/default_modify.c:
        Change the return type back to int (modify_defaults_file).
      a5949c84
  5. 18 May, 2005 1 commit
    • unknown's avatar
      New file default_modify.c. Fixed a typo on mysqld.cc · 1150c4aa
      unknown authored
      Changed name of function my_correct_default_file to
      modify_defaults_file. Improved function and fixed some
      bugs in it.
      
      
      include/my_sys.h:
        Changed function name.
      include/mysql_com.h:
        New function, modify_defaults_file()
      libmysql/Makefile.shared:
        New file, default_modify.lo
      libmysql/libmysql.def:
        New function, modify_defaults_file() and fixed version number.
      libmysqld/libmysqld.def:
        New function, modify_defaults_file()
      mysys/Makefile.am:
        New file, default_modify.c
      mysys/default.c:
        Removed function from default.c. New, corresponding one is in default_modify.c,
        name is modify_defaults_file.
      server-tools/instance-manager/commands.cc:
        Changed function name.
      sql/mysqld.cc:
        Fixed typo.
      1150c4aa
  6. 15 May, 2005 1 commit
    • unknown's avatar
      post-review fixes · 7317af46
      unknown authored
      include/my_sys.h:
        added prototype for the defaults correction function
      libmysql/Makefile.shared:
        my_chsize added to libmysql to let my_correct_defaults_file be used from libmysql
      mysys/default.c:
        New defaults function added we use it to correct defaults file. Currently the function doesn't lock defaults
        file. This is because of the linking and backwards-compatibility issues. This needs to be fixed later.
      mysys/my_chsize.c:
        comment added
      server-tools/instance-manager/buffer.cc:
        cleanup
      server-tools/instance-manager/commands.cc:
        refactoring: removed do_command method from most of the classes
      server-tools/instance-manager/commands.h:
        cleanup
      server-tools/instance-manager/guardian.cc:
        cleanup
      server-tools/instance-manager/instance.cc:
        cleanup
      server-tools/instance-manager/instance_map.cc:
        cleanup
      server-tools/instance-manager/instance_options.cc:
        cleanup
      server-tools/instance-manager/instance_options.h:
        cleanup
      server-tools/instance-manager/listener.cc:
        cleanup
      server-tools/instance-manager/log.cc:
        cleanup
      server-tools/instance-manager/manager.cc:
        cleanup
      server-tools/instance-manager/messages.cc:
        new errors added
      server-tools/instance-manager/mysql_connection.cc:
        cleanup
      server-tools/instance-manager/mysql_manager_error.h:
        new error codes added
      server-tools/instance-manager/mysqlmanager.cc:
        clenup
      server-tools/instance-manager/options.cc:
        cleanup
      server-tools/instance-manager/parse.cc:
        removed unused function
      server-tools/instance-manager/parse.h:
        removed prototype
      server-tools/instance-manager/protocol.cc:
        cleanup
      server-tools/instance-manager/protocol.h:
        added enum to be used in protocol.cc instead of the constants
      7317af46
  7. 05 May, 2005 1 commit
    • unknown's avatar
      terminal.c, sql_bitmap.h, my_sys.h, configure.in, config.h: · 2b9ae6cf
      unknown authored
        Initial Metrowerks CodeWarrior compiler support
      
      
      cmd-line-utils/libedit/config.h:
        Initial Metrowerks CodeWarrior compiler support
      configure.in:
        Initial Metrowerks CodeWarrior compiler support
      include/my_sys.h:
        Initial Metrowerks CodeWarrior compiler support
      sql/sql_bitmap.h:
        Initial Metrowerks CodeWarrior compiler support
      cmd-line-utils/readline/terminal.c:
        Initial Metrowerks CodeWarrior compiler support
      2b9ae6cf
  8. 28 Apr, 2005 2 commits
    • unknown's avatar
      Add default configuration files to my_print_defaults usage, and · f9fdc432
      unknown authored
      add handling of configuration file in the Windows shared system
      directory. (Bug #5354)
      
      
      extra/my_print_defaults.c:
        Print out list of default files that will be used.
      include/my_sys.h:
        Add new my_print_default_files() function.
      mysys/default.c:
        Increase MAX_DEFAULT_DIRS to handle shared Windows directory,
        move the logic for handling the Windows (and OS/2) system directories
        into init_default_directories(), and generalize handling of
        configuration file extensions.
      f9fdc432
    • unknown's avatar
      BUG#5964 - 4.1 MERGE tables regression from 4.0 · d9533bf6
      unknown authored
      Changed the creation of the .MRG file so that only the table  name
      is written when the MyISAM table is in the same database as the
      MERGE table, a relative path is used in other cases in mysqld,
      and possibly an absolute path is used in an embedded server.
      No test case is added as the external behaviour is unchanged.
      Only the file names within the .MRG file are changed.
      
      
      include/my_sys.h:
        BUG#5964 - 4.1 MERGE tables regression from 4.0
        Added declaration for a new function.
      myisammrg/myrg_open.c:
        BUG#5964 - 4.1 MERGE tables regression from 4.0
        Changed check for absolute path to check for any path.
      mysys/my_getwd.c:
        BUG#5964 - 4.1 MERGE tables regression from 4.0
        Added a new functions which checks for absolute _or_
        relative paths.
      sql/ha_myisammrg.cc:
        BUG#5964 - 4.1 MERGE tables regression from 4.0
        Changed the creation of the .MRG file so that only the table  name
        is written when the MyISAM table is in the same database as the
        MERGE table, a relative path is used in other cases in mysqld,
        and possibly an absolute path is used in an embedded server.
      d9533bf6
  9. 05 Apr, 2005 1 commit
    • unknown's avatar
      remove the rest of isam/merge references · 7211da48
      unknown authored
      fix a race condition in TC_LOG_BINLOG::unlog
      
      
      include/Makefile.am:
        remove the rest of isam/merge references
      include/config-win.h:
        unused and abused macro removed
      include/my_pthread.h:
        unused and abused macro removed
      include/my_sys.h:
        MY_IGNORE_BADFD flag
      include/mysql_embed.h:
        remove the rest of isam/merge references
      mysql-test/r/replace.result:
        remove the rest of isam/merge references
      mysql-test/t/replace.test:
        remove the rest of isam/merge references
      mysql-test/t/xa.test:
        comment
      mysys/my_sync.c:
        MY_IGNORE_BADFD flag
      sql/handler.cc:
        remove the rest of isam/merge references
      sql/log.cc:
        fix a race condition in TC_LOG_BINLOG::unlog
        preparation for binlog group commit
      sql/mysql_priv.h:
        remove duplicates
      sql/mysqld.cc:
        remove the rest of isam/merge references
      sql/opt_range.cc:
        remove the rest of isam/merge references
      sql/set_var.cc:
        hide unused variables. simplify sync_binlog code
      sql/sql_base.cc:
        remove the rest of isam/merge references
      sql/sql_class.h:
        cleanup
      7211da48
  10. 25 Mar, 2005 1 commit
    • unknown's avatar
      A fix for Bug#8226 "Cannot connect via shared memory": · 43c3be4a
      unknown authored
      provide created shared memory objects with proper
      access rights to make them usable when client and server
      are running under different accounts. 
      Post review fixes.
      
      
      VC++Files/mysys/mysys.dsp:
        Add my_windac.c to mysys.lib
      include/my_sys.h:
        Declarations for SECURITY_ATTRIBUTES create/destroy functions.
      mysys/Makefile.am:
        Add my_windac.c to the list of compiled files.
      sql-common/client.c:
        Lower requested access rights for events as the server won't 
        provide clients with ALL access in order to prevent denial
        of service attack.
      sql/mysqld.cc:
        Set proper security attributes for the kernel objects to make them
        usable when mysqld is running as a Windows service.
      43c3be4a
  11. 17 Mar, 2005 1 commit
    • unknown's avatar
      Field::quote_data(): · 4fc733ca
      unknown authored
        don't call escape_string_for_mysql() unnecesary
        don't overwrite local buffer
      escape_string_for_mysql():
        take a length of the destination buffer as an argument
      
      
      include/my_sys.h:
        prototype changed
      libmysql/libmysql.c:
        prototype changed
      mysys/charset.c:
        escape_string_for_mysql():
          take a length of the destination buffer as an argument
      sql/field.cc:
        Field::quote_data():
          don't call escape_string_for_mysql() unnecesary
          don't overwrite local buffer
      sql/item.cc:
        prototype changed
      sql/sql_prepare.cc:
        prototype changed
      4fc733ca
  12. 15 Mar, 2005 1 commit
    • unknown's avatar
      include/my_global.h · c286b086
      unknown authored
          define _XOPEN_SOURCE=500 for solaris
      include/my_sys.h
          remove a cast
      
      
      include/my_global.h:
        define _XOPEN_SOURCE=500 for solaris
      include/my_sys.h:
        remove a cast
      c286b086
  13. 08 Mar, 2005 1 commit
    • unknown's avatar
      Fixed Bug#8922. · 67ebe351
      unknown authored
      Reverted Jim's patch.
      
      
      client/mysql.cc:
        Fixed Bug#8922, The deilimeter cannot be reset after it is set as word 'delimiter'
      include/my_sys.h:
        Reverted Jim's patch.
      mysys/mf_iocache.c:
        Reverted Jim's patch.
      sql/sql_class.h:
        Reverted Jim's patch.
      67ebe351
  14. 04 Mar, 2005 1 commit
  15. 03 Mar, 2005 2 commits
    • unknown's avatar
      Prevent a collision with the system's '#define errno ...' by guarding the variable declaration. · 2cc4745b
      unknown authored
      include/my_sys.h:
        There are platforms which use '#define errno ...' and then cause a collision with
        'extern int errno;', one example is OpenBSD.
        Rather than treat them explicitly by the 'HAVE_ERRNO_AS_DEFINE', we can check for these
        by using '#ifndef errno'.
      2cc4745b
    • unknown's avatar
      Avoid calls to my_seek() and my_tell() on log files so that · 6086c3a9
      unknown authored
      non-seekable files like FIFOs can be used for logs other
      than the binlog. (Bug #8271)
      
      
      include/my_sys.h:
        Add APPEND_CACHE cache type
      mysys/mf_iocache.c:
        Handle APPEND_CACHE cache type to avoid calling my_seek() and my_tell()
        on logs opened O_APPEND that we never read from (so they can be a
        non-seekable file like a FIFO).
      sql/mysqld.cc:
        Use APPEND_CACHE for log files not set to SEQ_READ_APPEND.
      6086c3a9
  16. 22 Feb, 2005 1 commit
    • unknown's avatar
      compatibility fixes, crashing tests · c9995ef4
      unknown authored
      include/my_sys.h:
        sol9x86, sunfire100b, qnx compatibility
      mysql-test/t/rpl_rotate_logs.test:
        fix the test
      sql/ha_innodb.cc:
        don't bother
      sql/handler.cc:
        few more ways to crash mysqld :)
      sql/handler.h:
        gdb/safemalloc workaround
      sql/log.cc:
        rotate a binlog on heuristic recover
      sql/mysqld.cc:
        rotate a binlog on heuristic recover
      c9995ef4
  17. 20 Feb, 2005 1 commit
  18. 19 Feb, 2005 1 commit
  19. 18 Feb, 2005 1 commit
    • unknown's avatar
      made IM to work with --defaults-file smoothly · 94cefae6
      unknown authored
      BitKeeper/deleted/.del-my.cnf~9322f78f12eb2f3c:
        Delete: support-files/my.cnf
      include/my_sys.h:
        fixed prototype to reflect changes in default.c
      mysys/default.c:
        use my_search_option_files instead of process_default_option_files. This is used from the IM.
      server-tools/instance-manager/instance.cc:
        added parameter to complete_initialization(). this ine marks whether we are creating the only instance
        (for instance, when no config file given)
      server-tools/instance-manager/instance.h:
        prototype changed
      server-tools/instance-manager/instance_map.cc:
        Now call my_search_option_files to work smootly with --defaults-file
      server-tools/instance-manager/instance_map.h:
        added first_option member. This is set of mysqlmanager was started with --defaults-file or with
        --extra-defaults-file to be passed to the my_search_option_files
      server-tools/instance-manager/instance_options.cc:
        if we have only one instance, name the pidfile `hostname`.pid for compatibility reasons.
      server-tools/instance-manager/instance_options.h:
        header fixed according to .cc
      server-tools/instance-manager/manager.cc:
        prototype fixed
      server-tools/instance-manager/options.cc:
        save --defaults-file of --defaults-extra-file to pass it to my_search_option_files
      server-tools/instance-manager/options.h:
        added an optin to save --default-file options
      support-files/Makefile.am:
        revert changes
      94cefae6
  20. 26 Jan, 2005 1 commit
  21. 15 Jan, 2005 1 commit
  22. 03 Jan, 2005 1 commit
    • unknown's avatar
      fix for bug #5920 (embedded-server mysql doesn't handle --defaults-file) · da04be23
      unknown authored
      client/mysql.cc:
        bug #5920 (embedded-server mysql doesn't handle --defaults-file)
        defaults files handled
      include/my_sys.h:
        bug #5920 (embedded-server mysql doesn't handle --defaults-file)
        get_defaults_file interface added
      libmysqld/libmysqld.c:
        just small fix, not related to the bug.
      mysys/default.c:
        bug #5920 (embedded-server mysql doesn't handle --defaults-file)
        get_defaults_files implementation
      da04be23
  23. 23 Dec, 2004 1 commit
    • unknown's avatar
      WL#1895 - Print message to error log in case of detected MyISAM corruption · af80e6f3
      unknown authored
      Changed my_error() to print error messages, which come from
      arbitrary registered ranges of error messages. Messages can
      be unregistered (and should be at end of the program).
      Added registration of handler error messages.
      Added a new mi_print_error() macro and a new 
      mi_report_error() function, which supply error
      messages with a table name.
      Added calls to mi_print_error() or mi_report_error()
      at all places in MyISAM, where table corruption is detected.
      
      
      extra/comp_err.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added prints for ER_ERROR_FIRST and ER_ERROR_LAST.
        Removed print for ER_ERROR_MESSAGES.
      include/errmsg.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added declaration for a new function.
        Added first and last error number defines.
      include/my_base.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added first and last error number defines.
      include/my_sys.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Removed obsolete defines.
        Removed a global variable, which held pointers to the error message arrays.
        Added declarations for new functions.
      include/mysys_err.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Removed an obsolete define.
        Changed two defines to use the new defines.
        Added first and last error number defines.
      libmysql/errmsg.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Replaced global array initialization by proper registration
        and unregistration of client error messages.
      libmysql/libmysql.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added a call for unregistration of client error messages.
      myisam/mi_delete.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
        Added a debugging call to test undefined error numbers in case a special
        debug string is set.
      myisam/mi_extra.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_info.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added the error logging function.
      myisam/mi_key.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_keycache.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_locking.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_open.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
      myisam/mi_page.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_range.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_rkey.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_search.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
      myisam/mi_update.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
      myisam/mi_write.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added calls to the new error logging function at all places, where
        corruption is detected.
        Added a debugging call to pretend MyISAM corruption in case a special
        debug string is set.
      myisam/myisamdef.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added the declaration of the new error logging function
        and a new macro.
      mysql-test/r/merge.result:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed test results. These come from the changed error reporting
        in openfrm().
      mysql-test/r/repair.result:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed test results. These come from the changed error reporting
        in openfrm().
      mysql-test/t/merge.test:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changederror numbers. These come from the changed error reporting
        in openfrm().
      mysys/errors.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Dropped the assignment of the global errors to the
        dropped global pointer array.
      mysys/my_error.c:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed my_error() from using a static array of pointers to
        error message arrays to using a linked list of structures
        with pointers to array message arrays.
        Added functions for registering and unregistering error 
        message arrays to the chain.
      sql/derror.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed reading of mysqld error messages to using the new
        registering and unregistering functions.
      sql/handler.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Added initialization and deinitialization of handler error messages.
        Included more handler error messages in the mapping to
        mysqld error messages.
      sql/mysqld.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed deinitialization of error messages to proper
        unregistration.
      sql/table.cc:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed error reporting in openfrm() so that error messages from
        handler::ha_open() are reported by handler::print_error(). This
        changed messages from "Can't open 't1.MYI' (errno: 130)" to
        "Incorrect file format 't1'" for example.
      sql/unireg.h:
        WL#1895 - Print message to error log in case of detected MyISAM corruption
        Changed two defines to use the new defines.
      af80e6f3
  24. 14 Dec, 2004 1 commit
  25. 28 Nov, 2004 1 commit
    • unknown's avatar
      protection: TRASH in delete · b7c31a9e
      unknown authored
      fixed a bug that it discovered
      
      
      include/my_sys.h:
        move TRASH to my_sys.h from sql_list.h
      sql/field.h:
        use TRASH macro
      sql/item.h:
        TRASH in delete
      sql/item_func.h:
        never delete item's manually!
      sql/opt_range.cc:
        TRASH in delete
      sql/sql_lex.h:
        TRASH in delete
      sql/sql_list.h:
        move TRASH to my_sys.h from sql_list.h
      sql/sql_parse.cc:
        don't use properties of deleted objects (even when it's safe)
      sql/sql_select.cc:
        TRASH in delete
      sql/sql_show.cc:
        TRASH in delete
      sql/sql_string.h:
        TRASH in delete
      b7c31a9e
  26. 10 Nov, 2004 1 commit
    • unknown's avatar
      Added possibility to detect if libmysqld is restarted · bbacfb85
      unknown authored
      (Needed to check if memory allocated with mysql_once_init() has been freed)
      
      
      
      include/my_sys.h:
        Added possibility to detect if libmysqld is restarted
      mysys/my_init.c:
        Added possibility to detect if libmysqld is restarted
      sql/handler.cc:
        Detect if libmysqld is restarted
        Simple optimization of ha_known_exts()
      bbacfb85
  27. 07 Nov, 2004 1 commit
  28. 04 Nov, 2004 1 commit
    • unknown's avatar
      mmap portability layer, mmap for Windows · bda90564
      unknown authored
      new macro: thread_safe_decrement, thread_safe_dec_and_test, statistic_decrement
      
      
      mysys/my_chsize.c:
        cleanup
      include/config-win.h:
        mmap portability layer, mmap for Windows
      include/my_pthread.h:
        thread_safe_decrement, thread_safe_dec_and_test, statistic_decrement
      include/my_sys.h:
        mmap portability layer, mmap for Windows
      mysys/Makefile.am:
        mmap portability layer, mmap for Windows
      bda90564
  29. 14 Oct, 2004 1 commit
    • unknown's avatar
      true,false -> TRUE, FALSE · b76f5cd2
      unknown authored
      Simple fixes/optimization of things discovered during review of new pushed code
      
      
      include/my_sys.h:
        Ensure that clear_alloc_root() interacts correctly with alloc_root_inited()
      mysys/hash.c:
        More comments
        Simple optimization (merge identical code)
      mysys/my_bitmap.c:
        Change inline -> static inline
      sql/examples/ha_archive.cc:
        Fixed compiler warning
      sql/ha_ndbcluster.cc:
        true,false -> TRUE, FALSE
        Change if (false) -> #ifdef NOT_USED
      sql/ha_ndbcluster.h:
        true,false -> TRUE, FALSE
      sql/handler.cc:
        More comments
        Remove not needed initializations.
        #ifdef not used code
      sql/item_cmpfunc.h:
        true,false -> TRUE, FALSE
      sql/item_strfunc.cc:
        Move local variables to function beginning
        Remove wrong comments
      sql/log_event.h:
        true,false -> TRUE, FALSE
      sql/sql_base.cc:
        true,false -> TRUE, FALSE
        More comments
      sql/sql_help.cc:
        true,false -> TRUE, FALSE
      sql/sql_lex.cc:
        Simple optimization of new code
      sql/sql_parse.cc:
        true,false -> TRUE, FALSE
      sql/sql_prepare.cc:
        true,false -> TRUE, FALSE
      sql/sql_table.cc:
        true,false -> TRUE, FALSE
      sql/sql_yacc.yy:
        true,false -> TRUE, FALSE
      b76f5cd2
  30. 23 Sep, 2004 1 commit
    • unknown's avatar
      Implementation of Monty's idea about clear_alloc_root() optimization and cleanup of work · cf9e30b8
      unknown authored
      with memory roots in THD/Statement/Item_arena.
      Added assertions preventing memory allocation on bzero'ed MEM_ROOT since it is worked by 
      pure luck and was very ineffective.
      
      
      include/my_sys.h:
        Reimplementation of Monty's optimization of clear_alloc_root().
        Now clear_alloc_root() can be used only for detaching memory associated with MEM_ROOT
        (e.g. to avoid its freeing). It can not be used for MEM_ROOT initialization any longer 
        (it was bad idea anyway since memory allocation on such MEM_ROOT was very ineffective 
        and worked by pure luck).
        Introduced ALLOC_ROOT_MIN_BLOCK_SIZE constant.
      mysys/my_alloc.c:
        Added description of init_alloc_root().
        Added assertions to alloc_root() and reset_root_defaults() so now they can only be used
        on previosly initialized MEM_ROOT. (It worked for bzeroed MEM_ROOT before but 
        by pure luck and very inefficiently). Calling free_root() on bzero'ed MEM_ROOT
        is still ok (we can't remove this easily because of static MEM_ROOTs).
        Also now using ALLOC_ROOT_MIN_BLOCK_SIZE constant inside these functions.
      sql/opt_range.cc:
        Fixed get_quick_select_for_ref() function to not use bzero'ed MEM_ROOT for allocation.
        Also QUICK_RANGEs created in this function should be created in memory root of QUICK_SELECT.
      sql/sql_class.cc:
        Implementation of Monty's idea about clear_alloc_root() optimization and cleanup of work 
        with memory roots in THD/Statement/Item_arena.
        Now we are always initing THD::transaction.mem_root and THD::mem_root in THD constructor 
        (without memory allocation and with minimal block size) and then later change their
        parameters in THD::init_for_queries() (this is partially because we can't allocate anything
        on bzero'ed memory roots anymore).
        Item_arena() constructor is now trivial and is used only then Item_arena is created as backup
        storage for other Item_arena (we use Item_arena(bool) now if it is part of Statement).
        Both trivial Item_arena constructor and destructor are now inline.
        Removed unneeded clear_alloc_root from Item_arena::restore_backup_item_arena().
      sql/sql_class.h:
        Both trivial Item_arena constructor and destructor are now inline.
        Commented various Item_arena constructors.
      cf9e30b8
  31. 13 Sep, 2004 2 commits
  32. 09 Sep, 2004 1 commit
    • unknown's avatar
      After merge fixes of merge with 4.1 that included the new arena code. · 74e8c6af
      unknown authored
      Fixed (together with Guilhem) bugs in mysqlbinlog regarding --offset
      Prefix addresses with 0x for easier comparisons of debug logs
      Fixed problem where MySQL choosed index-read even if there would be a much better range on the same index
      This fix changed some 'index' queries to 'range' queries in the test suite
      Don't create 'dummy' WHERE clause for trivial WHERE clauses where we can remove the WHERE clause.
      This fix removed of a lot of 'Using where' notes in the test suite.
      Give NOTE instead of WARNING if table/function doesn't exists when using DROP IF EXISTS
      Give NOTE instead of WARNING for safe field-type conversions
      
      
      Makefile.am:
        Don't automaticly update files from bk
      client/mysqlbinlog.cc:
        Merge with 4.1 (+ apply bug fixes for --offset and --start-position)
      include/my_sys.h:
        Faster clear_alloc_root()
      mysql-test/r/bdb.result:
        Updated results after merge
      mysql-test/r/create.result:
        Updated results after merge
      mysql-test/r/func_group.result:
        Updated results after merge
      mysql-test/r/func_if.result:
        Updated results after merge
      mysql-test/r/heap_btree.result:
        Updated results after merge
      mysql-test/r/index_merge.result:
        Updated results after merge
      mysql-test/r/index_merge_ror.result:
        Updated results after merge
      mysql-test/r/innodb.result:
        Updated results after merge
      mysql-test/r/join_outer.result:
        Updated results after merge
      mysql-test/r/mysqlbinlog2.result:
        Updated results after merge
      mysql-test/r/negation_elimination.result:
        Updated results after merge
      mysql-test/r/null.result:
        Updated results after merge
        Added more tests
      mysql-test/r/null_key.result:
        Updated results after merge
        Added more tests
      mysql-test/r/order_by.result:
        Updated results after merge
      mysql-test/r/range.result:
        Updated results after merge
        Added more tests
      mysql-test/r/rpl_charset.result:
        Updated results after merge
      mysql-test/r/sp-error.result:
        Updated results after merge
      mysql-test/r/sp.result:
        Updated results after merge
        Added delete of some stored procedures in an attempt to be able to re-run test even if it aborts in the middle
      mysql-test/r/type_blob.result:
        Updated results after merge
        (Some warnings are now notes)
      mysql-test/r/user_var.result:
        Updated results after merge
        Added more tests
      mysql-test/r/variables.result:
        Updated results after merge
      mysql-test/r/view.result:
        Updated results after merge
      mysql-test/t/mysqlbinlog2.test:
        Updated tests to use new positions
      mysql-test/t/null.test:
        More tests
      mysql-test/t/null_key.test:
        More tests
      mysql-test/t/range.test:
        More tests
      mysql-test/t/rpl_charset.test:
        Avoid big diffs in the future if tests changes
      mysql-test/t/sp-error.test:
        Updated error numbers
      mysql-test/t/sp-security.test:
        Updated error numbers
      mysql-test/t/sp.test:
        Updated results after merge
        Added delete of some stored procedures in an attempt to be able to re-run test even if it aborts in the middle
      mysql-test/t/user_var.test:
        More tests
      mysql-test/t/view.test:
        Updated error numbers
      mysys/my_alloc.c:
        Write into debug log the address of the allocated area
      sql/ha_isam.cc:
        Prefix addresses with 0x for easier comparisons of debug logs
      sql/ha_myisam.cc:
        Prefix addresses with 0x for easier comparisons of debug logs
      sql/ha_ndbcluster.cc:
        Add missing enum to switch
      sql/handler.cc:
        remove compiler warning
      sql/item.cc:
        More debugging
        Simple cleanup
      sql/item.h:
        Move Item::cleanup() to item.cc
      sql/item_cmpfunc.cc:
        Fix arena code
      sql/item_subselect.cc:
        After merge fixes
      sql/item_subselect.h:
        After merge fixes
      sql/item_sum.cc:
        Updated comment
      sql/log_event.cc:
        Remove wrong test
      sql/mysql_priv.h:
        Indentation fixes
      sql/mysqld.cc:
        After merge fixes
        Added 0x to pointers in debug log
      sql/opt_range.cc:
        Fixed problem where MySQL choosed index-read even if there would be a much better range on the same index
        This fix changed some 'index' queries to 'range' queries in the test suite
      sql/set_var.cc:
        Indentation fixes
      sql/sp_head.cc:
        Set state to INITIALIZED to make SP work with new arena code
      sql/sql_base.cc:
        After merge fixes
      sql/sql_class.cc:
        More debugging
        Use clear_alloc_root() instead of init_alloc_root() as the former is faster
      sql/sql_class.h:
        New method 'only_prepare()'
      sql/sql_lex.cc:
        After merge fixes
      sql/sql_lex.h:
        After merge fixes
      sql/sql_parse.cc:
        Fix for timezone tables. (The old way to add timezone tables to global list in 'create_total_list' doesn't work anymore)
        Give NOTE instead of WARNING if table/function doesn't exists when using DROP IF EXISTS
      sql/sql_prepare.cc:
        After merge fixes
      sql/sql_select.cc:
        Don't create 'dummy' WHERE clause for trivial WHERE clauses where we can remove the WHERE clause.
        This fix removed of a lot of 'Using where' notes in the test suite
      sql/sql_table.cc:
        Give NOTE instead of WARNING if table/function doesn't exists when using DROP IF EXISTS
      sql/sql_union.cc:
        After merge fix
      sql/sql_view.cc:
        After merge fix
      sql/table.cc:
        After merge fix
      sql/tztime.cc:
        Update timezone table handling to use new table lists structure
      sql/tztime.h:
        Update timezone table handling to use new table lists structure
      sql/unireg.cc:
        Use 0x before pointers
      74e8c6af
  33. 30 Aug, 2004 1 commit
    • unknown's avatar
      Please rewiev. Here added a function to process config. files options. · 8e2f1a1d
      unknown authored
      A lot of the default.c module code was refactored. The patch is needed
      for the IM.
      
      
      include/my_sys.h:
        Definitions added.
      mysys/default.c:
        Added new api call: process_default_option_files. Also some coments
        changed to reflect current state of the code. It takes Basename for
        config file and the function to process options. The function is called
        everytime when we find an option. This way it is possible to get and
        process options from several groups in one file traversal.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      8e2f1a1d
  34. 19 Aug, 2004 1 commit
    • unknown's avatar
      Bug #4466 Nothing in .err when mysql service ends because of malformed my.ini options · f0d86d71
      unknown authored
      my_getopt.c:
        Moved the inclusion of my_getopt.h down below the inclusion of my_sys.h so that enum loglevel definition would be available
      my_sys.h, my_getopt.h:
        moved definition of enum loglevel from my_getopt.h to my_sys.h
      
      
      include/my_getopt.h:
        moved definition of enum loglevel from my_getopt.h to my_sys.h
      include/my_sys.h:
        moved definition of enum loglevel from my_getopt.h to my_sys.h
      mysys/my_getopt.c:
        Moved the inclusion of my_getopt.h down below the inclusion of my_sys.h so that enum loglevel definition would be available
      f0d86d71
  35. 29 May, 2004 1 commit
  36. 24 May, 2004 1 commit
    • unknown's avatar
      Support for character set conversion in binary protocol: another go · eff961a9
      unknown authored
      after Monty's review.
      - Item_param was rewritten.
      - it turns out that we can't convert string data to character set of
        connection on the fly, because they first should be written to the binary
        log.
        To support efficient conversion we need to rewrite prepared statements
        binlogging code first.
      
      
      include/my_global.h:
        Macro swap(a, b, c) was renamed to resolve name conflict with
        String::swap() method.
      include/my_sys.h:
        Added declaration of escape_string_for_mysql()
      include/mysql_com.h:
        Removed and moved back: a macro which is visible to libmysql user but
        has sence only in prepared statement protocol implementation.
      isam/_search.c:
        swap -> swap_variables
      isam/test2.c:
        swap -> swap_variables
      libmysql/libmysql.c:
        - sub_escape_string moved to mysys/charset.c to be visible in sql/
        - few cleanups
      myisam/mi_test2.c:
        swap -> swap_variables
      mysys/charset.c:
        sub_escape_string was moved from libmysql.c to be able to use it in...
      eff961a9
  37. 12 May, 2004 1 commit
    • unknown's avatar
      This is first cset for WL#1394 "Optimize index merge when all involved index... · f63352d3
      unknown authored
      This is first cset for WL#1394 "Optimize index merge when all involved index ranges include only values with equal keys"
      The main idea is to exploit the fact that key scans for "key=const" return ordered sequences of rowids.
      
      
      include/my_base.h:
        Added HA_EXTRA_KEYREAD_PRESERVE_FIELDS flag
      include/my_bitmap.h:
        Added a couple of utility functions
      include/my_sys.h:
        Added my_conunt_bits_ushort function
      innobase/include/row0mysql.h:
        Added support for HA_EXTRA_KEYREAD_PRESERVE_FIELDS
      innobase/row/row0sel.c:
        Added support for HA_EXTRA_KEYREAD_PRESERVE_FIELDS
      mysys/my_bit.c:
        Added my_count_bits_ushort function
      mysys/my_bitmap.c:
        Added a couple of utility functions
      sql/ha_berkeley.cc:
        Added cmp_ref rowid comparison function.
      sql/ha_berkeley.h:
        Added cmp_ref rowid comparison function.
      sql/ha_heap.h:
        Added cmp_ref rowid comparison function.
      sql/ha_innodb.cc:
        Added cmp_ref rowid comparison function and support from HA_EXTRA_KEYREAD_PRESERVE_FIELDS
      sql/ha_innodb.h:
        Added cmp_ref rowid comparison function.
      sql/handler.h:
        Added cmp_ref rowid comparison function.
      sql/opt_range.cc:
        Added QUICK_ROR_{INTERSECT,UNION}_SELECT classes and related optimizer code
      sql/opt_range.h:
        Added QUICK_ROR_{INTERSECT,UNION}_SELECT classes
      sql/sql_delete.cc:
        Changed to use new ROWID comparison function
        also always call quick->reset() for quick selects
      sql/sql_select.cc:
        Account for new quick select types
      sql/sql_select.h:
        New, proper rowid ordering/comparison function to be used with Unique class etc.
      sql/sql_test.cc:
        Account for new quick select types
      sql/sql_update.cc:
        Account for new quick select types
      f63352d3