1. 27 Mar, 2008 4 commits
  2. 26 Mar, 2008 2 commits
    • unknown's avatar
      Merge kaamos.(none):/data/src/bugteam/bug34928/my51 · 3834b3d5
      unknown authored
      into  kaamos.(none):/data/src/bugteam/mysql-5.1-bugteam
      
      
      3834b3d5
    • unknown's avatar
      Fix for bug #34928: Confusion by having Primary Key and Index · b4b72fb3
      unknown authored
      The bug is a regression introduced in 5.1 by the patch for bug28404.
      
      Under some circumstances test_if_skip_sort_order() could leave some
      data structures in an inconsistent state so that some parts of code
      could assume the selected execution strategy for GROUP BY/DISTINCT as
      a loose index scan (e.g. JOIN_TAB::is_using_loose_index_scan()), while
      the actual strategy chosen was an ordered index scan, which led to
      wrong data being returned.
      
      Fixed test_if_skip_sort_order() so that when changing the type for a
      join table, select->quick is reset not only for EXPLAIN, but for the 
      actual join execution as well, to not confuse code that depends on its
      value to determine the chosen GROUP BY/DISTINCT strategy.
      
      
      mysql-test/r/distinct.result:
        Added a test case for bug #34928.
      mysql-test/t/distinct.test:
        Added a test case for bug #34928.
      sql/sql_select.cc:
        When changing the table's join type to JT_NEXT in 
        test_if_skip_sort_order(), also reset select->quick because other
        code may depend on its value to determine the GROUP BY/DISTINCT
        execution strategy.
      b4b72fb3
  3. 25 Mar, 2008 2 commits
    • unknown's avatar
      Bug#35272: @@global.key_buffer_size = 4294967295 let the server crash · c3641cd5
      unknown authored
      When trying to get the requested amount of memory for the keybuffer,
      the out of memory could be signaled if one of the tentative allocations
      fail. Later the server would crash (debug assert) when trying to send
      a ok packet with a error set.
      
      The solution is only to signal the error if all tentative allocations
      for the keybuffer fail.
      
      
      mysql-test/r/key_cache.result:
        Add test case result for Bug#35272
      mysql-test/t/key_cache.test:
        Add test case for Bug#35272
      mysys/mf_keycache.c:
        Don't set error on my_large_malloc if allocation fails.
        Set the error if all tentative allocations failed.
      c3641cd5
    • unknown's avatar
      Fix for Bug #27944 Filtering THD::client capabilities · 2d5a444d
      unknown authored
      The server used to trust blindly information from the client about
      its capabilities. During the connection handshake the server sends
      information about what it supports and then the client sends back a
      set of capabilities which cover all of the server's or less.
      Before this changeset the server didn't check whether the flags sent
      by the client were valid for the server. For example, if the server
      doesn't support compressed protocol but the client does and sends that
      bit turned on, the server didn't check it. The change make the server code
      less error prone to problems related to the value of THD::client_capabilities.
      
      Clearly there is no vulnerability being fixed but this is a maintainenance
      fix to prevent misusage in the future.
      
      
      include/mysql_com.h:
        List all CLIENT flags in a common defition. Add also a definition
        which excludes flags, which are optoinal.
      sql/sql_connect.cc:
        Renamed client_flags to server_capabilities to reflect what
        the server supports. Only allow from the client the flags the
        server supports.
      2d5a444d
  4. 14 Mar, 2008 5 commits
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl · 92a09cf9
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      sql/slave.cc:
        Auto merged
      sql/sql_repl.h:
        Auto merged
      92a09cf9
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · 774d21cf
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      mysql-test/include/commit.inc:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/r/commit_1innodb.result:
        Auto merged
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_ctype_ucs.result:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/rpl_rli.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      774d21cf
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0 · 4097ee7f
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl
      
      
      4097ee7f
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 0b7d39fd
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Auto merged
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        Auto merged
      0b7d39fd
    • unknown's avatar
      Post-merge fixes. · 45978147
      unknown authored
      
      mysql-test/extra/rpl_tests/rpl_loaddata.test:
        Removing SHOW MASTER STATUS that does not seem to make sense.
      mysql-test/extra/rpl_tests/rpl_log.test:
        Correcting test case to sync slave with master.
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Result change.
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        Removing unsafe variable from list of safe variables.
      mysql-test/suite/rpl/r/rpl_loaddata.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_skip_error.result:
        Result change.
      mysql-test/suite/rpl/t/rpl_skip_error.test:
        Correcting bad manual+automatic merge. Test is now only relevant for statement-
        based replication.
      sql/rpl_rli.cc:
        Correcting automerge undoing previous change of return value.
        Relay_log_info::wait_for_pos() should return -2 when not initialized to work
        correctly.
      45978147
  5. 13 Mar, 2008 2 commits
  6. 12 Mar, 2008 11 commits
    • unknown's avatar
      3155a88d
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl · 62dee6f7
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      mysql-test/suite/rpl/r/rpl_loaddata.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_master_pos_wait.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_slave_status.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_master_pos_wait.test:
        Auto merged
      mysql-test/suite/rpl/t/rpl_temporary.test:
        Auto merged
      mysql-test/suite/rpl/t/rpl_loaddata.test:
        Manual merge. The rpl_loaddata.test file was moved on 5.1 by editing
        the file to include the file at the new location. This causes conflicts
        when merging, since the changes will not propagate to the moved file.
      sql/slave.cc:
        Manual merge.
      mysql-test/suite/rpl/t/rpl_skip_error.test:
        Manual merge.
      mysql-test/suite/rpl/t/rpl_slave_status.test:
        Manual merge.
      62dee6f7
    • unknown's avatar
      Merge ssh://bk-internal.mysql.com//home/bk/mysql-5.1-opt · 6c2f9bf5
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      sql/sql_show.cc:
        Auto merged
      sql/table.h:
        Auto merged
      6c2f9bf5
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 9fcf16a0
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      tests/mysql_client_test.c:
        Manual merge.
      9fcf16a0
    • unknown's avatar
      Post-merge fix. · fe846378
      unknown authored
      fe846378
    • unknown's avatar
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 69d49bca
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      scripts/mysql_config.sh:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      69d49bca
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.1 · d6df18dd
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      client/mysqldump.c:
        Auto merged
      configure.in:
        Auto merged
      include/my_global.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/disabled.def:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/ndb/src/kernel/blocks/backup/Backup.hpp:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/func_time.result:
        Manual merge.
      mysql-test/r/view.result:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      scripts/mysql_config.sh:
        Manual merge.
      sql-common/client.c:
        Manual merge.
      sql/sql_parse.cc:
        Manual merge.
      d6df18dd
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-4.1-opt · 66507ba8
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      
      66507ba8
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.0 · 09f8a4af
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      
      client/mysql.cc:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/view.result:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      scripts/mysql_config.sh:
        Manual merge.
      09f8a4af
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-4.1 · 6dfe411c
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-4.1-opt
      
      
      6dfe411c
  7. 11 Mar, 2008 5 commits
    • unknown's avatar
      Removed pushbuild errors. · 40515ad7
      unknown authored
      Problem: rpl_variables_stm.test used a character set and a collation which
      are not included on all platforms.
      Fix: replace the character set and collation by ones that are included on
      all platforms. (rpl_variables_stm does not rely on which character set is
      used, the only important aspect is the fact that it changes.)
      
      
      mysql-test/suite/rpl/r/rpl_variables_stm.result:
        Updated result file.
      mysql-test/suite/rpl/t/rpl_variables_stm.test:
        Changed test to get rid of pushbuild errors.
      40515ad7
    • unknown's avatar
      BUG#31024: STOP SLAVE does not stop attempted connect()s · 1836625f
      unknown authored
      Problem: if the IO slave thread is attempting to connect,
      STOP SLAVE waits for the attempt to finish. 
      It may take a long time.
      Fix: don't wait, stop the slave immediately.
      
      
      sql/slave.cc:
        Send a SIGALRM signal to the slave thread when stopping it (using
        pthread_kill()). This breaks current socket(), connect(), poll() etc.
        calls, and makes the subsequent thd->awake() call effective.
        
        Also, move the definition of KICK_SLAVE to slave.cc.
      sql/sql_repl.h:
        Removed KICK_SLAVE and inlined it in slave.cc because:
         - it was only called once, so better to make it local to where it is used
         - it needed to include a preprocessor conditional in the middle
      1836625f
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · a5e775b4
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/r/null_key.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sql_select.cc:
        Manual merge.
      a5e775b4
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.1-opt · f9bbd753
      unknown authored
      into  riffraff.(none):/data0/martin/bug34367/my51-bug34367-pushee
      
      
      f9bbd753
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 74783c57
      unknown authored
      into  mysql.com:/home/hf/work/32801/my51-32801
      
      
      74783c57
  8. 10 Mar, 2008 9 commits
    • unknown's avatar
      Problem: sporadic pushbuild errors in rpl_ndb_basic. · 1273b97d
      unknown authored
      The reason is that we are using a sleep to wait for slave to reach the
      slave_transaction_retries limit.
      Fix: wait for the slave to stop instead. This is what we want to do, since
      the slave stops when the limit is reached.
      
      
      1273b97d
    • unknown's avatar
      Problem: Pushbuild errors because sql_mode is unsafe but test thinks it is · 1d7d30d1
      unknown authored
      safe.
      Fix: Move sql_mode: from the section of the test where safe variables are
      tested, to the section where unsafe variables are tested.
      
      
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Updated result file of modified test.
      1d7d30d1
    • unknown's avatar
      Bug#34731: highest possible value for INT erroneously filtered by WHERE · ec62aba3
      unknown authored
      WHERE f1 < n ignored row if f1 was indexed integer column and
      f1 = TYPE_MAX ^ n = TYPE_MAX+1. The latter value when treated
      as TYPE overflowed (obviously). This was not handled, it is now.
      
      
      mysql-test/r/range.result:
        show that on an index int column, we no longer disregard
        a field val of TYPE_MAX in SELECT ... WHERE ... < TYPE_MAX+1
      mysql-test/t/range.test:
        show that on an index int column, we no longer disregard
        a field val of TYPE_MAX in SELECT ... WHERE ... < TYPE_MAX+1
      sql/opt_range.cc:
        Handle overflowing of int-types in range-optimizer.
        Unfortunately requires re-indentation of entire block.
        Overflow (err == 1) was handled, but only if
        field->cmp_type() != value->result_type(), which it
        just wasn't in our case.
      ec62aba3
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · ccf7f74e
      unknown authored
      into  mysql.com:/misc/mysql/34749/51-34749
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.h:
        Auto merged
      ccf7f74e
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 0abcb8ca
      unknown authored
      into  mysql.com:/misc/mysql/34749/50-34749
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      0abcb8ca
    • unknown's avatar
      Merge mysql.com:/misc/mysql/34749/50-34749 · 111de516
      unknown authored
      into  mysql.com:/misc/mysql/34749/51-34749
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/ha_ndbcluster_cond.cc:
        Auto merged
      sql/ha_ndbcluster_cond.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.h:
        Auto merged
      111de516
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · d9850aae
      unknown authored
      into  mysql.com:/misc/mysql/29645/51-29645
      
      
      d9850aae
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 9ddecde4
      unknown authored
      into  mysql.com:/misc/mysql/29645/50-29645
      
      
      9ddecde4
    • unknown's avatar
      Merge mysql.com:/misc/mysql/29645/50-29645 · 230c7a4c
      unknown authored
      into  mysql.com:/misc/mysql/29645/51-29645
      
      
      scripts/mysql_config.sh:
        Auto merged
      230c7a4c