- 20 Jul, 2010 1 commit
-
-
Igor Babaev authored
For queries with order by clauses that employed filesort usage of virtual column references in select lists could trigger assertion failures. It happened because a wrong vcol_set bitmap was used for filesort. It turned out that filesort required its own vcol_set bitmap. Made management of the vcol_set bitmaps similar to the management of the read_set and write_set bitmaps.
-
- 17 Jul, 2010 2 commits
-
-
Igor Babaev authored
-
Igor Babaev authored
If the expression for a virtual column of table contained datetime comparison then the execution of the second query that used this virtual column caused a crash. It happened because the execution of the first query that used this virtual column inserted a cached item into the expression tree. The cached tree was allocated in the statement memory while the expression tree was allocated in the table memory. Now the cached items that are inserted into expressions for virtual columns with datetime comparisons are always allocated in the same mem_root as the expressions for virtual columns. So now the inserted cached items are valid for any queries that use these virtual columns.
-
- 16 Jul, 2010 5 commits
-
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
The issue was that we didn't always check result of ha_rnd_init() which caused a problem for handlers that returned an error in this code. - Changed prototype of ha_rnd_init() to ensure that we get a compile warning if result is not checked. - Added ha_rnd_init_with_error() that prints error on failure. - Checked all usage of ha_rnd_init() and ensure we generate an error message on failures. - Changed init_read_record() to return 1 on failure. sql/create_options.cc: Fixed wrong printf sql/event_db_repository.cc: Check result from init_read_record() sql/events.cc: Check result from init_read_record() sql/filesort.cc: Check result from ha_rnd_init() sql/ha_partition.cc: Check result from ha_rnd_init() sql/ha_partition.h: Fixed compiler warning sql/handler.cc: Added ha_rnd_init_with_error() Check result from ha_rnd_init() sql/handler.h: Added ha_rnd_init_with_error() Changed prototype of ha_rnd_init() to ensure that we get a compile warning if result is not checked sql/item_subselect.cc: Check result from ha_rnd_init() sql/log.cc: Check result from ha_rnd_init() sql/log_event.cc: Check result from ha_rnd_init() sql/log_event_old.cc: Check result from ha_rnd_init() sql/mysql_priv.h: init_read_record() now returns error code on failure sql/opt_range.cc: Check result from ha_rnd_init() sql/records.cc: init_read_record() now returns error code on failure Check result from ha_rnd_init() sql/sql_acl.cc: Check result from init_read_record() sql/sql_cursor.cc: Print error if ha_rnd_init() fails sql/sql_delete.cc: Check result from init_read_record() sql/sql_help.cc: Check result from init_read_record() sql/sql_plugin.cc: Check result from init_read_record() sql/sql_select.cc: Check result from ha_rnd_init() Print error if ha_rnd_init() fails. sql/sql_servers.cc: Check result from init_read_record() sql/sql_table.cc: Check result from init_read_record() sql/sql_udf.cc: Check result from init_read_record() sql/sql_update.cc: Check result from init_read_record() storage/example/ha_example.cc: Don't return error on rnd_init() storage/ibmdb2i/ha_ibmdb2i.cc: Removed not relevant comment
-
Michael Widenius authored
mysql-test/suite/federated/federated_server.result: Update to new error message mysql-test/suite/federated/federated_server.test: Update to new error message storage/federatedx/ha_federatedx.cc: Return real error code, not 0, as in some cases before.
-
Michael Widenius authored
mysql client: Ignore --comments at start of command line. This allows one to more easily run mysqltest tests trough the command line. Fixed bug: LP#603026 RQG: pagecache_read: Assertion `pageno < ((1ULL) << 40)' on OPTIMIZE TABLE of a Maria table client/mysql.cc: Removed Oracle copyright from stdout, as Oracle doesn't have copyright to all code in this file. Ignore --comments at start of command line. This allows one to more easily run mysqltest tests trough the command line. mysql-test/suite/maria/r/optimize.result: Added test for LP#603026 mysql-test/suite/maria/t/optimize.test: Added test for LP#603026 sql/net_serv.cc: Removed DBUG_ASSERT(), as this code can happen during testing. storage/maria/ma_check.c: Fixed bug: LP#603026 RQG: pagecache_read: Assertion `pageno < ((1ULL) << 40)' on OPTIMIZE TABLE of a Maria table The problem was duplicated memory usage with long packed keys.
-
- 15 Jul, 2010 1 commit
-
-
Igor Babaev authored
There were two problems that caused wrong results reported with this bug. 1. In some cases stored(persistent) virtual columns were not marked in the write_set and in the vcol_set bitmaps. 2. If the list of fields in an insert command was empty then the values of the stored virtual columns were set to default. To fix the first problem the function st_table::mark_virtual_columns_for_write was modified. Now the function has a parameter that says whether the virtual columns are to be marked for insert or for update. To fix the second problem a special handling of empty insert lists is added in the function fill_record().
-
- 13 Jul, 2010 2 commits
-
-
Igor Babaev authored
If a virtual column was used in the ORDER BY clause of a query and some of the columns this virtual column was based upon were not referenced anywhere in the query then the execution of the query could cause an assertion failure. It happened because in this case the bitmap of the columns used for ordering keys was not formed correctly.
-
Igor Babaev authored
There was no error thrown when creating a table with a virtual table computed by an expression returning a row. This caused a crash when inserting into the table. Removed periods at the end of the error messages for virtual columns. Adjusted output in test result files accordingly.
-
- 09 Jul, 2010 2 commits
- 07 Jul, 2010 1 commit
-
-
Bo Thorsen authored
-
- 03 Jul, 2010 1 commit
-
-
Igor Babaev authored
The functions mysql_delete and mysql_update lacked calls of updated_virtual_fields(). This caused wrong results for some DELETEs/UPDATEs. Added test cases for this bug.
-
- 02 Jul, 2010 1 commit
-
-
Bo Thorsen authored
-
- 01 Jul, 2010 4 commits
-
-
Sergei Golubchik authored
redone locking in TC_LOG_MMAP::log_xid
-
Bo Thorsen authored
-
Bo Thorsen authored
-
Bo Thorsen authored
-
- 30 Jun, 2010 1 commit
-
-
Bo Thorsen authored
-
- 29 Jun, 2010 1 commit
-
-
Bo Thorsen authored
-
- 28 Jun, 2010 4 commits
-
-
Bo Thorsen authored
-
Bo Thorsen authored
-
Bo Thorsen authored
Fix a loop and install more script files. Renames the perlscripts component to scripts, since it now also has sql scripts.
-
Bo Thorsen authored
-
- 25 Jun, 2010 1 commit
-
-
Bo Thorsen authored
-
- 24 Jun, 2010 1 commit
-
-
Hakan Kuecuekyilmaz authored
Most of the changes are backports from MySQL 5.5. Please note that the 64-bit build fails with VS 2010 and the 32-bit build has problems running mysql-test-run.pl. * Added files for compiling with VS 2010 and added them to Makefile.am. * ifdef'ed ETIMEDOUT, because it is defined by VS 2010 now * Removed not needed /MAP's from cmake files
-
- 23 Jun, 2010 2 commits
-
-
Michael Widenius authored
-
Michael Widenius authored
- Fixed memory leaks in mysqldump - Fixed printf of NULL which caused crashes on OpenSolaris when using --debug - Fixed realloc() problem that caused out of memory when running mysqldump.test on OpenSolaris client/mysqldump.c: Fixed memory leaks Fixed printf of NULL which caused crashes on OpenSolaris when using --debug client/mysqltest.cc: Fixed printf of NULL which caused crashes on OpenSolaris when using --debug include/my_global.h: Added simple macro val_or_null() to simplify detecting of NULL strings for printf sql/handler.cc: Fixed printf of NULL which caused crashes on OpenSolaris when using --debug sql/sql_db.cc: Fixed printf of NULL which caused crashes on OpenSolaris when using --debug Removed testing of 'new_db_name' as this is guranteed never NULL sql/sql_show.cc: Fixed printf of NULL which caused crashes on OpenSolaris when using --debug storage/csv/ha_tina.cc: Fixed realloc() problem that caused out of memory when running mysqldump.test on OpenSolaris (OpenSolaris default malloc() can't handle a lot of reallocs() of strings that are growing one byte at a time) This did speed up logging to cvs with a magnitude for large strings.
-
- 17 Jun, 2010 2 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 16 Jun, 2010 3 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 15 Jun, 2010 4 commits
-
-
Michael Widenius authored
sql/log_event.cc: Fixed compiler warning on windows storage/maria/ma_state.c: Fixed compiler warning storage/maria/maria_chk.c: Fixed compiler warning storage/myisam/mi_dynrec.c: Fixed compiler warning support-files/compiler_warnings.supp: Fixed suppression rule
-
Michael Widenius authored
storage/maria/unittest/ma_pagecache_single.c: Check if we can flush write locked page for normal flush Check that we can't flush read locked page with FLUSH_KEEP_LAZY (used by checkpoint)
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 14 Jun, 2010 1 commit
-
-
Sergei Golubchik authored
-