Commit b4a6b540 authored by Jondy Zhao's avatar Jondy Zhao

Fix the empty variable problem in the configure scripts

parent 136840b5
...@@ -386,9 +386,9 @@ function install_tap_driver() ...@@ -386,9 +386,9 @@ function install_tap_driver()
# rename the connection name # rename the connection name
if [[ ! "$1" == "" ]] ; then if [[ ! "$1" == "" ]] ; then
OLDNAME=$(get_new_connection $original_connections) connection_name=$(get_new_connection $original_connections)
if [[ -n $OLDNAME ]] ; then if [[ -n "$connection_name" ]] ; then
netsh interface set interface name="$OLDNAME" newname="$1" netsh interface set interface name="$connection_name" newname="$1"
else else
echo Failed to get new connection name. echo Failed to get new connection name.
return 1 return 1
......
...@@ -188,7 +188,7 @@ echo ...@@ -188,7 +188,7 @@ echo
if [[ ! -f $node_certificate_file ]] ; then if [[ ! -f $node_certificate_file ]] ; then
read -p "Where is computer certificate file (/computer.crt): " filename read -p "Where is computer certificate file (/computer.crt): " filename
[[ -z $filenname ]] && filename="/computer.crt" [[ -z "$filename" ]] && filename="/computer.crt"
[[ ! -r "$filename" ]] && \ [[ ! -r "$filename" ]] && \
show_error_exit "Computer certificate file $filename doesn't exists." show_error_exit "Computer certificate file $filename doesn't exists."
echo "Copy certificate from $filename to $node_certificate_file" echo "Copy certificate from $filename to $node_certificate_file"
...@@ -202,7 +202,7 @@ openssl x509 -noout -in $node_certificate_file || \ ...@@ -202,7 +202,7 @@ openssl x509 -noout -in $node_certificate_file || \
if [[ ! -f $node_key_file ]] ; then if [[ ! -f $node_key_file ]] ; then
read -p "Where is computer key file (/computer.key): " filename read -p "Where is computer key file (/computer.key): " filename
[[ -z $filename ]] && filename="/computer.key" [[ -z "$filename" ]] && filename="/computer.key"
[[ ! -f "$filename" ]] && \ [[ ! -f "$filename" ]] && \
show_error_exit "Key file $filename doesn't exists." show_error_exit "Key file $filename doesn't exists."
echo "Copy key from $filename to $node_key_file" echo "Copy key from $filename to $node_key_file"
...@@ -250,7 +250,7 @@ sed -i -e "s%^\\s*interface_name.*$%interface_name = $interface_guid%" \ ...@@ -250,7 +250,7 @@ sed -i -e "s%^\\s*interface_name.*$%interface_name = $interface_guid%" \
if [[ ! -f $client_certificate_file ]] ; then if [[ ! -f $client_certificate_file ]] ; then
read -p "Where is client certificate file (/certificate): " filename read -p "Where is client certificate file (/certificate): " filename
[[ -z $filename ]] && filename="/certificate" [[ -z "$filename" ]] && filename="/certificate"
[[ ! -f "$filename" ]] && \ [[ ! -f "$filename" ]] && \
show_error_exit "Client certificate file $filename doesn't exists." show_error_exit "Client certificate file $filename doesn't exists."
echo "Copy client certificate from $filename to $client_certificate_file" echo "Copy client certificate from $filename to $client_certificate_file"
...@@ -262,7 +262,7 @@ openssl x509 -noout -in $client_certificate_file || \ ...@@ -262,7 +262,7 @@ openssl x509 -noout -in $client_certificate_file || \
if [[ ! -f $client_key_file ]] ; then if [[ ! -f $client_key_file ]] ; then
read -p "Where is client key file (/key): " filename read -p "Where is client key file (/key): " filename
[[ -z $filename ]] && filename="/key" [[ -z "$filename" ]] && filename="/key"
[[ ! -f "$filename" ]] && \ [[ ! -f "$filename" ]] && \
show_error_exit "Key file $filename doesn't exists." show_error_exit "Key file $filename doesn't exists."
echo "Copy client key from $filename to $client_key_file" echo "Copy client key from $filename to $client_key_file"
...@@ -398,7 +398,7 @@ echo Starting configure section taps ... ...@@ -398,7 +398,7 @@ echo Starting configure section taps ...
echo echo
original_connections=$(echo $(get_all_connections)) original_connections=$(echo $(get_all_connections))
client_count=$(sed -n -e "s/^client-count *//p" $re6stnet_configure_file) client_count=$(sed -n -e "s/^client-count *//p" $re6stnet_configure_file)
[[ -z $client_count ]] && client_count=10 [[ -z "$client_count" ]] && client_count=10
echo " Client count: $client_count" echo " Client count: $client_count"
re6stnet_name_list="re6stnet-tcp re6stnet-udp" re6stnet_name_list="re6stnet-tcp re6stnet-udp"
for (( i=1; i<=client_count; i=i+1 )) ; do for (( i=1; i<=client_count; i=i+1 )) ; do
...@@ -438,7 +438,7 @@ if ! grep -q -F "$feature_code" $slaprunner_startup_file ; then ...@@ -438,7 +438,7 @@ if ! grep -q -F "$feature_code" $slaprunner_startup_file ; then
if [[ -r $re6stnet_configure_file ]] ; then if [[ -r $re6stnet_configure_file ]] ; then
re6stnet_ipv6=$(grep "Your subnet" $re6stnet_configure_file| \ re6stnet_ipv6=$(grep "Your subnet" $re6stnet_configure_file| \
sed -e "s/^.*subnet: //g" -e "s/\/80 (CN.*\$/1/g") sed -e "s/^.*subnet: //g" -e "s/\/80 (CN.*\$/1/g")
if [[ ! -z $re6stnet_ipv6 ]] ; then if [[ ! -z "$re6stnet_ipv6" ]] ; then
echo "Re6stnet address in this computer: $re6stnet_ipv6" echo "Re6stnet address in this computer: $re6stnet_ipv6"
netsh interface ipv6 show addr $slapos_ifname level=normal | \ netsh interface ipv6 show addr $slapos_ifname level=normal | \
grep -q $re6stnet_ipv6 || \ grep -q $re6stnet_ipv6 || \
...@@ -481,7 +481,7 @@ if ! grep -q -F "$feature_code" $slaprunner_startup_file ; then ...@@ -481,7 +481,7 @@ if ! grep -q -F "$feature_code" $slaprunner_startup_file ; then
$slaprunner_title slaposwebrunner --node computer_guid=$computer_guid | \ $slaprunner_title slaposwebrunner --node computer_guid=$computer_guid | \
grep backend_url | sed -e "s/^.*': '//g" -e "s/',.*$//g") grep backend_url | sed -e "s/^.*': '//g" -e "s/',.*$//g")
echo "SlapOS Web Runner URL: $slaprunner_url" echo "SlapOS Web Runner URL: $slaprunner_url"
[[ -z $slaprunner_url ]] && \ [[ -z "$slaprunner_url" ]] && \
show_error_exit "Failed to create instance of SlapOS Web Runner." show_error_exit "Failed to create instance of SlapOS Web Runner."
cat <<EOF > $slaprunner_startup_file cat <<EOF > $slaprunner_startup_file
......
...@@ -194,7 +194,7 @@ create_unprivileged_user ${USER_NAME} $USER_HOME || ...@@ -194,7 +194,7 @@ create_unprivileged_user ${USER_NAME} $USER_HOME ||
(echo "Failed to create user ${USER_NAME}" ; exit 1) (echo "Failed to create user ${USER_NAME}" ; exit 1)
for grpname in ${USER_INIT_GROUP} ${USER_OTHER_GROUP} ; do for grpname in ${USER_INIT_GROUP} ${USER_OTHER_GROUP} ; do
[[ -z $grpname ]] && continue [[ -z "$grpname" ]] && continue
add_member_to_group ${USER_NAME} $grpname || add_member_to_group ${USER_NAME} $grpname ||
(echo "Failed to add ${USER_NAME} to group $group" ; exit 1) (echo "Failed to add ${USER_NAME} to group $group" ; exit 1)
done done
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment