Commit 760f102c authored by Jason A. Beranek's avatar Jason A. Beranek

common/config,download: fix URL and relative Windows local file path issues [GH-235] [GH-239]

parent 5b7d8fbc
......@@ -7,6 +7,7 @@ import (
"net/url"
"os"
"path/filepath"
"runtime"
"sort"
"strings"
)
......@@ -73,6 +74,12 @@ func DownloadableURL(original string) (string, error) {
}
if url.Scheme == "file" {
// For Windows absolute file paths, remove leading /
// prior to processing
if runtime.GOOS == "windows" && url.Path[0] == '/' {
url.Path = url.Path[1:len(url.Path)]
}
if _, err := os.Stat(url.Path); err != nil {
return "", err
}
......
......@@ -14,6 +14,7 @@ import (
"net/http"
"net/url"
"os"
"runtime"
)
// DownloadConfig is the configuration given to instantiate a new
......@@ -106,7 +107,13 @@ func (d *DownloadClient) Get() (string, error) {
// Files when we don't copy the file are special cased.
var finalPath string
if url.Scheme == "file" && !d.config.CopyFile {
finalPath = url.Path
// Remove forward slash on absolute Windows file URLs
// Before processing
if runtime.GOOS == "windows" && url.Path[0] == '/' {
finalPath = url.Path[1:len(url.Path)]
} else {
finalPath = url.Path
}
} else {
finalPath = d.config.TargetPath
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment