GitLab

We use internal transactions for invoices and any kind of accounting transactions (in reality, it's not limited to *invoice*), this is a set of changes to make it easier to record payments between two entities with internal transactions.

* We add a *Section Bank Account* field directly on the view ( ![Screenshot_2017-10-04_at_19.36.53](/uploads/4b1f22b5d5e6c1f77a70ea717c2323d9/Screenshot_2017-10-04_at_19.36.53.png)
* Reconfigure  *Causality (Invoices ...)* relation fieds to allow allow every accouting transactions portal type, so also Internal Invoice Transaction ...").  This way, when creating the "payment" internal transaction, we connect it to the "invoice" internal transaction  and grouping reference is set automatically when posting to general ledger.
*  Enable the *Create Payment* action from (which exists on sales and purchase) on normal invoices.

The rest is  small cleanup / fixes described in commit messages.

/reviewed-on nexedi/erp5!433

Various improvements to `CodingStyleTestCase` so that it can be used in a project test suite.

/reviewed-on nexedi/erp5!455

Usually, the split and defer dialog suggest you to define start and stop date. So if you have
already an existing delivery and you would like it to be updated, you have to set correct start
and stop date and, if all categories are fully the same, you might have some chance to see
this delivery updated.

To improve the case where you would like to move quantity to existing delivery, add option in the
solve divergence dialog of "Move to existing Delivery" that allows you to select similar deliveries. Then
this specific solver would set correct properties for you to make sure the expected delivery would be updated.

when form is used in another context (web section for exemple).

/reviewed-on nexedi/erp5!456

Not used in this test, but since it's made to be reusable in projects.

do not limit to the first script with errors

It produces almost same visual result

they may contain folder containing skins

Don't test a skin folder twice when business template is present more
than once

/reviewed-on nexedi/erp5!453

To make predicate lookup a bit faster by keeping `predicate` and `predicate_category` small, do not index the documents we do not need in these table. This is done for `Assignment`, `Career`, `Payment Condition`, `Delivery Cells`, `Budget Line` and `Budget Cells`.

/cc @vpelletier @kazuhiko  @tiwariayush 

/reviewed-on nexedi/erp5!257

ERP5's Code mirror supports viewing history of editions using codemirror's merge mode ( http://codemirror.net/demo/merge.html ).

This was enabled for portal_components, but not for web pages.

This moves the methods used by the components in a mixin class and make `TextDocument` class use this mixin.

This way, we can benefit from diff view on web pages as well:

![ERP5-history-on-web-pages](/uploads/2bd381948266da46225ae26fd807bd51/ERP5-history-on-web-pages.png)

@romain @vincentB @katomaso unless this interfere with your work of making codemirror works in renderjs ui, I think we can enable this. It does not include any change to codemirror code, just enable everywhere what was available only on components.

@klaus I did not check, but we probably want this enabled for PyData Script as well.

/reviewed-on nexedi/erp5!449

keep backward compatibility with erp5_officejs_support_request_ui

- fails if 0
- fails if too much
- also applied for predecessor

keep backward compatibility with erp5_officejs_support_request_ui

keep backward compatibility with erp5_officejs_support_request_ui

It was "dead code", this form was not used in any action.

Fields were not following naming conventions, so search would not even
work.

Because we generate search dialogs based on module listbox, organisation
module already had a working search dialog, so this dialog is not needed
anymore.

Prevent syncro fail on frozen document
Ignore Remove attachment or document for erp5

Prevent issue when document is edited in multiple tab.

And adapt cache

To be consistant with date format in hateoas
And follow Javascript default format
https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Objets_globaux/Date/parse

on form view discussable, by disabling submit button

on getting project list in the support request fast input dialog

This will fix the issue below:

======================================================================
ERROR: test_refresh_token (erp5.component.test.erp5_version.testGoogleLogin.TestGoogleLogin)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/srv/slapgrid/slappart11/srv/runner/software/46ff20cd786207637e80576bed95522d/parts/erp5/Products/ERP5Type/tests/runUnitTest.py", line 291, in setUp
super(ComponentTestCase, self).setUp()
File "/srv/slapgrid/slappart11/srv/runner/software/46ff20cd786207637e80576bed95522d/eggs/Zope2-2.13.24-py2.7.egg/Testing/ZopeTestCase/PortalTestCase.py", line 60, in setUp
self.afterSetUp()
File "<portal_components/test.erp5.testGoogleLogin>", line 143, in afterSetUp
secret_key=SECRET_KEY)
File "/srv/slapgrid/slappart11/srv/runner/software/46ff20cd786207637e80576bed95522d/parts/erp5/product/ERP5Type/Core/Folder.py", line 620, in newContent
return FolderMixIn.newContent(self, *args, ...

/reviewed-on nexedi/erp5!390

This is not used anywhere, and actually cannot be reused anywhere because
of hard-coded document identifiers.
It is too trivial to be worth salvaging, so drop it.