lab.nexedi.com will be down from Thursday, 20 March 2025, 07:30:00 UTC for a duration of approximately 2 hours

  • Stan Hu's avatar
    Fix Error 500 when application settings are saved · 681af5bc
    Stan Hu authored
    Due to a Rails bug, fetching the application settings from Redis
    may prevent the attribute methods from being loaded for the `ApplicationSetting`
    model. More details here: https://github.com/rails/rails/issues/27348
    
    There was also a secondary problem introduced by overriding these
    association methods which caused all default visibility levels to be
    set to `nil`. Before, the previous implementation allowed the string
    "20" to be saved as an integer, while now a table lookup happens
    before that. We fix this by enforcing the integer value in the
    controller and default to PRIVATE.
    
    Closes #29674
    681af5bc
admin_settings_spec.rb 1.97 KB
require 'spec_helper'

feature 'Admin updates settings', feature: true do
  include StubENV

  before do
    stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
    login_as :admin
    visit admin_application_settings_path
  end

  scenario 'Change visibility settings' do
    first(:radio_button, 'Public').set(true)
    click_button 'Save'

    expect(page).to have_content "Application settings saved successfully"
    expect(ApplicationSetting.current.default_project_visibility).to eq(Gitlab::VisibilityLevel::PUBLIC)
  end

  scenario 'Change application settings' do
    uncheck 'Gravatar enabled'
    fill_in 'Home page URL', with: 'https://about.gitlab.com/'
    fill_in 'Help page text', with: 'Example text'
    click_button 'Save'

    expect(current_application_settings.gravatar_enabled).to be_falsey
    expect(current_application_settings.home_page_url).to eq "https://about.gitlab.com/"
    expect(page).to have_content "Application settings saved successfully"
  end

  scenario 'Change Slack Notifications Service template settings' do
    click_link 'Service Templates'
    click_link 'Slack notifications'
    fill_in 'Webhook', with: 'http://localhost'
    fill_in 'Username', with: 'test_user'
    fill_in 'service_push_channel', with: '#test_channel'
    page.check('Notify only broken builds')

    check_all_events
    click_on 'Save'

    expect(page).to have_content 'Application settings saved successfully'

    click_link 'Slack notifications'

    page.all('input[type=checkbox]').each do |checkbox|
      expect(checkbox).to be_checked
    end
    expect(find_field('Webhook').value).to eq 'http://localhost'
    expect(find_field('Username').value).to eq 'test_user'
    expect(find('#service_push_channel').value).to eq '#test_channel'
  end

  def check_all_events
    page.check('Active')
    page.check('Push')
    page.check('Tag push')
    page.check('Note')
    page.check('Issue')
    page.check('Merge request')
    page.check('Build')
    page.check('Pipeline')
  end
end