Add GroupVariableSerializer for Ci::GroupVariable

app/controllers/groups/variables_controller.rb

@@ -8,7 +8,7 @@ module Groups
           variables = @group.variables
             .map { |variable| variable.present(current_user: current_user) }
 
-          render status: :ok, json: { variables: variables }
+          render status: :ok, json: { variables: GroupVariableSerializer.new.represent(variables) }
         end
       end
     end
@@ -20,7 +20,7 @@ module Groups
             variables = @group.variables
               .map { |variable| variable.present(current_user: current_user) }
 
-            return render status: :ok, json: { variables: variables }
+            return render status: :ok, json: { variables: GroupVariableSerializer.new.represent(variables) }
           end
 
           render status: :bad_request, json: @group.errors.full_messages

app/serializers/group_variable_entity.rb

+class GroupVariableEntity < Grape::Entity
+  expose :id
+  expose :key
+  expose :value
+
+  expose :protected?, as: :protected
+end

app/serializers/group_variable_serializer.rb

+class GroupVariableSerializer < BaseSerializer
+  entity GroupVariableEntity
+end

spec/controllers/groups/variables_controller_spec.rb

@@ -19,7 +19,7 @@ describe Groups::VariablesController do
     it 'renders the ci_group_variable as json' do
       subject
 
-      expect(response.body).to include(variable.to_json)
+      expect(response).to match_response_schema('variable')
     end
   end
 
@@ -82,7 +82,7 @@ describe Groups::VariablesController do
       it 'has all variables in response' do
         subject
 
-        expect(response.body).to include(group.variables.reload.to_json)
+        expect(response).to match_response_schema('variable')
       end
     end
 
@@ -111,7 +111,7 @@ describe Groups::VariablesController do
       it 'has all variables in response' do
         subject
 
-        expect(response.body).to include(group.variables.reload.to_json)
+        expect(json_response['variables'].count).to eq(0)
       end
     end
   end

spec/serializers/group_variable_entity_spec.rb

+require 'spec_helper'
+
+describe GroupVariableEntity do
+  let(:variable) { create(:ci_group_variable) }
+  let(:entity) { described_class.new(variable) }
+
+  describe '#as_json' do
+    subject { entity.as_json }
+
+    it 'contains required fields' do
+      expect(subject).to include(:id, :key, :value, :protected)
+    end
+  end
+end