Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
05107a89
Commit
05107a89
authored
Mar 16, 2017
by
Robert Speicher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Expand on the good changelog/bad changelog documentation examples
[ci skip]
parent
8f92de7b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
20 additions
and
0 deletions
+20
-0
doc/development/changelog.md
doc/development/changelog.md
+20
-0
No files found.
doc/development/changelog.md
View file @
05107a89
...
@@ -51,14 +51,34 @@ making it both concise and descriptive, err on the side of descriptive.
...
@@ -51,14 +51,34 @@ making it both concise and descriptive, err on the side of descriptive.
- **Bad:** Go to a project order.
- **Bad:** Go to a project order.
- **Good:** Show a user's starred projects at the top of the "Go to project"
- **Good:** Show a user's starred projects at the top of the "Go to project"
dropdown.
dropdown.
The first example provides no context of where the change was made, or why, or
how it benefits the user.
- **Bad:** Copy [some text] to clipboard.
- **Bad:** Copy [some text] to clipboard.
- **Good:** Update the "Copy to clipboard" tooltip to indicate what's being
- **Good:** Update the "Copy to clipboard" tooltip to indicate what's being
copied.
copied.
Again, the first example is too vague and provides no context.
- **Bad:** Fixes and Improves CSS and HTML problems in mini pipeline graph and
- **Bad:** Fixes and Improves CSS and HTML problems in mini pipeline graph and
builds dropdown.
builds dropdown.
- **Good:** Fix tooltips and hover states in mini pipeline graph and builds
- **Good:** Fix tooltips and hover states in mini pipeline graph and builds
dropdown.
dropdown.
The first example is too focused on implementation details. The user doesn't
care that we changed CSS and HTML, they care about the _end result_ of those
changes.
- **Bad:** Strip out `nil`s in the Array of Commit objects returned from
`find_commits_by_message_with_elastic`
- **Good:** Fix 500 errors caused by elasticsearch results referencing
garbage-collected commits
The first example focuses on _how_ we fixed something, not on _what_ it fixes.
The rewritten version clearly describes the _end benefit_ to the user (fewer 500
errors), and _when_ (searching commits with ElasticSearch).
Use your best judgement and try to put yourself in the mindset of someone
Use your best judgement and try to put yourself in the mindset of someone
reading the compiled changelog. Does this entry add value? Does it offer context
reading the compiled changelog. Does this entry add value? Does it offer context
about _where_ and _why_ the change was made?
about _where_ and _why_ the change was made?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment