Merge branch '35164-cycle-analytics-firefox' into 'master'

move click handler to button. when on the icon it wasn't triggered in firefox

Closes #35164

See merge request !12905

app/views/projects/cycle_analytics/show.html.haml

@@ -9,8 +9,8 @@
 #cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } }
   - if @cycle_analytics_no_data
     .landing.content-block{ "v-if" => "!isOverviewDialogDismissed" }
-      %button.dismiss-button{ type: 'button', 'aria-label': 'Dismiss Cycle Analytics introduction box' }
-        = icon("times", "@click" => "dismissOverviewDialog()")
+      %button.dismiss-button{ type: 'button', 'aria-label': 'Dismiss Cycle Analytics introduction box', "@click" => "dismissOverviewDialog()" }
+        = icon("times")
       .svg-container
         = custom_icon('icon_cycle_analytics_splash')
       .inner-content

changelogs/unreleased/35164-cycle-analytics-firefox.yml

+---
+title: allow closing Cycle Analytics intro box in firefox
+merge_request:
+author: