Upgrade eslint-plugin-jasmine and resolve violations

package.json

@@ -123,7 +123,7 @@
     "eslint-plugin-filenames": "^1.3.2",
     "eslint-plugin-html": "4.0.5",
     "eslint-plugin-import": "^2.14.0",
-    "eslint-plugin-jasmine": "^2.1.0",
+    "eslint-plugin-jasmine": "^2.10.1",
     "eslint-plugin-promise": "^4.0.1",
     "eslint-plugin-vue": "^5.0.0-beta.3",
     "gettext-extractor": "^3.3.2",

spec/javascripts/.eslintrc.yml

@@ -35,3 +35,9 @@ rules:
     - error
     - ignore:
       - 'fixtures/blob'
+  # Temporarily disabled to facilitate an upgrade to eslint-plugin-jasmine
+  jasmine/new-line-before-expect: off
+  jasmine/new-line-between-declarations: off
+  jasmine/no-promise-without-done-fail: off
+  jasmine/prefer-jasmine-matcher: off
+  jasmine/prefer-toHaveBeenCalledWith: off

spec/javascripts/close_reopen_report_toggle_spec.js

+/* eslint-disable jasmine/no-unsafe-spy */
+
 import CloseReopenReportToggle from '~/close_reopen_report_toggle';
 import DropLab from '~/droplab/drop_lab';
 

spec/javascripts/lib/utils/poll_spec.js

+/* eslint-disable jasmine/no-unsafe-spy */
+
 import Poll from '~/lib/utils/poll';
 import { successCodes } from '~/lib/utils/http_status';
 

spec/javascripts/right_sidebar_spec.js

-/* eslint-disable no-var, one-var, one-var-declaration-per-line, no-return-assign, vars-on-top, max-len */
+/* eslint-disable no-var, one-var, one-var-declaration-per-line, no-return-assign, vars-on-top, jasmine/no-unsafe-spy, max-len */
 
 import $ from 'jquery';
 import MockAdapter from 'axios-mock-adapter';

yarn.lock

@@ -2727,9 +2727,9 @@ eslint-plugin-import@^2.14.0:
     read-pkg-up "^2.0.0"
     resolve "^1.6.0"
 
-eslint-plugin-jasmine@^2.1.0:
-  version "2.2.0"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-jasmine/-/eslint-plugin-jasmine-2.2.0.tgz#7135879383c39a667c721d302b9f20f0389543de"
+eslint-plugin-jasmine@^2.10.1:
+  version "2.10.1"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-jasmine/-/eslint-plugin-jasmine-2.10.1.tgz#5733b709e751f4bc40e31e1c16989bd2cdfbec97"
 
 eslint-plugin-promise@^4.0.1:
   version "4.0.1"