Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
2a4ee2fd
Commit
2a4ee2fd
authored
9 years ago
by
Jeroen van Baarsen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
make sure the user.name is escaped
Signed-off-by:
Jeroen van Baarsen
<
jeroenvanbaarsen@gmail.com
>
parent
5dbbec46
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
2 deletions
+7
-2
spec/features/atom/users_spec.rb
spec/features/atom/users_spec.rb
+7
-2
No files found.
spec/features/atom/users_spec.rb
View file @
2a4ee2fd
...
...
@@ -24,11 +24,12 @@ describe "User Feed", feature: true do
end
it
"should have issue opened event"
do
body
.
should
have_content
(
"
#{
user
.
name
}
opened issue #
#{
issue
.
iid
}
"
)
expect
(
body
).
to
have_content
(
"
#{
safe_
name
}
opened issue #
#{
issue
.
iid
}
"
)
end
it
"should have issue comment event"
do
body
.
should
have_content
(
"
#{
user
.
name
}
commented on issue #
#{
issue
.
iid
}
"
)
expect
(
body
).
to
have_content
(
"
#{
safe_name
}
commented on issue #
#{
issue
.
iid
}
"
)
end
end
end
...
...
@@ -40,4 +41,8 @@ describe "User Feed", feature: true do
def
note_event
(
note
,
user
)
EventCreateService
.
new
.
leave_note
(
note
,
user
)
end
def
safe_name
html_escape
(
user
.
name
)
end
end
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment