Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
2f0f62e5
Commit
2f0f62e5
authored
Nov 02, 2017
by
Nick Thomas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove an exception from the git user default SSH config check
parent
8e8ab2f3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
10 deletions
+2
-10
lib/system_check/app/git_user_default_ssh_config_check.rb
lib/system_check/app/git_user_default_ssh_config_check.rb
+2
-2
spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb
...ystem_check/app/git_user_default_ssh_config_check_spec.rb
+0
-8
No files found.
lib/system_check/app/git_user_default_ssh_config_check.rb
View file @
2f0f62e5
...
...
@@ -11,10 +11,10 @@ module SystemCheck
]
.
freeze
set_name
'Git user has default SSH configuration?'
set_skip_reason
'skipped (
GitLab read-only, or
git user is not present / configured)'
set_skip_reason
'skipped (git user is not present / configured)'
def
skip?
Gitlab
::
Database
.
read_only?
||
!
home_dir
||
!
File
.
directory?
(
home_dir
)
!
home_dir
||
!
File
.
directory?
(
home_dir
)
end
def
check?
...
...
spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb
View file @
2f0f62e5
...
...
@@ -39,14 +39,6 @@ describe SystemCheck::App::GitUserDefaultSSHConfigCheck do
it
{
is_expected
.
to
eq
(
expected_result
)
}
end
it
'skips GitLab read-only instances'
do
stub_user
stub_home_dir
allow
(
Gitlab
::
Database
).
to
receive
(
:read_only?
).
and_return
(
true
)
is_expected
.
to
be_truthy
end
end
describe
'#check?'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment