Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
5bf22606
Commit
5bf22606
authored
Jan 29, 2017
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix XSS issue by not using URI.join
parent
27f2ca94
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
2 deletions
+1
-2
app/models/environment.rb
app/models/environment.rb
+1
-2
No files found.
app/models/environment.rb
View file @
5bf22606
...
@@ -185,8 +185,7 @@ class Environment < ActiveRecord::Base
...
@@ -185,8 +185,7 @@ class Environment < ActiveRecord::Base
public_path
=
project
.
public_path_for_source_path
(
path
,
commit_sha
)
public_path
=
project
.
public_path_for_source_path
(
path
,
commit_sha
)
return
unless
public_path
return
unless
public_path
# TODO: Verify this can't be used for XSS
[
external_url
,
public_path
].
join
(
'/'
)
URI
.
join
(
external_url
,
public_path
).
to_s
end
end
private
private
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment