IssueNotesRefactor: Implement note delete.

app/assets/javascripts/notes/components/issue_discussion.vue

@@ -58,10 +58,10 @@ export default {
     <div class="timeline-entry-inner">
       <div class="timeline-icon">
         <user-avatar-link
-          :link-href="author.path"
-          :img-src="author.avatar_url"
-          :img-alt="author.name"
-          :img-size="40" />
+          :linkHref="author.path"
+          :imgSrc="author.avatar_url"
+          :imgAlt="author.name"
+          :imgSize="40" />
       </div>
       <div class="timeline-content">
         <div class="discussion">

app/assets/javascripts/notes/components/issue_note.vue

@@ -39,15 +39,20 @@ export default {
       this.isEditing = true;
     },
     deleteHandler() {
-      this.isDeleting = true;
-      this.$store
-        .dispatch('deleteNote', this.note)
-        .then(() => {
-          this.isDeleting = false;
-        })
-        .catch(() => {
-          this.isDeleting = false;
-        });
+      const msg = 'Are you sure you want to delete this list?';
+      const isConfirmed = confirm(msg); // eslint-disable-line
+
+      if (isConfirmed) {
+        this.isDeleting = true;
+        this.$store
+          .dispatch('deleteNote', this.note)
+          .then(() => {
+            this.isDeleting = false;
+          })
+          .catch(() => {
+            this.isDeleting = false;
+          });
+      }
     },
     formUpdateHandler() {
       // console.log('update requested', data);
@@ -66,10 +71,10 @@ export default {
     <div class="timeline-entry-inner">
       <div class="timeline-icon">
         <user-avatar-link
-          :link-href="author.path"
-          :img-src="author.avatar_url"
-          :img-alt="author.name"
-          :img-size="40" />
+          :linkHref="author.path"
+          :imgSrc="author.avatar_url"
+          :imgAlt="author.name"
+          :imgSize="40" />
       </div>
       <div class="timeline-content">
         <div class="note-header">

app/assets/javascripts/notes/components/issue_note_actions.vue

@@ -97,6 +97,7 @@ export default {
         </li>
         <li>
           <a
+            v-if="canEdit"
             @click.prevent="deleteHandler"
             class="js-note-delete"
             href="#">

app/assets/javascripts/notes/services/issue_notes_service.js

@@ -8,6 +8,6 @@ export default {
     return Vue.http.get(endpoint);
   },
   deleteNote(endpoint) {
-    return Vue.http.get(endpoint);
+    return Vue.http.delete(endpoint);
   },
 };

app/assets/javascripts/notes/stores/issue_notes_store.js

@@ -53,10 +53,8 @@ const actions = {
       });
   },
   deleteNote(context, note) {
-    // FIXME: Implement request, remove fake delete timer...
     return service
-      .deleteNote(`${document.location.href}.json`)
-      .then(res => res.json)
+      .deleteNote(note.path)
       .then(() => {
         context.commit('deleteNote', note);
       })