Memoize method which is called multiple times on presenter

70156f3b · Oswaldo Ferreira · 1521fd9f · 70156f3b
Commit 70156f3b authored Feb 20, 2018 by Oswaldo Ferreira
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

app/presenters/project_presenter.rb app/presenters/project_presenter.rb +7 -4

No files found.
--- a/app/presenters/project_presenter.rb
+++ b/app/presenters/project_presenter.rb
@@ -4,6 +4,7 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated
  include GitlabRoutingHelper
  include StorageHelper
  include TreeHelper
+  include Gitlab::Utils::StrongMemoize
  presents :project
@@ -159,10 +160,12 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated
  end
  def can_current_user_push_code?
-    if empty_repo?
+    strong_memoize(:can_current_user_push_code) do
-      can?(current_user, :push_code, project)
+      if empty_repo?
-    else
+        can?(current_user, :push_code, project)
-      user_can_push_to_branch?(current_user, default_branch)
+      else
+        user_can_push_to_branch?(current_user, default_branch)
+      end
    end
  end