Commit 80a7c369 authored by Oswaldo Ferreira's avatar Oswaldo Ferreira

Do not rely on style class for changing DOM state on "Mark all as done"

parent 27a79491
...@@ -85,7 +85,7 @@ ...@@ -85,7 +85,7 @@
}, },
success: (data) => { success: (data) => {
$target.remove(); $target.remove();
$('.prepend-top-default').html('<div class="nothing-here-block">You\'re all done!</div>'); $('.js-todos-all').html('<div class="nothing-here-block">You\'re all done!</div>');
return this.updateBadges(data); return this.updateBadges(data);
} }
}); });
......
...@@ -67,40 +67,41 @@ ...@@ -67,40 +67,41 @@
= sort_title_oldest_created = sort_title_oldest_created
- if @todos.any? .js-todos-all
.js-todos-options{ data: {per_page: @todos.limit_value, current_page: @todos.current_page, total_pages: @todos.total_pages} } - if @todos.any?
.panel.panel-default.panel-small.panel-without-border .js-todos-options{ data: {per_page: @todos.limit_value, current_page: @todos.current_page, total_pages: @todos.total_pages} }
%ul.content-list.todos-list .panel.panel-default.panel-small.panel-without-border
= render @todos %ul.content-list.todos-list
= paginate @todos, theme: "gitlab" = render @todos
= paginate @todos, theme: "gitlab"
- elsif current_user.todos.any? - elsif current_user.todos.any?
.todos-all-done .todos-all-done
= render "shared/empty_states/todos_all_done.svg" = render "shared/empty_states/todos_all_done.svg"
- if todos_filter_empty? - if todos_filter_empty?
%h4.text-center %h4.text-center
= Gitlab.config.gitlab.no_todos_messages.sample = Gitlab.config.gitlab.no_todos_messages.sample
%p.text-center %p.text-center
Are you looking for things to do? Take a look at Are you looking for things to do? Take a look at
= succeed "," do = succeed "," do
= link_to "the opened issues", issues_dashboard_path = link_to "the opened issues", issues_dashboard_path
contribute to contribute to
= link_to "merge requests", merge_requests_dashboard_path = link_to "merge requests", merge_requests_dashboard_path
or mention someone in a comment to assign a new todo automatically. or mention someone in a comment to assign a new todo automatically.
- else - else
%h4.text-center %h4.text-center
There are no todos to show. There are no todos to show.
- else - else
.todos-empty .todos-empty
.todos-empty-hero .todos-empty-hero
= render "shared/empty_states/todos_empty.svg" = render "shared/empty_states/todos_empty.svg"
.todos-empty-content .todos-empty-content
%h4 %h4
Todos let you see what you should do next. Todos let you see what you should do next.
%p %p
When an issue or merge request is assigned to you, or when you When an issue or merge request is assigned to you, or when you
%strong %strong
@mention @mention
in a comment, this will trigger a new item in your todo list, automatically. in a comment, this will trigger a new item in your todo list, automatically.
%p %p
You will always know what to work on next. You will always know what to work on next.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment