Commit 87d1e865 authored by Robert Speicher's avatar Robert Speicher

Use have_link over have_content for GPG feature

It's more semantically accurate for what we're verifying.
parent ee172686
...@@ -15,8 +15,8 @@ describe 'GPG signed commits' do ...@@ -15,8 +15,8 @@ describe 'GPG signed commits' do
visit project_commit_path(project, ref) visit project_commit_path(project, ref)
expect(page).to have_content 'Unverified' expect(page).to have_link 'Unverified'
expect(page).not_to have_content 'Verified' expect(page).not_to have_link 'Verified'
# user changes his email which makes the gpg key verified # user changes his email which makes the gpg key verified
perform_enqueued_jobs do perform_enqueued_jobs do
...@@ -26,8 +26,8 @@ describe 'GPG signed commits' do ...@@ -26,8 +26,8 @@ describe 'GPG signed commits' do
visit project_commit_path(project, ref) visit project_commit_path(project, ref)
expect(page).not_to have_content 'Unverified' expect(page).not_to have_link 'Unverified'
expect(page).to have_content 'Verified' expect(page).to have_link 'Verified'
end end
it 'changes from unverified to verified when the user adds the missing gpg key' do it 'changes from unverified to verified when the user adds the missing gpg key' do
...@@ -36,8 +36,8 @@ describe 'GPG signed commits' do ...@@ -36,8 +36,8 @@ describe 'GPG signed commits' do
visit project_commit_path(project, ref) visit project_commit_path(project, ref)
expect(page).to have_content 'Unverified' expect(page).to have_link 'Unverified'
expect(page).not_to have_content 'Verified' expect(page).not_to have_link 'Verified'
# user adds the gpg key which makes the signature valid # user adds the gpg key which makes the signature valid
perform_enqueued_jobs do perform_enqueued_jobs do
...@@ -46,8 +46,8 @@ describe 'GPG signed commits' do ...@@ -46,8 +46,8 @@ describe 'GPG signed commits' do
visit project_commit_path(project, ref) visit project_commit_path(project, ref)
expect(page).not_to have_content 'Unverified' expect(page).not_to have_link 'Unverified'
expect(page).to have_content 'Verified' expect(page).to have_link 'Verified'
end end
context 'shows popover badges', :js do context 'shows popover badges', :js do
...@@ -136,7 +136,7 @@ describe 'GPG signed commits' do ...@@ -136,7 +136,7 @@ describe 'GPG signed commits' do
visit project_commit_path(project, GpgHelpers::SIGNED_AND_AUTHORED_SHA) visit project_commit_path(project, GpgHelpers::SIGNED_AND_AUTHORED_SHA)
# wait for the signature to get generated # wait for the signature to get generated
expect(page).to have_content 'Verified' expect(page).to have_link 'Verified'
user_1.destroy! user_1.destroy!
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment