Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
ab53f7aa
Commit
ab53f7aa
authored
Mar 21, 2018
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix performance bar spacing
parent
40c338a4
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
34 additions
and
16 deletions
+34
-16
app/assets/javascripts/performance_bar/components/detailed_metric.vue
...avascripts/performance_bar/components/detailed_metric.vue
+28
-12
app/assets/javascripts/performance_bar/components/performance_bar_app.vue
...cripts/performance_bar/components/performance_bar_app.vue
+1
-1
app/assets/javascripts/performance_bar/components/upstream_performance_bar.vue
...s/performance_bar/components/upstream_performance_bar.vue
+2
-0
app/assets/javascripts/performance_bar/index.js
app/assets/javascripts/performance_bar/index.js
+2
-2
app/views/peek/_bar.html.haml
app/views/peek/_bar.html.haml
+1
-1
No files found.
app/assets/javascripts/performance_bar/components/detailed_metric.vue
View file @
ab53f7aa
...
@@ -27,6 +27,11 @@ export default {
...
@@ -27,6 +27,11 @@ export default {
required
:
true
,
required
:
true
,
},
},
},
},
computed
:
{
detailsList
()
{
return
this
.
currentRequest
.
details
[
this
.
metric
][
this
.
details
];
},
},
};
};
</
script
>
</
script
>
<
template
>
<
template
>
...
@@ -55,19 +60,30 @@ export default {
...
@@ -55,19 +60,30 @@ export default {
:header-title-text="header"
:header-title-text="header"
class="performance-bar-modal"
class="performance-bar-modal"
>
>
<table
class=
"table"
>
<table
<tr
class=
"table"
v-for=
"(item, index) in currentRequest.details[metric][details]"
>
:key=
"index"
<template
v-if=
"detailsList.length"
>
>
<tr
<td><strong>
{{
item
.
duration
}}
ms
</strong></td>
v-for=
"(item, index) in detailsList"
<td
:key=
"index"
v-for=
"key in keys"
:key=
"key"
>
>
{{
item
[
key
]
}}
<td><strong>
{{
item
.
duration
}}
ms
</strong></td>
</td>
<td
</tr>
v-for=
"key in keys"
:key=
"key"
>
{{
item
[
key
]
}}
</td>
</tr>
</
template
>
<
template
v-else
>
<tr>
<td>
No
{{
header
.
toLowerCase
()
}}
for this request.
</td>
</tr>
</
template
>
</table>
</table>
<div
slot=
"footer"
>
<div
slot=
"footer"
>
...
...
app/assets/javascripts/performance_bar/components/performance_bar_app.vue
View file @
ab53f7aa
...
@@ -124,7 +124,7 @@ export default {
...
@@ -124,7 +124,7 @@ export default {
class=
"view prepend-left-5"
class=
"view prepend-left-5"
>
>
<span
<span
v-if=
"currentRequest && currentRequest.details"
v-if=
"currentRequest && currentRequest.details
&& currentRequest.details.host
"
class=
"current-host"
class=
"current-host"
>
>
{{
currentRequest
.
details
.
host
.
hostname
}}
{{
currentRequest
.
details
.
host
.
hostname
}}
...
...
app/assets/javascripts/performance_bar/components/upstream_performance_bar.vue
View file @
ab53f7aa
...
@@ -5,6 +5,8 @@ export default {
...
@@ -5,6 +5,8 @@ export default {
.
getElementById
(
'
peek-view-performance-bar
'
)
.
getElementById
(
'
peek-view-performance-bar
'
)
.
cloneNode
(
true
);
.
cloneNode
(
true
);
upstreamPerformanceBar
.
classList
.
remove
(
'
hidden
'
);
this
.
$refs
.
wrapper
.
appendChild
(
upstreamPerformanceBar
);
this
.
$refs
.
wrapper
.
appendChild
(
upstreamPerformanceBar
);
},
},
};
};
...
...
app/assets/javascripts/performance_bar/index.js
View file @
ab53f7aa
...
@@ -4,9 +4,9 @@ import Vue from 'vue';
...
@@ -4,9 +4,9 @@ import Vue from 'vue';
import
performanceBarApp
from
'
./components/performance_bar_app.vue
'
;
import
performanceBarApp
from
'
./components/performance_bar_app.vue
'
;
import
PerformanceBarStore
from
'
./stores/performance_bar_store
'
;
import
PerformanceBarStore
from
'
./stores/performance_bar_store
'
;
export
default
()
=>
export
default
(
{
container
}
)
=>
new
Vue
({
new
Vue
({
el
:
'
#js-peek
'
,
el
:
container
,
components
:
{
components
:
{
performanceBarApp
,
performanceBarApp
,
},
},
...
...
app/views/peek/_bar.html.haml
View file @
ab53f7aa
...
@@ -6,7 +6,7 @@
...
@@ -6,7 +6,7 @@
profile_url:
url_for
(
params
.
merge
(
lineprofiler:
'true'
))
},
profile_url:
url_for
(
params
.
merge
(
lineprofiler:
'true'
))
},
class:
Peek
.
env
}
class:
Peek
.
env
}
#peek-view-performance-bar
#peek-view-performance-bar
.hidden
=
render_server_response_time
=
render_server_response_time
%span
#serverstats
%span
#serverstats
%ul
.performance-bar
%ul
.performance-bar
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment