Commit af6cf695 authored by Sean McGivern's avatar Sean McGivern

Add specs for a user from a group link

parent db9979bc
...@@ -5,6 +5,8 @@ describe IssuePolicy, models: true do ...@@ -5,6 +5,8 @@ describe IssuePolicy, models: true do
let(:author) { create(:user) } let(:author) { create(:user) }
let(:assignee) { create(:user) } let(:assignee) { create(:user) }
let(:reporter) { create(:user) } let(:reporter) { create(:user) }
let(:group) { create(:group, :public) }
let(:reporter_from_group_link) { create(:user) }
def permissions(user, issue) def permissions(user, issue)
IssuePolicy.abilities(user, issue).to_set IssuePolicy.abilities(user, issue).to_set
...@@ -21,6 +23,10 @@ describe IssuePolicy, models: true do ...@@ -21,6 +23,10 @@ describe IssuePolicy, models: true do
project.team << [author, :guest] project.team << [author, :guest]
project.team << [assignee, :guest] project.team << [assignee, :guest]
project.team << [reporter, :reporter] project.team << [reporter, :reporter]
group.add_reporter(reporter_from_group_link)
create(:project_group_link, group: group, project: project)
end end
it 'does not allow non-members to read issues' do it 'does not allow non-members to read issues' do
...@@ -41,6 +47,11 @@ describe IssuePolicy, models: true do ...@@ -41,6 +47,11 @@ describe IssuePolicy, models: true do
expect(permissions(reporter, issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue) expect(permissions(reporter, issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue)
end end
it 'allows reporters from group links to read, update, and admin issues' do
expect(permissions(reporter_from_group_link, issue)).to include(:read_issue, :update_issue, :admin_issue)
expect(permissions(reporter_from_group_link, issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue)
end
it 'allows issue authors to read and update their issues' do it 'allows issue authors to read and update their issues' do
expect(permissions(author, issue)).to include(:read_issue, :update_issue) expect(permissions(author, issue)).to include(:read_issue, :update_issue)
expect(permissions(author, issue)).not_to include(:admin_issue) expect(permissions(author, issue)).not_to include(:admin_issue)
...@@ -76,6 +87,11 @@ describe IssuePolicy, models: true do ...@@ -76,6 +87,11 @@ describe IssuePolicy, models: true do
expect(permissions(reporter, confidential_issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue) expect(permissions(reporter, confidential_issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue)
end end
it 'allows reporters from group links to read, update, and admin confidential issues' do
expect(permissions(reporter_from_group_link, confidential_issue)).to include(:read_issue, :update_issue, :admin_issue)
expect(permissions(reporter_from_group_link, confidential_issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue)
end
it 'allows issue authors to read and update their confidential issues' do it 'allows issue authors to read and update their confidential issues' do
expect(permissions(author, confidential_issue)).to include(:read_issue, :update_issue) expect(permissions(author, confidential_issue)).to include(:read_issue, :update_issue)
expect(permissions(author, confidential_issue)).not_to include(:admin_issue) expect(permissions(author, confidential_issue)).not_to include(:admin_issue)
...@@ -100,6 +116,10 @@ describe IssuePolicy, models: true do ...@@ -100,6 +116,10 @@ describe IssuePolicy, models: true do
before do before do
project.team << [guest, :guest] project.team << [guest, :guest]
project.team << [reporter, :reporter] project.team << [reporter, :reporter]
group.add_reporter(reporter_from_group_link)
create(:project_group_link, group: group, project: project)
end end
it 'allows guests to read issues' do it 'allows guests to read issues' do
...@@ -115,6 +135,11 @@ describe IssuePolicy, models: true do ...@@ -115,6 +135,11 @@ describe IssuePolicy, models: true do
expect(permissions(reporter, issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue) expect(permissions(reporter, issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue)
end end
it 'allows reporters from group links to read, update, and admin issues' do
expect(permissions(reporter_from_group_link, issue)).to include(:read_issue, :update_issue, :admin_issue)
expect(permissions(reporter_from_group_link, issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue)
end
it 'allows issue authors to read and update their issues' do it 'allows issue authors to read and update their issues' do
expect(permissions(author, issue)).to include(:read_issue, :update_issue) expect(permissions(author, issue)).to include(:read_issue, :update_issue)
expect(permissions(author, issue)).not_to include(:admin_issue) expect(permissions(author, issue)).not_to include(:admin_issue)
...@@ -145,6 +170,11 @@ describe IssuePolicy, models: true do ...@@ -145,6 +170,11 @@ describe IssuePolicy, models: true do
expect(permissions(reporter, confidential_issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue) expect(permissions(reporter, confidential_issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue)
end end
it 'allows reporter from group links to read, update, and admin confidential issues' do
expect(permissions(reporter_from_group_link, confidential_issue)).to include(:read_issue, :update_issue, :admin_issue)
expect(permissions(reporter_from_group_link, confidential_issue_no_assignee)).to include(:read_issue, :update_issue, :admin_issue)
end
it 'allows issue authors to read and update their confidential issues' do it 'allows issue authors to read and update their confidential issues' do
expect(permissions(author, confidential_issue)).to include(:read_issue, :update_issue) expect(permissions(author, confidential_issue)).to include(:read_issue, :update_issue)
expect(permissions(author, confidential_issue)).not_to include(:admin_issue) expect(permissions(author, confidential_issue)).not_to include(:admin_issue)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment