Commit bf93a9f5 authored by Sean McGivern's avatar Sean McGivern

Remove issue and MR counts from labels index

We were performing two (quite slow, because of the need to do access
checks) queries for each label on the page: one to get the count of
issues with that label, and one to get the count of merge requests with
that label.

Until we have a performant way of doing this, remove the counts.
parent 35824650
- label_css_id = dom_id(label) - label_css_id = dom_id(label)
- open_issues_count = label.open_issues_count(current_user)
- open_merge_requests_count = label.open_merge_requests_count(current_user)
- status = label_subscription_status(label, @project).inquiry if current_user - status = label_subscription_status(label, @project).inquiry if current_user
- subject = local_assigns[:subject] - subject = local_assigns[:subject]
...@@ -15,10 +13,10 @@ ...@@ -15,10 +13,10 @@
%ul %ul
%li %li
= link_to_label(label, subject: subject, type: :merge_request) do = link_to_label(label, subject: subject, type: :merge_request) do
= pluralize open_merge_requests_count, 'merge request' view merge requests
%li %li
= link_to_label(label, subject: subject) do = link_to_label(label, subject: subject) do
= pluralize open_issues_count, 'open issue' view open issues
- if current_user && defined?(@project) - if current_user && defined?(@project)
%li.label-subscription %li.label-subscription
- if label.is_a?(ProjectLabel) - if label.is_a?(ProjectLabel)
...@@ -40,9 +38,9 @@ ...@@ -40,9 +38,9 @@
.pull-right.hidden-xs.hidden-sm.hidden-md .pull-right.hidden-xs.hidden-sm.hidden-md
= link_to_label(label, subject: subject, type: :merge_request, css_class: 'btn btn-transparent btn-action') do = link_to_label(label, subject: subject, type: :merge_request, css_class: 'btn btn-transparent btn-action') do
= pluralize open_merge_requests_count, 'merge request' view merge requests
= link_to_label(label, subject: subject, css_class: 'btn btn-transparent btn-action') do = link_to_label(label, subject: subject, css_class: 'btn btn-transparent btn-action') do
= pluralize open_issues_count, 'open issue' view open issues
- if current_user && defined?(@project) - if current_user && defined?(@project)
.label-subscription.inline .label-subscription.inline
......
---
title: Remove issue and MR counts from labels index
merge_request:
author:
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment