Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
c433f520
Commit
c433f520
authored
Jul 28, 2017
by
Filipa Lacerda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[ci skip] Remove usage of global scope and remove dom querying from issue note form
parent
b27fb233
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
7 deletions
+5
-7
app/assets/javascripts/notes/components/issue_note_form.vue
app/assets/javascripts/notes/components/issue_note_form.vue
+5
-7
No files found.
app/assets/javascripts/notes/components/issue_note_form.vue
View file @
c433f520
...
@@ -28,11 +28,13 @@
...
@@ -28,11 +28,13 @@
},
},
},
},
data
()
{
data
()
{
const
{
getIssueData
,
getNotesData
}
=
this
.
$store
.
getters
;
return
{
return
{
initialNote
:
this
.
noteBody
,
initialNote
:
this
.
noteBody
,
note
:
this
.
noteBody
,
note
:
this
.
noteBody
,
markdownPreviewUrl
:
g
l
.
i
ssueData
.
preview_note_path
,
markdownPreviewUrl
:
g
etI
ssueData
.
preview_note_path
,
markdownDocsUrl
:
''
,
markdownDocsUrl
:
getNotesData
.
markdownDocs
,
conflictWhileEditing
:
false
,
conflictWhileEditing
:
false
,
};
};
},
},
...
@@ -67,10 +69,6 @@
...
@@ -67,10 +69,6 @@
},
},
},
},
mounted
()
{
mounted
()
{
const
issuableDataEl
=
document
.
getElementById
(
'
js-issuable-app-initial-data
'
);
const
issueData
=
JSON
.
parse
(
issuableDataEl
.
innerHTML
.
replace
(
/"/g
,
'
"
'
));
this
.
markdownDocsUrl
=
issueData
.
markdownDocs
;
this
.
$refs
.
textarea
.
focus
();
this
.
$refs
.
textarea
.
focus
();
},
},
watch
:
{
watch
:
{
...
@@ -126,7 +124,7 @@
...
@@ -126,7 +124,7 @@
{{
saveButtonTitle
}}
{{
saveButtonTitle
}}
</button>
</button>
<button
<button
@
click=
"cancelHandler
()
"
@
click=
"cancelHandler"
class=
"btn btn-nr btn-cancel note-edit-cancel"
class=
"btn btn-nr btn-cancel note-edit-cancel"
type=
"button"
>
type=
"button"
>
Cancel
Cancel
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment