Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
cde455c4
Commit
cde455c4
authored
Jan 12, 2016
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add encoding feature tests for builds artifacts browser
parent
487b0a02
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
48 additions
and
0 deletions
+48
-0
features/project/builds.feature
features/project/builds.feature
+18
-0
features/steps/project/builds.rb
features/steps/project/builds.rb
+30
-0
No files found.
features/project/builds.feature
View file @
cde455c4
...
...
@@ -30,3 +30,21 @@ Feature: Project Builds
And
I click artifacts browse button
And
I click link to subdirectory within build artifacts
Then
I should see content of subdirectory within artifacts archive
Scenario
:
I
browse directory with UTF-8 characters in name
Given
recent build has artifacts available
And
recent build has artifacts metadata available
And
recent build artifacts contain directory with UTF-8 characters
When
I visit recent build summary page
And
I click artifacts browse button
And
I navigate to directory with UTF-8 characters in name
Then
I should see content of directory with UTF-8 characters in name
Scenario
:
I
try to browse directory with invalid UTF-8 characters in name
Given
recent build has artifacts available
And
recent build has artifacts metadata available
And
recent build artifacts contain directory with invalid UTF-8 characters
When
I visit recent build summary page
And
I click artifacts browse button
And
I navigate to parent directory of directory with invalid name
Then
I should not see directory with invalid name on the list
features/steps/project/builds.rb
View file @
cde455c4
...
...
@@ -45,4 +45,34 @@ class Spinach::Features::ProjectBuilds < Spinach::FeatureSteps
expect
(
page
).
to
have_content
'doc_sample.txt'
end
end
step
'recent build artifacts contain directory with UTF-8 characters'
do
# metadata fixture contains relevant directory
end
step
'I navigate to directory with UTF-8 characters in name'
do
page
.
within
(
'.tree-table'
)
{
click_link
'tests_encoding'
}
page
.
within
(
'.tree-table'
)
{
click_link
'utf8 test dir ✓'
}
end
step
'I should see content of directory with UTF-8 characters in name'
do
page
.
within
(
'.tree-table'
)
do
expect
(
page
).
to
have_content
'..'
expect
(
page
).
to
have_content
'regular_file_2'
end
end
step
'recent build artifacts contain directory with invalid UTF-8 characters'
do
# metadata fixture contains relevant directory
end
step
'I navigate to parent directory of directory with invalid name'
do
page
.
within
(
'.tree-table'
)
{
click_link
'tests_encoding'
}
end
step
'I should not see directory with invalid name on the list'
do
page
.
within
(
'.tree-table'
)
do
expect
(
page
).
to
have_no_content
(
'non-utf8-dir'
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment