Merge branch '46903-osw-fix-permitted-params-filtering-on-merge-scheduling' into 'master'

Adjust permitted params filtering on merge scheduling

Closes #46903

See merge request gitlab-org/gitlab-ce!19255

app/controllers/projects/merge_requests_controller.rb

@@ -296,14 +296,14 @@ class Projects::MergeRequestsController < Projects::MergeRequests::ApplicationCo
       elsif @merge_request.actual_head_pipeline.success?
         # This can be triggered when a user clicks the auto merge button while
         # the tests finish at about the same time
-        @merge_request.merge_async(current_user.id, params)
+        @merge_request.merge_async(current_user.id, merge_params)
 
         :success
       else
         :failed
       end
     else
-      @merge_request.merge_async(current_user.id, params)
+      @merge_request.merge_async(current_user.id, merge_params)
 
       :success
     end

changelogs/unreleased/46903-osw-fix-permitted-params-filtering-on-merge-scheduling.yml

+---
+title: Adjust permitted params filtering on merge scheduling
+merge_request:
+author:
+type: fixed

spec/controllers/projects/merge_requests_controller_spec.rb

@@ -326,8 +326,8 @@ describe Projects::MergeRequestsController do
         expect(json_response).to eq('status' => 'success')
       end
 
-      it 'starts the merge immediately' do
-        expect(MergeWorker).to receive(:perform_async).with(merge_request.id, anything, anything)
+      it 'starts the merge immediately with permitted params' do
+        expect(MergeWorker).to receive(:perform_async).with(merge_request.id, anything, { 'squash' => false })
 
         merge_with_sha
       end