Merge branch 'winh-remove-convertPermissionToBoolean' into 'master'

Remove convertPermissionToBoolean() from common_utils.js

See merge request gitlab-org/gitlab-ce!25454

app/assets/javascripts/lib/utils/common_utils.js

@@ -455,21 +455,6 @@ export const historyPushState = newUrl => {
  */
 export const parseBoolean = value => (value && value.toString()) === 'true';
 
-/**
- * Converts permission provided as strings to booleans.
- *
- * @param  {String} string
- * @returns {Boolean}
- */
-export const convertPermissionToBoolean = permission => {
-  if (process.env.NODE_ENV !== 'production') {
-    // eslint-disable-next-line no-console
-    console.warn('convertPermissionToBoolean is deprecated! Please use parseBoolean instead.');
-  }
-
-  return parseBoolean(permission);
-};
-
 /**
  * @callback backOffCallback
  * @param {Function} next

spec/javascripts/lib/utils/common_utils_spec.js

@@ -409,13 +409,6 @@ describe('common_utils', () => {
     });
   });
 
-  describe('convertPermissionToBoolean', () => {
-    it('should convert a boolean in a string to a boolean', () => {
-      expect(commonUtils.convertPermissionToBoolean('true')).toEqual(true);
-      expect(commonUtils.convertPermissionToBoolean('false')).toEqual(false);
-    });
-  });
-
   describe('backOff', () => {
     beforeEach(() => {
       // shortcut our timeouts otherwise these tests will take a long time to finish