Merge branch 'rs-haml-lint-useless-assignment' into 'master'

Enable `Lint/UselessAssignment` for haml-lint

See merge request gitlab-org/gitlab-ce!21457

.haml-lint.yml

@@ -113,7 +113,6 @@ linters:
       - Lint/ParenthesesAsGroupedExpression
       - Lint/RedundantWithIndex
       - Lint/Syntax
-      - Lint/UselessAssignment
       - Metrics/BlockNesting
       - Naming/VariableName
       - Performance/RedundantMatch

app/views/award_emoji/_awards_block.html.haml

 - grouped_emojis = awardable.grouped_awards(with_thumbs: inline)
-- user_authored = awardable.user_authored?(current_user)
 .awards.js-awards-block{ class: ("hidden" if !inline && grouped_emojis.empty?), data: { award_url: toggle_award_url(awardable) } }
   - awards_sort(grouped_emojis).each do |emoji, awards|
     %button.btn.award-control.js-emoji-btn.has-tooltip{ type: "button",

app/views/discussions/_diff_with_notes.html.haml

 - diff_file = discussion.diff_file
-- blob = discussion.blob
-- discussions = { discussion.original_line_code => [discussion] }
 - diff_file_class = diff_file.text? ? 'text-file' : 'js-image-file'
 - diff_data = {}
 - expanded = discussion.expanded? || local_assigns.fetch(:expanded, nil)

app/views/doorkeeper/authorized_applications/_delete_form.html.haml

-- submit_btn_css ||= 'btn btn-link btn-remove'
 - if defined?(token)
   - path = oauth_authorized_application_path(0, token_id: token)
 - else

app/views/groups/labels/index.html.haml

 - @no_container = true
 - page_title "Labels"
 - can_admin_label = can?(current_user, :admin_label, @group)
-- hide_class = ''
 - hide = @available_labels.empty? || (params[:page].present? && params[:page] != '1')
 - issuables = ['issues', 'merge requests']
 

app/views/layouts/_search.html.haml

-- if controller.controller_path =~ /^groups/ && @group.persisted?
-  - label = _('This group')
-- if controller.controller_path =~ /^projects/ && @project.persisted?
-  - label = _('This project')
 - if @group && @group.persisted? && @group.path
   - group_data_attrs = { group_path: j(@group.path), name: @group.name, issues_path: issues_group_path(j(@group.path)), mr_path: merge_requests_group_path(j(@group.path)) }
 - if @project && @project.persisted?

app/views/layouts/explore.html.haml

-- page_title    = _("Explore")
+- page_title _("Explore")
 - unless current_user
-  - header_title  = _("Explore GitLab"), explore_root_path
+  - header_title _("Explore GitLab"), explore_root_path
 
 = render template: "layouts/application"

app/views/layouts/group_settings.html.haml

-- page_title    = _("Settings")
-- nav           "group"
+- page_title _("Settings")
+- nav "group"
 
 = render template: "layouts/group"

app/views/projects/_home_panel.html.haml

 - empty_repo = @project.empty_repo?
-- fork_network = @project.fork_network
 .project-home-panel.text-center{ class: ("empty-project" if empty_repo) }
   .limit-container-width{ class: container_class }
     .avatar-container.s70.project-avatar

app/views/projects/_merge_request_merge_method_settings.html.haml

 - form = local_assigns.fetch(:form)
-- project = local_assigns.fetch(:project)
 
 .form-group
   = label_tag :merge_method_merge, class: 'label-bold' do

app/views/projects/diffs/_parallel_view.html.haml

@@ -5,7 +5,6 @@
     - diff_file.parallel_diff_lines.each do |line|
       - left = line[:left]
       - right = line[:right]
-      - last_line = right.new_pos if right
       - discussions_left, discussions_right = parallel_diff_discussions(left, right, diff_file)
       %tr.line_holder.parallel
         - if left

app/views/projects/diffs/_single_image_diff.html.haml

 - blob = diff_file.blob
-- old_blob = diff_file.old_blob
 - blob_raw_url = diff_file_blob_raw_url(diff_file)
-- old_blob_raw_url = diff_file_old_blob_raw_url(diff_file)
 - click_to_comment = local_assigns.fetch(:click_to_comment, true)
 - diff_view_data = local_assigns.fetch(:diff_view_data, '')
 - class_name = ''

app/views/projects/labels/index.html.haml

 - @no_container = true
 - page_title "Labels"
 - can_admin_label = can?(current_user, :admin_label, @project)
-- hide_class = ''
 - search = params[:search]
 
 - if can_admin_label

app/views/projects/new.html.haml

@@ -3,7 +3,6 @@
 - @hide_top_links = true
 - page_title    'New Project'
 - header_title  "Projects", dashboard_projects_path
-- visibility_level = params.dig(:project, :visibility_level) || default_project_visibility
 - active_tab = local_assigns.fetch(:active_tab, 'blank')
 
 .project-edit-container

app/views/projects/notes/_actions.html.haml

@@ -38,7 +38,6 @@
 
 - if can?(current_user, :award_emoji, note)
   - if note.emoji_awardable?
-    - user_authored = note.user_authored?(current_user)
     .note-actions-item
       = button_tag title: 'Add reaction', class: "note-action-button note-emoji-button js-add-award js-note-emoji} has-tooltip btn btn-transparent", data: { position: 'right', container: 'body' } do
         = icon('spinner spin')

app/views/projects/pipelines/new.html.haml

 - breadcrumb_title "Pipelines"
-- page_title = s_("Pipeline|Run Pipeline")
+- page_title s_("Pipeline|Run Pipeline")
 - settings_link = link_to _('CI/CD settings'), project_settings_ci_cd_path(@project)
 
 %h3.page-title

app/views/projects/settings/ci_cd/_autodevops_form.html.haml

@@ -5,7 +5,6 @@
       %fieldset.builds-feature.js-auto-devops-settings
         .form-group
           - message = auto_devops_warning_message(@project)
-          - ci_file_formatted = '<code>.gitlab-ci.yml</code>'.html_safe
           - if message
             %p.auto-devops-warning-message.settings-message.text-center
               = message.html_safe

app/views/shared/_label.html.haml

@@ -4,8 +4,6 @@
 - use_label_priority = local_assigns.fetch(:use_label_priority, false)
 - force_priority = local_assigns.fetch(:force_priority, use_label_priority ? label.priority.present? : false)
 - toggle_subscription_path = toggle_subscription_label_path(label, @project) if current_user
-- show_label_merge_requests_link = show_label_issuables_link?(label, :merge_requests, project: @project)
-- show_label_issues_link = show_label_issuables_link?(label, :issues, project: @project)
 - tooltip_title = label_status_tooltip(label, status) if status
 
 %li.label-list-item{ id: label_css_id, data: { id: label.id } }

app/views/shared/_mini_pipeline_graph.html.haml

@@ -3,7 +3,6 @@
     - if stage.status
       - detailed_status = stage.detailed_status(current_user)
       - icon_status = "#{detailed_status.icon}_borderless"
-      - status_klass = "ci-status-icon ci-status-icon-#{detailed_status.group}"
 
       .stage-container.dropdown{ class: klass }
         %button.mini-pipeline-graph-dropdown-toggle.has-tooltip.js-builds-dropdown-button{ class: "ci-status-icon-#{detailed_status.group}", type: 'button', data: { toggle: 'dropdown', title: "#{stage.name}: #{detailed_status.label}", placement: 'top', "stage-endpoint" => stage_ajax_project_pipeline_path(pipeline.project, pipeline, stage: stage.name) } }

app/views/shared/_ref_switcher.html.haml

-- show_create = local_assigns.fetch(:show_create, false)
-
 - dropdown_toggle_text = @ref || @project.default_branch
 = form_tag switch_project_refs_path(@project), method: :get, class: "project-refs-form" do
   = hidden_field_tag :destination, destination

app/views/shared/issuable/_filter.html.haml

-- boards_page = controller.controller_name == 'boards'
-
 .issues-filters
   .issues-details-filters.row-content-block.second-block
     = form_tag page_filter_path(without: [:assignee_id, :author_id, :milestone_title, :label_name, :search]), method: :get, class: 'filter-form js-filter-form' do

app/views/shared/issuable/_label_dropdown.html.haml

@@ -7,7 +7,6 @@
 - data_options = local_assigns.fetch(:data_options, {})
 - classes = local_assigns.fetch(:classes, [])
 - selected = local_assigns.fetch(:selected, nil)
-- selected_toggle = local_assigns.fetch(:selected_toggle, nil)
 - dropdown_title = local_assigns.fetch(:dropdown_title, "Filter by label")
 - dropdown_data = {toggle: 'dropdown', field_name: "label_name[]", show_no: "true", show_any: "true", namespace_path: @project.try(:namespace).try(:full_path), project_path: @project.try(:path), labels: labels_filter_path, default_label: "Labels"}
 - dropdown_data.merge!(data_options)

app/views/shared/issuable/form/_metadata.html.haml

@@ -3,7 +3,6 @@
 - return unless can?(current_user, :"admin_#{issuable.to_ability_name}", issuable.project)
 
 - has_due_date = issuable.has_attribute?(:due_date)
-- has_labels = @labels && @labels.any?
 - form = local_assigns.fetch(:form)
 
 %hr

app/views/shared/projects/_project.html.haml

 - avatar = true unless local_assigns[:avatar] == false
 - stars = true unless local_assigns[:stars] == false
 - forks = false unless local_assigns[:forks] == true
-- ci = false unless local_assigns[:ci] == true
 - skip_namespace = false unless local_assigns[:skip_namespace] == true
-- user = local_assigns[:user]
 - access = max_project_member_access(project)
 - css_class = '' unless local_assigns[:css_class]
 - show_last_commit_as_description = false unless local_assigns[:show_last_commit_as_description] == true && can_show_last_commit_in_list?(project)

app/views/snippets/notes/_actions.html.haml

 - if current_user
   - if note.emoji_awardable?
-    - user_authored = note.user_authored?(current_user)
     .note-actions-item
       = link_to '#', title: 'Add reaction', class: "note-action-button note-emoji-button js-add-award js-note-emoji has-tooltip", data: { position: 'right' } do
         = icon('spinner spin')