- 04 Oct, 2018 40 commits
-
-
Sean McGivern authored
If we don't call #to_a, we're relying on the members already being loaded from elsewhere. Otherwise we'll do a separate query for each user: [1] pry(main)> Project.first.team.members.include?(User.first) Project Load (0.7ms) SELECT "projects".* FROM "projects" ORDER BY "projects"."id" ASC LIMIT 1 ↳ (pry):3 User Load (1.8ms) SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1 ↳ (pry):3 User Exists (0.6ms) SELECT 1 AS one FROM "users" INNER JOIN "project_authorizations" ON "users"."id" = "project_authorizations"."user_id" WHERE "project_authorizations"."project_id" = $1 AND "users"."id" = $2 LIMIT 1 [["project_id", 1], ["id", 1]] ↳ (pry):3 => true [2] pry(main)> Project.first.team.members.to_a.include?(User.first) Project Load (12.8ms) SELECT "projects".* FROM "projects" ORDER BY "projects"."id" ASC LIMIT 1 ↳ (pry):1 User Load (9.6ms) SELECT "users".* FROM "users" INNER JOIN "project_authorizations" ON "users"."id" = "project_authorizations"."user_id" WHERE "project_authorizations"."project_id" = $1 [["project_id", 1]] ↳ (pry):1 User Load (0.6ms) SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1 ↳ (pry):1 => true
-
Sean McGivern authored
-
Sean McGivern authored
Backport EE merge spec changes See merge request gitlab-org/gitlab-ce!22108
-
Phil Hughes authored
Renders empty states in the Vue app in Job page See merge request gitlab-org/gitlab-ce!22087
-
Filipa Lacerda authored
-
Dmitriy Zaporozhets authored
Clone nurtch demo notebooks at Jupyter startup See merge request gitlab-org/gitlab-ce!21698
-
Amit Rathi authored
-
Nick Thomas authored
Support short reference to epics from project entities See merge request gitlab-org/gitlab-ce!22048
-
Stan Hu authored
Remove addtionalProperties in runners schema Closes #52195 See merge request gitlab-org/gitlab-ce!22105
-
Fatih Acet authored
Add signature badge and pipeline status to commit details in MR diff Closes #49329 See merge request gitlab-org/gitlab-ce!22079
-
Achilleas Pipinellis authored
Fix links to external site and minor Markdown improvements See merge request gitlab-org/gitlab-ce!22098
-
Rémy Coutable authored
Port: Add checks to InterpretService conditions See merge request gitlab-org/gitlab-ce!22047
-
Rémy Coutable authored
Add a QA spec for RBAC cluster and auto devops See merge request gitlab-org/gitlab-ce!22025
-
Filipa Lacerda authored
Fix environment name overlapping Closes #52065 See merge request gitlab-org/gitlab-ce!22104
-
Phil Hughes authored
Fix faulty resolution of babel-messages in yarn.lock Closes #52192 See merge request gitlab-org/gitlab-ce!22111
-
Nick Thomas authored
Instance Configuration page now displays correct SSH fingerprints Closes #40636 See merge request gitlab-org/gitlab-ce!22081
-
Rémy Coutable authored
Show percentage of language detection on the language bar Closes #51457 See merge request https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22056
-
jerasmus authored
-
Rémy Coutable authored
Fix todo cops See merge request gitlab-org/gitlab-ce!21850
-
Lukas Eipert authored
-
Lukas Eipert authored
I don't know if the issue [0] was caused by a faulty merge, or why, but it seems like babel-messages had the wrong URL in there and resolved to babel-plugin-transform-object-rest-spread, which is wrong. So the integrity check did actually work and catch that! [0]: https://gitlab.com/gitlab-org/gitlab-ce/issues/52192
-
Kamil Trzciński authored
Simplify runner registration token resetting Closes #41922 See merge request gitlab-org/gitlab-ce!21658
-
Phil Hughes authored
Adds MR reference in job sidebar Closes #52191 See merge request gitlab-org/gitlab-ce!22103
-
Sean McGivern authored
These can be triggered by project creation in the setup phase if a spec uses the RequestStore, but we really don't care about that - it's not an N+1, it's just several projects being created!
-
Sean McGivern authored
This isn't called from anywhere.
-
Dylan Griffith authored
This fails now because we have not yet implemented support for this
-
Kamil Trzciński authored
Remove :rbac_clusters feature flag Closes #51009 See merge request gitlab-org/gitlab-ce!22096
-
Kamil Trzciński authored
Add pipeline.default_branch? mehod See merge request gitlab-org/gitlab-ce!22102
-
Steve Azzopardi authored
This resulted into failure on EE pipeline, for more information follow from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7600#note_105310648 onwards.
-
jerasmus authored
-
Filipa Lacerda authored
In the refactor the `!` reference was missed This commit adds it back and adds coverage for it.
-
Jarka Košanová authored
- add a direct project parent (group) to Banzai context - if an epic is referenced from a direct descendant -> change epic to_reference to use short reference
-
Phil Hughes authored
Resolve "Add status message from within user menu" Closes #51393 and #49075 See merge request gitlab-org/gitlab-ce!21643
-
Dennis Tang authored
-
Sean McGivern authored
Docs lock/unlock quick action See merge request gitlab-org/gitlab-ce!22088
-
Douwe Maan authored
Port of create labels_as_hash_ concern, modify params for method See merge request gitlab-org/gitlab-ce!21992
-
Rémy Coutable authored
docs: moving repositories cleanup See merge request gitlab-org/gitlab-ce!22099
-
GitLab Release Tools Bot authored
[ci skip]
-
Phil Hughes authored
Update environment item empty state See merge request gitlab-org/gitlab-ce!21976
-
Phil Hughes authored
Resolve "Add new "Overview" tab on user profile page" Closes #49801 See merge request gitlab-org/gitlab-ce!21663
-