- 29 Apr, 2018 1 commit
-
-
blackst0ne authored
In Arel 7.0.0 (Arel 7.1.4 is used in Rails 5.0) the `engine` parameter of `Arel::UpdateManager#initializer` was removed. This commit makes the gitlab database helpers work both in rails 4 and rails 5. Fixes errors like this one: ``` 1) Gitlab::Database::MigrationHelpers#update_column_in_batches when running outside of a transaction updates all the rows in a table Failure/Error: update_arel = Arel::UpdateManager.new(ActiveRecord::Base) .table(table) .set([[table[column], value]]) .where(table[:id].gteq(start_id)) ArgumentError: wrong number of arguments (given 1, expected 0) # ./lib/gitlab/database/migration_helpers.rb:317:in `new' # ./lib/gitlab/database/migration_helpers.rb:317:in `block in update_column_in_batches' # ./lib/gitlab/database/migration_helpers.rb:307:in `loop' # ./lib/gitlab/database/migration_helpers.rb:307:in `update_column_in_batches' # ./spec/lib/gitlab/database/migration_helpers_spec.rb:367:in `block (4 levels) in <top (required)>' ```
-
- 27 Apr, 2018 23 commits
-
-
Kamil Trzciński authored
Fix example config miss-alignment in uploads.object_store.connection Closes gitlab-development-kit#342 See merge request gitlab-org/gitlab-ce!18622
-
Marcia Ramos authored
Resolve "Add how to use nip.io to Auto DevOps and Kubernetes documentation" Closes #45561 See merge request gitlab-org/gitlab-ce!18494
-
Dylan Griffith authored
-
Stan Hu authored
Remove IDE image upload spec Closes #45045 See merge request gitlab-org/gitlab-ce!18617
-
Alessio Caiazza authored
-
Phil Hughes authored
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/45045
-
Nick Thomas authored
Remove comma from the time system notes See merge request gitlab-org/gitlab-ce!18593
-
Nick Thomas authored
Repository#exists? can only be queried with Gitaly Closes gitaly#314 See merge request gitlab-org/gitlab-ce!18567
-
Grzegorz Bizon authored
Don't run JS lint report for QA See merge request gitlab-org/gitlab-ce!18621
-
Grzegorz Bizon authored
Add gitlab-pages admin ping rake task See merge request gitlab-org/gitlab-ce!18372
-
Jacob Vosmaer (GitLab) authored
-
Lin Jen-Shin authored
-
Grzegorz Bizon authored
Skip db related tests for QA See merge request gitlab-org/gitlab-ce!18618
-
Grzegorz Bizon authored
CE: Fix QA protected branches tests See merge request gitlab-org/gitlab-ce!18585
-
Lin Jen-Shin authored
and skip db related jobs for QA branches
-
Grzegorz Bizon authored
Fix rubocop offense and enable jobs for qa See merge request gitlab-org/gitlab-ce!18613
-
Lin Jen-Shin authored
while producing products. Basically an attempt to fix: https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/65016456 Selenium::WebDriver::Error::StaleElementReferenceError: stale element reference: element is not attached to the page document in: ``` ruby product :name do Page::Project::Settings::Repository.act do expand_protected_branches(&:last_branch_name) end end ```
-
Rémy Coutable authored
Fixed typos See merge request gitlab-org/gitlab-ce!18432
-
Pascal Borreli authored
-
Lin Jen-Shin authored
We could revisit which we don't want to run in qa.
-
Filipa Lacerda authored
CE Backport: Reveal labels dropdown when labels icon is clicked on collapsed Epic sidebar See merge request gitlab-org/gitlab-ce!18611
-
Grzegorz Bizon authored
Add more QA SSH key tests Closes gitlab-qa#183 See merge request gitlab-org/gitlab-ce!17662
-
Kushal Pandya authored
-
- 26 Apr, 2018 16 commits
-
-
Clement Ho authored
Clear refresh interval when MRWidgetFailedToMerge component is destroyed See merge request gitlab-org/gitlab-ce!18600
-
Winnie Hellmann authored
-
Phil Hughes authored
Reset milestone filter when clicking "Any Milestone" in dashboard Closes #45295 See merge request gitlab-org/gitlab-ce!18531
-
Winnie Hellmann authored
-
Sean McGivern authored
Remove `peek-performance_bar` from the performance bar See merge request gitlab-org/gitlab-ce!18597
-
Rémy Coutable authored
Rename the Edge label to Quality See merge request gitlab-org/gitlab-ce!18457
-
Rémy Coutable authored
-
Sean McGivern authored
Delete object_state_models.md See merge request gitlab-org/gitlab-ce!18588
-
Mike Greiling authored
Fix calendar day position See merge request gitlab-org/gitlab-ce!18516
-
Clement Ho authored
-
Rémy Coutable authored
Restore size and position for fork icon See merge request gitlab-org/gitlab-ce!18449
-
Nick Thomas authored
-
Nick Thomas authored
-
Filipa Lacerda authored
Fixed bugs with IDE new directory Closes #44838 See merge request gitlab-org/gitlab-ce!18274
-
Filipa Lacerda authored
Merge branch '45451-user-deletion-modal-with-same-info-for-delete-user-or-delete-user-and-contributions' into 'master' Resolve "User deletion modal with same info for delete user / delete user and contributions" Closes #45451 See merge request gitlab-org/gitlab-ce!18463
-
schwedenmut authored
-