1. 11 Jan, 2019 23 commits
    • Toon Claes's avatar
      Cleanup dead code and comments · 83767dd0
      Toon Claes authored
      83767dd0
    • Toon Claes's avatar
      Fix failing spec with orphaned namespace · 082cc122
      Toon Claes authored
      082cc122
    • Toon Claes's avatar
      Load all projects, namespaces, routes in 1 query · d3e028b8
      Toon Claes authored
      Avoid doing sequential database queries to load the namespaces and the
      routes of projects and namespaces.
      
      This results in the following query:
      
      ```sql
      SELECT "projects"."id" AS t0_r0,
             "projects"."name" AS t0_r1,
             "projects"."path" AS t0_r2,
             "projects"."description" AS t0_r3,
             "projects"."created_at" AS t0_r4,
             "projects"."updated_at" AS t0_r5,
             "projects"."creator_id" AS t0_r6,
             "projects"."namespace_id" AS t0_r7,
             "projects"."last_activity_at" AS t0_r8,
             "projects"."import_url" AS t0_r9,
             "projects"."visibility_level" AS t0_r10,
             "projects"."archived" AS t0_r11,
             "projects"."avatar" AS t0_r12,
             "projects"."import_status" AS t0_r13,
             "projects"."star_count" AS t0_r14,
             "projects"."import_type" AS t0_r15,
             "projects"."import_source" AS t0_r16,
             "projects"."import_error" AS t0_r17,
             "projects"."ci_id" AS t0_r18,
             "projects"."shared_runners_enabled" AS t0_r19,
             "projects"."runners_token" AS t0_r20,
             "projects"."build_coverage_regex" AS t0_r21,
             "projects"."build_allow_git_fetch" AS t0_r22,
             "projects"."build_timeout" AS t0_r23,
             "projects"."pending_delete" AS t0_r24,
             "projects"."public_builds" AS t0_r25,
             "projects"."last_repository_check_failed" AS t0_r26,
             "projects"."last_repository_check_at" AS t0_r27,
             "projects"."container_registry_enabled" AS t0_r28,
             "projects"."only_allow_merge_if_pipeline_succeeds" AS t0_r29,
             "projects"."has_external_issue_tracker" AS t0_r30,
             "projects"."repository_storage" AS t0_r31,
             "projects"."request_access_enabled" AS t0_r32,
             "projects"."has_external_wiki" AS t0_r33,
             "projects"."ci_config_path" AS t0_r34,
             "projects"."lfs_enabled" AS t0_r35,
             "projects"."description_html" AS t0_r36,
             "projects"."only_allow_merge_if_all_discussions_are_resolved" AS t0_r37,
             "projects"."printing_merge_request_link_enabled" AS t0_r38,
             "projects"."auto_cancel_pending_pipelines" AS t0_r39,
             "projects"."import_jid" AS t0_r40,
             "projects"."cached_markdown_version" AS t0_r41,
             "projects"."delete_error" AS t0_r42,
             "projects"."last_repository_updated_at" AS t0_r43,
             "projects"."storage_version" AS t0_r44,
             "projects"."resolve_outdated_diff_discussions" AS t0_r45,
             "projects"."repository_read_only" AS t0_r46,
             "projects"."merge_requests_ff_only_enabled" AS t0_r47,
             "projects"."merge_requests_rebase_enabled" AS t0_r48,
             "projects"."jobs_cache_index" AS t0_r49,
             "projects"."pages_https_only" AS t0_r50,
             "projects"."remote_mirror_available_overridden" AS t0_r51,
             "projects"."pool_repository_id" AS t0_r52,
             "projects"."runners_token_encrypted" AS t0_r53,
             "projects"."bfg_object_map" AS t0_r54,
             "namespaces"."id" AS t1_r0,
             "namespaces"."name" AS t1_r1,
             "namespaces"."path" AS t1_r2,
             "namespaces"."owner_id" AS t1_r3,
             "namespaces"."created_at" AS t1_r4,
             "namespaces"."updated_at" AS t1_r5,
             "namespaces"."type" AS t1_r6,
             "namespaces"."description" AS t1_r7,
             "namespaces"."avatar" AS t1_r8,
             "namespaces"."share_with_group_lock" AS t1_r9,
             "namespaces"."visibility_level" AS t1_r10,
             "namespaces"."request_access_enabled" AS t1_r11,
             "namespaces"."description_html" AS t1_r12,
             "namespaces"."lfs_enabled" AS t1_r13,
             "namespaces"."parent_id" AS t1_r14,
             "namespaces"."require_two_factor_authentication" AS t1_r15,
             "namespaces"."two_factor_grace_period" AS t1_r16,
             "namespaces"."cached_markdown_version" AS t1_r17,
             "namespaces"."runners_token" AS t1_r18,
             "namespaces"."runners_token_encrypted" AS t1_r19,
             "routes"."id" AS t2_r0,
             "routes"."source_id" AS t2_r1,
             "routes"."source_type" AS t2_r2,
             "routes"."path" AS t2_r3,
             "routes"."created_at" AS t2_r4,
             "routes"."updated_at" AS t2_r5,
             "routes"."name" AS t2_r6,
             "routes_projects"."id" AS t3_r0,
             "routes_projects"."source_id" AS t3_r1,
             "routes_projects"."source_type" AS t3_r2,
             "routes_projects"."path" AS t3_r3,
             "routes_projects"."created_at" AS t3_r4,
             "routes_projects"."updated_at" AS t3_r5,
             "routes_projects"."name" AS t3_r6
      FROM "projects"
      LEFT OUTER JOIN "namespaces" ON "namespaces"."id" = "projects"."namespace_id"
      LEFT OUTER JOIN "routes" ON "routes"."source_id" = "namespaces"."id"
      AND "routes"."source_type" = $1
      LEFT OUTER JOIN "routes" "routes_projects" ON "routes_projects"."source_id" = "projects"."id"
      AND "routes_projects"."source_type" = $2
      LEFT OUTER JOIN "project_repositories" ON "projects"."id" = "project_repositories"."project_id"
      WHERE ("projects"."storage_version" IS NULL
             OR "projects"."storage_version" = 0)
        AND "project_repositories"."project_id" IS NULL
        AND ("projects"."id" BETWEEN $3 AND $4);
        -- [["source_type", "Namespace"],
        --  ["source_type", "Project"],
        --  ["id", 1],
        --  ["id", 4]]
      ```
      d3e028b8
    • Stan Hu's avatar
      Fix duplicate disk path in Backfill ProjectRepos · 618875c5
      Stan Hu authored
      On GitLab.com, we saw numerous duplicate disk entry inserts because
      the migration was not taking the routes table into account. We now
      implement this in the migration to be consistent.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56061
      618875c5
    • Grzegorz Bizon's avatar
      Merge branch 'remove-get-builds-method' into 'master' · 6b2f81f6
      Grzegorz Bizon authored
      Remove get_build method for find_by_id
      
      See merge request gitlab-org/gitlab-ce!24271
      6b2f81f6
    • Mike Lewis's avatar
      Merge branch 'docs-serverless-function-sample' into 'master' · 249607c0
      Mike Lewis authored
      Add link to sample project for functions
      
      See merge request gitlab-org/gitlab-ce!24323
      249607c0
    • danielgruesso's avatar
      Add link to sample project · 33c016b2
      danielgruesso authored
      33c016b2
    • Grzegorz Bizon's avatar
      Merge branch 'fix-udpate-head-pipeline-method' into 'master' · 3ce491c5
      Grzegorz Bizon authored
      Fix unexpected exception by failure of finding an actual head pipeline
      
      Closes #56113
      
      See merge request gitlab-org/gitlab-ce!24257
      3ce491c5
    • Douwe Maan's avatar
      Merge branch 'zj-nillify-pool-repo-when-leaving' into 'master' · 0f71b4bc
      Douwe Maan authored
      Nullify pool_repository when a project leaves
      
      See merge request gitlab-org/gitlab-ce!24225
      0f71b4bc
    • Filipa Lacerda's avatar
      Merge branch 'notebook-multiple-outputs' into 'master' · e593e14a
      Filipa Lacerda authored
      Support multiple outputs in Jupyter notebooks
      
      Closes #32588 and #31910
      
      See merge request gitlab-org/gitlab-ce!24263
      e593e14a
    • Dmitriy Zaporozhets's avatar
      Merge branch '45779-fix-default-visibility-level-for-projects' into 'master' · 7e1b5f42
      Dmitriy Zaporozhets authored
      Fix default visibility_level for new projects
      
      Closes #45779
      
      See merge request gitlab-org/gitlab-ce!24120
      7e1b5f42
    • Fabian Schneider's avatar
      00a3b466
    • Sean McGivern's avatar
      Merge branch '53431-fix-upcoming-milestone-filter-for-groups' into 'master' · 7a10ef6e
      Sean McGivern authored
      Add group milestones in upcoming filter
      
      Closes #53431
      
      See merge request gitlab-org/gitlab-ce!23098
      7a10ef6e
    • Zeger-Jan van de Weg's avatar
      Nullify pool_repository when a project leaves · e672ed84
      Zeger-Jan van de Weg authored
      Previously the nullification wasn't done, as the only caller would later
      destroy the model all together. In
      https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9070 this change
      was made. This commit is basically a backport before that MR is merged.
      e672ed84
    • Kamil Trzciński's avatar
      Merge branch '56110-cluster-kubernetes-api-500-error-on-post-request' into 'master' · b98f6e53
      Kamil Trzciński authored
      Improves restriction of multiple Kubernetes clusters via API
      
      Closes #56110
      
      See merge request gitlab-org/gitlab-ce!24251
      b98f6e53
    • Phil Hughes's avatar
    • Kamil Trzciński's avatar
      Merge branch 'remove-releases_page-feature-flag' into 'master' · b682a6f8
      Kamil Trzciński authored
      Remove `releases_page` feature flag
      
      Closes #56072
      
      See merge request gitlab-org/gitlab-ce!24215
      b682a6f8
    • Kushal Pandya's avatar
      Merge branch '54167-rename-project-tags-to-project-topics' into 'master' · 437e9e4f
      Kushal Pandya authored
      Resolve "Rename project tags to project topics"
      
      Closes #54167
      
      See merge request gitlab-org/gitlab-ce!24219
      437e9e4f
    • Marcia Ramos's avatar
      Merge branch 'docs-release-asset-link' into 'master' · 6ac5c2d3
      Marcia Ramos authored
      Add documentation for Release Asset Link API
      
      Closes #56060
      
      See merge request gitlab-org/gitlab-ce!24211
      6ac5c2d3
    • Shinya Maeda's avatar
      90be0b1c
    • Shinya Maeda's avatar
      Remove releases_page feature flag · 9b823af4
      Shinya Maeda authored
      We introduced releases_page feature flag.
      Given this feature is deemed stable, we should remove
      this flag before 19th.
      9b823af4
    • Mike Greiling's avatar
      Merge branch 'knative-show-page' into 'master' · 89c4d2ae
      Mike Greiling authored
      Initial Serverless Functions detailed view
      
      See merge request gitlab-org/gitlab-ce!23863
      89c4d2ae
    • Mayra Cabrera's avatar
      Restrict multiple clusters through API · 8b2fe985
      Mayra Cabrera authored
      Modifies authorize! method to accept a third param, and then use it in
      combination with 'add_cluster' policy to appropriately restrict adding
      multiple clusters
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56110
      8b2fe985
  2. 10 Jan, 2019 17 commits